From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6C7FBAC14BA for ; Mon, 23 Oct 2023 14:18:13 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=mFRgAJWc+pROyArOX+EUu6FhLbysp7Ke0X2vPYut/F4=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1698070692; v=1; b=VGJ3F5nNrBlWqxBoYdNRxNur+nwz20c/U2kzmH9OSl/r2bW4YkVaZYbr56NlNNaKoaU5m6u3 Fw2rtSTwPq6u5553kqefhtce4ZAFaiIxdT/+R6WvwWCQvI+lkJNd3CmQPjpV9VgKpN9A8y9dnwe uQMJ+IubCymqkbxh4O2xpw/U= X-Received: by 127.0.0.2 with SMTP id yDXMYY7687511xsI0V0mY2Wn; Mon, 23 Oct 2023 07:18:12 -0700 X-Received: from NAM02-DM3-obe.outbound.protection.outlook.com (NAM02-DM3-obe.outbound.protection.outlook.com [40.107.95.51]) by mx.groups.io with SMTP id smtpd.web11.122145.1698070691529017534 for ; Mon, 23 Oct 2023 07:18:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VSdreEY3hT7BN3I0QKsXRzglcsWRB3uJ2EeyzUZIPETIdWR34RL4cU3NymR/WZAGAVPmR+Vcb56xolrljd0PStCRTjCyyw/LrrpeZXtECr3lVySoIIUZdNGpHXXkBWFe8mpanZiVwf1mCCTiezB35Km5/I9qz960OVCYiyzvEoOsWDwVZOItKfZB1+AeLhcTwaOhnqm9nHtP7r+eSdEUElCm+qUEgat/LbUc8mmuQgU4d1219aWtJZhAAi53cZusQ7Sj6SrmBAXQkPt1IIJnIn/imaOiyqm4o0X8wvsBoYORnXRk/cdglStF/HNVrNXzZNHuXD9arR6m3oYS0YxSQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rmgH1UQPzg96j4zLhsMCcIFyn/IWkqMXZobDKFJBY8w=; b=RkxFT2wk7Zn6L7qYo/bGI7toBFK45j+vwohC/CdTFdbZPthoQ/N0FSd2aw5bMfBZJAiG8Q39oGMEaXsu/ZFJLDzYi7FQhmLpAQcBNTl5XmzEDP50MxI/OLtzJ7jwNVpJ6tu7brgYGRqqsWD+D2zXoXj70pjHt4YLQTroB5EJX/FzAzpfZwt6LBLv+rqWRsebmxm9tKYI3mngK7KWL3XnhKWRsloxw55B5SDBIyYwIUljofErnUFxD3OndldNOIkoZyPuComWOmLuPEWes4amdbmOSVd4jeNOdzC7yicAPJQ8yPKejYcg+bgvWDobky/Yhj6lHilFuxPMnlNXTcPvqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none X-Received: from SA9PR13CA0029.namprd13.prod.outlook.com (2603:10b6:806:21::34) by SA1PR12MB6894.namprd12.prod.outlook.com (2603:10b6:806:24d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.29; Mon, 23 Oct 2023 14:18:07 +0000 X-Received: from SN1PEPF000252A0.namprd05.prod.outlook.com (2603:10b6:806:21:cafe::70) by SA9PR13CA0029.outlook.office365.com (2603:10b6:806:21::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.15 via Frontend Transport; Mon, 23 Oct 2023 14:18:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C X-Received: from mail.nvidia.com (216.228.118.232) by SN1PEPF000252A0.mail.protection.outlook.com (10.167.242.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.15 via Frontend Transport; Mon, 23 Oct 2023 14:18:07 +0000 X-Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 23 Oct 2023 07:17:48 -0700 X-Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 23 Oct 2023 07:17:47 -0700 X-Received: from NV-CL38DL3.nvidia.com (10.127.8.13) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.986.41 via Frontend Transport; Mon, 23 Oct 2023 07:17:46 -0700 From: "Nickle Wang via groups.io" To: CC: Abner Chang , Igor Kulchytskyy , "Nick Ramirez" Subject: [edk2-devel] [PATCH] RedfishPkg/RedfishDiscoverDxe: remove Redfish false alarm Date: Mon, 23 Oct 2023 22:17:45 +0800 Message-ID: <20231023141745.259-1-nicklew@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF000252A0:EE_|SA1PR12MB6894:EE_ X-MS-Office365-Filtering-Correlation-Id: c066864a-9946-4f15-f44f-08dbd3d2e0ee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: pdqgzMyWQBgGMj514AR2APpA6gEYNaynsRBCWFygcBmrepLyvFq7AF2tVnO7/OSFD9wDY6t506C3ZZ3sw/yzLut3dRBEgoJmgFFgvKNm8r5DMjFA1q1KCGoRxjJ2m4otLpaNsilikNvr8AO01/37kWNvhYMkZyHNA1FgDFYOAvGpmAifE/FewKhjuvTAU9zkLoXEdlMGnmBdy2qWbLzaeobwAVXDDK8pZIbXx/SSTX5qmGLTeWBKksZD2gPOBM26ZkOhqTyTggGOg+wX4tzRzh2z3ZUjqFuMqscS6bxEG2wbr1s7FmZ17gLZyFAqb1nfRoP/9oz+EWbV7gvDg1k8JAHqUy4nU6bC7XOcgzyOGfCWr1wsvleovFEoLeMpQ+mhdhxh8TwicJLd4x6r++f1JybGgQDmiK4g9S+LJ3Z09gQss2/l69nIZIdpPeqFIHzxjo9+ndh3DcxzWGNuYDSaTKOpYZrnszDeN3qbqVxUl5mdJG+nEhvprdYrkcIdS/mGb92NLzdmZ98ja2AalvOTYyMXBLVK9tGmjWOizBW5SNeASgtZJz6NwUSiUUmRqCLW0DDQ1i3E4Ttgj4kCwY6Pxw4LwOPQrAqWJJvudP1ycc6/CzNJv29JavvMFOXxTK3noMRD33kYb0nwFB9mYXsIEbvqG3Q2klbJN6Ooi6KuYeowB5S7ke0kvpOBw402M4xuz4qFcKTCnl522aPnVQ/Dsk891BXxzT0s8uNONH9AHVJ3mh+SRvbXcH90FHNFlAWQ X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 14:18:07.2156 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c066864a-9946-4f15-f44f-08dbd3d2e0ee X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF000252A0.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6894 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 3oGUsn1Pc8hdC6dcrxmpMha9x7686176AA= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-Spam-Flag: yes X-Spam-Level: ************ X-GND-Spam-Score: 190 X-GND-Status: SPAM Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=VGJ3F5nN; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io - It is expected that caller receives EFI_NO_MAPPING status when call issues Configure() to unconfigured network interface. Remove this false alarm in GetSubnetInfo() function. - Fix typos Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPk= g/RedfishDiscoverDxe/RedfishDiscoverDxe.c index 2f9e604f6cd6..23da3b968f6c 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -198,13 +198,17 @@ Tcp4GetSubnetInfo ( Tcp4Option.EnableNagle =3D TRUE; Status =3D Tcp4->Configure (Tcp4, &Tcp4CfgData); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Can't get subnet information\n", __func__)); + if (Status =3D=3D EFI_NO_MAPPING) { + return EFI_SUCCESS; + } + + DEBUG ((DEBUG_ERROR, "%a: Can't get subnet information: %r\n", __func_= _, Status)); return Status; } =20 Status =3D Tcp4->GetModeData (Tcp4, NULL, NULL, &IpModedata, NULL, NULL)= ; if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Can't get IP mode data information\n", __fun= c__)); + DEBUG ((DEBUG_ERROR, "%a: Can't get IP mode data information: %r\n", _= _func__, Status)); return Status; } =20 @@ -267,7 +271,7 @@ Tcp6GetSubnetInfo ( ZeroMem ((VOID *)&IpModedata, sizeof (EFI_IP6_MODE_DATA)); Status =3D Tcp6->GetModeData (Tcp6, NULL, NULL, &IpModedata, NULL, NULL)= ; if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Can't get IP mode data information\n", __fun= c__)); + DEBUG ((DEBUG_ERROR, "%a: Can't get IP mode data information: %r\n", _= _func__, Status)); return Status; } =20 @@ -1002,13 +1006,13 @@ NetworkInterfaceGetSubnetInfo ( Instance ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a:Failed to get Subnet infomation.\n", __func= __)); + DEBUG ((DEBUG_ERROR, "%a:Failed to get Subnet information.\n", __fun= c__)); return Status; } else { DEBUG ((DEBUG_MANAGEABILITY, "%a:MAC address: %s\n", __func__, Insta= nce->StrMacAddr)); if (CheckIsIpVersion6 (Instance)) { if (Instance->SubnetAddrInfoIPv6Number =3D=3D 0) { - DEBUG ((DEBUG_ERROR, "%a: There is no Subnet infomation for IPv6= network interface.\n", __func__)); + DEBUG ((DEBUG_WARN, "%a: There is no Subnet information for IPv6= network interface.\n", __func__)); return EFI_NOT_FOUND; } =20 @@ -1554,7 +1558,7 @@ TestForRequiredProtocols ( ); if (EFI_ERROR (Status)) { if (Index =3D=3D ListCount - 1) { - DEBUG ((DEBUG_ERROR, "%a: all required protocols are found on th= is controller handle: %p.\n", __func__, ControllerHandle)); + DEBUG ((DEBUG_INFO, "%a: all required protocols are found on thi= s controller handle: %p.\n", __func__, ControllerHandle)); return EFI_SUCCESS; } } --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109926): https://edk2.groups.io/g/devel/message/109926 Mute This Topic: https://groups.io/mt/102136152/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-