From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6E0E1740045 for ; Thu, 26 Oct 2023 14:17:30 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=rb8i3diBiWMalAan7blZytxh0lmgYXnhJ4E0ZndePbo=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1698329848; v=1; b=lz4FYjRpMBuSXDNblVhwEjcwHXILbIIIy3XVBGMDP0EV8it/2nUoyaEbytmm8mmyd0VfCHib +norexVWjHCM6HUksajT+STGipkh5HpDm2Iz2dOaLb9Ak1rTYnt379RCBCZ9QOQTmNwJ1/hneq8 8GASZTVPElIquPqBMOJ45J50= X-Received: by 127.0.0.2 with SMTP id 9u44YY7687511xFFPWuIHI3b; Thu, 26 Oct 2023 07:17:28 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.201460.1698329846500057640 for ; Thu, 26 Oct 2023 07:17:28 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="372607291" X-IronPort-AV: E=Sophos;i="6.03,253,1694761200"; d="scan'208";a="372607291" X-Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2023 07:17:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="794225084" X-IronPort-AV: E=Sophos;i="6.03,253,1694761200"; d="scan'208";a="794225084" X-Received: from njayapra-mobl.gar.corp.intel.com ([10.213.103.39]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2023 07:17:26 -0700 From: "Jayaprakash, N" To: devel@edk2.groups.io Cc: Jayaprakash N , Rebecca Cran , Michael D Kinney , Kloper Dimitry Subject: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: realpath function signature doesn't match the standard Date: Thu, 26 Oct 2023 19:47:16 +0530 Message-Id: <20231026141716.823-2-n.jayaprakash@intel.com> In-Reply-To: <20231026141716.823-1-n.jayaprakash@intel.com> References: <20231026141716.823-1-n.jayaprakash@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,n.jayaprakash@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 0BjxTg77IzhOScGSS83J0bpDx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=lz4FYjRp; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4574 This commit is for processing the below PR on edk2-libc repo https://github.com/tianocore/edk2-libc/pull/10 The realpath function signature in stdlib of edk2-libc doesn't match signature as per the standard definition of this function given below https://pubs.opengroup.org/onlinepubs/009695399/functions/realpath.html This patch extracted from the above pull request fixes this issue. Cc: Rebecca Cran Cc: Michael D Kinney Cc: Jayaprakash N Signed-off-by: Kloper Dimitry --- StdLib/Include/stdlib.h | 4 ++-- StdLib/LibC/StdLib/realpath.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/StdLib/Include/stdlib.h b/StdLib/Include/stdlib.h index 0b9dfd3..022ddbd 100644 --- a/StdLib/Include/stdlib.h +++ b/StdLib/Include/stdlib.h @@ -74,7 +74,7 @@ const wchar_t * __restrict src, size_t limit); ################ Miscelaneous functions for *nix compatibility - char *realpath (char *file_name, char *resolved_name); + char *realpath (const char *file_name, char *resolved_name); const char *getprogname (void); void setprogname (const char *progname); @@ -875,7 +875,7 @@ size_t wcstombs(char * __restrict Dest, const wchar_t * __restrict Src, size_t @retval NULL An error occured. @retval resolved_name. **/ -char * realpath(char *file_name, char *resolved_name); +char * realpath(const char *file_name, char *resolved_name); /** The getprogname() function returns the name of the program. If the name has not been set yet, it will return NULL. diff --git a/StdLib/LibC/StdLib/realpath.c b/StdLib/LibC/StdLib/realpath.c index 3d4118d..29abe9a 100644 --- a/StdLib/LibC/StdLib/realpath.c +++ b/StdLib/LibC/StdLib/realpath.c @@ -34,7 +34,7 @@ **/ char * realpath( - char *file_name, + const char *file_name, char *resolved_name ) { -- 2.40.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110106): https://edk2.groups.io/g/devel/message/110106 Mute This Topic: https://groups.io/mt/102200532/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-