From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id B2CD5740034 for ; Thu, 26 Oct 2023 23:54:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=+lb3ZH/OJNRvq0MbINNhn13nl1v7lx7qG0covd0t35E=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1698364446; v=1; b=b8NbkTX7n4HJCTDVtGaAMSrsINRXx15IY4hqN3y3Lc6EVpWa5FifviyZ9d9DTyzsBxAvodI4 8hKX/cyEWdrFQDkd20T5FaQhp/Grm+OMV9wG7x3SWtmD+Vex5+bqX+trzRcmh+fRGwOAw0aIm0n +6KByMzuWiIpYXncGX97YzBY= X-Received: by 127.0.0.2 with SMTP id 5oiIYY7687511x04e2JKoozN; Thu, 26 Oct 2023 16:54:06 -0700 X-Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by mx.groups.io with SMTP id smtpd.web10.215567.1698364444710503378 for ; Thu, 26 Oct 2023 16:54:05 -0700 X-Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-5082a874098so12064e87.3 for ; Thu, 26 Oct 2023 16:54:04 -0700 (PDT) X-Gm-Message-State: Imt0DiTLpi19jJX0F8kPOPFlx7686176AA= X-Google-Smtp-Source: AGHT+IGVAoSDDFuitkrllyL5mtam3hiR9hyr/qnqfvSDj6zz2i87kIco8wTflWyrJ/zZK9YSP7OH8w== X-Received: by 2002:ac2:48b4:0:b0:507:9f0a:60e5 with SMTP id u20-20020ac248b4000000b005079f0a60e5mr574393lfg.43.1698364442785; Thu, 26 Oct 2023 16:54:02 -0700 (PDT) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id u8-20020a056512040800b00507a8789b43sm39389lfk.269.2023.10.26.16.54.02 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 26 Oct 2023 16:54:02 -0700 (PDT) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [edk2-redfish-client][PATCH v2 07/11] RedfishClientPkg: fix memory leak Date: Fri, 27 Oct 2023 02:53:50 +0300 Message-Id: <20231026235354.67625-8-mike.maslenkin@gmail.com> In-Reply-To: <20231026235354.67625-1-mike.maslenkin@gmail.com> References: <20231026235354.67625-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=b8NbkTX7; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io This patch fixes leak in RedfishExternalResourceResourceFeatureCallback function. Signed-off-by: Mike Maslenkin --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c b/RedfishC= lientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c index 32dca964aa0a..9b336d3de479 100644 --- a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c +++ b/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c @@ -718,6 +718,7 @@ RedfishExternalResourceResourceFeatureCallback ( Private->Uri =3D RedfishGetUri (ResourceUri);=0D if (Private->Uri =3D=3D NULL) {=0D ASSERT (FALSE);=0D + FreePool (ResourceUri);=0D return EFI_OUT_OF_RESOURCES;=0D }=0D =0D @@ -727,6 +728,7 @@ RedfishExternalResourceResourceFeatureCallback ( }=0D =0D FreePool (Private->Uri);=0D + FreePool (ResourceUri);=0D return Status;=0D }=0D =0D --=20 2.32.0 (Apple Git-132) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110152): https://edk2.groups.io/g/devel/message/110152 Mute This Topic: https://groups.io/mt/102211776/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-