public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chang, Abner via groups.io" <abner.chang=amd.com@groups.io>
To: <devel@edk2.groups.io>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Chasel Chiu <chasel.chiu@intel.com>,
	Li-Xia Huang <lisa.huang@intel.com>,
	Abdul Lateef Attar <AbdulLateef.Attar@amd.com>,
	Nickle Wang <nicklew@nvidia.com>
Subject: [edk2-devel] [edk2-platforms][PATCH] Features/IpmiFeaturePkg: Remove IpmiCommandLib from IpmiFeaturePkg
Date: Mon, 30 Oct 2023 14:58:50 +0800	[thread overview]
Message-ID: <20231030065850.1016-1-abner.chang@amd.com> (raw)

From: Abner Chang <abner.chang@amd.com>

Remove IpmiCommandLib from IpmiFeaturePkg as ManageabilityPkg
already had one and is newer.

Signed-off-by: Abner Chang <abner.chang@amd.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Li-Xia Huang <lisa.huang@intel.com>
Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com>
Cc: Nickle Wang <nicklew@nvidia.com>
---
 .../IpmiFeaturePkg/IpmiFeaturePkg.dec         |   4 -
 .../IpmiFeaturePkg/Include/IpmiFeature.dsc    |   2 +-
 .../Library/IpmiCommandLib/IpmiCommandLib.inf |  32 --
 .../IpmiCommandLib/IpmiCommandLibNetFnApp.c   | 335 ------------------
 .../IpmiCommandLibNetFnChassis.c              | 144 --------
 .../IpmiCommandLibNetFnStorage.c              | 274 --------------
 .../IpmiCommandLibNetFnTransport.c            | 123 -------
 7 files changed, 1 insertion(+), 913 deletions(-)
 delete mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLib.inf
 delete mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnApp.c
 delete mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnChassis.c
 delete mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnStorage.c
 delete mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnTransport.c

diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec
index 5df71300cb..f26741e244 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec
@@ -32,10 +32,6 @@
   OsWdt
 
 [LibraryClasses]
-  ## @libraryclass  Provides services to send IPMI commands.
-  #
-  IpmiCommandLib|Include/Library/IpmiCommandLib.inf
-
   ## @libraryclass  Provides an API for platform-specific IPMI hooks.
   #
   IpmiCommandLib|Include/Library/IpmiPlatformHookLib.h
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
index 0401974b82..063638ce56 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc
@@ -37,7 +37,7 @@
 [LibraryClasses]
   IpmiLib|MdeModulePkg/Library/BaseIpmiLibNull/BaseIpmiLibNull.inf
 
-  IpmiCommandLib|IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLib.inf
+  IpmiCommandLib|ManageabilityPkg/Library/IpmiCommandLib/IpmiCommandLib.inf
   IpmiPlatformHookLib|IpmiFeaturePkg/Library/IpmiPlatformHookLibNull/IpmiPlatformHookLibNull.inf
 
 [LibraryClasses.common.PEI_CORE,LibraryClasses.common.PEIM]
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLib.inf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLib.inf
deleted file mode 100644
index d5c14ff2a4..0000000000
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLib.inf
+++ /dev/null
@@ -1,32 +0,0 @@
-### @file
-# Component description file for IPMI Command Library.
-#
-# Copyright (c) 2018 - 2021, Intel Corporation. All rights reserved.<BR>
-#
-# SPDX-License-Identifier: BSD-2-Clause-Patent
-#
-###
-
-[Defines]
-  INF_VERSION                    = 0x00010005
-  BASE_NAME                      = IpmiCommandLib
-  FILE_GUID                      = E599C9C7-5913-40A0-8669-67282E2BEC53
-  MODULE_TYPE                    = UEFI_DRIVER
-  VERSION_STRING                 = 1.0
-  LIBRARY_CLASS                  = IpmiCommandLib
-
-[sources]
-  IpmiCommandLibNetFnApp.c
-  IpmiCommandLibNetFnTransport.c
-  IpmiCommandLibNetFnChassis.c
-  IpmiCommandLibNetFnStorage.c
-
-[Packages]
-  MdePkg/MdePkg.dec
-  MdeModulePkg/MdeModulePkg.dec
-  IpmiFeaturePkg/IpmiFeaturePkg.dec
-
-[LibraryClasses]
-  BaseMemoryLib
-  DebugLib
-  IpmiBaseLib
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnApp.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnApp.c
deleted file mode 100644
index 2e34909f3e..0000000000
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnApp.c
+++ /dev/null
@@ -1,335 +0,0 @@
-/** @file
-  IPMI Command - NetFnApp.
-
-  Copyright (c) 2018 - 2021, Intel Corporation. All rights reserved.<BR>
-  Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
-
-  SPDX-License-Identifier: BSD-2-Clause-Patent
-**/
-
-#include <PiPei.h>
-#include <Library/BaseMemoryLib.h>
-#include <Library/DebugLib.h>
-#include <Library/IpmiBaseLib.h>
-
-#include <IndustryStandard/Ipmi.h>
-
-EFI_STATUS
-EFIAPI
-IpmiGetDeviceId (
-  OUT IPMI_GET_DEVICE_ID_RESPONSE  *DeviceId
-  )
-{
-  EFI_STATUS                   Status;
-  UINT32                       DataSize;
-
-  DataSize = sizeof(*DeviceId);
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_APP,
-             IPMI_APP_GET_DEVICE_ID,
-             NULL,
-             0,
-             (VOID *)DeviceId,
-             &DataSize
-             );
-  return Status;
-}
-
-EFI_STATUS
-EFIAPI
-IpmiGetSelfTestResult (
-  OUT IPMI_SELF_TEST_RESULT_RESPONSE   *SelfTestResult
-  )
-{
-  EFI_STATUS                   Status;
-  UINT32                       DataSize;
-
-  DataSize = sizeof(*SelfTestResult);
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_APP,
-             IPMI_APP_GET_SELFTEST_RESULTS,
-             NULL,
-             0,
-             (VOID *)SelfTestResult,
-             &DataSize
-             );
-  return Status;
-}
-
-EFI_STATUS
-EFIAPI
-IpmiResetWatchdogTimer (
-  OUT UINT8                            *CompletionCode
-  )
-{
-  EFI_STATUS                   Status;
-  UINT32                       DataSize;
-
-  DataSize = sizeof(*CompletionCode);
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_APP,
-             IPMI_APP_RESET_WATCHDOG_TIMER,
-             NULL,
-             0,
-             (VOID *)CompletionCode,
-             &DataSize
-             );
-  return Status;
-}
-
-EFI_STATUS
-EFIAPI
-IpmiSetWatchdogTimer (
-  IN  IPMI_SET_WATCHDOG_TIMER_REQUEST  *SetWatchdogTimer,
-  OUT UINT8                            *CompletionCode
-  )
-{
-  EFI_STATUS                   Status;
-  UINT32                       DataSize;
-
-  DataSize = sizeof(*CompletionCode);
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_APP,
-             IPMI_APP_SET_WATCHDOG_TIMER,
-             (VOID *)SetWatchdogTimer,
-             sizeof(*SetWatchdogTimer),
-             (VOID *)CompletionCode,
-             &DataSize
-             );
-  return Status;
-}
-
-EFI_STATUS
-EFIAPI
-IpmiGetWatchdogTimer (
-  OUT IPMI_GET_WATCHDOG_TIMER_RESPONSE *GetWatchdogTimer
-  )
-{
-  EFI_STATUS                   Status;
-  UINT32                       DataSize;
-
-  DataSize = sizeof(*GetWatchdogTimer);
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_APP,
-             IPMI_APP_GET_WATCHDOG_TIMER,
-             NULL,
-             0,
-             (VOID *)GetWatchdogTimer,
-             &DataSize
-             );
-  return Status;
-}
-
-EFI_STATUS
-EFIAPI
-IpmiSetBmcGlobalEnables (
-  IN  IPMI_SET_BMC_GLOBAL_ENABLES_REQUEST  *SetBmcGlobalEnables,
-  OUT UINT8                                *CompletionCode
-  )
-{
-  EFI_STATUS                   Status;
-  UINT32                       DataSize;
-
-  DataSize = sizeof(*CompletionCode);
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_APP,
-             IPMI_APP_SET_BMC_GLOBAL_ENABLES,
-             (VOID *)SetBmcGlobalEnables,
-             sizeof(*SetBmcGlobalEnables),
-             (VOID *)CompletionCode,
-             &DataSize
-             );
-  return Status;
-}
-
-EFI_STATUS
-EFIAPI
-IpmiGetBmcGlobalEnables (
-  OUT IPMI_GET_BMC_GLOBAL_ENABLES_RESPONSE *GetBmcGlobalEnables
-  )
-{
-  EFI_STATUS                   Status;
-  UINT32                       DataSize;
-
-  DataSize = sizeof(*GetBmcGlobalEnables);
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_APP,
-             IPMI_APP_GET_BMC_GLOBAL_ENABLES,
-             NULL,
-             0,
-             (VOID *)GetBmcGlobalEnables,
-             &DataSize
-             );
-  return Status;
-}
-
-EFI_STATUS
-EFIAPI
-IpmiClearMessageFlags (
-  IN  IPMI_CLEAR_MESSAGE_FLAGS_REQUEST  *ClearMessageFlagsRequest,
-  OUT UINT8                             *CompletionCode
-  )
-{
-  EFI_STATUS                   Status;
-  UINT32                       DataSize;
-
-  DataSize = sizeof(*CompletionCode);
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_APP,
-             IPMI_APP_CLEAR_MESSAGE_FLAGS,
-             (VOID *)ClearMessageFlagsRequest,
-             sizeof(*ClearMessageFlagsRequest),
-             (VOID *)CompletionCode,
-             &DataSize
-             );
-  return Status;
-}
-
-EFI_STATUS
-EFIAPI
-IpmiGetMessageFlags (
-  OUT IPMI_GET_MESSAGE_FLAGS_RESPONSE *GetMessageFlagsResponse
-  )
-{
-  EFI_STATUS                   Status;
-  UINT32                       DataSize;
-
-  DataSize = sizeof(*GetMessageFlagsResponse);
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_APP,
-             IPMI_APP_GET_MESSAGE_FLAGS,
-             NULL,
-             0,
-             (VOID *)GetMessageFlagsResponse,
-             &DataSize
-             );
-  return Status;
-}
-
-EFI_STATUS
-EFIAPI
-IpmiGetMessage (
-  OUT IPMI_GET_MESSAGE_RESPONSE *GetMessageResponse,
-  IN OUT UINT32                 *GetMessageResponseSize
-  )
-{
-  EFI_STATUS                   Status;
-
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_APP,
-             IPMI_APP_GET_MESSAGE,
-             NULL,
-             0,
-             (VOID *)GetMessageResponse,
-             GetMessageResponseSize
-             );
-  return Status;
-}
-
-EFI_STATUS
-EFIAPI
-IpmiSendMessage (
-  IN  IPMI_SEND_MESSAGE_REQUEST  *SendMessageRequest,
-  IN  UINT32                     SendMessageRequestSize,
-  OUT IPMI_SEND_MESSAGE_RESPONSE *SendMessageResponse,
-  IN OUT UINT32                  *SendMessageResponseSize
-  )
-{
-  EFI_STATUS                   Status;
-
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_APP,
-             IPMI_APP_SEND_MESSAGE,
-             (VOID *)SendMessageRequest,
-             SendMessageRequestSize,
-             (VOID *)SendMessageResponse,
-             SendMessageResponseSize
-             );
-  return Status;
-}
-
-/**
-  This function gets the system UUID.
-
-  @param[out] SystemGuid   The pointer to retrieve system UUID.
-
-  @retval EFI_SUCCESS               UUID is returned.
-  @retval EFI_INVALID_PARAMETER     SystemGuid is a NULL pointer.
-  @retval Others                    Other errors.
-
-**/
-EFI_STATUS
-EFIAPI
-IpmiGetSystemUuid (
-  OUT EFI_GUID *SystemGuid
-  )
-{
-  EFI_STATUS                    Status;
-  UINT32                        RequestSize;
-  UINT32                        ResponseSize;
-  IPMI_GET_SYSTEM_UUID_RESPONSE GetSystemUuidResponse;
-
-  if (SystemGuid == NULL) {
-    return EFI_INVALID_PARAMETER;
-  }
-  RequestSize = 0;
-  ResponseSize = sizeof (IPMI_GET_SYSTEM_UUID_RESPONSE);
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_APP,
-             IPMI_APP_GET_SYSTEM_GUID,
-             (VOID *)NULL,
-             RequestSize,
-             (VOID *)&GetSystemUuidResponse,
-             &ResponseSize
-             );
-  if (!EFI_ERROR (Status) && GetSystemUuidResponse.CompletionCode == IPMI_COMP_CODE_NORMAL) {
-    CopyMem (
-      (VOID *)SystemGuid,
-      (VOID *)&GetSystemUuidResponse.SystemUuid,
-      sizeof (EFI_GUID)
-      );
-  }
-  return Status;
-}
-
-/**
-  This function gets the channel information.
-
-  @param[in]  GetChannelInfoRequest          The get channel information request.
-  @param[out] GetChannelInfoResponse         The get channel information response.
-  @param[out] GetChannelInfoResponseSize     When input, the expected size of response.
-                                             When output, the exact size of the returned
-                                             response.
-
-  @retval EFI_SUCCESS            Get channel information successfully.
-  @retval EFI_INVALID_PARAMETER  One of the given input parameters is invalid.
-  @retval Others                 Other errors.
-
-**/
-EFI_STATUS
-EFIAPI
-IpmiGetChannelInfo (
-  IN  IPMI_GET_CHANNEL_INFO_REQUEST  *GetChannelInfoRequest,
-  OUT IPMI_GET_CHANNEL_INFO_RESPONSE *GetChannelInfoResponse,
-  OUT UINT32                         *GetChannelInfoResponseSize
-  )
-{
-  EFI_STATUS Status;
-
-  if (GetChannelInfoRequest == NULL ||
-      GetChannelInfoResponse == NULL ||
-      GetChannelInfoResponseSize == NULL) {
-    return EFI_INVALID_PARAMETER;
-  }
-
-  *GetChannelInfoResponseSize = sizeof (IPMI_GET_CHANNEL_INFO_RESPONSE);
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_APP,
-             IPMI_APP_GET_CHANNEL_INFO,
-             (UINT8 *)GetChannelInfoRequest,
-             sizeof (IPMI_GET_CHANNEL_INFO_REQUEST),
-             (UINT8 *)GetChannelInfoResponse,
-             GetChannelInfoResponseSize
-             );
-  return Status;
-}
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnChassis.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnChassis.c
deleted file mode 100644
index 9c19f52ce4..0000000000
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnChassis.c
+++ /dev/null
@@ -1,144 +0,0 @@
-/** @file
-  IPMI Command - NetFnChassis.
-
-  Copyright (c) 2018 - 2021, Intel Corporation. All rights reserved.<BR>
-  SPDX-License-Identifier: BSD-2-Clause-Patent
-**/
-
-#include <PiPei.h>
-#include <Library/BaseMemoryLib.h>
-#include <Library/DebugLib.h>
-#include <Library/IpmiBaseLib.h>
-
-#include <IndustryStandard/Ipmi.h>
-
-
-EFI_STATUS
-EFIAPI
-IpmiGetChassisCapabilities (
-  OUT IPMI_GET_CHASSIS_CAPABILITIES_RESPONSE  *GetChassisCapabilitiesResponse
-  )
-{
-  EFI_STATUS                   Status;
-  UINT32                       DataSize;
-
-  DataSize = sizeof(*GetChassisCapabilitiesResponse);
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_CHASSIS,
-             IPMI_CHASSIS_GET_CAPABILITIES,
-             NULL,
-             0,
-             (VOID *)GetChassisCapabilitiesResponse,
-             &DataSize
-             );
-  return Status;
-}
-
-EFI_STATUS
-EFIAPI
-IpmiGetChassisStatus (
-  OUT IPMI_GET_CHASSIS_STATUS_RESPONSE  *GetChassisStatusResponse
-  )
-{
-  EFI_STATUS                   Status;
-  UINT32                       DataSize;
-
-  DataSize = sizeof(*GetChassisStatusResponse);
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_CHASSIS,
-             IPMI_CHASSIS_GET_STATUS,
-             NULL,
-             0,
-             (VOID *)GetChassisStatusResponse,
-             &DataSize
-             );
-  return Status;
-}
-
-EFI_STATUS
-EFIAPI
-IpmiChassisControl (
-  IN IPMI_CHASSIS_CONTROL_REQUEST  *ChassisControlRequest,
-  OUT UINT8                        *CompletionCode
-  )
-{
-  EFI_STATUS                   Status;
-  UINT32                       DataSize;
-
-  DataSize = sizeof(*CompletionCode);
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_CHASSIS,
-             IPMI_CHASSIS_CONTROL,
-             (VOID *)ChassisControlRequest,
-             sizeof(*ChassisControlRequest),
-             (VOID *)CompletionCode,
-             &DataSize
-             );
-  return Status;
-}
-
-EFI_STATUS
-EFIAPI
-IpmiSetPowerRestorePolicy (
-  IN  IPMI_SET_POWER_RESTORE_POLICY_REQUEST  *ChassisControlRequest,
-  OUT IPMI_SET_POWER_RESTORE_POLICY_RESPONSE *ChassisControlResponse
-  )
-{
-  EFI_STATUS                   Status;
-  UINT32                       DataSize;
-
-  DataSize = sizeof(*ChassisControlResponse);
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_CHASSIS,
-             IPMI_CHASSIS_SET_POWER_RESTORE_POLICY,
-             (VOID *)ChassisControlRequest,
-             sizeof(*ChassisControlRequest),
-             (VOID *)ChassisControlResponse,
-             &DataSize
-             );
-  return Status;
-}
-
-EFI_STATUS
-EFIAPI
-IpmiSetSystemBootOptions (
-  IN  IPMI_SET_BOOT_OPTIONS_REQUEST   *BootOptionsRequest,
-  OUT IPMI_SET_BOOT_OPTIONS_RESPONSE  *BootOptionsResponse
-  )
-{
-  EFI_STATUS                   Status;
-  UINT32                       DataSize;
-
-  DataSize = sizeof(*BootOptionsResponse);
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_CHASSIS,
-             IPMI_CHASSIS_SET_SYSTEM_BOOT_OPTIONS,
-             (VOID *)BootOptionsRequest,
-             sizeof(*BootOptionsRequest),
-             (VOID *)BootOptionsResponse,
-             &DataSize
-             );
-  return Status;
-}
-
-EFI_STATUS
-EFIAPI
-IpmiGetSystemBootOptions (
-  IN  IPMI_GET_BOOT_OPTIONS_REQUEST  *BootOptionsRequest,
-  OUT IPMI_GET_BOOT_OPTIONS_RESPONSE *BootOptionsResponse
-  )
-{
-  EFI_STATUS                   Status;
-  UINT32                       DataSize;
-
-  DataSize = sizeof(*BootOptionsResponse);
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_CHASSIS,
-             IPMI_CHASSIS_GET_SYSTEM_BOOT_OPTIONS,
-             (VOID *)BootOptionsRequest,
-             sizeof(*BootOptionsRequest),
-             (VOID *)BootOptionsResponse,
-             &DataSize
-             );
-  return Status;
-}
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnStorage.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnStorage.c
deleted file mode 100644
index 2215028089..0000000000
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnStorage.c
+++ /dev/null
@@ -1,274 +0,0 @@
-/** @file
-  IPMI Command - NetFnStorage.
-
-  Copyright (c) 2018 - 2021, Intel Corporation. All rights reserved.<BR>
-  SPDX-License-Identifier: BSD-2-Clause-Patent
-**/
-
-#include <PiPei.h>
-#include <Library/BaseMemoryLib.h>
-#include <Library/DebugLib.h>
-#include <Library/IpmiBaseLib.h>
-
-#include <IndustryStandard/Ipmi.h>
-
-
-EFI_STATUS
-EFIAPI
-IpmiGetFruInventoryAreaInfo (
-  IN  IPMI_GET_FRU_INVENTORY_AREA_INFO_REQUEST   *GetFruInventoryAreaInfoRequest,
-  OUT IPMI_GET_FRU_INVENTORY_AREA_INFO_RESPONSE  *GetFruInventoryAreaInfoResponse
-  )
-{
-  EFI_STATUS                   Status;
-  UINT32                       DataSize;
-
-  DataSize = sizeof(*GetFruInventoryAreaInfoResponse);
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_STORAGE,
-             IPMI_STORAGE_GET_FRU_INVENTORY_AREAINFO,
-             (VOID *)GetFruInventoryAreaInfoRequest,
-             sizeof(*GetFruInventoryAreaInfoRequest),
-             (VOID *)GetFruInventoryAreaInfoResponse,
-             &DataSize
-             );
-  return Status;
-}
-
-EFI_STATUS
-EFIAPI
-IpmiReadFruData (
-  IN  IPMI_READ_FRU_DATA_REQUEST        *ReadFruDataRequest,
-  OUT IPMI_READ_FRU_DATA_RESPONSE       *ReadFruDataResponse,
-  IN OUT UINT32                         *ReadFruDataResponseSize
-  )
-{
-  EFI_STATUS                   Status;
-
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_STORAGE,
-             IPMI_STORAGE_READ_FRU_DATA,
-             (VOID *)ReadFruDataRequest,
-             sizeof(*ReadFruDataRequest),
-             (VOID *)ReadFruDataResponse,
-             ReadFruDataResponseSize
-             );
-  return Status;
-}
-
-EFI_STATUS
-EFIAPI
-IpmiWriteFruData (
-  IN  IPMI_WRITE_FRU_DATA_REQUEST       *WriteFruDataRequest,
-  IN  UINT32                            WriteFruDataRequestSize,
-  OUT IPMI_WRITE_FRU_DATA_RESPONSE      *WriteFruDataResponse
-  )
-{
-  EFI_STATUS                   Status;
-  UINT32                       DataSize;
-
-  DataSize = sizeof(*WriteFruDataResponse);
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_STORAGE,
-             IPMI_STORAGE_WRITE_FRU_DATA,
-             (VOID *)WriteFruDataRequest,
-             WriteFruDataRequestSize,
-             (VOID *)WriteFruDataResponse,
-             &DataSize
-             );
-  return Status;
-}
-
-EFI_STATUS
-EFIAPI
-IpmiGetSelInfo (
-  OUT IPMI_GET_SEL_INFO_RESPONSE  *GetSelInfoResponse
-  )
-{
-  EFI_STATUS                   Status;
-  UINT32                       DataSize;
-
-  DataSize = sizeof(*GetSelInfoResponse);
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_STORAGE,
-             IPMI_STORAGE_GET_SEL_INFO,
-             NULL,
-             0,
-             (VOID *)GetSelInfoResponse,
-             &DataSize
-             );
-  return Status;
-}
-
-EFI_STATUS
-EFIAPI
-IpmiGetSelEntry (
-  IN IPMI_GET_SEL_ENTRY_REQUEST    *GetSelEntryRequest,
-  OUT IPMI_GET_SEL_ENTRY_RESPONSE  *GetSelEntryResponse,
-  IN OUT UINT32                    *GetSelEntryResponseSize
-  )
-{
-  EFI_STATUS                   Status;
-
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_STORAGE,
-             IPMI_STORAGE_GET_SEL_ENTRY,
-             (VOID *)GetSelEntryRequest,
-             sizeof(*GetSelEntryRequest),
-             (VOID *)GetSelEntryResponse,
-             GetSelEntryResponseSize
-             );
-  return Status;
-}
-
-EFI_STATUS
-EFIAPI
-IpmiAddSelEntry (
-  IN IPMI_ADD_SEL_ENTRY_REQUEST    *AddSelEntryRequest,
-  OUT IPMI_ADD_SEL_ENTRY_RESPONSE  *AddSelEntryResponse
-  )
-{
-  EFI_STATUS                   Status;
-  UINT32                       DataSize;
-
-  DataSize = sizeof(*AddSelEntryResponse);
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_STORAGE,
-             IPMI_STORAGE_ADD_SEL_ENTRY,
-             (VOID *)AddSelEntryRequest,
-             sizeof(*AddSelEntryRequest),
-             (VOID *)AddSelEntryResponse,
-             &DataSize
-             );
-  return Status;
-}
-
-EFI_STATUS
-EFIAPI
-IpmiPartialAddSelEntry (
-  IN IPMI_PARTIAL_ADD_SEL_ENTRY_REQUEST    *PartialAddSelEntryRequest,
-  IN UINT32                                PartialAddSelEntryRequestSize,
-  OUT IPMI_PARTIAL_ADD_SEL_ENTRY_RESPONSE  *PartialAddSelEntryResponse
-  )
-{
-  EFI_STATUS                   Status;
-  UINT32                       DataSize;
-
-  DataSize = sizeof(*PartialAddSelEntryResponse);
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_STORAGE,
-             IPMI_STORAGE_PARTIAL_ADD_SEL_ENTRY,
-             (VOID *)PartialAddSelEntryRequest,
-             PartialAddSelEntryRequestSize,
-             (VOID *)PartialAddSelEntryResponse,
-             &DataSize
-             );
-  return Status;
-}
-
-EFI_STATUS
-EFIAPI
-IpmiClearSel (
-  IN IPMI_CLEAR_SEL_REQUEST   *ClearSelRequest,
-  OUT IPMI_CLEAR_SEL_RESPONSE *ClearSelResponse
-  )
-{
-  EFI_STATUS                   Status;
-  UINT32                       DataSize;
-
-  DataSize = sizeof(*ClearSelResponse);
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_STORAGE,
-             IPMI_STORAGE_CLEAR_SEL,
-             (VOID *)ClearSelRequest,
-             sizeof(*ClearSelRequest),
-             (VOID *)ClearSelResponse,
-             &DataSize
-             );
-  return Status;
-}
-
-EFI_STATUS
-EFIAPI
-IpmiGetSelTime (
-  OUT IPMI_GET_SEL_TIME_RESPONSE *GetSelTimeResponse
-  )
-{
-  EFI_STATUS                   Status;
-  UINT32                       DataSize;
-
-  DataSize = sizeof(*GetSelTimeResponse);
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_STORAGE,
-             IPMI_STORAGE_GET_SEL_TIME,
-             NULL,
-             0,
-             (VOID *)GetSelTimeResponse,
-             &DataSize
-             );
-  return Status;
-}
-
-EFI_STATUS
-EFIAPI
-IpmiSetSelTime (
-  IN IPMI_SET_SEL_TIME_REQUEST  *SetSelTimeRequest,
-  OUT UINT8                     *CompletionCode
-  )
-{
-  EFI_STATUS                   Status;
-  UINT32                       DataSize;
-
-  DataSize = sizeof(*CompletionCode);
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_STORAGE,
-             IPMI_STORAGE_SET_SEL_TIME,
-             (VOID *)SetSelTimeRequest,
-             sizeof(*SetSelTimeRequest),
-             (VOID *)CompletionCode,
-             &DataSize
-             );
-  return Status;
-}
-
-EFI_STATUS
-EFIAPI
-IpmiGetSdrRepositoryInfo (
-  OUT IPMI_GET_SDR_REPOSITORY_INFO_RESPONSE  *GetSdrRepositoryInfoResp
-  )
-{
-  EFI_STATUS                   Status;
-  UINT32                       DataSize;
-
-  DataSize = sizeof(*GetSdrRepositoryInfoResp);
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_STORAGE,
-             IPMI_STORAGE_GET_SDR_REPOSITORY_INFO,
-             NULL,
-             0,
-             (VOID *)GetSdrRepositoryInfoResp,
-             &DataSize
-             );
-  return Status;
-}
-
-EFI_STATUS
-EFIAPI
-IpmiGetSdr (
-  IN  IPMI_GET_SDR_REQUEST          *GetSdrRequest,
-  OUT IPMI_GET_SDR_RESPONSE         *GetSdrResponse,
-  IN OUT UINT32                     *GetSdrResponseSize
-  )
-{
-  EFI_STATUS                   Status;
-
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_STORAGE,
-             IPMI_STORAGE_GET_SDR,
-             (VOID *)GetSdrRequest,
-             sizeof(*GetSdrRequest),
-             (VOID *)GetSdrResponse,
-             GetSdrResponseSize
-             );
-  return Status;
-}
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnTransport.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnTransport.c
deleted file mode 100644
index 30ea84c04b..0000000000
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnTransport.c
+++ /dev/null
@@ -1,123 +0,0 @@
-/** @file
-  IPMI Command - NetFnTransport.
-
-  Copyright (c) 2018 - 2021, Intel Corporation. All rights reserved.<BR>
-  Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
-
-  SPDX-License-Identifier: BSD-2-Clause-Patent
-**/
-
-#include <PiPei.h>
-#include <Library/BaseMemoryLib.h>
-#include <Library/DebugLib.h>
-#include <Library/IpmiBaseLib.h>
-
-#include <IndustryStandard/Ipmi.h>
-
-
-EFI_STATUS
-EFIAPI
-IpmiSolActivating (
-  IN  IPMI_SOL_ACTIVATING_REQUEST  *SolActivatingRequest,
-  OUT UINT8                        *CompletionCode
-  )
-{
-  EFI_STATUS                   Status;
-  UINT32                       DataSize;
-
-  DataSize = sizeof(*CompletionCode);
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_TRANSPORT,
-             IPMI_TRANSPORT_SOL_ACTIVATING,
-             (VOID *)SolActivatingRequest,
-             sizeof(*SolActivatingRequest),
-             (VOID *)CompletionCode,
-             &DataSize
-             );
-  return Status;
-}
-
-EFI_STATUS
-EFIAPI
-IpmiSetSolConfigurationParameters (
-  IN  IPMI_SET_SOL_CONFIGURATION_PARAMETERS_REQUEST  *SetConfigurationParametersRequest,
-  IN  UINT32                                         SetConfigurationParametersRequestSize,
-  OUT UINT8                                          *CompletionCode
-  )
-{
-  EFI_STATUS                   Status;
-  UINT32                       DataSize;
-
-  DataSize = sizeof(*CompletionCode);
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_TRANSPORT,
-             IPMI_TRANSPORT_SET_SOL_CONFIG_PARAM,
-             (VOID *)SetConfigurationParametersRequest,
-             SetConfigurationParametersRequestSize,
-             (VOID *)CompletionCode,
-             &DataSize
-             );
-  return Status;
-}
-
-EFI_STATUS
-EFIAPI
-IpmiGetSolConfigurationParameters (
-  IN  IPMI_GET_SOL_CONFIGURATION_PARAMETERS_REQUEST  *GetConfigurationParametersRequest,
-  OUT IPMI_GET_SOL_CONFIGURATION_PARAMETERS_RESPONSE *GetConfigurationParametersResponse,
-  IN OUT UINT32                                      *GetConfigurationParametersResponseSize
-  )
-{
-  EFI_STATUS                   Status;
-
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_TRANSPORT,
-             IPMI_TRANSPORT_GET_SOL_CONFIG_PARAM,
-             (VOID *)GetConfigurationParametersRequest,
-             sizeof(*GetConfigurationParametersRequest),
-             (VOID *)GetConfigurationParametersResponse,
-             GetConfigurationParametersResponseSize
-             );
-  return Status;
-}
-
-/**
-  This function gets the LAN configuration parameter.
-
-  @param[in]     GetLanConfigurationParametersRequest   Request data
-  @param[out]    GetLanConfigurationParametersResponse  Response data
-  @param[in,out] GetLanConfigurationParametersSize      When input, the expected size of response data.
-                                                        When out, the exact  size of response data.
-
-  @retval EFI_SUCCESS            Lan configuration parameter is returned in the response.
-  @retval EFI_INVALID_PARAMETER  One of the given input parameters is invalid.
-  @retval Others                 Other errors.
-
-**/
-
-EFI_STATUS
-EFIAPI
-IpmiGetLanConfigurationParameters (
-  IN     IPMI_GET_LAN_CONFIGURATION_PARAMETERS_REQUEST  *GetLanConfigurationParametersRequest,
-  OUT    IPMI_GET_LAN_CONFIGURATION_PARAMETERS_RESPONSE *GetLanConfigurationParametersResponse,
-  IN OUT UINT32                                         *GetLanConfigurationParametersSize
-  )
-{
-  EFI_STATUS Status;
-
-  if (GetLanConfigurationParametersRequest == NULL ||
-      GetLanConfigurationParametersResponse == NULL ||
-      GetLanConfigurationParametersSize == NULL) {
-    return EFI_INVALID_PARAMETER;
-  }
-
-  Status = IpmiSubmitCommand (
-             IPMI_NETFN_TRANSPORT,
-             IPMI_TRANSPORT_GET_LAN_CONFIG_PARAMETERS,
-             (UINT8 *)GetLanConfigurationParametersRequest,
-             sizeof(*GetLanConfigurationParametersRequest),
-             (UINT8 *)GetLanConfigurationParametersResponse,
-             GetLanConfigurationParametersSize
-             );
-  return Status;
-}
-- 
2.37.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110292): https://edk2.groups.io/g/devel/message/110292
Mute This Topic: https://groups.io/mt/102270138/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



             reply	other threads:[~2023-10-30  6:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-30  6:58 Chang, Abner via groups.io [this message]
     [not found] <1792D0690F720C15.7262@groups.io>
2023-11-08  3:22 ` [edk2-devel] [edk2-platforms][PATCH] Features/IpmiFeaturePkg: Remove IpmiCommandLib from IpmiFeaturePkg Chang, Abner via groups.io

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231030065850.1016-1-abner.chang@amd.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox