From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 42CBE94006B for ; Tue, 31 Oct 2023 01:41:44 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=w7OJ2D9wDi5a5MmSBn61oTo/mWEWPIn5mjC+RAI3ahw=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:From:To:Cc:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1698716503; v=1; b=oI2V5s73nyMyx/Vx34JyMspFgDMvy3rdLbppoV9pzlCjuzVPyJzGNSV0ScWgQXyEzHnyV7E8 WMJc7TBPnOWb+2DASW1sA/buW9h0b582wcfk0DcavvpObC2A+b/MYW1htvzQfTYFE5PQcFsvQHS 6H006FCRPqAAkagSVdE/jw0w= X-Received: by 127.0.0.2 with SMTP id yxRiYY7687511xfwyjST55Hb; Mon, 30 Oct 2023 18:41:43 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.177445.1698716502514544013 for ; Mon, 30 Oct 2023 18:41:42 -0700 X-Received: from localhost.localdomain (unknown [47.201.241.95]) by linux.microsoft.com (Postfix) with ESMTPSA id 7AF7820B74C0; Mon, 30 Oct 2023 18:41:41 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7AF7820B74C0 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Sean Brogan , Michael Kubacki , Michael D Kinney , Laszlo Ersek Subject: [edk2-devel] [PATCH v1 1/1] .github/workflows: Add Stale Check Date: Mon, 30 Oct 2023 21:41:19 -0400 Message-ID: <20231031014120.917-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: NOODHeppEwpOZ6I9vSd6gPiGx7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=oI2V5s73; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io From: Michael Kubacki Adds a GitHub workflow that uses the actions/stale GitHub action to automatically leave notifications on and close PRs that have had no activity for a long time. Note: Modifications to a PR reset the staleness counter. This includes pushing to the PR, adding a label to the PR, commenting on the PR, etc. If a PR has been marked "stale", simply leaving a comment will reset the counter. Configuration choices: 1. Do not attempt to close edk2 GitHub issues. 2. Mark edk2 PRs as stale if no activity in the last 60 days. Close PRs marked stale if no further activity in 7 days. 3. Do not exempt PRs with a "push" label. 4. Run the check once daily. Allow manual runs from those that have permission to run GitHub workflows. 5. Add the label "stale" to the PR when it enters the stale state. Rationale: 1. We do not use issues often enough. The limited usage of GitHub issues in Tianocore org GitHub projects are in another repo not impacted by this workflow and expected to track long term tasks. 2. This is the default value. In non-edk2 projects, I've seen these times work fairly well to identify PRs that have fallen stale. 3. Adding a "push" label resets the stale timer. If a PR has had a "push" label for 60+ days and has not been fixed for submission, then it is has very likely been abandoned. 4. This is sufficient to update PRs on the day granularity the configuration settings are applied against. 5. The label makes it easy to filter stale PRs in the PR list and write automation around PRs that are stale. It's also an obvious visual identifier that a PR needs attention in the PR list. Cc: Sean Brogan Cc: Michael Kubacki Cc: Michael D Kinney Cc: Laszlo Ersek Signed-off-by: Michael Kubacki --- Notes: I tested this workflow on my edk2 fork: =20 https://github.com/makubacki/edk2/actions/runs/6700887619 =20 Here's an example of a PR it did not mark stale there: =20 https://github.com/makubacki/edk2/pull/136 =20 Here's an example of a PR it did mark stale there: =20 https://github.com/makubacki/edk2/pull/4 .github/workflows/stale.yml | 44 ++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml new file mode 100644 index 000000000000..b9160b548ab3 --- /dev/null +++ b/.github/workflows/stale.yml @@ -0,0 +1,44 @@ +# This workflow warns and then closes issues and PRs that have had no ac= tivity +# for a specified amount of time. +# +# For more information, see: +# https://github.com/actions/stale +# +# Copyright (c) Microsoft Corporation. +# SPDX-License-Identifier: BSD-2-Clause-Patent +# + +name: Stale Check + +on: + schedule: + # At 23:35 on every day-of-week from Sunday through Saturday + # https://crontab.guru/#35_23_*_*_0-6 + - cron: '35 23 * * 0-6' + workflow_dispatch: + +jobs: + stale: + name: Stale + runs-on: ubuntu-latest + permissions: + issues: write + pull-requests: write + + steps: + - name: Check for Stale Items + uses: actions/stale@v8 + with: + days-before-issue-close: -1 + days-before-issue-stale: -1 + days-before-pr-stale: 60 + days-before-pr-close: 7 + stale-pr-message: > + This PR has been automatically marked as stale because it has = not had + activity in 60 days. It will be closed if no further activity = occurs within + 7 days. Thank you for your contributions. + close-pr-message: > + This pull request has been automatically been closed because i= t did not have any + activity in 60 days and no follow up within 7 days after being= marked stale. + Thank you for your contributions. + stale-pr-label: stale --=20 2.42.0.windows.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110355): https://edk2.groups.io/g/devel/message/110355 Mute This Topic: https://groups.io/mt/102289677/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-