From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4A2FC74003B for ; Wed, 1 Nov 2023 10:28:23 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=dKXU080KLKU5SfyJ+Y1nwCrBR0Myqpg7vXwngxR5hK0=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:MIME-Version:NoDisclaimer:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1698834501; v=1; b=Y3XffKGMeFAyQeDWSqQDkpyw6/vqnX2w61m3na5HGffGSwDZn5f/vIpvYZHplaql4UFPOS3R wrEvdOiEFKxellizxvXrVmrKHol/SvZ7oqbA3jt8M0hBY5MbSqhFm+tVQSjdVtnhloR7RL8IuNw jVRpXyOFqd7W1Xbjh7F5mPHE= X-Received: by 127.0.0.2 with SMTP id qsvFYY7687511x97q9rHesTI; Wed, 01 Nov 2023 03:28:21 -0700 X-Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.76]) by mx.groups.io with SMTP id smtpd.web10.3942.1698834500561466579 for ; Wed, 01 Nov 2023 03:28:20 -0700 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=kua0xalCHatJ1r75HtHQhulHIp9kWK4m+4IajTl0uC7216MCaCpgmRc/PVY4LgDVZjbf4BEi9oFp9VFKAyUszshoUvxodBhai4EydT1SOF5ae2EbXHVGN+zF51HHqK4Q0HFU1GGB3V6vb8ykGJ6Ul0T0spiOsNbbz3G68QKTcdtiSFp21CWFACxYapGaJelvhAVSguHGlHcVEKj1bIHEGkdVukeOO6I0fW6Cw3pySlBAO87hK4ScZ0PF45A5iZkrdbDoHYngSY7rvA0YB1/+01SM1QNPvd/Ms5+JWrx2zozFAu+3mPMv5LJ1erttzAN6x3l701PnfqM4mo8cq0ZLuA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TaSCtBzCcf59h2uUOUEqDfP6Hppp0XCnni2FIa8Oh34=; b=VAheRjGYpSI7WtmKz9img3JkQp9UTtj3RQIs3AznPcQtsbeL93pz70PJK6vZKEFXjHiEtQ6iVoxoyIudgxogqtEZ/fHiAoVtCbtJe6JbA0ao9Uh4yZ0W3Bd4RbN5q0oXs5Hl/de4vCiUFHUHHngedAuIpdD2oBUWZQBk0SMm3RcY1cByRo6DJe2iRgWQ5zDiZXOF6tLo57D6OWn6oOAOEt3/Op+TpzchXk2VYzqOPF0Z5H/oz/R+CDmJIBDUU3fuJwoVDd0gMk7iv7HMd/uYaFOrRoLK1AKSEczADxbFDwXQcvnmuAU+iOEdotpHv9dOf60Kof2RO/ZHeR8JjfA6bg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) X-Received: from AM9P193CA0003.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:21e::8) by PAXPR08MB6560.eurprd08.prod.outlook.com (2603:10a6:102:12d::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.22; Wed, 1 Nov 2023 10:28:15 +0000 X-Received: from AM3PEPF0000A78F.eurprd04.prod.outlook.com (2603:10a6:20b:21e:cafe::de) by AM9P193CA0003.outlook.office365.com (2603:10a6:20b:21e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.29 via Frontend Transport; Wed, 1 Nov 2023 10:28:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM3PEPF0000A78F.mail.protection.outlook.com (10.167.16.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.19 via Frontend Transport; Wed, 1 Nov 2023 10:28:15 +0000 X-Received: ("Tessian outbound e243565b0037:v228"); Wed, 01 Nov 2023 10:28:15 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 80923be42cffe661 X-CR-MTA-TID: 64aa7808 X-Received: from ca02892aa047.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1D6FCC63-1FB9-4657-8765-A19B45B473F6.1; Wed, 01 Nov 2023 10:28:07 +0000 X-Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ca02892aa047.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 01 Nov 2023 10:28:07 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j6c7tw3CWVMuZzJXD1ZJgbkI8DdiO+VhPdVKhHMu6s05UZdmUhXTJZ9BAtppUDGgAiIDQ+WbCHB+2q6tc2i4djrMUEQIFNTjHPCUlZDgU+uljw6baaF+6uJVE2DSMpZy93Ar25MLY9d/CZqnZrzqpWtwl0zuk3D/C0dIRVPzMSRDXM6LuaOj5jG+Ah1jTMv50d75bp2s4jM6P8cZ20uW940rhkvwJ7UsAE7QoEAwl28aOQWjorYkeNNkgQBkeHUKfsaKHYbEcyOWHxe/AEJndu7LzbVqMzmnbMhJdT3pIbaRVtpu23zRmMKDWLKIYkVMVmjcrI2Nj6B5W5P0Waeg8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TaSCtBzCcf59h2uUOUEqDfP6Hppp0XCnni2FIa8Oh34=; b=Ar7qBMSsPNZwfIxqV2pkI8SBVamo6LfYBviNC4cHu8Y1VNlO1wgYuLxkaNsbQiCBHyOO8+1PNxvjq72rrR66cVRIyNjTytnJqltsWUbVJWBVZZv+jyX2qKm22tXSk1ebuTBabgQDVK/ZHxjTDfN4UnvTVe5bYZu/2tcWFx+R85dxtyKAEHzr8+R79otr6ru+wdi4DVUS0SqfExYJT7YW5EPf0auP7pmU/VDyTChzmaNaZx//1Wb75bJPaqnVHgn7lgnARlBZPsn9+QP5sfAvxuSTKHj6C5i5zkMtWmuO0cO8NfiDxfhPOQ3sH16Hjt5XkUUeHXllqX+Nu7K94qnS1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none (0) X-Received: from AS4P191CA0045.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:657::28) by DU5PR08MB10753.eurprd08.prod.outlook.com (2603:10a6:10:518::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.19; Wed, 1 Nov 2023 10:28:05 +0000 X-Received: from AM4PEPF00027A5D.eurprd04.prod.outlook.com (2603:10a6:20b:657:cafe::63) by AS4P191CA0045.outlook.office365.com (2603:10a6:20b:657::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.29 via Frontend Transport; Wed, 1 Nov 2023 10:28:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by AM4PEPF00027A5D.mail.protection.outlook.com (10.167.16.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6954.19 via Frontend Transport; Wed, 1 Nov 2023 10:28:05 +0000 X-Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 1 Nov 2023 10:28:04 +0000 X-Received: from E114225.Arm.com (10.1.196.27) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2507.32 via Frontend Transport; Wed, 1 Nov 2023 10:28:04 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , Subject: [edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: Fix assert in CmObject parser Date: Wed, 1 Nov 2023 10:28:03 +0000 Message-ID: <20231101102803.26716-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM4PEPF00027A5D:EE_|DU5PR08MB10753:EE_|AM3PEPF0000A78F:EE_|PAXPR08MB6560:EE_ X-MS-Office365-Filtering-Correlation-Id: ff0b6b92-435b-40bb-26e2-08dbdac541f8 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1MlPAzMTxjp1BqeYZBfQplRktHQms4IqYqWF6eRnBqXkTUnRMasA/5TeB8wrqenCoUyItdZ+oHaFgST7irEt5F8wg9gzv/s2CNANOxMwiYstd+oc5ZTmFI8iHORI2cTP8jvSUPIWy9a9HIXv4zHIhnb1ZkN3PgQfXgKZqtG+WaHlxJ3wdScdXpIVBKcklSn1rD+0/j2aFPtibAawQ9JsqTBDvq3PggsMgsoHDSmLBJTXuNTVUdDco5UuMj8Tt4FEYObENfaghJaB48k0B4MPyfKgasNY2fMEU1zaQJc6bKAz5Hg1/BH3TFLn83HnuDZBNifqg0ARLPe9aCQcwom3j+2GHlsf6lrK41XUX6zzJDJUxTCZ46GJr8s06gW7P2LGzhJ3BxnXAByheKcBTqbIsIqVzGr/Y6Z88m8tyL/Cpy5kY58rzX3My4cZ8UGokghCMEvgdGRlXoDlfP3wVVJiXWjel0/7bagzHKWYl9X5Z+0sqp4/WO45iKvBWyng1zefsObCI8eLZgGGBNxqG4pCH4tHtHgLiwliuG1Mr+ynUnh5m5+ugp9M8dcdLttzlSisHufdPxeLMrAINCZst+D9igtZLXc8Q39CrRnnw4a/sxdPppkwoIaYXnpQGvh2ebE2m52Nz7aKjzneoKOa/nIkevz0wwuMeH86gqP4TVXSFQJGIXPrrK/iiwVZDyXMMgxqeFJBVi3HvK3r1qlVpxStMSvm6AsvZJBgkO6DU+OkdSJFwCCnUcUUWUEA+wz/Kaor32Biz2wmXgN+0F1e8QhU+w== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(6029001)(4636009)(39860400002)(376002)(136003)(346002)(396003)(230922051799003)(82310400011)(64100799003)(1800799009)(186009)(451199024)(36840700001)(46966006)(40470700004)(36756003)(40480700001)(40460700003)(8676002)(8936002)(7696005)(4326008)(83380400001)(1076003)(2616005)(54906003)(70586007)(6916009)(26005)(316002)(70206006)(426003)(336012)(478600001)(36860700001)(86362001)(82740400003)(81166007)(44832011)(41300700001)(47076005)(2906002)(5660300002)(356005)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU5PR08MB10753 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM3PEPF0000A78F.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9ff7e1b2-ca18-4f2c-ac09-08dbdac53c20 X-Microsoft-Antispam-Message-Info: ncJFjXmc18s84e/iMVl+/J7/pkMU5r4vey2Iwh4RI4Gm0GsPhG5vKC1FGlxvAXm78N/53SMtFNKRK08NJoss11yfnkgzDUlKRbNCFZ3sMP6+9EKAbnpgIGMGz2y9bWa9N99zVaT12QTHhibIDVUJkFPrtSvxmZ29x4loy1T1KIZFHYlYlHCd9/zhHxTJzPR58kymj5eLfHggvAYFzEI26yMEIH5I7+EDrvXAV6hn5hUehugvSJM8QVs6CjDh0tOVm5Aw1jEnkEHrBh+8aGtf6cQ+5mn7drhJJ7hXf8UCgedLBWVwoiPlN07M+6neJdmzDRl7nMiZx9NkiplqsVVmwR8UAdLSBTTju78JTWMdAFUlGozlmICv4zzPAlQcXCHRrqtQAsapSOQzWGUFW7MuzqHf3stwv632hYbcnMNvAlKsRcxrQ95jfh0zyxutKWKrHoZWmbXkzhg1TO+NGzRM7Nui6Cy/KpzXkduW4OjQv03hZSKqxUwnJZxA4kW5OeHYmIcYM3fhRJ4eYZxEx6u0GsnIOEKS0NY/eUM2OswIdJO2BVaRpvdT+M/iIQNnMGAXhNOJHWcWtHITk1Kbz1enDNx/FeG7GqBihz7K+JjiGjkKFecmxzRP124ICQjKrPmvDzDpdhPpawOSCRgXKbwpFB5Cc+KzT/Qj9qHc10e1mbQODoyUC22JwApUsD+j/UAOCwMqhMZWNPnNKbNtPS0NYCDna559zArN4dZwDjH2Q4Vvy1Bt/keWPvstkmHov7bw X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2023 10:28:15.2782 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ff0b6b92-435b-40bb-26e2-08dbdac541f8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM3PEPF0000A78F.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6560 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: S0cVQ7TqA3vz3TW7ccGni4Ccx7686176AA= Content-Type: text/plain X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Y3XffKGM; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") The patch "f81ee47513e5 DynamicTablesPkg: Add an ET info object parser" updates the Configuration Manager object parser to add support for parsing CM_ARM_ET_INFO object. However, the GicC info structure also has an ET Reference token that points to the CM_ARM_ET_INFO object. Therefore, update the GICC info object parser to add an entry to parse the ET reference token. Without this change an assert stating that the RemainingSize != 0 will be triggered. Signed-off-by: Sami Mujawar --- DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c index 127675d4cec435e6a076c4466b86a31160bf9de1..ce494816ed884f14af56fb32e7bf6bbba8595521 100644 --- a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c @@ -84,7 +84,8 @@ STATIC CONST CM_OBJ_PARSER CmArmGicCInfoParser[] = { { "ClockDomain", 4, "0x%x", NULL }, { "AffinityFlags", 4, "0x%x", NULL }, { "CpcToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL }, - { "TRBEInterrupt", 2, "0x%x", NULL } + { "TRBEInterrupt", 2, "0x%x", NULL }, + { "EtToken", sizeof (CM_OBJECT_TOKEN), "0x%p", NULL } }; /** A parser for EArmObjGicDInfo. -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110474): https://edk2.groups.io/g/devel/message/110474 Mute This Topic: https://groups.io/mt/102315705/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-