From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0C24DAC0D07 for ; Thu, 2 Nov 2023 09:10:18 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=WhRFZk2p8/DQdakJXrLofkZghKxFyZ/bDq3moQbRRFI=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1698916217; v=1; b=Y3cHH6gYPAFGy0VocIVm09GE0cU4Z3iWWKgw7AloILr+ylAqjsoNlLlJR4nD+fGkyV6se3ft rNv9giuXzj39SsIXW7j99LM/mzOpTkhNSUAH5eLvr13jK68V9QJqECgH8oYNJWPl1vGA/xWtru/ HM2yZ3mv24AOViKDgZ0eZeFc= X-Received: by 127.0.0.2 with SMTP id jg5YYY7687511xE3GDeEL2PN; Thu, 02 Nov 2023 02:10:17 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by mx.groups.io with SMTP id smtpd.web10.26767.1698916216748968208 for ; Thu, 02 Nov 2023 02:10:17 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10881"; a="1583175" X-IronPort-AV: E=Sophos;i="6.03,271,1694761200"; d="scan'208";a="1583175" X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2023 02:10:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10881"; a="737695051" X-IronPort-AV: E=Sophos;i="6.03,271,1694761200"; d="scan'208";a="737695051" X-Received: from cepingsx-mobl1.ccr.corp.intel.com ([10.239.49.140]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2023 02:10:13 -0700 From: "sunceping" To: devel@edk2.groups.io Cc: sunceping , Liming Gao , Michael D Kinney , Erdem Aktas , James Bottomley , Jiewen Yao , Min Xu , Tom Lendacky , Michael Roth , Gerd Hoffmann Subject: [edk2-devel] [PATCH V2 0/2] OvmfPkg: Update TdVmCall to handle the retry for MapGPA Date: Thu, 2 Nov 2023 17:09:55 +0800 Message-Id: <20231102090957.2076-1-cepingx.sun@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,cepingx.sun@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: fgkexYbBQwdYuQWmCii9wTtdx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Y3cHH6gY; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4572 According to section 3.2 of the [GHCI] spec, if the result is "TDG.VP.VMCALL_RETRY" for TDG.VP.VMCALL.MapGPA, TD must retry the mapping for the pages in the region starting at the GPA specified in r11. Currently, TDVF does not properly handle the retry results of MapGPA. For this, TDVF should update the TdVmCall to return the value in R11 and must retry the mapping for the pages by the value. How to verify the retry for MapGPA in TDVF: Note: Since the range size of MapGPA in QEMU is limited to 64MB and TDVF always maps 1.5GB( 2GB~3.5GB) MMIO to shared-memory for TD guest, the retry action is triggered always. Pre-Config: QEMU: https://github.com/intel/qemu-tdx/tree/tdx-qemu-upstream | tag: tdx-qemu-upstream-2023.10.20-v8.1.0 KERNEL: https://github.com/intel/tdx/tree/kvm-upstream-2023.10.16-v6.6-rc2 Step: Boot with TD guest and check the log with TdVmcall(MAPGPA), as below: TdxDxe:SetMemorySharedOrPrivate: Cr3Base=0x0 Physical=0x80000000 Length=0x60000000 Mode=Shared SetOrClearSharedBit: TdVmcall(MAPGPA) Retry PhysicalAddress is 8000080000000, MapGpaRetryaddr is 8000084000000 Reference: [GHCI]: TDX Guest-Host-Communication Interface v1.0 https://cdrdv2.intel.com/v1/dl/getContent/726790 v2 changes: - Update the code based on the comments of v1 reviewer - Update TdVmcall to instead of the extra API file code: https://github.com/sunceping/edk2/tree/handleRetryMapGPA.v2 Cc: Liming Gao Cc: Michael D Kinney Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Min Xu Cc: Tom Lendacky Cc: Michael Roth Cc: Gerd Hoffmann Signed-off-by: Ceping Sun Ceping Sun (2): MdePkg/BaseLib: Update TdVmcall to always output the value in R11 OvmfPkg/BaseMemEncryptTdxLib: Handle retry result of MapGPA MdePkg/Library/BaseLib/X64/TdVmcall.nasm | 4 +- .../BaseMemEncryptTdxLib/MemoryEncryption.c | 43 ++++++++++++++++++- 2 files changed, 43 insertions(+), 4 deletions(-) -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110505): https://edk2.groups.io/g/devel/message/110505 Mute This Topic: https://groups.io/mt/102337973/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-