From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 57ED9D8081E for ; Thu, 2 Nov 2023 20:03:54 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=rn39XF16P0W7NBtsyJ8T0F71kOqvt12S18lihK0Ejr0=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1698955433; v=1; b=p/kvtcHd3XyD1nWz1vUOEmmOojIRbeMF3zuSaiX70kUHjQe3MNLs+Hnv9JJHY5yCZwpeS6yW nYvS2SxAdo6A2sYC49GySX7SHXqzCnqSU6NUzHVoDTr9MamHQ4/fcQiTF/xcd25YveV6bzbEo4h WlpHmdNaTGLxOp2hGKE0XXtQ= X-Received: by 127.0.0.2 with SMTP id AwupYY7687511xKYPniuKLVk; Thu, 02 Nov 2023 13:03:53 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.42737.1698955432593708838 for ; Thu, 02 Nov 2023 13:03:52 -0700 X-Received: from localhost.localdomain (unknown [47.201.241.95]) by linux.microsoft.com (Postfix) with ESMTPSA id D070120B74C1; Thu, 2 Nov 2023 13:03:51 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com D070120B74C1 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Sean Brogan , Michael D Kinney , Liming Gao Subject: [edk2-devel] [PATCH v4 6/8] .pytool/CISettings: Enable CodeQL audit mode Date: Thu, 2 Nov 2023 16:03:10 -0400 Message-ID: <20231102200313.1010-7-mikuback@linux.microsoft.com> In-Reply-To: <20231102200313.1010-1-mikuback@linux.microsoft.com> References: <20231102200313.1010-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: rnRYg2LwypJGQfNk1pNYq9sNx7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="p/kvtcHd"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none) From: Michael Kubacki Since a large number of CodeQL queries are being enabled to identify issues that the community can collectively resolve, audit mode needs to be enabled to prevent the build from failing. In the future, this global audit mode can be disabled and individual packages can enable/disable audit mode in their package CI YAML file using the instructions in the CodeQL plugin readme. Cc: Sean Brogan Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Michael Kubacki Acked-by: Michael D Kinney --- .pytool/CISettings.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py index b8b8080439c1..ec3beb0dcf9d 100644 --- a/.pytool/CISettings.py +++ b/.pytool/CISettings.py @@ -196,6 +196,12 @@ class Settings(CiBuildSettingsManager, UpdateSetting= sManager, SetupSettingsManag =20 try: scopes +=3D codeql_helpers.get_scopes(self.codeql) + + if self.codeql: + shell_environment.GetBuildVars().SetValue( + "STUART_CODEQL_AUDIT_ONLY", + "TRUE", + "Set in CISettings.py") except NameError: pass =20 --=20 2.42.0.windows.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110571): https://edk2.groups.io/g/devel/message/110571 Mute This Topic: https://groups.io/mt/102350796/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-