From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6E47EAC0A5E for ; Tue, 7 Nov 2023 05:58:14 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=4GCmDd43yiH6jbB4evcQ19Cjjnh96iX7mP+rMQVpSls=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1699336693; v=1; b=OQ4+a4eP2DN0cbt8dXEvE6+cGbkRc11Ek/2ncuflA5oEeeTJ4suDVbxkmXfyw9YZqqQCPelZ lpJaS9SmbKKqODxnfLJ7tfhE08JxWmQ1l/wEtVSzp7koDTgYEummfbEnmMxK4A6VY/5Va8TYnTO l+m1Q/A71ETug+eUMgNG1r4s= X-Received: by 127.0.0.2 with SMTP id Osl7YY7687511xhWs8wEjwR6; Mon, 06 Nov 2023 21:58:13 -0800 X-Received: from mail-vk1-f170.google.com (mail-vk1-f170.google.com [209.85.221.170]) by mx.groups.io with SMTP id smtpd.web10.4798.1699336692447448917 for ; Mon, 06 Nov 2023 21:58:12 -0800 X-Received: by mail-vk1-f170.google.com with SMTP id 71dfb90a1353d-49d8dd34f7bso2127667e0c.3 for ; Mon, 06 Nov 2023 21:58:12 -0800 (PST) X-Gm-Message-State: wVg2Dq0D1JHwT3HBc1LeG5JVx7686176AA= X-Google-Smtp-Source: AGHT+IGumW6lLBhj7qz3vx9nmoTZ0Ov9DfINKndI55oOEtKv4+dUMAaYbyt/elNELUz5j/zjpJ8VhA== X-Received: by 2002:a1f:26c6:0:b0:49a:bff1:23 with SMTP id m189-20020a1f26c6000000b0049abff10023mr28162422vkm.5.1699336691324; Mon, 06 Nov 2023 21:58:11 -0800 (PST) X-Received: from user-Latitude-5420.dc1.ventanamicro.com ([2401:4900:1f24:775d:7335:84a5:7d11:9393]) by smtp.gmail.com with ESMTPSA id d20-20020a02a494000000b0042b16c005e9sm2607854jam.124.2023.11.06.21.58.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 21:58:11 -0800 (PST) From: "Ranbir Singh" To: devel@edk2.groups.io, rsingh@ventanamicro.com Cc: Ray Ni , Veeresh Sangolli Subject: [edk2-devel] [PATCH v2 2/2] MdeModulePkg/Bus/Pci/XhciDxe: Fix MISSING_BREAK Coverity issues Date: Tue, 7 Nov 2023 11:28:00 +0530 Message-Id: <20231107055800.86752-3-rsingh@ventanamicro.com> In-Reply-To: <20231107055800.86752-1-rsingh@ventanamicro.com> References: <20231107055800.86752-1-rsingh@ventanamicro.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rsingh@ventanamicro.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=OQ4+a4eP; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io From: Ranbir Singh The functions XhcInitializeEndpointContext and XhcInitializeEndpointContext64 has a switch-case code in which the case USB_ENDPOINT_CONTROL: falls through to default: While this may be intentional, it is not evident to any general code reader why there is no break; in between. Adding // No break; here as this is an intentional fallthrough. as comment in between makes it explicit. Incidentally, the comment satisfies Coverity as well. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4221 Cc: Ray Ni Co-authored-by: Veeresh Sangolli Signed-off-by: Ranbir Singh Signed-off-by: Ranbir Singh --- MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c b/MdeModulePkg/Bus/Pc= i/XhciDxe/XhciSched.c index 05528a478baf..2afecd40cab0 100644 --- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c +++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c @@ -2979,6 +2979,9 @@ XhcInitializeEndpointContext ( // Do not support control transfer now.=0D //=0D DEBUG ((DEBUG_INFO, "XhcInitializeEndpointContext: Unsupport Contr= ol EP found, Transfer ring is not allocated.\n"));=0D + //=0D + // No break; here as this is an intentional fall through.=0D + //=0D default:=0D DEBUG ((DEBUG_INFO, "XhcInitializeEndpointContext: Unknown EP foun= d, Transfer ring is not allocated.\n"));=0D EpDesc =3D (USB_ENDPOINT_DESCRIPTOR *)((UINTN)EpDesc + EpDesc->Len= gth);=0D @@ -3182,6 +3185,9 @@ XhcInitializeEndpointContext64 ( // Do not support control transfer now.=0D //=0D DEBUG ((DEBUG_INFO, "XhcInitializeEndpointContext64: Unsupport Con= trol EP found, Transfer ring is not allocated.\n"));=0D + //=0D + // No break; here as this is an intentional fall through.=0D + //=0D default:=0D DEBUG ((DEBUG_INFO, "XhcInitializeEndpointContext64: Unknown EP fo= und, Transfer ring is not allocated.\n"));=0D EpDesc =3D (USB_ENDPOINT_DESCRIPTOR *)((UINTN)EpDesc + EpDesc->Len= gth);=0D --=20 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110809): https://edk2.groups.io/g/devel/message/110809 Mute This Topic: https://groups.io/mt/102438128/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-