public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>,
	Sai Chaganty <rangasai.v.chaganty@intel.com>
Subject: [edk2-devel] [edk2-platforms PATCH 2/2] SimicsOpenBoardPkg: remove <Mps.h> reference
Date: Thu,  9 Nov 2023 13:06:10 +0100	[thread overview]
Message-ID: <20231109120610.55894-3-lersek@redhat.com> (raw)
In-Reply-To: <20231109120610.55894-1-lersek@redhat.com>

For removing "MdePkg/Include/Guid/Mps.h" from edk2, first remove the
edk2-platforms references to that header file.

I can't build-test this change. As far as I can tell, building the
BoardX58Ich10 platform with "build_bios.py" should build the change;
however, that platform fails to build without an FSP blob.

I think there's a fair chance that this patch should work nonetheless;
<Mps.h> introduces EFI_MPS_TABLE_GUID, MPS_TABLE_GUID, and
gEfiMpsTableGuid, and edk2-platforms doesn't contain those strings.

Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1754
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 Platform/Intel/SimicsOpenBoardPkg/Library/BoardBdsHookLib/BoardBdsHook.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Platform/Intel/SimicsOpenBoardPkg/Library/BoardBdsHookLib/BoardBdsHook.h b/Platform/Intel/SimicsOpenBoardPkg/Library/BoardBdsHookLib/BoardBdsHook.h
index 566b6a48c65d..62c6dfe9b52d 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/Library/BoardBdsHookLib/BoardBdsHook.h
+++ b/Platform/Intel/SimicsOpenBoardPkg/Library/BoardBdsHookLib/BoardBdsHook.h
@@ -46,7 +46,6 @@
 
 #include <Guid/Acpi.h>
 #include <Guid/SmBios.h>
-#include <Guid/Mps.h>
 #include <Guid/HobList.h>
 #include <Guid/GlobalVariable.h>
 #include <Guid/EventGroup.h>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110972): https://edk2.groups.io/g/devel/message/110972
Mute This Topic: https://groups.io/mt/102483855/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  parent reply	other threads:[~2023-11-09 12:06 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-09 12:05 [edk2-devel] remove <LegacyBiosMpTable.h> and <Mps.h>, including references Laszlo Ersek
2023-11-09 12:06 ` [edk2-devel] [edk2-platforms PATCH 0/2] remove <LegacyBiosMpTable.h> and <Mps.h> refs Laszlo Ersek
2023-11-09 12:06   ` [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove <LegacyBiosMpTable.h> references Laszlo Ersek
2023-11-10  1:13     ` Chiu, Chasel
2023-11-13 10:37       ` Laszlo Ersek
2023-11-15 11:51       ` Laszlo Ersek
2023-11-21  2:17         ` Chiu, Chasel
2023-11-23 10:04           ` Laszlo Ersek
2023-11-27 18:37             ` Chiu, Chasel
2023-11-27 23:14           ` Pedro Falcato
2023-11-28  3:47             ` Chiu, Chasel
2023-11-09 12:06   ` Laszlo Ersek [this message]
2023-11-09 12:06 ` [edk2-devel] [PATCH 0/3] remove <LegacyBiosMpTable.h> and <Mps.h>, including refs Laszlo Ersek
2023-11-09 12:06   ` [edk2-devel] [PATCH 1/3] MdePkg: remove <LegacyBiosMpTable.h> Laszlo Ersek
2023-11-09 12:06   ` [edk2-devel] [PATCH 2/3] ShellPkg/UefiShellDebug1CommandsLib: remove gEfiMpsTableGuid ref from DMEM Laszlo Ersek
2023-11-21  8:51     ` Gao, Zhichao
2023-11-09 12:06   ` [edk2-devel] [PATCH 3/3] MdePkg: remove <Mps.h> Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231109120610.55894-3-lersek@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox