From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io
Cc: Zhichao Gao <zhichao.gao@intel.com>
Subject: [edk2-devel] [PATCH 2/3] ShellPkg/UefiShellDebug1CommandsLib: remove gEfiMpsTableGuid ref from DMEM
Date: Thu, 9 Nov 2023 13:06:27 +0100 [thread overview]
Message-ID: <20231109120628.55913-3-lersek@redhat.com> (raw)
In-Reply-To: <20231109120628.55913-1-lersek@redhat.com>
We're removing <MdePkg/Include/Guid/Mps.h>. First, remove the
gEfiMpsTableGuid system config table reference from the UEFI Shell's DMEM
debug command.
Cc: Zhichao Gao <zhichao.gao@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1754
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni | 1 -
ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf | 1 -
ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c | 9 ---------
3 files changed, 11 deletions(-)
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni
index 4041f0cd483e..155efc1a82f1 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni
@@ -112,7 +112,6 @@
"SAL System Table %016LX\r\n"
"ACPI Table %016LX\r\n"
"ACPI 2.0 Table %016LX\r\n"
- "MPS Table %016LX\r\n"
"SMBIOS Table %016LX\r\n"
"DTB Table %016LX\r\n"
"Memory Attribute Table %016LX\r\n"
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
index 3741dac5d94c..2074cb7d96da 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf
@@ -127,7 +127,6 @@ [Guids]
gEfiGlobalVariableGuid ## SOMETIMES_CONSUMES ## GUID
gEfiSmbiosTableGuid ## SOMETIMES_CONSUMES ## SystemTable
gEfiSmbios3TableGuid ## SOMETIMES_CONSUMES ## SystemTable
- gEfiMpsTableGuid ## SOMETIMES_CONSUMES ## SystemTable
gEfiAcpi10TableGuid ## SOMETIMES_CONSUMES ## SystemTable
gEfiAcpi20TableGuid ## SOMETIMES_CONSUMES ## SystemTable
gShellDebug1HiiGuid ## SOMETIMES_CONSUMES ## HII
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
index a609971f345e..39a59c195512 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c
@@ -12,7 +12,6 @@
#include <Protocol/PciRootBridgeIo.h>
#include <Protocol/HiiDatabase.h>
#include <Guid/Acpi.h>
-#include <Guid/Mps.h>
#include <Guid/SmBios.h>
#include <Guid/MemoryAttributesTable.h>
#include <Guid/RtPropertiesTable.h>
@@ -113,7 +112,6 @@ ShellCommandRunDmem (
UINT64 Acpi20TableAddress;
UINT64 SalTableAddress;
UINT64 SmbiosTableAddress;
- UINT64 MpsTableAddress;
UINT64 DtbTableAddress;
UINT64 MemoryAttributesTableAddress;
UINT64 RtPropertiesTableAddress;
@@ -190,7 +188,6 @@ ShellCommandRunDmem (
AcpiTableAddress = 0;
SalTableAddress = 0;
SmbiosTableAddress = 0;
- MpsTableAddress = 0;
DtbTableAddress = 0;
MemoryAttributesTableAddress = 0;
RtPropertiesTableAddress = 0;
@@ -224,11 +221,6 @@ ShellCommandRunDmem (
continue;
}
- if (CompareGuid (&gST->ConfigurationTable[TableWalker].VendorGuid, &gEfiMpsTableGuid)) {
- MpsTableAddress = (UINT64)(UINTN)gST->ConfigurationTable[TableWalker].VendorTable;
- continue;
- }
-
if (CompareGuid (&gST->ConfigurationTable[TableWalker].VendorGuid, &gEfiMemoryAttributesTableGuid)) {
MemoryAttributesTableAddress = (UINT64)(UINTN)gST->ConfigurationTable[TableWalker].VendorTable;
continue;
@@ -292,7 +284,6 @@ ShellCommandRunDmem (
SalTableAddress,
AcpiTableAddress,
Acpi20TableAddress,
- MpsTableAddress,
SmbiosTableAddress,
DtbTableAddress,
MemoryAttributesTableAddress,
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110974): https://edk2.groups.io/g/devel/message/110974
Mute This Topic: https://groups.io/mt/102483865/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-11-09 12:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 12:05 [edk2-devel] remove <LegacyBiosMpTable.h> and <Mps.h>, including references Laszlo Ersek
2023-11-09 12:06 ` [edk2-devel] [edk2-platforms PATCH 0/2] remove <LegacyBiosMpTable.h> and <Mps.h> refs Laszlo Ersek
2023-11-09 12:06 ` [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove <LegacyBiosMpTable.h> references Laszlo Ersek
2023-11-10 1:13 ` Chiu, Chasel
2023-11-13 10:37 ` Laszlo Ersek
2023-11-15 11:51 ` Laszlo Ersek
2023-11-21 2:17 ` Chiu, Chasel
2023-11-23 10:04 ` Laszlo Ersek
2023-11-27 18:37 ` Chiu, Chasel
2023-11-27 23:14 ` Pedro Falcato
2023-11-28 3:47 ` Chiu, Chasel
2023-11-09 12:06 ` [edk2-devel] [edk2-platforms PATCH 2/2] SimicsOpenBoardPkg: remove <Mps.h> reference Laszlo Ersek
2023-11-09 12:06 ` [edk2-devel] [PATCH 0/3] remove <LegacyBiosMpTable.h> and <Mps.h>, including refs Laszlo Ersek
2023-11-09 12:06 ` [edk2-devel] [PATCH 1/3] MdePkg: remove <LegacyBiosMpTable.h> Laszlo Ersek
2023-11-09 12:06 ` Laszlo Ersek [this message]
2023-11-21 8:51 ` [edk2-devel] [PATCH 2/3] ShellPkg/UefiShellDebug1CommandsLib: remove gEfiMpsTableGuid ref from DMEM Gao, Zhichao
2023-11-09 12:06 ` [edk2-devel] [PATCH 3/3] MdePkg: remove <Mps.h> Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231109120628.55913-3-lersek@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox