From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id AB481D81113 for ; Fri, 10 Nov 2023 17:04:11 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=9eXxGtsONRG8BUPwOMsAoP8Y6I3fzMxghm0PJG++HCk=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1699635850; v=1; b=bihcUFlqsyYeDWwxbXvt89c8LW+/rsn+6dDlLsCYq3QyALeaipk9ulotXt2O6rMSlXi547Tn CF85FbA2DlYE+3I/euxWmLTK3Z6Ct6vICX/s2lMk92Alc3I3JSM7zJkLnZB9ohJvZQZSNxRf/QE xXeQ2eor5Lj22fZLUPy5tLKw= X-Received: by 127.0.0.2 with SMTP id uvOnYY7687511xQzGFeKNuUC; Fri, 10 Nov 2023 09:04:10 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mx.groups.io with SMTP id smtpd.web11.33120.1699635848781681059 for ; Fri, 10 Nov 2023 09:04:09 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10890"; a="8858158" X-IronPort-AV: E=Sophos;i="6.03,291,1694761200"; d="scan'208";a="8858158" X-Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2023 09:04:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,291,1694761200"; d="scan'208";a="11525418" X-Received: from mdkinney-mobl.amr.corp.intel.com ([10.212.164.220]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2023 09:04:08 -0800 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Rebecca Cran , Liming Gao , Bob Feng , Yuwei Chen , Leif Lindholm Subject: [edk2-devel] [edk2-stable202311][Patch v2 0/4] BaseTools/Scripts/GetMaintainer: Handle reviewer only case Date: Fri, 10 Nov 2023 09:03:59 -0800 Message-Id: <20231110170403.1068-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 1FFKJcAXaHA7s13eNPy6j2SJx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=bihcUFlq; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4593 New in V2: Split into patch series Fix logic bug where maintainers was incorrectly added to lists. If a package only has reviewers and no maintainers, then also return the maintainers. In order to detect this case, get_maintainers() is updated to return maintainers, reviews, and lists separately instead of a single merged list. This also allows this module to be used by other scripts that need to distinguish between maintainers, reviewers, and lists. Simplify logic that accumulates maintainers, reviewers, lists. Sort the list of output addresses alphabetically and use set() instead of OrderedDict() to accumulate unique addresses. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Cc: Leif Lindholm Signed-off-by: Michael D Kinney Michael D Kinney (4): BaseTools/Scripts/GetMaintainer: Fix logic bug collecting maintainers BaseTools/Scripts/GetMaintainer: Handle reviewer only case BaseTools/Scripts/GetMaintainer: Simplify logic BaseTools/Scripts/GetMaintainer: Sort output addresses BaseTools/Scripts/GetMaintainer.py | 42 ++++++++++++++++++------------ 1 file changed, 26 insertions(+), 16 deletions(-) -- 2.40.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111042): https://edk2.groups.io/g/devel/message/111042 Mute This Topic: https://groups.io/mt/102510788/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-