From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6334AD80D5A for ; Fri, 10 Nov 2023 17:04:13 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=0FC4Y11Dmbi0ty/wzoU6rpUqyD7VcQR8cQReHmaEAyE=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1699635852; v=1; b=MfieVRWba2AJyqkuPPdYEqZZWHmQ7TpKiUZ10zSmiDyE++FBeR0UbQlEXWK7rkCT2x2TB8Yw SaWhpqx9svCi6sFV97XS/xOS1XIV5PRa/duaiqjQHv/99GeMSUAad07CYw8EoKJSvKMfMhT4x2Q /HvcLpOFFeHME/y/ckisVsQw= X-Received: by 127.0.0.2 with SMTP id cO0jYY7687511xwctXdF79N5; Fri, 10 Nov 2023 09:04:12 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mx.groups.io with SMTP id smtpd.web11.33120.1699635848781681059 for ; Fri, 10 Nov 2023 09:04:09 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10890"; a="8858169" X-IronPort-AV: E=Sophos;i="6.03,291,1694761200"; d="scan'208";a="8858169" X-Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2023 09:04:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,291,1694761200"; d="scan'208";a="11525428" X-Received: from mdkinney-mobl.amr.corp.intel.com ([10.212.164.220]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2023 09:04:09 -0800 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Rebecca Cran , Liming Gao , Bob Feng , Yuwei Chen , Leif Lindholm Subject: [edk2-devel] [edk2-stable202311][Patch v2 3/4] BaseTools/Scripts/GetMaintainer: Simplify logic Date: Fri, 10 Nov 2023 09:04:02 -0800 Message-Id: <20231110170403.1068-4-michael.d.kinney@intel.com> In-Reply-To: <20231110170403.1068-1-michael.d.kinney@intel.com> References: <20231110170403.1068-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: MrfwWN0FeeBU3J7hQFxDXvdBx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=MfieVRWb; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4593 get_section_maintainers() either returns a list with valid entries or an empty list. It never returns None. Simplify logic that accumulates maintainers, reviewers, and lists by unconditionally appending lists returned from get_section_maintainers(). Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Cc: Leif Lindholm Signed-off-by: Michael D Kinney --- BaseTools/Scripts/GetMaintainer.py | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/BaseTools/Scripts/GetMaintainer.py b/BaseTools/Scripts/GetMaintainer.py index 081460451e9b..a887962dd1bd 100644 --- a/BaseTools/Scripts/GetMaintainer.py +++ b/BaseTools/Scripts/GetMaintainer.py @@ -113,12 +113,9 @@ def get_maintainers(path, sections, level=0): lists = [] for section in sections: tmp_maint, tmp_review, tmp_lists = get_section_maintainers(path, section) - if tmp_maint: - maintainers += tmp_maint - if tmp_review: - reviewers += tmp_review - if tmp_lists: - lists += tmp_lists + maintainers += tmp_maint + reviewers += tmp_review + lists += tmp_lists if not maintainers: # If no match found, look for match for (nonexistent) file -- 2.40.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111044): https://edk2.groups.io/g/devel/message/111044 Mute This Topic: https://groups.io/mt/102510791/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-