From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 871C1AC1634 for ; Fri, 10 Nov 2023 17:04:13 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=xUhEeUjcsEhBnOF+67LWldxTaaRGflF22PPMoEjro5o=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1699635852; v=1; b=LM0uzXcdAMTx/SS0EUfQIQD92X4pSzbS1XVwX4hjNSF7AqMteUSZGYGf/2aGLF1hBVJ9i0pp aHwwymybiitR1EBWm+o4yADZPfaXZ15AoZnnMfInleqE3KSz8fTXtFji7e7g4modDgtJv2wAatB g1nUIOAjf6S5CmwC3/stBHTY= X-Received: by 127.0.0.2 with SMTP id svgcYY7687511x3KmEbJTUKL; Fri, 10 Nov 2023 09:04:12 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mx.groups.io with SMTP id smtpd.web11.33120.1699635848781681059 for ; Fri, 10 Nov 2023 09:04:09 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10890"; a="8858174" X-IronPort-AV: E=Sophos;i="6.03,291,1694761200"; d="scan'208";a="8858174" X-Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2023 09:04:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,291,1694761200"; d="scan'208";a="11525433" X-Received: from mdkinney-mobl.amr.corp.intel.com ([10.212.164.220]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2023 09:04:09 -0800 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Rebecca Cran , Liming Gao , Bob Feng , Yuwei Chen , Leif Lindholm Subject: [edk2-devel] [edk2-stable202311][Patch v2 4/4] BaseTools/Scripts/GetMaintainer: Sort output addresses Date: Fri, 10 Nov 2023 09:04:03 -0800 Message-Id: <20231110170403.1068-5-michael.d.kinney@intel.com> In-Reply-To: <20231110170403.1068-1-michael.d.kinney@intel.com> References: <20231110170403.1068-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: JWhapIkevvlCUIjz1mgbGEoCx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=LM0uzXcd; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4593 Sort the list of output addresses alphabetically so this script produces the same output even if the order of patches in a patch series is modified such that that order of files processed by this script changes. Use set() logic instead of OrderedDict to accumulate the list of unique addresses that are sorted alphabetically. Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Cc: Leif Lindholm Signed-off-by: Michael D Kinney --- BaseTools/Scripts/GetMaintainer.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/BaseTools/Scripts/GetMaintainer.py b/BaseTools/Scripts/GetMaintainer.py index a887962dd1bd..b33546b10f21 100644 --- a/BaseTools/Scripts/GetMaintainer.py +++ b/BaseTools/Scripts/GetMaintainer.py @@ -191,15 +191,16 @@ if __name__ == '__main__': else: FILES = get_modified_files(REPO, ARGS) - ADDRESSES = [] - + # Accumulate a sorted list of addresses + ADDRESSES = set([]) for file in FILES: print(file) maintainers, reviewers, lists = get_maintainers(file, SECTIONS) - if maintainers or reviewers or lists: - ADDRESSES += (maintainers + reviewers + lists) + ADDRESSES |= set(maintainers + reviewers + lists) + ADDRESSES = list(ADDRESSES) + ADDRESSES.sort() - for address in list(OrderedDict.fromkeys(ADDRESSES)): + for address in ADDRESSES: if '<' in address and '>' in address: address = address.split('>', 1)[0] + '>' print(' %s' % address) -- 2.40.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111045): https://edk2.groups.io/g/devel/message/111045 Mute This Topic: https://groups.io/mt/102510793/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-