public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-devel] [PATCH edk2-test 0/4] Various improvements to the repo
@ 2023-11-10 19:01 Rebecca Cran
  2023-11-10 19:01 ` [edk2-devel] [PATCH edk2-test 1/4] Unbreak buildzip.sh Rebecca Cran
                   ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: Rebecca Cran @ 2023-11-10 19:01 UTC (permalink / raw)
  To: devel, G Edhaya Chandran, Barton Gao, Carolyn Gjertsen,
	Samer El-Haj-Mahmoud, Eric Jin, Arvin Chen, Supreeth Venkatesh
  Cc: Rebecca Cran

Some improvements to the edk2-test repository.

Since buildzip.sh creates output that appears more useful for running on
the target machine, I wonder if we might want to mention it in the
documentation someplace?

Also, I suspect the HowToBuildSctInUdk2017.txt file is now pretty
outdated. Should we delete it?

Finally, is the TianoCore Contribution Agreement still relevant? I know
it is for the edk2 docs repositories, but not sure if edk2-test should
be updated to match the other code repos like edk2 and edk2-platforms?

Rebecca Cran (4):
  Unbreak buildzip.sh
  Rename files in HowToBuild to avoid spaces in filenames
  Point users to the URL for edk2-test-parser if it doesn't exist
  Fix the URL for the edk2-test repo

 Maintainers.txt                                                                              | 2 +-
 uefi-sct/HowToBuild/{How to accelerate SCT execution.txt => HowToAccelerateSctExecution.txt} | 0
 uefi-sct/HowToBuild/{How to build SCT.txt => HowToBuildSct.txt}                              | 0
 uefi-sct/HowToBuild/{How to build SCT in UDK2017.txt => HowToBuildSctInUdk2017.txt}          | 0
 uefi-sct/SctPkg/buildzip.sh                                                                  | 4 +---
 5 files changed, 2 insertions(+), 4 deletions(-)
 rename uefi-sct/HowToBuild/{How to accelerate SCT execution.txt => HowToAccelerateSctExecution.txt} (100%)
 rename uefi-sct/HowToBuild/{How to build SCT.txt => HowToBuildSct.txt} (100%)
 rename uefi-sct/HowToBuild/{How to build SCT in UDK2017.txt => HowToBuildSctInUdk2017.txt} (100%)

-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111052): https://edk2.groups.io/g/devel/message/111052
Mute This Topic: https://groups.io/mt/102513210/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 7+ messages in thread

* [edk2-devel] [PATCH edk2-test 1/4] Unbreak buildzip.sh
  2023-11-10 19:01 [edk2-devel] [PATCH edk2-test 0/4] Various improvements to the repo Rebecca Cran
@ 2023-11-10 19:01 ` Rebecca Cran
  2023-11-10 19:01 ` [edk2-devel] [PATCH edk2-test 2/4] Rename files in HowToBuild to avoid spaces in filenames Rebecca Cran
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 7+ messages in thread
From: Rebecca Cran @ 2023-11-10 19:01 UTC (permalink / raw)
  To: devel, G Edhaya Chandran, Barton Gao, Carolyn Gjertsen,
	Samer El-Haj-Mahmoud, Eric Jin, Arvin Chen, Supreeth Venkatesh
  Cc: Rebecca Cran

Unbreak buildzip.sh by removing the line sourcing edksetup.sh: unless
WORKSPACE and PACKAGES_PATH are already configured, edksetup.sh will
error out.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Contributed-under: TianoCore Contribution Agreement 1.1
---
 uefi-sct/SctPkg/buildzip.sh | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/uefi-sct/SctPkg/buildzip.sh b/uefi-sct/SctPkg/buildzip.sh
index 625475701f12..c7f4673f62b2 100755
--- a/uefi-sct/SctPkg/buildzip.sh
+++ b/uefi-sct/SctPkg/buildzip.sh
@@ -32,9 +32,6 @@ esac
 # clear all positional parameters
 set --
 
-source ./edk2/edksetup.sh
-
-
 NUM_CPUS=$((`getconf _NPROCESSORS_ONLN` + 2))
 
 make -j"$NUM_CPUS" -C edk2/BaseTools/
-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111053): https://edk2.groups.io/g/devel/message/111053
Mute This Topic: https://groups.io/mt/102513211/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [edk2-devel] [PATCH edk2-test 2/4] Rename files in HowToBuild to avoid spaces in filenames
  2023-11-10 19:01 [edk2-devel] [PATCH edk2-test 0/4] Various improvements to the repo Rebecca Cran
  2023-11-10 19:01 ` [edk2-devel] [PATCH edk2-test 1/4] Unbreak buildzip.sh Rebecca Cran
@ 2023-11-10 19:01 ` Rebecca Cran
  2023-11-10 19:01 ` [edk2-devel] [PATCH edk2-test 3/4] Point users to the URL for edk2-test-parser if it doesn't exist Rebecca Cran
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 7+ messages in thread
From: Rebecca Cran @ 2023-11-10 19:01 UTC (permalink / raw)
  To: devel, G Edhaya Chandran, Barton Gao, Carolyn Gjertsen,
	Samer El-Haj-Mahmoud, Eric Jin, Arvin Chen, Supreeth Venkatesh
  Cc: Rebecca Cran

Rename the text files in the HowToBuild directory to remove the spaces
and use CamelCase instead.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Contributed-under: TianoCore Contribution Agreement 1.1
---
 uefi-sct/HowToBuild/{How to accelerate SCT execution.txt => HowToAccelerateSctExecution.txt} | 0
 uefi-sct/HowToBuild/{How to build SCT.txt => HowToBuildSct.txt}                              | 0
 uefi-sct/HowToBuild/{How to build SCT in UDK2017.txt => HowToBuildSctInUdk2017.txt}          | 0
 3 files changed, 0 insertions(+), 0 deletions(-)

diff --git a/uefi-sct/HowToBuild/How to accelerate SCT execution.txt b/uefi-sct/HowToBuild/HowToAccelerateSctExecution.txt
similarity index 100%
rename from uefi-sct/HowToBuild/How to accelerate SCT execution.txt
rename to uefi-sct/HowToBuild/HowToAccelerateSctExecution.txt
diff --git a/uefi-sct/HowToBuild/How to build SCT.txt b/uefi-sct/HowToBuild/HowToBuildSct.txt
similarity index 100%
rename from uefi-sct/HowToBuild/How to build SCT.txt
rename to uefi-sct/HowToBuild/HowToBuildSct.txt
diff --git a/uefi-sct/HowToBuild/How to build SCT in UDK2017.txt b/uefi-sct/HowToBuild/HowToBuildSctInUdk2017.txt
similarity index 100%
rename from uefi-sct/HowToBuild/How to build SCT in UDK2017.txt
rename to uefi-sct/HowToBuild/HowToBuildSctInUdk2017.txt
-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111054): https://edk2.groups.io/g/devel/message/111054
Mute This Topic: https://groups.io/mt/102513212/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 7+ messages in thread

* [edk2-devel] [PATCH edk2-test 3/4] Point users to the URL for edk2-test-parser if it doesn't exist
  2023-11-10 19:01 [edk2-devel] [PATCH edk2-test 0/4] Various improvements to the repo Rebecca Cran
  2023-11-10 19:01 ` [edk2-devel] [PATCH edk2-test 1/4] Unbreak buildzip.sh Rebecca Cran
  2023-11-10 19:01 ` [edk2-devel] [PATCH edk2-test 2/4] Rename files in HowToBuild to avoid spaces in filenames Rebecca Cran
@ 2023-11-10 19:01 ` Rebecca Cran
  2023-12-11 11:10   ` Sunny Wang
  2023-11-10 19:01 ` [edk2-devel] [PATCH edk2-test 4/4] Fix the URL for the edk2-test repo Rebecca Cran
  2023-11-10 19:04 ` [edk2-devel] [PATCH edk2-test 0/4] Various improvements to the repo Rebecca Cran
  4 siblings, 1 reply; 7+ messages in thread
From: Rebecca Cran @ 2023-11-10 19:01 UTC (permalink / raw)
  To: devel, G Edhaya Chandran, Barton Gao, Carolyn Gjertsen,
	Samer El-Haj-Mahmoud, Eric Jin, Arvin Chen, Supreeth Venkatesh
  Cc: Rebecca Cran

If edk2-test-parser doesn't exist, tell the user where they can clone it
from.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Contributed-under: TianoCore Contribution Agreement 1.1
---
 uefi-sct/SctPkg/buildzip.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/uefi-sct/SctPkg/buildzip.sh b/uefi-sct/SctPkg/buildzip.sh
index c7f4673f62b2..cc02ad3056b6 100755
--- a/uefi-sct/SctPkg/buildzip.sh
+++ b/uefi-sct/SctPkg/buildzip.sh
@@ -54,6 +54,7 @@ cp Build/MdeModule/RELEASE_GCC5/${TARGET_ARCH}/CapsuleApp.efi ${TARGET_ARCH}_SCT
 if [ ! -d "${pwd}edk2-test-parser" ]
 then
         echo "edk2-test-parser repo is missing from current directory, please clone and try again"
+	echo "The URL for edk2-test-parser is https://git.gitlab.arm.com/systemready/edk2-test-parser.git"
         exit
 fi
 
-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111055): https://edk2.groups.io/g/devel/message/111055
Mute This Topic: https://groups.io/mt/102513215/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [edk2-devel] [PATCH edk2-test 4/4] Fix the URL for the edk2-test repo
  2023-11-10 19:01 [edk2-devel] [PATCH edk2-test 0/4] Various improvements to the repo Rebecca Cran
                   ` (2 preceding siblings ...)
  2023-11-10 19:01 ` [edk2-devel] [PATCH edk2-test 3/4] Point users to the URL for edk2-test-parser if it doesn't exist Rebecca Cran
@ 2023-11-10 19:01 ` Rebecca Cran
  2023-11-10 19:04 ` [edk2-devel] [PATCH edk2-test 0/4] Various improvements to the repo Rebecca Cran
  4 siblings, 0 replies; 7+ messages in thread
From: Rebecca Cran @ 2023-11-10 19:01 UTC (permalink / raw)
  To: devel, G Edhaya Chandran, Barton Gao, Carolyn Gjertsen,
	Samer El-Haj-Mahmoud, Eric Jin, Arvin Chen, Supreeth Venkatesh
  Cc: Rebecca Cran

Fix the URL for the edk2-test repo: the uefi-sct is a directory inside
the repo.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Contributed-under: TianoCore Contribution Agreement 1.1
---
 Maintainers.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Maintainers.txt b/Maintainers.txt
index a94255f015ad..ae6dd7008bcd 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -28,7 +28,7 @@ Descriptions of section entries:
 
 UEFI-SCT
 ------
-T: git - https://github.com/tianocore/edk2-test/uefi-sct
+T: git - https://github.com/tianocore/edk2-test
 
 
 Responsible Disclosure, Reporting Security Issues
-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111056): https://edk2.groups.io/g/devel/message/111056
Mute This Topic: https://groups.io/mt/102513216/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [edk2-devel] [PATCH edk2-test 0/4] Various improvements to the repo
  2023-11-10 19:01 [edk2-devel] [PATCH edk2-test 0/4] Various improvements to the repo Rebecca Cran
                   ` (3 preceding siblings ...)
  2023-11-10 19:01 ` [edk2-devel] [PATCH edk2-test 4/4] Fix the URL for the edk2-test repo Rebecca Cran
@ 2023-11-10 19:04 ` Rebecca Cran
  4 siblings, 0 replies; 7+ messages in thread
From: Rebecca Cran @ 2023-11-10 19:04 UTC (permalink / raw)
  To: devel, G Edhaya Chandran, Barton Gao, Carolyn Gjertsen,
	Samer El-Haj-Mahmoud, Supreeth Venkatesh

It looks like Maintainers.txt also needs to be updated since I got 
bounces from Eric Jin and Arvin Chen's email addresses.


On 11/10/23 12:01, Rebecca Cran wrote:
> Some improvements to the edk2-test repository.
>
> Since buildzip.sh creates output that appears more useful for running on
> the target machine, I wonder if we might want to mention it in the
> documentation someplace?
>
> Also, I suspect the HowToBuildSctInUdk2017.txt file is now pretty
> outdated. Should we delete it?
>
> Finally, is the TianoCore Contribution Agreement still relevant? I know
> it is for the edk2 docs repositories, but not sure if edk2-test should
> be updated to match the other code repos like edk2 and edk2-platforms?
>
> Rebecca Cran (4):
>    Unbreak buildzip.sh
>    Rename files in HowToBuild to avoid spaces in filenames
>    Point users to the URL for edk2-test-parser if it doesn't exist
>    Fix the URL for the edk2-test repo
>
>   Maintainers.txt                                                                              | 2 +-
>   uefi-sct/HowToBuild/{How to accelerate SCT execution.txt => HowToAccelerateSctExecution.txt} | 0
>   uefi-sct/HowToBuild/{How to build SCT.txt => HowToBuildSct.txt}                              | 0
>   uefi-sct/HowToBuild/{How to build SCT in UDK2017.txt => HowToBuildSctInUdk2017.txt}          | 0
>   uefi-sct/SctPkg/buildzip.sh                                                                  | 4 +---
>   5 files changed, 2 insertions(+), 4 deletions(-)
>   rename uefi-sct/HowToBuild/{How to accelerate SCT execution.txt => HowToAccelerateSctExecution.txt} (100%)
>   rename uefi-sct/HowToBuild/{How to build SCT.txt => HowToBuildSct.txt} (100%)
>   rename uefi-sct/HowToBuild/{How to build SCT in UDK2017.txt => HowToBuildSctInUdk2017.txt} (100%)
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111057): https://edk2.groups.io/g/devel/message/111057
Mute This Topic: https://groups.io/mt/102513210/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [edk2-devel] [PATCH edk2-test 3/4] Point users to the URL for edk2-test-parser if it doesn't exist
  2023-11-10 19:01 ` [edk2-devel] [PATCH edk2-test 3/4] Point users to the URL for edk2-test-parser if it doesn't exist Rebecca Cran
@ 2023-12-11 11:10   ` Sunny Wang
  0 siblings, 0 replies; 7+ messages in thread
From: Sunny Wang @ 2023-12-11 11:10 UTC (permalink / raw)
  To: devel@edk2.groups.io, rebecca@bsdio.com, G Edhaya Chandran,
	Barton Gao, Carolyn Gjertsen, Samer El-Haj-Mahmoud, Eric Jin,
	Arvin Chen, Supreeth Venkatesh
  Cc: Sunny Wang

This is good. Thanks, Rebecca!
Reviewed-by: Sunny Wang <sunny.wang@arm.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca Cran via groups.io
Sent: Friday, November 10, 2023 7:02 PM
To: devel@edk2.groups.io; G Edhaya Chandran <Edhaya.Chandran@arm.com>; Barton Gao <gaojie@byosoft.com.cn>; Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>; Eric Jin <eric.jin@intel.com>; Arvin Chen <arvinx.chen@intel.com>; Supreeth Venkatesh <Supreeth.Venkatesh@amd.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Subject: [edk2-devel] [PATCH edk2-test 3/4] Point users to the URL for edk2-test-parser if it doesn't exist

If edk2-test-parser doesn't exist, tell the user where they can clone it
from.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
Contributed-under: TianoCore Contribution Agreement 1.1
---
 uefi-sct/SctPkg/buildzip.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/uefi-sct/SctPkg/buildzip.sh b/uefi-sct/SctPkg/buildzip.sh
index c7f4673f62b2..cc02ad3056b6 100755
--- a/uefi-sct/SctPkg/buildzip.sh
+++ b/uefi-sct/SctPkg/buildzip.sh
@@ -54,6 +54,7 @@ cp Build/MdeModule/RELEASE_GCC5/${TARGET_ARCH}/CapsuleApp.efi ${TARGET_ARCH}_SCT
 if [ ! -d "${pwd}edk2-test-parser" ]
 then
         echo "edk2-test-parser repo is missing from current directory, please clone and try again"
+       echo "The URL for edk2-test-parser is https://git.gitlab.arm.com/systemready/edk2-test-parser.git"
         exit
 fi

--
2.34.1






IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112293): https://edk2.groups.io/g/devel/message/112293
Mute This Topic: https://groups.io/mt/102513215/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-12-11 11:11 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-10 19:01 [edk2-devel] [PATCH edk2-test 0/4] Various improvements to the repo Rebecca Cran
2023-11-10 19:01 ` [edk2-devel] [PATCH edk2-test 1/4] Unbreak buildzip.sh Rebecca Cran
2023-11-10 19:01 ` [edk2-devel] [PATCH edk2-test 2/4] Rename files in HowToBuild to avoid spaces in filenames Rebecca Cran
2023-11-10 19:01 ` [edk2-devel] [PATCH edk2-test 3/4] Point users to the URL for edk2-test-parser if it doesn't exist Rebecca Cran
2023-12-11 11:10   ` Sunny Wang
2023-11-10 19:01 ` [edk2-devel] [PATCH edk2-test 4/4] Fix the URL for the edk2-test repo Rebecca Cran
2023-11-10 19:04 ` [edk2-devel] [PATCH edk2-test 0/4] Various improvements to the repo Rebecca Cran

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox