[edk2-devel] [PATCH 10/37] OvmfPkg: remove gEfiVgaMiniPortProtocolGuid

["Laszlo Ersek" <lersek@redhat.com>]

At this point, gEfiVgaMiniPortProtocolGuid is unused; remove it.

This shrinks the list of resources scheduled for removal to:

- GUIDs (protocols or otherwise):
  - gEfiLegacyBiosGuid
  - gEfiLegacyBiosProtocolGuid

- headers:
  - FrameworkDxe.h
  - Guid/LegacyBios.h
  - Protocol/LegacyBios.h

- PCDs:
  - PcdBiosVideoCheckVbeEnable
  - PcdBiosVideoCheckVgaEnable
  - PcdBiosVideoSetTextVgaModeEnable

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4588
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 OvmfPkg/OvmfPkg.dec                        |  1 -
 OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h | 88 --------------------
 2 files changed, 89 deletions(-)

diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec
index 19149dc9fec7..c9f41c7ddea5 100644
--- a/OvmfPkg/OvmfPkg.dec
+++ b/OvmfPkg/OvmfPkg.dec
@@ -190,7 +190,6 @@ [Protocols]
   gEfiLegacyBiosProtocolGuid            = {0xdb9a1e3d, 0x45cb, 0x4abb, {0x85, 0x3b, 0xe5, 0x38, 0x7f, 0xdb, 0x2e, 0x2d}}
   gEfiLegacyBiosPlatformProtocolGuid    = {0x783658a3, 0x4172, 0x4421, {0xa2, 0x99, 0xe0, 0x09, 0x07, 0x9c, 0x0c, 0xb4}}
   gEfiLegacyInterruptProtocolGuid       = {0x31ce593d, 0x108a, 0x485d, {0xad, 0xb2, 0x78, 0xf2, 0x1f, 0x29, 0x66, 0xbe}}
-  gEfiVgaMiniPortProtocolGuid           = {0xc7735a2f, 0x88f5, 0x4882, {0xae, 0x63, 0xfa, 0xac, 0x8c, 0x8b, 0x86, 0xb3}}
   gOvmfLoadedX86LinuxKernelProtocolGuid = {0xa3edc05d, 0xb618, 0x4ff6, {0x95, 0x52, 0x76, 0xd7, 0x88, 0x63, 0x43, 0xc8}}
   gOvmfSevMemoryAcceptanceProtocolGuid  = {0xc5a010fe, 0x38a7, 0x4531, {0x8a, 0x4a, 0x05, 0x00, 0xd2, 0xfd, 0x16, 0x49}}
   gQemuAcpiTableNotifyProtocolGuid      = {0x928939b2, 0x4235, 0x462f, {0x95, 0x80, 0xf6, 0xa2, 0xb2, 0xc2, 0x1a, 0x4f}}
diff --git a/OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h b/OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h
deleted file mode 100644
index fa023a2dfae4..000000000000
--- a/OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h
+++ /dev/null
@@ -1,88 +0,0 @@
-/** @file
-  The VGA Mini Port Protocol used to set the text display mode of a VGA controller.
-
-Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
-SPDX-License-Identifier: BSD-2-Clause-Patent
-
-**/
-
-#ifndef __VGA_MINI_PORT_H_
-#define __VGA_MINI_PORT_H_
-
-///
-/// Global ID for the EFI_VGA_MINI_PORT_PROTOCOL.
-///
-#define EFI_VGA_MINI_PORT_PROTOCOL_GUID \
-  { \
-    0xc7735a2f, 0x88f5, 0x4882, {0xae, 0x63, 0xfa, 0xac, 0x8c, 0x8b, 0x86, 0xb3 } \
-  }
-
-///
-/// Forward declaration for the EFI_VGA_MINI_PORT_PROTOCOL.
-///
-typedef struct _EFI_VGA_MINI_PORT_PROTOCOL EFI_VGA_MINI_PORT_PROTOCOL;
-
-/**
-  Sets the text display mode of a VGA controller.
-
-  Sets the text display mode of the VGA controller to the mode specified by
-  ModeNumber.  A ModeNumber of 0 is a request for an 80x25 text mode.  A
-  ModeNumber of 1 is a request for an 80x50 text mode.  If ModeNumber is greater
-  than MaxModeNumber, then EFI_UNSUPPORTED is returned.  If the VGA controller
-  is not functioning properly, then EFI_DEVICE_ERROR is returned.  If the VGA
-  controller is successfully set to the mode number specified by ModeNumber, then
-  EFI_SUCCESS is returned.
-
-  @param[in] This         A pointer to the EFI_VGA_MINI_PORT_PROTOCOL instance.
-  @param[in] ModeNumber   The requested mode number.  0 for 80x25.  1 for 80x5.
-
-  @retval EFI_SUCCESS        The mode number was set.
-  @retval EFI_UNSUPPORTED    The mode number specified by ModeNumber is not supported.
-  @retval EFI_DEVICE_ERROR   The device is not functioning properly.
-
-**/
-typedef
-EFI_STATUS
-(EFIAPI *EFI_VGA_MINI_PORT_SET_MODE)(
-  IN EFI_VGA_MINI_PORT_PROTOCOL  *This,
-  IN UINTN                        ModeNumber
-  );
-
-struct _EFI_VGA_MINI_PORT_PROTOCOL {
-  EFI_VGA_MINI_PORT_SET_MODE    SetMode;
-  ///
-  /// MMIO base address of the VGA text mode framebuffer.  Typically set to 0xB8000.
-  ///
-  UINT64                        VgaMemoryOffset;
-  ///
-  /// I/O Port address for the VGA CRTC address register. Typically set to 0x3D4.
-  ///
-  UINT64                        CrtcAddressRegisterOffset;
-  ///
-  /// I/O Port address for the VGA CRTC data register.  Typically set to 0x3D5.
-  ///
-  UINT64                        CrtcDataRegisterOffset;
-  ///
-  /// PCI Controller MMIO BAR index of the VGA text mode frame buffer.  Typically
-  /// set to EFI_PCI_IO_PASS_THROUGH_BAR
-  ///
-  UINT8                         VgaMemoryBar;
-  ///
-  /// PCI Controller I/O BAR index of the VGA CRTC address register.  Typically
-  /// set to EFI_PCI_IO_PASS_THROUGH_BAR
-  ///
-  UINT8                         CrtcAddressRegisterBar;
-  ///
-  /// PCI Controller I/O BAR index of the VGA CRTC data register.  Typically set
-  /// to EFI_PCI_IO_PASS_THROUGH_BAR
-  ///
-  UINT8                         CrtcDataRegisterBar;
-  ///
-  /// The maximum number of text modes that this VGA controller supports.
-  ///
-  UINT8                         MaxMode;
-};
-
-extern EFI_GUID  gEfiVgaMiniPortProtocolGuid;
-
-#endif



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111081): https://edk2.groups.io/g/devel/message/111081
Mute This Topic: https://groups.io/mt/102518648/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-