From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 24CF27803CE for ; Mon, 13 Nov 2023 17:24:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=RjamjSBq/8bfLc9hjjMKd4yjyfxquX/imdLPc/vHhBQ=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699896248; v=1; b=IhrQYFwSRV5NiNUZ83BiSAJogToqpXPJW4Em+napXxN1DlTJYvg5RuDjW9QuyugZIPGPtcO6 ZTrFSOoFifat1XkJdSvsoGOBT95M5frnyTi9fV08rjccBl+KuvMzsBLmpJOeeu90xMhc3wR3npJ uOLDRFtwfvCoMDlGrGqrecq8= X-Received: by 127.0.0.2 with SMTP id 0VBNYY7687511xRePFqfvtaj; Mon, 13 Nov 2023 09:24:08 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.59]) by mx.groups.io with SMTP id smtpd.web10.1227.1699896247607563052 for ; Mon, 13 Nov 2023 09:24:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GxXLBm8BPyWM0CO4gcLk2a+7zhVvSjcVBu0Dy1wP+xo5dL5pb8VWA2LMwcSgoR0SGS6befhed3z0amfTzaOzeLFh5zMcOdgiCrnjQxQa+yOGF8x2UyRM2LOMCoOwFVuhDPWcInMm1BF+UFaQrR6ll09sERWnwp8bZH6ZU9WZ0uNG93tvv/mIOSrGF3sT3wrCNPEdRNw2YyBY2w8EFwun8dq/KpAgZYwh1ih6703HBwWV7+0ICOlCB2Scxvck0dt/JOxK0sxCDc0S/cUHcVldLwtl6PwfiDitIgzAU0yE0e+sRgKWSy4GdYtYdfEw77Ew94OOXngMIMazwt9glC/clA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Qoxem4Yns+taR4mrBhhAjuQ5MC0PYxXhG8t/Z4uSngo=; b=D/ExspwqP6OqApCmC9MpcYGAqhdSy2o99xsKAc1imU9cLSLfb2a0/ZPMx1d/hqEMZI0EPxpR86t08VwtAKthgLK0VQRU45K8GAAAjQnNizurudpyVTB8+mOPSjHgi8DxufxQKXhGMQZ8y+wM4FLGexLfq80LXOxq8dhHwEoFrlACV6AmeauhEMHrlhTWLyXDqMS8VCcWQbmq/pO3HC48Db8VuYGyTSXSJPkL7WXLE+JGk7LJFv7a34aVfL88aYXnXfo3GhcfaqyAGfpQkogT+A+u6A14kClxF7JukB3Zox1Qmjx0FnyoFOZL9Z04sfyMr5hYCEBhBPPqCxWegjvKdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by CH2PR10MB4263.namprd10.prod.outlook.com (2603:10b6:610:a6::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.29; Mon, 13 Nov 2023 17:24:01 +0000 X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::9dc0:d4e1:1d40:3e33]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::9dc0:d4e1:1d40:3e33%4]) with mapi id 15.20.6977.029; Mon, 13 Nov 2023 17:24:01 +0000 From: "Igor Kulchytskyy via groups.io" To: "devel@edk2.groups.io" CC: Abner Chang , Nickle Wang Subject: [edk2-devel] [PATCH 1/2] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx Thread-Topic: [PATCH 1/2] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx Thread-Index: AQHaFlYxKyPCDtpRckaBY847TCjq/w== Date: Mon, 13 Nov 2023 17:24:01 +0000 Message-ID: <20231113172359.1898-1-igork@ami.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BLAPR10MB5185:EE_|CH2PR10MB4263:EE_ x-ms-office365-filtering-correlation-id: 948219f1-b01c-43d4-a19b-08dbe46d5437 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: I5oLMStpaoMSIPkYALKV4U/eXRNXK5pYZKwgEVkcIi6ZNjPTDXLlxtnhCLw9lVMOz8Gd+r+7L0ZE3UIpbi6yjOSMMlDnsSHtDVcxUBI9hKKRkW7TFwnjfYOo4t92pXTOM3JWJWeGPC0Kxiwi4wbTfdQylqS5GC/nOMh7vZPO6QKvLdkbeWKKHXEzEmKcLKqVDkHrU66KwyrXM71mXBymyDYC1DToLwwd77y2smzTWi+n0AHqsXj+jynK0BUIcy7CXMDrUYk60n9STfD0QPsKYliH+Sj8gSCA6rDk2TG8+zE92XnAhQm+pc2aWVau4h8V9YCX90Cth0yOeUprgkEvKH9GfrAALfYF8NRGNFbC3GG4O1zmgqPnhBnrVSDDt9/fJ7KOT5l1YiILKPV+uzhntKo426J0opw9Y4xOr7w2iAKKgn6L6Z6USLSLAkP3iwFHVKaFxwW+u62Dmkt9iIREvIAfFOq6vAM80WdVz1bgqKKPOrMZn99fGFREMwTCTjDKVihuoeZFzNJGvTXG915jksshKvDdWtWjFM7mtTaYAmyN3VcCFR2enOpesVdZf9ooZdsSMr4mJ4gcmDSlMiDyZTuE/RKcK9qAHd/u1YiuoAhwOZZKyoypBd+gIsBDHJjP x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?mxZAa0zUzXv+nayJSy81N6MoZAB3vg22CrqFB749p5Al77zUijBXs6Vnvg?= =?iso-8859-1?Q?hmjwpkNMnLo4pLKf7sDVw23XkrI5f4I/dN9gFOcRMPObqgvakz2H3BIb+Y?= =?iso-8859-1?Q?MMIuFk15ZPHghbAmA5aHvWzQPpxGRWmYf/y2O5BXJ46WZ0CKrXOdknO+kF?= =?iso-8859-1?Q?+yuH7L9sq/Z5+LurpSkG6wHKxFM+lU2SDEAyqV1dz2YIVRKR8G2/nakujH?= =?iso-8859-1?Q?FxdP+mvF9lxVwFxd1i01BvVW7iVS9Mirx87GTmoe7BwVRX5PmBKHCPbTs+?= =?iso-8859-1?Q?H3jCHsP84V0RcGvoHh2NzVv8uSxoktOzRWaeQr1Y+qLACL11TJfr1qu76L?= =?iso-8859-1?Q?MvSQY2fUPGKssdIymFpXD7GH9SkLIoKxx2KMrIwhSEMmrT3WnSIQl1CieF?= =?iso-8859-1?Q?TOx3Taqi98BME6f08MLK6xpHvOcZXBwI0b+AfwYwYsXPYR+uWXbxdx2kXk?= =?iso-8859-1?Q?LEKg2XTKsVPWACltwMD17/RBvkKPU11+EwO82znHZQ1EULP0Fn9BA9FGH2?= =?iso-8859-1?Q?nomJsRgxdirGS/X0Hu9clj4YLzlfgSlP3DYZZ41bJibfZ2xZxSK0LLtRt+?= =?iso-8859-1?Q?jDcYFXboMiDfxv9m4c0z44TvC/k32j8PY/Xs7+mS+9zeKmUlOJF0iWg9Im?= =?iso-8859-1?Q?023JafdMc5WIJOvXzX+dzIcuNRMeoq176WA4RgI99JEXlYrXETYB4WOFWJ?= =?iso-8859-1?Q?+43LxdnITIrIpVOTB5DcP2f8rZHJMCmbH3twdp7JFpRTH7CfyMEE8CL6Io?= =?iso-8859-1?Q?Bcu0a2ZlUdnYiob1cP7gooQN39283sHUZHe/BMAs+Y+z1UAPVrFO9MzJQJ?= =?iso-8859-1?Q?RCaYEFYJAfWrDPbmGq8RzRE7HjGvCHXihXmxi/NY3eQaMoYMqy/zbosA3+?= =?iso-8859-1?Q?1+21a05Mmi0UfHu06tjMHPsmHFtxZ5dgD6xq29fnTLUmm50Ug91EstENPU?= =?iso-8859-1?Q?uOPHFEzsdhkgT9e1Rg8FhuRojjHmeSYSGJa6xj5pdHo9A3trdwrRNVcVPG?= =?iso-8859-1?Q?8FUWP8IDpMo9Q/4CAp9yaa46FdrRbVGCewDr8n0khygUWRksCTftBaXm7D?= =?iso-8859-1?Q?zAUHkVieVRDyo7q3DDwA80gzdQa1DhuwfGFK6eecQRYsKIvojDW81FwDVV?= =?iso-8859-1?Q?DiC5E8RE+fjgeZHy+FMe3YV/Kajz8pKvH/VhwS0X8PUlV6QwRFEO2guQpR?= =?iso-8859-1?Q?0PvydlOK8/H1uK1YSW64xXSOaNn60N2/dQXk5sZHCvmo5VRkI/cTrp6438?= =?iso-8859-1?Q?mwk5QSR8PPsqySPPkVBOhMdf9RAdDmsnvVPpWOfEmvHt1fabq7/HiYA+v3?= =?iso-8859-1?Q?GTZeMsWAvYUUkGJVYI0et5dIa020izFmeDI4huAS5OPD3Fh1+aNSbhWCUD?= =?iso-8859-1?Q?xUgErY52Iro7DX9M/oBQRB2CiEL6muYqDCrtHmZHotsnanx0an4mJEu4mw?= =?iso-8859-1?Q?3bRe6j2TkYrtO+ipsAAem5gdFdCFB4ADsUZMK3FV5X5yMV4qxrSbwPPuf6?= =?iso-8859-1?Q?5B/ZW6ImgUzURpCJdphfbSe0EEPuoaeORtssjd3no7/+Vr3zF/CAXIIgnG?= =?iso-8859-1?Q?sp55PEMx7RYZttep9M48HsxTqkrZcfQN4FYA6knyL1YStHpLS2+YdHd/t+?= =?iso-8859-1?Q?iMGQa5YKCu0MeQ5MWUIHYYSGLw0z7pVyTP?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 948219f1-b01c-43d4-a19b-08dbe46d5437 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2023 17:24:01.8514 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GP+ZS0FFteMoTmzoOFK89eh78zYc1bwzvA7tWfKiiWC/Lf/asJbgWuUib7IZcYqc X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4263 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,igork@ami.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: LUdyM7ANBsGa0yQN34nc4YS2x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=IhrQYFwS; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Supported function of the driver changed to wait for all network interface to be installed. Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Igor Kulchytskyy --- .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 31 ++++++++++--------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPk= g/RedfishDiscoverDxe/RedfishDiscoverDxe.c index 23da3b968f..0f622e05a9 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -1547,25 +1547,26 @@ TestForRequiredProtocols ( ControllerHandle, EFI_OPEN_PROTOCOL_TEST_PROTOCOL ); + if (EFI_ERROR (Status)) { + return EFI_UNSUPPORTED; + } + + Status =3D gBS->OpenProtocol ( + ControllerHandle, + gRequiredProtocol[Index].DiscoveredProtocolGuid, + (VOID **)&Id, + This->DriverBindingHandle, + ControllerHandle, + EFI_OPEN_PROTOCOL_GET_PROTOCOL + ); if (!EFI_ERROR (Status)) { - Status =3D gBS->OpenProtocol ( - ControllerHandle, - gRequiredProtocol[Index].DiscoveredProtocolGuid, - (VOID **)&Id, - This->DriverBindingHandle, - ControllerHandle, - EFI_OPEN_PROTOCOL_GET_PROTOCOL - ); - if (EFI_ERROR (Status)) { - if (Index =3D=3D ListCount - 1) { - DEBUG ((DEBUG_INFO, "%a: all required protocols are found on thi= s controller handle: %p.\n", __func__, ControllerHandle)); - return EFI_SUCCESS; - } - } + // Already installed + return EFI_UNSUPPORTED; } } - return EFI_UNSUPPORTED; + DEBUG ((DEBUG_MANAGEABILITY, "%a: all required protocols are found on th= is controller handle: %p.\n", __func__, ControllerHandle)); + return EFI_SUCCESS; } /** -- 2.37.1.windows.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111170): https://edk2.groups.io/g/devel/message/111170 Mute This Topic: https://groups.io/mt/102566319/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-