From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4B842AC1143 for ; Tue, 14 Nov 2023 14:28:12 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=sAvpjO8/Y00FGyndw1Kv4PtIO/B+0evZd15BY+0pnGo=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699972091; v=1; b=fpjQLSqs1qLhrB11mRnrsv2ssC7Rbg2chpKtxZKKHpbUbgQa0ydcbnyEDV/3hdimV4O7xhP7 poDQimMpnYMORC3pLNBqLu6+M3pQwUWlBC4HVtxAfSX/a1oUjqUQ+JuT+xErBuMzoN4QD/mU3zh 6dRp9Trcg3BQ2+alDgoeKVPQ= X-Received: by 127.0.0.2 with SMTP id StJwYY7687511xz836maOqR6; Tue, 14 Nov 2023 06:28:11 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.58]) by mx.groups.io with SMTP id smtpd.web10.13758.1699972090200071665 for ; Tue, 14 Nov 2023 06:28:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T/nq0iwYj/yLl48fVuYp8jfTG5uUusPXNwdRyGjy/Ze1BJbw2gS06gTQcoyBB7q2y0stUFNb0YxfeCDwKVtv3FyzUAaBFQhYrBQUlfYWzE5IXVlFwxCVS+YhTHUODxKPYqG0M8BVyTe7ri1FyqIShf4xMDQ8qKg/ewOKp5ajw1+BUvM0aruwCnFlPbtKOLEeAZoeyw8KloKiUEM1brqR3H6RKa4YctHB58ATkZVxvi649R3OuI3CWYEsiocpPiuwEU4P3J5If3FWueu0CdmuEDnf3Yn5rKHmn45qv6bAZTwqdZv1F/CX3QQxHjT2Tm0eJxpcX2tdzrUTt+KzH+rn9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LatQJy74lsl0+EKmrcv3aJeRn/uKI8MV4a52aIgmIro=; b=YHuLh26LDKdW02cigKGLINs2EhdXDHpBjl6SkYhl/TQywoZb1k1MWfxH3woQsFVHY9ALziD6JsHt73b75oIdm5c1fo8FSxZLPE3xa6SJhgyOwdidZYhDZAv2D2T9vS5EDOwX1VEB1eDxSIWdSsz/geGbAmtZZo3jVfm7id73YM1ZlHB/4TG2fxclehctDLwAH5s/CvMjNdfC1Wf4m9De8YCZXcdDxP8cz8eOGLMJnV0B3YHmC9BtSry9BoxqS5MJjKbbLC8KX7DCtjLUHsFw178z1Yzsjd/1vz8lMBSdjbMEHxw7XJFU6EptrzFtIUgxbLI2yt4DnDOgpkljPloeZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by CO1PR10MB4594.namprd10.prod.outlook.com (2603:10b6:303:9a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.29; Tue, 14 Nov 2023 14:28:07 +0000 X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::9dc0:d4e1:1d40:3e33]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::9dc0:d4e1:1d40:3e33%4]) with mapi id 15.20.7002.015; Tue, 14 Nov 2023 14:28:07 +0000 From: "Igor Kulchytskyy via groups.io" To: "devel@edk2.groups.io" CC: Abner Chang , Nickle Wang Subject: [edk2-devel] [PATCH v5 1/2] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx Thread-Topic: [PATCH v5 1/2] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx Thread-Index: AQHaFwbJ9rsBiebOqUyrd2XIVDds3A== Date: Tue, 14 Nov 2023 14:28:07 +0000 Message-ID: <20231114142805.90-1-igork@ami.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BLAPR10MB5185:EE_|CO1PR10MB4594:EE_ x-ms-office365-filtering-correlation-id: e93b2ca7-96d8-456c-300d-08dbe51debd5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: keHjhljEwb0ddOZjYkNXfShyEjQ/7GxAM2eHqAvsxu5x+d6coKJUF+26nxTi/l+n9tIM4AKIVOTp56eVkkv2VUZmNu5DIoBkL6+wa1qXBvxDaTVUOjD5uLRVuChHYpYvocbDZUY6IHy7DewjVlSYLswY96X9Cv/UfEwgasnhGRIMIw4M/Q+vZSMDlslrVkDkNVsv/uxb/oFzMWJh4noxma0sQeaUvDktMYFYondnsBb3EYVwH8fpLK7Vvrj+gNDCQbM8RxI1vY9n4EFM5WLttfAFSuOjaP91fYirOi+s7IgVzconbT20QsTrCPV6T+hAxqakLyfuJ+N8ogQC2qHO69G0+6lfF/LNcntPF3/NYueUJ92UBFK/mRimxiCGBX+kgZcCsOtLueOL8plrE4aEKGqBW/oe9rvxvy00E/lqVQ82Oqxxicfi2dwiG04kl72SWy5b4UDipYs8DYW62mLPRX4PTIfKjHmqxgu0BgD6PjxrtmPPEwI//gUl1spDXXXn1/CiXldhSj7cU2NWiZi+3nyFYsJchHb2A3uC8UPv4ythP/6pFZIRBWvtuz9+ncEytF0blvv+oyTnEYoBqPGrCx7+EW2UR8tHtD9tTpArlcZw/7tw3JFCCLaoLgS74PW4 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?kan/9peLHhM8yfekn1jeyX1fSVleVmKCQtTIbKx6M++RakG4brqGfnYXL7?= =?iso-8859-1?Q?B/yOvtq8zF3Ra7EmHOiWjWuLzE+VJQQjnZmdy6cJXXw9suiGuXMfvtr0ka?= =?iso-8859-1?Q?8M6O8Ez6N1tuk+nPfQ2jJz4nfSv4XZiyJT7naxmJdseD98ihMb3XwChZiU?= =?iso-8859-1?Q?1eU7TfxxOBziU9kRsFee87vXsQJLOZFs2eEEdxIE6kicnzpTZjedz3wTxk?= =?iso-8859-1?Q?MJKbNoDLTjKAdIiNsHxCsfXSRXPObNp+LIoXIq/4sImJY0WvNq+yU/i1xB?= =?iso-8859-1?Q?8GARTNQBCc3Jfy9vdO/rTjuUh1M3aj/lDkyaaAooyVbzxlNOe51pjkoQ45?= =?iso-8859-1?Q?+wi0jfxpzvTQ3Ns+rpttu2rXQZ8Fd6TTt6XvSWW2Z3UjQLC7wh3FL7zc0A?= =?iso-8859-1?Q?G7fM1eIMTCefMWqC2geN3Oc5qJt11RkIm1kUrED+83TpDLbYCDEvgZaJbU?= =?iso-8859-1?Q?4Mi6cZe5t2e4e5PIxIahLACEkNMpMKL7Se/Wa4f+4f57XnICNb0PqfiIaN?= =?iso-8859-1?Q?NFu1P3caAToD7ee2NfVPcMgTq5WsI1iOABYDQLMmcxk9g3jfossPZYi44S?= =?iso-8859-1?Q?nePYvC5V9OqO3ptnoCADiI/JA3UyqhRotEKBPEwzIvnBSHjpPI4i86y3sp?= =?iso-8859-1?Q?IaZU8hauPCUPAv0mpcnbbP3hWJ2+OrJemjJ1zNNSUt0E20e3CeYT4a+vLQ?= =?iso-8859-1?Q?VwTTLir751m4bcMga01eWycp1Elmo4gx8ZPbVDf30i+yPNf2Txws5kun+V?= =?iso-8859-1?Q?TJQhhfRKrKN9MwNjWnCI5qsoQOc+I0Sr2VqfE7SdSiZxBNeUwDJTBaN5dm?= =?iso-8859-1?Q?7WkYp+Mp247T8wmHFoHMpu4usSh+1mUhwtE61qUy0dad8Tm+/MBBAqd5C4?= =?iso-8859-1?Q?gl5z77puHtfZF1DT/YtQdTl2bU7KCjDpM+DsKgTr6h1CY3USMxYHSpI5C9?= =?iso-8859-1?Q?8AVU9PP4I+/HOKs4GOiDjKpge0YltbPJtxJ7jbTgCEILctT72KjRRmX3Hx?= =?iso-8859-1?Q?D2eRYqouuVNT36AySNILyricjuEC9J3ooAybIHNCBy8DWjixXxcX38Me7V?= =?iso-8859-1?Q?Y34XESEjW8XLWTX8PNlQeBYiKLPI2IfS9xD4kXcxDj57EPXeYOtuWeBWIv?= =?iso-8859-1?Q?GXORqZLd0SookKtZy5w9d5JMUm6SieIXZlYLtFNrt5Jn4FAXvlUanJvPRf?= =?iso-8859-1?Q?HAuxuF8EERIvRUGRMN2k1kx8f9nWn1RjrTsZ3xgp8ipNzu2i+jI91vMiF9?= =?iso-8859-1?Q?tzR19aHX5pRQnG3CYvpDUrRYFs4c5avH2eYNV3LniCBd4H43GJDj3SbtQA?= =?iso-8859-1?Q?d3VegiZ3KVzkajGoSIB25IujMTfQA/Oi0Xgn096EBIL5fy9THQmw9NkkZl?= =?iso-8859-1?Q?52W1H2xmsTESS/qL7SD9rvpKYbdBAzQquYC5VZ9Vcl1sUSpw4SZMv257fJ?= =?iso-8859-1?Q?xP1CP0tAt/32qo2uB5uokVv6l3+2y6CVAVgHwmtUrivgbNKq+KFeoI7EQB?= =?iso-8859-1?Q?+beLJTqh22rnosPqW9R6H/Xem7L30D2HAU57tSCHJImdlTSYN9i19RUKWO?= =?iso-8859-1?Q?yvKMhlp4XUFpzWE0WCCiLHJE2CAYMqwnLeCWBir16ejVn2pABR46PPyEIQ?= =?iso-8859-1?Q?dOwQ3h/0s8jEdq0YH3FKQT6OWKLy4UJyJK?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e93b2ca7-96d8-456c-300d-08dbe51debd5 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2023 14:28:07.6122 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yhDV6iGxUNCtDYMVa5oXgGU3WIUQCnU8PXOmlGLIt9qltCz50GHCi0QFo0X7cicN X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4594 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,igork@ami.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: u8WE6k3f0pjnJvMPx8jndJg4x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=fpjQLSqs; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Supported function of the driver changed to wait for all network interface to be installed. Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Igor Kulchytskyy --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 31 ++++++++++--------= -- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPk= g/RedfishDiscoverDxe/RedfishDiscoverDxe.c index 23da3b968f..0f622e05a9 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -1547,25 +1547,26 @@ TestForRequiredProtocols ( ControllerHandle, EFI_OPEN_PROTOCOL_TEST_PROTOCOL ); + if (EFI_ERROR (Status)) { + return EFI_UNSUPPORTED; + } + + Status =3D gBS->OpenProtocol ( + ControllerHandle, + gRequiredProtocol[Index].DiscoveredProtocolGuid, + (VOID **)&Id, + This->DriverBindingHandle, + ControllerHandle, + EFI_OPEN_PROTOCOL_GET_PROTOCOL + ); if (!EFI_ERROR (Status)) { - Status =3D gBS->OpenProtocol ( - ControllerHandle, - gRequiredProtocol[Index].DiscoveredProtocolGuid, - (VOID **)&Id, - This->DriverBindingHandle, - ControllerHandle, - EFI_OPEN_PROTOCOL_GET_PROTOCOL - ); - if (EFI_ERROR (Status)) { - if (Index =3D=3D ListCount - 1) { - DEBUG ((DEBUG_INFO, "%a: all required protocols are found on thi= s controller handle: %p.\n", __func__, ControllerHandle)); - return EFI_SUCCESS; - } - } + // Already installed + return EFI_UNSUPPORTED; } } - return EFI_UNSUPPORTED; + DEBUG ((DEBUG_MANAGEABILITY, "%a: all required protocols are found on th= is controller handle: %p.\n", __func__, ControllerHandle)); + return EFI_SUCCESS; } /** -- 2.37.1.windows.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111196): https://edk2.groups.io/g/devel/message/111196 Mute This Topic: https://groups.io/mt/102584128/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-