From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 836CAD81092 for ; Wed, 15 Nov 2023 07:35:41 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=GFpTX2KTC/19YWAksAkYFeEp+7UA0Dc1DkkJGDqQnUQ=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Date:From:To:Cc:Subject:Message-ID:References:In-Reply-To:User-Agent:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1700033740; v=1; b=WQ5Eb8vWw+JMfjscviP/CRoDOsRgYUXXavPcSKcVrIQShEJfJrM9BM6O+52FHXukYBfPQwnl Fspyt/cnxUI30SN4yO5pOTmNY1PJeDFg/2q4WQAaQ3gBxmEZk53SJXsRLSlISLaVizwHiKZf3K/ Tj39S76CCK38sU1+c3ZGRckE= X-Received: by 127.0.0.2 with SMTP id Qd8oYY7687511xtekfbJDHp0; Tue, 14 Nov 2023 23:35:40 -0800 X-Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.87]) by mx.groups.io with SMTP id smtpd.web10.8203.1700033739091563882 for ; Tue, 14 Nov 2023 23:35:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jxFS0cyHOZKvcScRwd0qRuUIiEsMEzuyjkO0YsZepZw0NAxzStlQknENfphkHvX3vNsAaDjhEC1i1Dx2jL55+9YllGyyDLc4eb53ir+8uJp1NKdoEdUrZfyc2TQcYdm7fG2VPRg6B49cfCvblPaNqHuWjIiY/0c7Sxmr11gpry2ooNDgfZoqubhLl3aVz1/C9n6mF4EGBhJ+yBFaVbRudMVCxuApiC09X/MFvfdtM+yeMQbmBCTwXEaztcHRsc4FRaPVCao6RW6JJIgv/PQBunJcNLg77gqRMx29OFiq5EpmxA8RroWz4yUmklFb9Y/ACzDLGmnAidN45cdzFbX8HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+mXaja/M+A0EK716oNB3gOBdWmYfSUANu9uLhgCj/sU=; b=PooXID3JWZ47eRo/FjGJo9lKTnGM4ZSp3BwZ/tl+jAhxrvr0lruSCnihk6N0cf2JQlq+uIZ+iSpjmDTg/FpK+oMi1BqeKahZ1/NvPn1bqlx90dCGatl6/SAiVMWWUKsY+Mm7TE1615JH0svPI6w8BXw+E7kyOFVfPXDyl0uCiZirWqdeXUqgDmJvKiyaOJktmUmCxA68Z3WRLM4gY/LVtAQYJ+vNNuFQ78y+oc2MU/KEp41SgKoBe1p4Nn3cxW+EFxGnliG/qYIf6sMA7fgK6SOS2gJ7yAa7t21ojjLM8oc2JujPoejC9FpwU6uqy07xJVxSmC0y3RryoYc4rIylMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none X-Received: from DB8PR04MB7164.eurprd04.prod.outlook.com (2603:10a6:10:129::23) by AS4PR04MB9715.eurprd04.prod.outlook.com (2603:10a6:20b:4f9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.20; Wed, 15 Nov 2023 07:35:35 +0000 X-Received: from DB8PR04MB7164.eurprd04.prod.outlook.com ([fe80::a075:b8bc:387a:c665]) by DB8PR04MB7164.eurprd04.prod.outlook.com ([fe80::a075:b8bc:387a:c665%3]) with mapi id 15.20.6977.018; Wed, 15 Nov 2023 07:35:35 +0000 Date: Wed, 15 Nov 2023 15:35:26 +0800 From: "joeyli via groups.io" To: devel@edk2.groups.io, hongbin1.zhang@intel.com Cc: Eric Dong , Ray Ni , Rahul Kumar , Gerd Hoffmann , Star Zeng , Jiaxin Wu Subject: Re: [edk2-devel] [PATCH v1] UefiCpuPkg: Get processor extended information for SmmCpuServiceProtocol Message-ID: <20231115073526.GV3859@linux-l9pv.suse> References: <20230529063938.230-1-hongbin1.zhang@intel.com> In-Reply-To: <20230529063938.230-1-hongbin1.zhang@intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-ClientProxiedBy: TYCP301CA0052.JPNP301.PROD.OUTLOOK.COM (2603:1096:400:384::15) To DB8PR04MB7164.eurprd04.prod.outlook.com (2603:10a6:10:129::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB8PR04MB7164:EE_|AS4PR04MB9715:EE_ X-MS-Office365-Filtering-Correlation-Id: 8f81091a-31e5-4823-b5fc-08dbe5ad74a0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: 9BG5/Ty+tbxwt8cyQLHHLBiR0c+f5YUKVLpGuwLL6flhFBqkTrb8FE3AdrBfP7mcEFJDDGzhN8ZhCFf686/0cw5G+qkZVq53mPLcTkUuF0m+59pOCoVioCkIluz9qGs75rf4wfR21fTPTxxI5Tc7kIFo/ISKEZGxPg/M3KRriwiibG6mOKOFsSBsmalfRy3mQL8aRL1ZsI/dAgJTmzdKrWN0BNky+Bo0VwpkvCPeD0610hfXpYmo0Sd9C6BZiwUIU442haIDKG3lnet8rL/uP1Ybuwew9jylsZPAlhtAzqHFM2z+dMVkDJZ04WEr0phrt5P94VtPJ8KugU5tr4IwWF+DeGwdi/xk5HPKlzTldgn1qQIbwEp2p5J5wF7XXq61qkzpR6DMZ3kpYkzmiqFEZukF0+H5AQ8tYEJTKmjHE0nYpf3UPaAS1uyrh6medtgYF/FkqhhcWf3sOzk1z7HPdJ+K8wOoNJrsMVBD7Ux6G0jNh71bi6eu46FoLSMhOa7zthgel2g3WzetIeaFUTFMgQTN+e7eU782DhwCMoB8YeYxWqegy0Sh/ZrboR/5Wl8KFqyttzVYFRlBZLUN1rSfPdUZU0x03AK9T9PmygEv7mo= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?41i/vbAAEV/zogtAle6mzEEJkO6RYIxNouM2VzmrDi27QlqDea5hm7Q49Dup?= =?us-ascii?Q?iaDM12MKBGskJ23ma4lw8PKdqmRG/5kcnUrQlCueaEeM7qMjtJ+GjDC51MeP?= =?us-ascii?Q?92F57jV0pFAjAf2qSFxPgmVtDzPaNrE4ofzz/9MyVkyG8Gpg9/t8tIkalEqf?= =?us-ascii?Q?Lx/+Bk+/kSQMmT1czoST+6/mMoDyrqWzL3dC7EAXbPg7hnMFDThYCb81MLh9?= =?us-ascii?Q?1qXtoWpmWgJUvr1yx2cVc9cWswmbJxl71QCGwivFT6rh/oQ56ujTbQi9MPL8?= =?us-ascii?Q?M+KGZcCTGjj82vcRnhDDL7PFrOcBuPstHbrRUxVFMbulwQz102QYl/C1BzVy?= =?us-ascii?Q?OFRXi1GTG1TBfeI8px5rfKv8YZklY7eoZHCuu3Jbx0j9TGAUmT4nS1T21FHI?= =?us-ascii?Q?pIvIsqeoA/vMdaMP9SbqYq77IQBDA2wded/D5rv4SSLWKGHbawy/YI3LBome?= =?us-ascii?Q?aZJnKTbBGYvchJGSEFNoMH6Odfz6aRfVQnbxbqk/0MPq/ig+jmHnnCDr3CZb?= =?us-ascii?Q?mgrON7mCy6CaJzNelK002A6pIF9PJ65bXOICeWsw+JJysT1CQVI5O5MfkVYw?= =?us-ascii?Q?wJtxVc0w7y2prgruNywIzcIR8p8263zfoQgmSmNWFMxoA0+9wprN8sAVzd6w?= =?us-ascii?Q?bYSmK7G9dWsp+36KdMGi7i3IKX9Urg2PN3lBBmlh/ol0Q/CjmahUzyqzxM4s?= =?us-ascii?Q?04n3rJJM4x3Sl87tIYtG03kroVsgR2TTZR+t44ql7qJN0JxapfErg/7wz5x4?= =?us-ascii?Q?Gfnw/i/kqG5+9Xk/C4xbwW/B2l/7AGef4i5cmjfGgQDNr0terQsVYJxEL/rS?= =?us-ascii?Q?EZGXnAOIQB/gmnhkbwDcPk9nnwF8S6GhmvVuq0yEuuvWV8bAFhDDHMV5R6P6?= =?us-ascii?Q?XRUUBM2TS2DYhM1EPIfIdQ99ywfw5BEP4PQtPU7xCnkQ36GoX1/PJQeLst12?= =?us-ascii?Q?lCQ7W5D0E0cIzjqaVQcirhbIOpkaBJbq8lV9vrUPp5LcRG/Y8twiPv5hd20Z?= =?us-ascii?Q?bZxtWXtahhuyB6GbhhJeCJ11tkgrDeiPq9v1IySb9yBvCuNzeJKdBe9Pho93?= =?us-ascii?Q?DWAFxYVpA0qtW3rKrSFl51lMogq138wlUa0KTkcGKDvILUZXa9swMg5DFlGR?= =?us-ascii?Q?ncfVsuoRMiLDOFzK4l6jzqUqOd9a/qD6bfzYOa3gT2PXazlNyNIiUQ1sdVj9?= =?us-ascii?Q?dsjRq2zugoBWLWT5HLh7C9NuuUJbmXQun/kgkMBRboXacItuUwo9OzEd/+JG?= =?us-ascii?Q?TTyvHy+A0ZLXXSqUi/s8lnls14nuDQ35v1Ftbq8ID3gh8NZb+aPwykNYV18o?= =?us-ascii?Q?5MRQqqR79jNunJgw/1x0u/LBp3WQN8slOPLKq+6N9mBS0kfnx+Oe45JaKOWD?= =?us-ascii?Q?ypHUpodlgmjYOkIXpc2+W2rjO8fz7xlM729RFHTiBVqq1KL35icu37+xpR8G?= =?us-ascii?Q?Qxgi3DXm5uyygJsEABOSpyIqX7Hq4Zup6KEDe2QbJRpIr/UglC04Ybk5QYp6?= =?us-ascii?Q?ccPrf0KkJfh3i7alGD7u9nrie51u7RTYeHGv6vLBkUarG4Am96Ql8z/Lkuwo?= =?us-ascii?Q?eazEZ/VmBN3fR7ltdLs=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f81091a-31e5-4823-b5fc-08dbe5ad74a0 X-MS-Exchange-CrossTenant-AuthSource: DB8PR04MB7164.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2023 07:35:35.4022 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8wNdAd0mSryMcJruolxREtP9DUJIjW7XRKsWOuzcA9+EjkfClNqlOekNA91Mnpc5 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9715 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jlee@suse.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 4mGyMsKvmVw68cRRlInCrXuux7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=WQ5Eb8vW; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi Hongbin1, On Mon, May 29, 2023 at 02:39:38PM +0800, Zhang, Hongbin1 via groups.io wrote: > Some features like RAS need to use processor extended information > under smm, So add code to support it > > Signed-off-by: Hongbin1 Zhang I got a ASSERT when booting edk2-stable202308 on a issue machine: ASSERT /home/joeyli/source_code-git/edk2/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c(1478): (Index != 0) || (LevelType == 0x01) And, the ASSERT can also be reproduced on edk2 master. After reverted this patch, the ASSERT is gone. I have filed a bug here: https://bugzilla.tianocore.org/show_bug.cgi?id=4598 I have put some tracing information on bugzilla. Thank a lot! Joey Lee > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Gerd Hoffmann > Cc: Star Zeng > Cc: Jiaxin Wu > --- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > index c0e368ea94..8311c3b9de 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > @@ -929,7 +929,7 @@ PiCpuSmmEntry ( > gSmmCpuPrivate->Operation[Index] = SmmCpuNone; > > if (Index < mNumberOfCpus) { > - Status = MpServices->GetProcessorInfo (MpServices, Index, &gSmmCpuPrivate->ProcessorInfo[Index]); > + Status = MpServices->GetProcessorInfo (MpServices, Index | CPU_V2_EXTENDED_TOPOLOGY, &gSmmCpuPrivate->ProcessorInfo[Index]); > ASSERT_EFI_ERROR (Status); > mCpuHotPlugData.ApicId[Index] = gSmmCpuPrivate->ProcessorInfo[Index].ProcessorId; > > -- > 2.37.0.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111242): https://edk2.groups.io/g/devel/message/111242 Mute This Topic: https://groups.io/mt/99209786/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-