From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id ECCE8AC1257 for ; Wed, 15 Nov 2023 12:11:29 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=DrYm/GyiJdHIsnKoehS8bGCBvaBVgNfPyEE9RVyy2Go=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Date:From:To:Cc:Subject:Message-ID:References:In-Reply-To:User-Agent:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1700050288; v=1; b=YfvQt93kP4nBPtUe4qB3y6jc5o5YFdzptbwgPzXVna5PQmKb93hGWp/CcmK/0JRVXagdJird 3HtV6vPG5d6IGggJPFlHrk5UUr3Rwo6yoee5t2A6a9Ja9HI0vwXHJJcTTkfdcdToqyuA2n4zTH/ vSpfCAjzyJgfBk7QTFZR9vHQ= X-Received: by 127.0.0.2 with SMTP id a4cbYY7687511x92xylhxzDA; Wed, 15 Nov 2023 04:11:28 -0800 X-Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.77]) by mx.groups.io with SMTP id smtpd.web10.11485.1700050287554894895 for ; Wed, 15 Nov 2023 04:11:28 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UTpvzI/orBCf/0w04XAEstJe8GeKmsqLmaFLtBOiMWOrYkMhMuK1C6Xcl0zUSgBb423N/NicluRWTGkxDcv2eCUPQiKJbRM5FaC/nvV4Zp/kewll1ePkeTwZQGLwztLfPdbOzqgrpL1eUguB5Z6ekL58j4jlGp6ZN68B6BYa5iOOchY03xciNpZP0Z9tlt8EEk+9LGDpXmkUYbRTRtcQNSd9ZXY6YW9kCKjTDLI9xu4eKltzdUY7EozDBix4rdGZILXBtoj4sLegXeoY8SwOxjg5PeK9lXkbPHzutk86FzlOvXuMvE0T6idL6D53s4WiTPi9Wrv2/hEn7G6NyXCrfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bdOQqBPvUCGsXNRI7rLmGjgqnEMhzdd6dweUKffXErA=; b=cu3RawKPX8u3UOXEd7WcZ1fcJfD0X0N8rnA1DsrnIPSTFREJX1Ds6dUD8sPXPdT6pHRHltk+2RcJYvWjRQWFgazJFcD1fqvzbrIYQdoncsrRh6kkuaCAi2W3otKJroi3H2VAzu3L34kZMSZv3ZRemA0yigg2HvaRf+40glmVFhuW2SqTM+DjPRl+LuJSnL279wQfcFK8fYFqNmdbj+bhZuvVVk16urwZg/sZrQBbLGdqV5ua/boHYKbxEFWUhfRpW33MaGhvvfcZcGWHhuKj6LdeMarVUtqCbFR4GSjCIOWFfodcWx14hQgpYtGLlh1wLmYS/TaVI8EcGVvddBRqzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none X-Received: from DB8PR04MB7164.eurprd04.prod.outlook.com (2603:10a6:10:129::23) by PAWPR04MB9839.eurprd04.prod.outlook.com (2603:10a6:102:38b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.14; Wed, 15 Nov 2023 12:11:24 +0000 X-Received: from DB8PR04MB7164.eurprd04.prod.outlook.com ([fe80::a075:b8bc:387a:c665]) by DB8PR04MB7164.eurprd04.prod.outlook.com ([fe80::a075:b8bc:387a:c665%3]) with mapi id 15.20.6977.018; Wed, 15 Nov 2023 12:11:24 +0000 Date: Wed, 15 Nov 2023 20:11:17 +0800 From: "joeyli via groups.io" To: "Wu, Jiaxin" Cc: "devel@edk2.groups.io" , "Zhang, Hongbin1" , "Dong, Eric" , "Ni, Ray" , "Kumar, Rahul R" , Gerd Hoffmann , "Zeng, Star" Subject: Re: [edk2-devel] [PATCH v1] UefiCpuPkg: Get processor extended information for SmmCpuServiceProtocol Message-ID: <20231115121117.GZ3859@linux-l9pv.suse> References: <20230529063938.230-1-hongbin1.zhang@intel.com> <20231115073526.GV3859@linux-l9pv.suse> In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) X-ClientProxiedBy: VI1P191CA0013.EURP191.PROD.OUTLOOK.COM (2603:10a6:800:1ba::9) To DB8PR04MB7164.eurprd04.prod.outlook.com (2603:10a6:10:129::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB8PR04MB7164:EE_|PAWPR04MB9839:EE_ X-MS-Office365-Filtering-Correlation-Id: 46694ff1-2d86-4e94-4c1a-08dbe5d3fc7d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: fJZulFP0uW+qc/9TST9yCd5piwX64O08EYEhR4lHtdakS66w7QnX3CQ2o0IYtpzfoEuZ89bIUlsINR4rssIwVLPhCPW1tcxJ38k+1fAv/5IIgZZz9VjA1hmA8m8uSYHObs4bCV3UdM7rLj4RbEAD+QVan2+FIqB0uOE2UNt1M6ObajN7vt+srjru2SL9YiFP7lGYh0RCb1BLhNiQz27GOtW6S+zHPC72LZ1mUcPXUoAlcOkJkJXfsSfU4TVB764WBLnTNn2QlQC8xiM+Ml2xRGA0ynP+70o6BHMbRi82iO4rGq2j77CJTWsME9q7eU/AN4CcjFFZp/dr3BYsDzICkGH9yNAChDWyciqHohBabAsV/SWPkrSn1e506mLrVYzPNBqBU3mtUWJdSfzP7ZFG6SWSGm1FBcbTDTVVic3aTXsKuHHOr+l94IxaO7tIpeTc39kFqczJpwQzAdHW0ywdP4qbsWNZFo1c1fokvwQcXnHPSibyGGvqaZLvMEP+u5k4JQcmkx8jGRk/JnJPq5A3osZoSLdflWWBkr6LgmSPmajg6TXTSV+xAniQN6+GuTeywZkOkJbM+JOB9MrWs4l89wMGXDiVSTZnb+g0aBDSmxA= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?u0B0ZTBpnjFk0YouXc6i9gFmNLCTfOXp5WK5142GjW14idwFy6fBGKddtofK?= =?us-ascii?Q?oUPVzESVW9kb40T2NF6BLta37swRjx4va3NBoSrbugwDD5kJLcNeXez3QxD5?= =?us-ascii?Q?pgQZxSurDODohL7DzchXQR7rSr/fyTdLNI8JEFJSCHpCjAZinQ0r7PzSjw52?= =?us-ascii?Q?9w/AAbOSmYRd7Uyikf9pdocq8uOyr+v7/xG6hPDOEL7KsXIETjz/PoBdg5jZ?= =?us-ascii?Q?Cy3tX/CNqa3ZSnnDp/KdNsMdjXDPAzOdSIOxNe5jdQXMRbg5aVGmB5M9y+cN?= =?us-ascii?Q?+S111TP50S01tk0Vb5r/tkEEaWJTpZMQjpeJ3PsN1oRGVwmOXhgM+jaa3EXL?= =?us-ascii?Q?MvdqkUFocAlewywLe4WxoBwF8CuIoa9rUMgk/YT6I6Az52lOYrZevPxaEKxt?= =?us-ascii?Q?jAjSOH77OEUrHalS4jiV1DcfTQypBQkAVILuFrWn2caaeG9ssBCdQwm9GHQW?= =?us-ascii?Q?3msy9W4mzrgFDzUh7dCgJEQQIxhNWfcckUY0Bq44BLEXnmrQGa87sboZkW7v?= =?us-ascii?Q?wDGk3Au38DAwKGyNkpBSfQ5Ys5SaaGgrbISdue+ufnVz6xwmE1fZXaJ+4Z0s?= =?us-ascii?Q?P2volJRIdKcmg7ekGzGx8/bUcfjdLwil2wcFI5uX/GprWqVT++sABniXb7uN?= =?us-ascii?Q?gdyT2BdprQUemHYeRbdRFbGBKLGEkMhVR72z9rfb/p9HQ6Qnt6pAHSZARVjy?= =?us-ascii?Q?AY94eXYZ0yqnW2I0caN0rbFOm+gKSDtKSvZWj186I/owxu4n8oSnDKToyo+e?= =?us-ascii?Q?xUV3kq3ULLAlqFco7SAsxaXhJ1d7aZ7hWfjlJnz+iqzxDG7XOnznm9hwRAP2?= =?us-ascii?Q?noiZbURWtR7yTCDNb20tjWf8sEjJsq1FqxCrS4t1kxrrP9a84gwcRNi+yWcc?= =?us-ascii?Q?w/aexhGpjVtXxCdTKVZld2og7BseQoBT/6IO/TEAXazkZhRJVUdVoNzlw0rJ?= =?us-ascii?Q?pwkG2mYXxh2KGNn+Mr4Mjj4ksuqXFnAKRu1Zf/FWs7/9ljbX+M2Lpkjl2hRB?= =?us-ascii?Q?xxdNVCg77Vi6HfyoQ2Uklp9SLY0j8LRKoh/UVajtvDxErwMlG16MCkP6ErCl?= =?us-ascii?Q?mnmbP45hUZge/L666WtiYUcKqtEXfYiTZ6MpZdX3FTlgKF8uTLrqB0wVRHil?= =?us-ascii?Q?5wmMIak/VZue5PaK7S89Zcs9FH7UCvxcbCVTqXk6by8ROY8BKNSgyXqW1Z+V?= =?us-ascii?Q?XNXJN7RvPxB6b/4XolAwcsjN+3RZKGgWoyY73/jv6tOVREhjJJnWZ3wudzJM?= =?us-ascii?Q?qau6gPLUTrq2eZJuL0+338Ht9yajtvmeUP9JcQFf2FxjEkyuZWktjyAtAqoC?= =?us-ascii?Q?XGm0gChxm7Afg28HOJTEe9VYXmcTnJaPT2WeWsx7/3nWLcwvW01f5wrBcSjD?= =?us-ascii?Q?ionEBRO2o//wqO1VnCJc9Dk6Wj9zmqyzOoJCrGy2nV01ri4FmEvuMNlen/rW?= =?us-ascii?Q?zkbMoATeq63bTX8va5oDZNKDn9obO1Jb7Hj6JTI3CLsnhsiRpuMkp7VDWgLD?= =?us-ascii?Q?1kXuxVUPKy11NBDZh6KTHvykpJEXBaLUn9zNyRUF+l1+ApgTzR2Hnlvamy5n?= =?us-ascii?Q?tT/3hqp/QcO/DKmO6jQeyaDh+w1ab+s3nAG1cNgY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46694ff1-2d86-4e94-4c1a-08dbe5d3fc7d X-MS-Exchange-CrossTenant-AuthSource: DB8PR04MB7164.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2023 12:11:24.1143 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dkWVmtRBULpeUd9YDN1Cu6+r0S46RhMsputR31+/K6xw+rzAz4w67I5w7vwClNrS X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9839 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jlee@suse.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: KQ7j7Fjvn2tEPeQGYhVAlREhx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=YfvQt93k; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Jiaxin, Thanks for your reminder! I have tested Gerd's patch and it works to me! Joey Lee On Wed, Nov 15, 2023 at 11:30:07AM +0000, Wu, Jiaxin wrote: > Hi Joey, > > Please check your local code whether has the commit 170d4ce8e90abb1eff03852940a69c9d17f8afe5 from Gerd, > > Assert in 1478 means you don't have that patch. > > Besides, I'm also porting the change to BaseXApicLib, see patch: https://edk2.groups.io/g/devel/message/111257 > > Thanks, > Jiaxin > > > -----Original Message----- > > From: joeyli > > Sent: Wednesday, November 15, 2023 3:35 PM > > To: devel@edk2.groups.io; Zhang, Hongbin1 > > Cc: Dong, Eric ; Ni, Ray ; Kumar, > > Rahul R ; Gerd Hoffmann ; > > Zeng, Star ; Wu, Jiaxin > > Subject: Re: [edk2-devel] [PATCH v1] UefiCpuPkg: Get processor extended > > information for SmmCpuServiceProtocol > > > > Hi Hongbin1, > > > > On Mon, May 29, 2023 at 02:39:38PM +0800, Zhang, Hongbin1 via groups.io > > wrote: > > > Some features like RAS need to use processor extended information > > > under smm, So add code to support it > > > > > > Signed-off-by: Hongbin1 Zhang > > > > I got a ASSERT when booting edk2-stable202308 on a issue machine: > > > > ASSERT /home/joeyli/source_code- > > git/edk2/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c(147 > > 8): (Index != 0) || (LevelType == 0x01) > > > > And, the ASSERT can also be reproduced on edk2 master. After reverted this > > patch, the ASSERT is gone. > > > > I have filed a bug here: > > https://bugzilla.tianocore.org/show_bug.cgi?id=4598 > > > > I have put some tracing information on bugzilla. > > > > Thank a lot! > > Joey Lee > > > > > Cc: Eric Dong > > > Cc: Ray Ni > > > Cc: Rahul Kumar > > > Cc: Gerd Hoffmann > > > Cc: Star Zeng > > > Cc: Jiaxin Wu > > > --- > > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > > b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > > > index c0e368ea94..8311c3b9de 100644 > > > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > > > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > > > @@ -929,7 +929,7 @@ PiCpuSmmEntry ( > > > gSmmCpuPrivate->Operation[Index] = SmmCpuNone; > > > > > > if (Index < mNumberOfCpus) { > > > - Status = MpServices->GetProcessorInfo (MpServices, Index, > > &gSmmCpuPrivate->ProcessorInfo[Index]); > > > + Status = MpServices->GetProcessorInfo (MpServices, Index | > > CPU_V2_EXTENDED_TOPOLOGY, &gSmmCpuPrivate->ProcessorInfo[Index]); > > > ASSERT_EFI_ERROR (Status); > > > mCpuHotPlugData.ApicId[Index] = gSmmCpuPrivate- > > >ProcessorInfo[Index].ProcessorId; > > > > > > -- > > > 2.37.0.windows.1 > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111269): https://edk2.groups.io/g/devel/message/111269 Mute This Topic: https://groups.io/mt/99209786/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-