From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6E565941732 for ; Wed, 15 Nov 2023 12:46:31 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=GIwLyhzaO8m9yt/URNWQiqecxBr6ATqJ2QkBtt2GfGU=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1700052390; v=1; b=rYX/Ja9urCAcNLOJ2epC5QwucjHirAqMSJZQgcpgA2sPd9FXWdRnIliBFVioYWYKUA3/KH3V 4GjHh7c9TjLJSdvh/h6z5+oKYl+vsyPERgNwVQe+c6xitMs5Xv70SnadH4hOu53l2Opzl+dVXvV aykSSLoXxH6Zk+LZ+HOgDj1c= X-Received: by 127.0.0.2 with SMTP id hR3TYY7687511xgyB9IuBuiM; Wed, 15 Nov 2023 04:46:30 -0800 X-Received: from muminek.juszkiewicz.com.pl (muminek.juszkiewicz.com.pl [213.251.184.221]) by mx.groups.io with SMTP id smtpd.web11.12044.1700052389083983104 for ; Wed, 15 Nov 2023 04:46:29 -0800 X-Received: from localhost (localhost [127.0.0.1]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTP id E8AC7261138; Wed, 15 Nov 2023 13:46:24 +0100 (CET) X-Virus-Scanned: Debian amavis at juszkiewicz.com.pl X-Received: from muminek.juszkiewicz.com.pl ([127.0.0.1]) by localhost (muminek.juszkiewicz.com.pl [127.0.0.1]) (amavis, port 10024) with ESMTP id DZjheK1A1fTn; Wed, 15 Nov 2023 13:46:23 +0100 (CET) X-Received: from applejack.lan (83.11.8.194.ipv4.supernova.orange.pl [83.11.8.194]) by muminek.juszkiewicz.com.pl (Postfix) with ESMTPSA id 04224260836; Wed, 15 Nov 2023 13:46:20 +0100 (CET) From: "Marcin Juszkiewicz" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Graeme Gregory , Jeremy Linton , Leif Lindholm , Ling Jia , Marcin Wojtas , Peng Xie , Yiqi Shu , Marcin Juszkiewicz Subject: [edk2-devel] [PATCH edk2-platforms 1/1] set WritePolicyValid for all cache types Date: Wed, 15 Nov 2023 13:46:08 +0100 Message-ID: <20231115124608.1712896-1-marcin.juszkiewicz@linaro.org> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: CJJ4TKnh170A3sZmvwXfPCZlx7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="rYX/Ja9u"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linaro.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io acpiview complains: ERROR: On Arm based systems, all cache properties must be provided in the cache type structure. Missing 'Write Policy Valid' flag. ACPI specification says: > Set to 1 if the write policy attribute described is valid. A value=20 > of 0 indicates that, where possible, processor architecture specific > discovery mechanisms should be used to ascertain the value of this > attribute. Signed-off-by: Marcin Juszkiewicz --- Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h | 2 +- Platform/RaspberryPi/AcpiTables/Pptt.aslc | 2 +- Silicon/Marvell/Armada7k8k/AcpiTables/Pptt.aslc | 2 +- Silicon/Marvell/OcteonTx/AcpiTables/T91/Pptt.aslc | 2 +- Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc | 2 +- Silicon/Socionext/SynQuacer/AcpiTables/Pptt.aslc | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.= h b/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h index 983d17f6fa50..61d8bce8c959 100644 --- a/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h +++ b/Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h @@ -126,7 +126,7 @@ typedef struct { 1, /* AssociativityValid */ = \ 1, /* AllocationTypeValid */ = \ 1, /* CacheTypeValid */ = \ - 0, /* WritePolicyValid */ = \ + 1, /* WritePolicyValid */ = \ 1, /* LineSizeValid */ = \ }, = \ 0, /* NextLevelOfCache */ = \ diff --git a/Platform/RaspberryPi/AcpiTables/Pptt.aslc b/Platform/Raspber= ryPi/AcpiTables/Pptt.aslc index a52bc5a31adf..b80f5ff1e057 100644 --- a/Platform/RaspberryPi/AcpiTables/Pptt.aslc +++ b/Platform/RaspberryPi/AcpiTables/Pptt.aslc @@ -114,7 +114,7 @@ typedef struct { 1, /* AssociativityValid */ = \ 1, /* AllocationTypeValid */ = \ 1, /* CacheTypeValid */ = \ - 0, /* WritePolicyValid */ = \ + 1, /* WritePolicyValid */ = \ 1, /* LineSizeValid */ = \ }, = \ 0, /* NextLevelOfCache */ = \ diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Pptt.aslc b/Silicon/Ma= rvell/Armada7k8k/AcpiTables/Pptt.aslc index e03bfcd6211d..f3a9b90fb564 100644 --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Pptt.aslc +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Pptt.aslc @@ -94,7 +94,7 @@ typedef struct { 1, /* AssociativityValid */ = \ 1, /* AllocationTypeValid */ = \ 1, /* CacheTypeValid */ = \ - 0, /* WritePolicyValid */ = \ + 1, /* WritePolicyValid */ = \ 1, /* LineSizeValid */ = \ }, = \ 0, /* NextLevelOfCache */ = \ diff --git a/Silicon/Marvell/OcteonTx/AcpiTables/T91/Pptt.aslc b/Silicon/= Marvell/OcteonTx/AcpiTables/T91/Pptt.aslc index f37c7511134d..3793cbbca0b5 100644 --- a/Silicon/Marvell/OcteonTx/AcpiTables/T91/Pptt.aslc +++ b/Silicon/Marvell/OcteonTx/AcpiTables/T91/Pptt.aslc @@ -94,7 +94,7 @@ typedef struct { 1, /* AssociativityValid */ = \ 1, /* AllocationTypeValid */ = \ 1, /* CacheTypeValid */ = \ - 0, /* WritePolicyValid */ = \ + 1, /* WritePolicyValid */ = \ 1, /* LineSizeValid */ = \ }, = \ 0, /* NextLevelOfCache */ = \ diff --git a/Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc b/S= ilicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc index ae1a21df23b9..04652653563e 100644 --- a/Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc +++ b/Silicon/Phytium/FT2000-4Pkg/Drivers/AcpiTables/Pptt.aslc @@ -92,7 +92,7 @@ typedef struct { 1, /* AssociativityValid */ = \ 1, /* AllocationTypeValid */ = \ 1, /* CacheTypeValid */ = \ - 0, /* WritePolicyValid */ = \ + 1, /* WritePolicyValid */ = \ 1, /* LineSizeValid */ = \ }, = \ 0, /* NextLevelOfCache */ = \ diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Pptt.aslc b/Silicon/S= ocionext/SynQuacer/AcpiTables/Pptt.aslc index e351d82b9763..f3e9149769ea 100644 --- a/Silicon/Socionext/SynQuacer/AcpiTables/Pptt.aslc +++ b/Silicon/Socionext/SynQuacer/AcpiTables/Pptt.aslc @@ -91,7 +91,7 @@ typedef struct { 1, /* AssociativityValid */ = \ 1, /* AllocationTypeValid */ = \ 1, /* CacheTypeValid */ = \ - 0, /* WritePolicyValid */ = \ + 1, /* WritePolicyValid */ = \ 1, /* LineSizeValid */ = \ }, = \ 0, /* NextLevelOfCache */ = \ --=20 2.41.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111270): https://edk2.groups.io/g/devel/message/111270 Mute This Topic: https://groups.io/mt/102603819/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-