From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 801D7AC19CF for ; Wed, 15 Nov 2023 22:12:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6eKBCHInW6V8+S81xjFJBpjSBCkcnysrqVQTTMEW+qg=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700086372; v=1; b=RNxcP84MNEjAohCNdRhki8uVpv/gE5ld7Ele+p4Ft77BMyWyCS/FLUIVzzla+aNcyjh3ZDzV EpwoQ91ps5pDHlbEH+X7xmvHEJQvwFqKO8DSKQ4txUS3Gd93JZkXjGUiJZ/5Lf5DkgZleAfsFVb LcvnpYHqdipTVBgbiPo1WoXo= X-Received: by 127.0.0.2 with SMTP id d71bYY7687511xq3GTX9gTrP; Wed, 15 Nov 2023 14:12:52 -0800 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.76]) by mx.groups.io with SMTP id smtpd.web10.26695.1700086371176478017 for ; Wed, 15 Nov 2023 14:12:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KL/Rr8LBHYghjkxOMYNAR4rY1iptUrGoVfRYQ/iDIR3U3VX8RR2MWjCThy24a1bgcO42utUVBXJzVtxxsAmKeZvy+myoDtMlAzTOp0BXgM3TipRAssyLOOxisZe9zUZiDtvwwjePLcTbvxZbFLBDnhrhHeqsS8AMxUTjxKdieehdwdni/UuHlZUyVRG49EMSCLf5P6YedeYQGxkfw9+JzWt1pkBcs2/TtAGWOJIq/HHtI2spAsOhJxGaQgCntBQPeKc0edMzDdb4R6rZ94HQIaWt3nhJmImlEfbi7ct8cNCy6qEWQG2XsEgiosCAexo7tmQ8hzsVAzGn4lHtyuX17A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XuZAXJaXsIgSMIb8VEuZuYB2ZukvV5U/QPvapd+urRw=; b=LoaLJUf+JIna37gvJ43NPScyDuGBkYd75hreJj1xIlnNWKQR3uyO+R1wMorwmMGhmVhUyl3M9yY44VP03Al6wMhE+2WkBdUq27AjfPjILZvpqfE/UeCA8X8PNJcXwn50Pi5p70Ge3ef7BG9CUOr45jfemnoCpKYLAy4RvVRjdp1nW5sygOdv8pRo2+sZI5799hGstkmSCv7n184pW8bHJYdKs2p7eOOavmG2POLz68XGBJACl+/YTDDeXo/GMtPK39mJpvO1aVE2ATHpQyzIUvpUxyEHV5SLfisW1pI8z9JbOXBKMb5qYA3iPhRdNYHwjSQAv+JaHkFHOia8Fxfq7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none X-Received: from CH0PR10MB5194.namprd10.prod.outlook.com (2603:10b6:610:d9::14) by SA1PR10MB5685.namprd10.prod.outlook.com (2603:10b6:806:23d::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.19; Wed, 15 Nov 2023 22:12:49 +0000 X-Received: from CH0PR10MB5194.namprd10.prod.outlook.com ([fe80::5f36:d8c0:cede:b253]) by CH0PR10MB5194.namprd10.prod.outlook.com ([fe80::5f36:d8c0:cede:b253%5]) with mapi id 15.20.7002.015; Wed, 15 Nov 2023 22:12:49 +0000 From: "Igor Kulchytskyy via groups.io" To: "devel@edk2.groups.io" CC: Abner Chang , Nickle Wang Subject: [edk2-devel] [PATCH v6 1/2] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx Thread-Topic: [PATCH v6 1/2] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx Thread-Index: AQHaGBDe0Fi4pVk6nEKA430MptSu2A== Date: Wed, 15 Nov 2023 22:12:48 +0000 Message-ID: <20231115221247.611-1-igork@ami.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CH0PR10MB5194:EE_|SA1PR10MB5685:EE_ x-ms-office365-filtering-correlation-id: 096d7627-38d1-46b7-91a8-08dbe62800d0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: +zl0raHnTeqXZN2V3JCYERvpc2xpjVSlwMolXZUkdIRTpqMWOwocrvYY3EJE7Qi1HoehleXG1d95HeaW76N1ky48MO9jmZSiu4Dgt07WBId2Ltr3MGLcFOm144/xAU7XilDyS5k2376huldwAuPS6ZvnvPEFsj2v7TwvkFZ4jvwJ9+GvUKVG22qWPFOuZIjQIOj91SzCxOnyZX0ZMe/+tGJhv40acKWCdjNDdYm2aePgHxXFAkeFk2/gqsV2rI7p/4BH6etliOaAj+BUBaZwjE5kFxi3EhPm3J8SWO4ZMYqT4AMdDGNKDtbROcJL6e/JgNtjbubzsJeGkSigtsLm/jp8/ZGdwqwB04czAzEbF/+L44XwvEHz6eT1tAqdYLVouBuXX3ubeEra9MWvnVN75qzLdOiWebZpzrdDGlgsgg6S2goSy9NdATjMJOuVcvxgWtuNsNvRNbPo2yft++K6gQ4mgOWR/8dcohp5/V5W7WXaiAmKc+/4LhHm6u+me4CujmKayuUT4clj8TT+xm2ubDmHDcCVvxiQGZ09UQTyqj84rg2qeb0fr5vwOroS2gdr6FezwaVBbv3MdmcFmDOY4Tb1iDL5ZUQ71Nb76auWU2PkM9fNFMY4SSoZ+jYwrlKB x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?dLG7sO3Ml8u2U6d6SDLDO/O4ZaTG09m1wWBnnUb/DTzZigOPDLLJBcOSKz?= =?iso-8859-1?Q?S+zfBw8+/xrFW5HKPEKjuQSCHYS2VJGJzuJC0wSBC1ATiMsVVIiR+n3fPs?= =?iso-8859-1?Q?dxtgmYwgsc86BHnO4B1wbjf8sf2q5oCq+buOUQXvuFItcOPW+6Mh4lQ1+m?= =?iso-8859-1?Q?DWdClsBCX4gKIvDzmT/d7JP2oXbPwdDzwbXSeD/3zVL8hJycmTtT2vemWJ?= =?iso-8859-1?Q?AXxO+r1imcTX5/D0r9NcL3wHmoXy218oDzxrQjKFP6Zn4/7eW5FqU6onjj?= =?iso-8859-1?Q?XFnEIib1AVFnJ/QNStVnhClHJNnWcc2FjQGZiyUXTieVEPiYbEog7X0OAF?= =?iso-8859-1?Q?n7MBDR6PQnUqYfpQ5d5xco3wVu4KSD0cMRMm744wjdO+G9Xw3kCsTCu9XQ?= =?iso-8859-1?Q?tPM5NqgTuMT7Y85U/H/nL6tJaG6gGJMtm28nkT7lQVSn0fYB2soLhwkQbC?= =?iso-8859-1?Q?O6LlS9cbSwk1Xbfrv97iJW9IFk+McyKfWDypJxdotWh44IaFkYlAo+frE+?= =?iso-8859-1?Q?u6gDHZkVqDUD+xMNnXELvbEYNUy+dMA24qZ5P2GFui07ajWLXPykzE1mOJ?= =?iso-8859-1?Q?q0wyeACZuE+lCdwJy8QaRCkltyY+PsiSTm4Y+gjdBToyeRMG7CNNAfDegU?= =?iso-8859-1?Q?ov1aLe9QmDMD+O31ZZs5WxdUb7cOSMLLw6kA6lRsKn6swBoSPX2tWk2/JS?= =?iso-8859-1?Q?JQtXVYnJbfEzLeGaOXRY+2F8D5I8YkY8xD83ktwsTu48dfz1BjyJAJ8yNI?= =?iso-8859-1?Q?j9f813YN3B7oLFEjc9U6Lm89G1KYJmG3ze/chTuaoo5uNrhjtqOzWQHOpX?= =?iso-8859-1?Q?dY/x0o7j7wmAyMkMY6lM8qjKPGTvQEcZAwIZvfP+oewMGJNHewL8EjZVoW?= =?iso-8859-1?Q?LkmD6FsAKo+xWBu8SGUOn4fTEt5CyKKNmGClW+bWuZ6llEAYKeB7AO/VW0?= =?iso-8859-1?Q?gSz6U6kwf7Xu+lxgu6tajeFyzWb53a4G6nZRikKrgQZgs7vminnwSyBhd2?= =?iso-8859-1?Q?gFsGQSa8sElGZjfbNwr5n6n6Gba6vcg5bVqzVa8dwFMymaMmMuoBr4qVXi?= =?iso-8859-1?Q?JZALZyijZaxPm5Omso5uoMyNrQQB7AO/5cr6oj15nD2FFFnDRLEygbipji?= =?iso-8859-1?Q?Yf2TGAWgAXnd+YlHZuVvIXmsIH40VNv8juONKU0i8Dj1M1OvYarLMDTrdI?= =?iso-8859-1?Q?b8/bZ8TIzy01cYa2x8JifrsvwCiF/9DQYtbWmlnorVfsB7ubWYcre1nVgy?= =?iso-8859-1?Q?y18auZ4/nrHjRvw0tAS3yTZbpRUTf2wfbNtirXPLay/46bwqksI/r1h3UX?= =?iso-8859-1?Q?pNYJvtWb7wbklRyHNSm/w51mgGNvoOJ/OlW7dNCQ2ui/fe8D72OZVNXn9H?= =?iso-8859-1?Q?AxVsx688WvdOmjFCotYz+pqZJ+vM8cSpiOdGulrpdF4L/3KR5bBNY2mlDH?= =?iso-8859-1?Q?mRUqhd+6Caw0C8DrL1gdn+JOWSfLPTHiV6+iiAo0Ion9jXoSzMar99vL1a?= =?iso-8859-1?Q?HoGGKkCUyICEMEGc/stlf5S7NMP8LJhsGWIElbmeuhwbD1tD3s+V6rFxXH?= =?iso-8859-1?Q?+rcfYjYnJpmvnICOnFQbg4ZmYkfIhI4jL3iaJfVwdzmvpEeV0Of0cpEcJ1?= =?iso-8859-1?Q?6EhRxKSisH0hXkWaIUnMmyk0ybCDjqO+ek?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB5194.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 096d7627-38d1-46b7-91a8-08dbe62800d0 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Nov 2023 22:12:48.9208 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tEHmCq++9aDuz9rUjVlM41TpQVOffN9Ou+N5sxDbn5X0fq/ZzDlhMkpiBPldD9Xo X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB5685 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,igork@ami.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: RTuCzMIemxLorMJb3lcD5p99x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=RNxcP84M; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Supported function of the driver changed to wait for all network interface to be installed. Reviewed-by: Abner Chang Reviewed-by: Nickle Wang Acked-by Mike Maslenkin Signed-off-by: Igor Kulchytskyy --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 31 ++++++++++--------= -- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPk= g/RedfishDiscoverDxe/RedfishDiscoverDxe.c index 23da3b968f..0f622e05a9 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -1547,25 +1547,26 @@ TestForRequiredProtocols ( ControllerHandle, EFI_OPEN_PROTOCOL_TEST_PROTOCOL ); + if (EFI_ERROR (Status)) { + return EFI_UNSUPPORTED; + } + + Status =3D gBS->OpenProtocol ( + ControllerHandle, + gRequiredProtocol[Index].DiscoveredProtocolGuid, + (VOID **)&Id, + This->DriverBindingHandle, + ControllerHandle, + EFI_OPEN_PROTOCOL_GET_PROTOCOL + ); if (!EFI_ERROR (Status)) { - Status =3D gBS->OpenProtocol ( - ControllerHandle, - gRequiredProtocol[Index].DiscoveredProtocolGuid, - (VOID **)&Id, - This->DriverBindingHandle, - ControllerHandle, - EFI_OPEN_PROTOCOL_GET_PROTOCOL - ); - if (EFI_ERROR (Status)) { - if (Index =3D=3D ListCount - 1) { - DEBUG ((DEBUG_INFO, "%a: all required protocols are found on thi= s controller handle: %p.\n", __func__, ControllerHandle)); - return EFI_SUCCESS; - } - } + // Already installed + return EFI_UNSUPPORTED; } } - return EFI_UNSUPPORTED; + DEBUG ((DEBUG_MANAGEABILITY, "%a: all required protocols are found on th= is controller handle: %p.\n", __func__, ControllerHandle)); + return EFI_SUCCESS; } /** -- 2.37.1.windows.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111293): https://edk2.groups.io/g/devel/message/111293 Mute This Topic: https://groups.io/mt/102615659/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-