From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5CEFD940486 for ; Thu, 16 Nov 2023 02:36:51 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=dddk9n/UglANO3GvXkPmdCYY0eZcsm7SuKca6xP9a2c=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700102209; v=1; b=fsTyHOgomxumwoZ7kSrK2UiOAHb3b6t5vxtunOi/g20bn0QkUFN3Jm9sEFCYExek0kYDvfpf LNThXZPNq8wtzCJ4Ifsd6/KvWwqyLL3q/n7esQqt87ktF4uuob8UYw3DP50lQE+/YEkBGa/7ShA cXVg6fKFeyXcbv9mHojT3s+E= X-Received: by 127.0.0.2 with SMTP id M9ygYY7687511x4jJyAt7KiJ; Wed, 15 Nov 2023 18:36:49 -0800 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.50]) by mx.groups.io with SMTP id smtpd.web10.31960.1700102208465099598 for ; Wed, 15 Nov 2023 18:36:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UM3sP0aJaebohsEvtQIGvJS52mwCWoh+ZUW6PlABRY+2+oqGBjmbo3eJoxifhgSNZg2HDMWKDiznZrDl8wo99f6KAGdV9vb8w8ytEuXu1EAFkyV02S9PtMhTjcRmA4hGADiTQBwoY3Ylap8Robx5uWWuNjwXLvp4mgxEQ0spu11CwjrUuEsCcWxZWqwBmieCEZx1I/31CQAj1OYJy92bBidNTNbuG6qc+Qit5t1NbGxF4ztekwUb2schDpYO0DeOIqJIxc6xazCXvbAVWtzKvuYjuOuxfynOGIuIsNMK06Sb2BNoI3A8L2X/f1lXYlZGUL1mfDQqatwFDGoCtQf0wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XuZAXJaXsIgSMIb8VEuZuYB2ZukvV5U/QPvapd+urRw=; b=AuHPWUQ8/L48HKitQDOMqcFlO9UJXrDxVDiSjv3GjNiceVFh8Dst0hDffWAH34BfZPAS88+pBYVhlvSm1BO5xY6Z7ENLen/0r49Q7F7M8MzE1nV9jCstRfaGS1Fnepv8l+0rTSUknu5o8WBxFA9D64vlJIO/CMaw6eD8FLfoKZnZxzUSyh/aqAlujsPctNwMKznYO0hKY+XMkMVCUUeZGKFnOWTOS2B6OzuXPSbRO/FpNiU6T3kDsMoypa+Lg4WG+SmHK2HBQL1DJdP7fyINF0vBhWw26fGinPAUlD2ZuPxlvSr9o9NxEdMEgFMoDXz8eYl0O6JZ5ukm48CIypq/ZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com (2603:10b6:208:328::16) by SJ0PR10MB5672.namprd10.prod.outlook.com (2603:10b6:a03:3ef::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.18; Thu, 16 Nov 2023 02:36:46 +0000 X-Received: from BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::9dc0:d4e1:1d40:3e33]) by BLAPR10MB5185.namprd10.prod.outlook.com ([fe80::9dc0:d4e1:1d40:3e33%4]) with mapi id 15.20.7002.021; Thu, 16 Nov 2023 02:36:46 +0000 From: "Igor Kulchytskyy via groups.io" To: "devel@edk2.groups.io" CC: Abner Chang , Nickle Wang Subject: [edk2-devel] [PATCH v6 1/2] [edk2-stable202311] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx Thread-Topic: [PATCH v6 1/2] [edk2-stable202311] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx Thread-Index: AQHaGDW9o47Tb73ZPU+Fy/9J+HMlrw== Date: Thu, 16 Nov 2023 02:36:46 +0000 Message-ID: <20231116023644.101-1-igork@ami.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BLAPR10MB5185:EE_|SJ0PR10MB5672:EE_ x-ms-office365-filtering-correlation-id: 74ae0e63-a3de-45c5-7d21-08dbe64ce074 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: sGzBrcJSmrS55eMJH0fOm4bqI+kWEwUvqFBUM5AiCxPl2evB0KB7kjlrsnvspR9l+Wf2OwCO5t6dn75y5fAlfI5LUPM3hGMJRiLWczDo+2vnJhRM+4NDp8S4eBAes2hGaVbIDcEVntQT8/j7pIyNmj3o5dM/S/V+2Xu890cdXWJzkbEiYRkbwdBipMvOMu4rQA1sD2Ow8urtX//MO7ig39948QyU/9/H6W6SA55xntFmQUtKVnSIos/vxtCj9wlLHJTFhxwfzavNwgm89kJYK29CpR0qSxlFK4nSzlxLjC7PdWjHLGYD/eWirbBGlZNOXsRBvKodaBOJgELVkJU7U8/fyDppqVAZIaTCEdBfroWDsDYu9u/3NkDHkaIcweY9NDFa1a8s9RxlqPwENOUBq1eAJXyDyMzCdcx/nhoO5hHj6NsXVYLceosD8UrJqSodWGUmLFeU2MZvxyxyiytjCxAl6hqvvFs0Fo9tZY1LZmny41tkBl/Tq2tQiEsufn+Wk6QENQzQRtBTTD5Fu1wT9zOf6S5evt6y6lA2SK/0nqpgqUseZv0bWJVnZPGNoYsDWeqeISUQT/VkSbnM86HnptET6cmOuG9u90Rhk3DN89TBkPGlNipRwnM2K+P9gGSg x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?SerPRQUZ4yPa+g6hXetOTfrmmKI3KWtqdRTrZ80fR0WywVpNomTT8uWpOz?= =?iso-8859-1?Q?zk6y3MexXARe819ZR/yVRp6Qc7gG1oRAkQfm+yqH8iTBOOKlgMhjUn/bau?= =?iso-8859-1?Q?irRUgNqhfLU9c2g9nqJBtgCytwRQGDksS5X8jPd9Hhfgaey7CpLbuAazmG?= =?iso-8859-1?Q?JljiYu2k9qTE1pBBARI5liBhvdgFmW6Q+/5GIxVyN9EYTmEvqfIbBaXVVq?= =?iso-8859-1?Q?WHLAvM0V6IKDyqtMKnGYQxOAr+VoUTFpNlX4FEfke2UPuIbxlA/3nnW9An?= =?iso-8859-1?Q?llG0Upda3dZpKx/sK6gakIhHiJ/GuUUvh43SvGeWwtdrCJEPM3vSLmYveq?= =?iso-8859-1?Q?NRGdfnk6Hf5TaMI8wLUNfiNKxJbX6kEpnxgFY/eNYHb60jVy2KlSozqPKc?= =?iso-8859-1?Q?opn5ABbZFlJRW6fPZqiW490Vx007ZjBP4TiP7oyd1og8r52wpTT+1fIMeQ?= =?iso-8859-1?Q?DKtHqdIPKBetaETk7kHOTQKJ74eqlJpCeOj5AyEot1YOl1PcoZ4cB9TWql?= =?iso-8859-1?Q?KZa8+CUiMX2EhIsazxrdVIIXbrb7/zJhqIffcl51o9hulDGvo3T7WfehTg?= =?iso-8859-1?Q?ngpzqZmKS3bHUXqh7aHAy951PocN6FtWlFpqz2T4FdDGcqKWqvlKMzQ/kW?= =?iso-8859-1?Q?RClGyXO8XMLQEC+TDXGWQ8o79oW74buT69HSIkOizyDDCKawBUizEQhGMi?= =?iso-8859-1?Q?ST0W43SGEAJ+q77+wrbziZYe4vreBimOVQ+55FCchfcfgC1JDEdW8jPY/I?= =?iso-8859-1?Q?mhMW7Jbij/uAoXFbXG7G+slFx1umZBpDD3PD/fJ8e5RruiIruOyDMaIkCb?= =?iso-8859-1?Q?P42aFhAmNpiRGLySiKrSpFNtaXaRyQgeFmc8+sW5WsXABA2otQJbxPolqx?= =?iso-8859-1?Q?+JWLl1UxTExJ0EyiWJdvzq688JIyjXCMsfLRZch7DObkS/HR5OxKpWgxky?= =?iso-8859-1?Q?bHtax3RDgwpqYc9trs7jINCBOrCNQMyP0dLw6WUn5bTiiKVhj7OhRfCQy9?= =?iso-8859-1?Q?TpdyGouuLXizhVjcKwxObc+oClglUejcN5ObCm6vuMcBylK5bDFqxBWzjI?= =?iso-8859-1?Q?66XwnGQ3+PEIidT0c6Xc34IbgtSyl46PCz/xoHTG4ejfUBMN7qObX9L7gF?= =?iso-8859-1?Q?tjmu5DXeb5uZg2CdiSXgRxAjm0h3Psmcsti8aWEu1OMlaXMSkXwDC+rLh2?= =?iso-8859-1?Q?heUFElxSa1GqPGDpqucInu0/7PzyW6xLXzIvDbFJ7f0+w1YVTiAKlMyJI1?= =?iso-8859-1?Q?yf6NlvwbwEJMRxyyLUgDifhiEstXzI+xEWBZ0YOETkUIu8igCCz4H6VXf5?= =?iso-8859-1?Q?I+tlah17oYkRxKjZG2Z2S19Hxg2SOwAnogt/x48LSySugxtyBdtf1r2wRL?= =?iso-8859-1?Q?NxuwpyHw79aSwna5aKXbm13TjYhfcJkSq/3j/MrDqFXOF24CUax2mTUpCD?= =?iso-8859-1?Q?59YenkOCVNcy9sfzL0Je8AOZRoUzgnukHoEsOSJksdypIvgNksxAZf1bHd?= =?iso-8859-1?Q?og949sY+f6rXDu6b933a+u8g6ppOXCqxmMGqIFxeRWB4UWqMXraxgiqxC1?= =?iso-8859-1?Q?JChvDw3LmKxAooNh6pdlBDeBPxdxs5KNqQfgvnOxd7dEabRGVXJgQHGQD+?= =?iso-8859-1?Q?A7N/Q7tfk/u5YVbq+Yf8LbZ98d9GCYlzVA?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5185.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74ae0e63-a3de-45c5-7d21-08dbe64ce074 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2023 02:36:46.0176 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KXIiZjQ/6PCKhaNvvlWFXrIVNZ6alwh7t/EfWRZh/zfMQsseR0HG4NK+yJtGMrBf X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5672 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,igork@ami.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: WMIeXQTNgV1VTS3tAQTibE1kx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=fsTyHOgo; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Supported function of the driver changed to wait for all network interface to be installed. Reviewed-by: Abner Chang Reviewed-by: Nickle Wang Acked-by Mike Maslenkin Signed-off-by: Igor Kulchytskyy --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 31 ++++++++++--------= -- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPk= g/RedfishDiscoverDxe/RedfishDiscoverDxe.c index 23da3b968f..0f622e05a9 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -1547,25 +1547,26 @@ TestForRequiredProtocols ( ControllerHandle, EFI_OPEN_PROTOCOL_TEST_PROTOCOL ); + if (EFI_ERROR (Status)) { + return EFI_UNSUPPORTED; + } + + Status =3D gBS->OpenProtocol ( + ControllerHandle, + gRequiredProtocol[Index].DiscoveredProtocolGuid, + (VOID **)&Id, + This->DriverBindingHandle, + ControllerHandle, + EFI_OPEN_PROTOCOL_GET_PROTOCOL + ); if (!EFI_ERROR (Status)) { - Status =3D gBS->OpenProtocol ( - ControllerHandle, - gRequiredProtocol[Index].DiscoveredProtocolGuid, - (VOID **)&Id, - This->DriverBindingHandle, - ControllerHandle, - EFI_OPEN_PROTOCOL_GET_PROTOCOL - ); - if (EFI_ERROR (Status)) { - if (Index =3D=3D ListCount - 1) { - DEBUG ((DEBUG_INFO, "%a: all required protocols are found on thi= s controller handle: %p.\n", __func__, ControllerHandle)); - return EFI_SUCCESS; - } - } + // Already installed + return EFI_UNSUPPORTED; } } - return EFI_UNSUPPORTED; + DEBUG ((DEBUG_MANAGEABILITY, "%a: all required protocols are found on th= is controller handle: %p.\n", __func__, ControllerHandle)); + return EFI_SUCCESS; } /** -- 2.37.1.windows.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission= . -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111299): https://edk2.groups.io/g/devel/message/111299 Mute This Topic: https://groups.io/mt/102620280/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-