From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9DCB9941099 for ; Mon, 20 Nov 2023 04:21:23 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=K7afrZxtiidlgnrvl/NXOSVAp484x/9gtfm3JNQF84s=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1700454082; v=1; b=gKcJAEGaZR3FspEIKu2RDQdeNUQcFVcaO6eD/W9mv4y+z+tahqWMpkrEH8bxgGuunQAgTZjP BH1shPdXYKie1KYo/S7DdLO0hCU54L4gvo4hfi/423PNwRmFu/ZjClMnYkBV428iceVdMhdFlJB 26YId4T/X6R5YusKcsb4dimo= X-Received: by 127.0.0.2 with SMTP id AopsYY7687511xgkPVby2Z4G; Sun, 19 Nov 2023 20:21:22 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.43973.1700454081395369065 for ; Sun, 19 Nov 2023 20:21:21 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10899"; a="455871836" X-IronPort-AV: E=Sophos;i="6.04,212,1695711600"; d="scan'208";a="455871836" X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2023 20:19:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10899"; a="939678754" X-IronPort-AV: E=Sophos;i="6.04,212,1695711600"; d="scan'208";a="939678754" X-Received: from shwdeopenlab813.ccr.corp.intel.com ([10.239.55.230]) by orsmga005.jf.intel.com with ESMTP; 19 Nov 2023 20:19:03 -0800 From: "Yuanhao Xie" To: devel@edk2.groups.io Cc: xieyuanh , Eric Dong , Ray Ni , Rahul Kumar , Gerd Hoffmann Subject: [edk2-devel] [Patch V5 2/2] UefiCpuPkg/MpInitLib: Update the comments of _CPU_MP_DATA. Date: Mon, 20 Nov 2023 12:18:46 +0800 Message-Id: <20231120041846.2221-3-yuanhao.xie@intel.com> In-Reply-To: <20231120041846.2221-1-yuanhao.xie@intel.com> References: <20231120041846.2221-1-yuanhao.xie@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yuanhao.xie@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: JEiV20HO4mUhxVFUDu5OQnEIx7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=gKcJAEGa; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io No functional changes in this patch. Updated the comments of _CPU_MP_DATA to delcared that duplications in CpuMpData are present to avoid to be direct accessed and comprehended in assembly code. CpuMpData: Intended for use in C code while ExchangeInfo are used in assembly code in this module. Signed-off-by: Yuanhao Xie Cc: Laszlo Ersek lersek@redhat.com Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPkg/Library/MpInitLib/MpLib.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpInitLib/MpLib.h index 0afac7c78c..242935816c 100644 --- a/UefiCpuPkg/Library/MpInitLib/MpLib.h +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h @@ -239,7 +239,11 @@ typedef struct { #pragma pack() // -// CPU MP Data save in memory +// CPU MP Data save in memory, and intended for use in C code. +// There are some duplicated fields, such as XD status, between +// CpuMpData and ExchangeInfo. These duplications in CpuMpData +// are present to avoid to be direct accessed and comprehended +// in assembly code. // struct _CPU_MP_DATA { UINT64 CpuInfoInHob; -- 2.39.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111446): https://edk2.groups.io/g/devel/message/111446 Mute This Topic: https://groups.io/mt/102702055/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-