From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 82FC39419F7 for ; Tue, 21 Nov 2023 16:43:03 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=kfyqACc4k5qJaJ24fN6ULOwXwMEX1YSFUblaRKsGZXI=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1700584982; v=1; b=pcaHfYEr6L6CPh3tzzmKTPG+Tqf8fIDwft7wtXvKFHqT45MfBMIn2F/Loc43NYPW6g3HT1/s +v9tMz/UFv+fWROuJ8OhLTy2FODWoY82MzhJHzq4FGN20wslKUa/6942LfadXTWUY7l6EsGstdy f5ABougtE7yrlx+Lpxyhzjag= X-Received: by 127.0.0.2 with SMTP id TedmYY7687511xrrA3xBJEqX; Tue, 21 Nov 2023 08:43:02 -0800 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web10.46579.1700584981574291950 for ; Tue, 21 Nov 2023 08:43:01 -0800 X-Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3ALGLj4N003808; Tue, 21 Nov 2023 16:42:51 GMT X-Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3ugxn8ga10-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 16:42:50 +0000 X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3ALGgcgE007682 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 16:42:38 GMT X-Received: from qc-i7.qualcomm.com (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Tue, 21 Nov 2023 08:42:36 -0800 From: "Leif Lindholm" To: CC: Pierre Gondois , Jiewen Yao , Ard Biesheuvel , Liming Gao , Michael D Kinney , Sami Mujawar , Zhiguang Liu Subject: [edk2-devel] [RFC PATCH 1/1] ArmPkg,MdePkg: move ArmLib.h to MdePkg Date: Tue, 21 Nov 2023 16:42:28 +0000 Message-ID: <20231121164228.766299-1-quic_llindhol@quicinc.com> MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-ORIG-GUID: pQRSXhHDtAkEtZys6pn43NQnPZWy0DTu X-Proofpoint-GUID: pQRSXhHDtAkEtZys6pn43NQnPZWy0DTu Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: gJCFhURTpnzVC6YT5etNbLytx7686176AA= Content-Transfer-Encoding: 8bit Content-Type: text/plain X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=pcaHfYEr; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Related to https://bugzilla.tianocore.org/show_bug.cgi?id=4121, but not resolving it. (Nearly?) all of ArmPkg describes industry standard behaviour, and hence according to general rules, ought to live in MdePkg. Addressing this will however be a substantial task. Take a first step by moving the ArmLib interface definition to MdePkg, as discussed in https://edk2.groups.io/g/devel/topic/patch_v5_2_6/102725178 Cc: Pierre Gondois Cc: Jiewen Yao Cc: Ard Biesheuvel Cc: Liming Gao Cc: Michael D Kinney Cc: Sami Mujawar Cc: Zhiguang Liu Signed-off-by: Leif Lindholm --- This should have no functional differences (and the set of platforms I have test built didn't find any problems). This may result in some modules depending on ArmPkg only for ArmLib now being able to drop ArmPkg dependency. ArmPkg/ArmPkg.dec | 4 ---- MdePkg/MdePkg.dec | 5 +++++ {ArmPkg => MdePkg}/Include/Library/ArmLib.h | 0 Maintainers.txt | 6 ++++++ 4 files changed, 11 insertions(+), 4 deletions(-) diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec index 7fe2b9bca43b..4ce59f3e1fbd 100644 --- a/ArmPkg/ArmPkg.dec +++ b/ArmPkg/ArmPkg.dec @@ -50,10 +50,6 @@ [LibraryClasses.common] # ArmHvcLib|Include/Library/ArmHvcLib.h - ## @libraryclass Provides an interface to Arm registers. - # - ArmLib|Include/Library/ArmLib.h - ## @libraryclass Provides a Mmu interface. # ArmMmuLib|Include/Library/ArmMmuLib.h diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index ac54338089e8..78e18ee444cd 100644 --- a/MdePkg/MdePkg.dec +++ b/MdePkg/MdePkg.dec @@ -339,6 +339,11 @@ [LibraryClasses.RISCV64] ## @libraryclass Provides function to make ecalls to SBI BaseRiscVSbiLib|Include/Library/BaseRiscVSbiLib.h +[LibraryClasses.ARM, LibraryClasses.AARCH64] + ## @libraryclass Provides an interface to Arm registers. + # + ArmLib|Include/Library/ArmLib.h + [Guids] # # GUID defined in UEFI2.1/UEFI2.0/EFI1.1 diff --git a/ArmPkg/Include/Library/ArmLib.h b/MdePkg/Include/Library/ArmLib.h similarity index 100% rename from ArmPkg/Include/Library/ArmLib.h rename to MdePkg/Include/Library/ArmLib.h diff --git a/Maintainers.txt b/Maintainers.txt index 7c0b4cb58cfd..0315fa23dfce 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -450,6 +450,12 @@ M: Abner Chang [changab] R: Abdul Lateef Attar [abdattar] R: Nickle Wang [nicklela] +MdePkg: ARM/AARCH64 standard interfaces +F: MdePkg/Include/Library/ArmLib.h +M: Leif Lindholm [leiflindholm] +M: Ard Biesheuvel [ardbiesheuvel] +R: Sami Mujawar [samimujawar] + NetworkPkg F: NetworkPkg/ W: https://github.com/tianocore/tianocore.github.io/wiki/NetworkPkg -- 2.30.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111566): https://edk2.groups.io/g/devel/message/111566 Mute This Topic: https://groups.io/mt/102731845/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-