public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Mike Maslenkin" <mike.maslenkin@gmail.com>
To: devel@edk2.groups.io
Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com
Subject: [edk2-devel] [PATCH 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC
Date: Thu, 23 Nov 2023 02:50:08 +0300	[thread overview]
Message-ID: <20231122235008.31001-4-mike.maslenkin@gmail.com> (raw)
In-Reply-To: <20231122235008.31001-1-mike.maslenkin@gmail.com>

According to RedfishPkg/Readme.md document:
"The last byte of host-end USB NIC MAC address is the last byte of
BMC-end USB NIC MAC address minus 1."

It is necessary to subtract 1 from IpmiLanChannelMacAddress.

Cc: Abner Chang <abner.chang@amd.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
---
 .../PlatformHostInterfaceBmcUsbNicLib.c                       | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfaceBmcUsbNicLib.c b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfaceBmcUsbNicLib.c
index 95900579118b..20ec89d4fcb0 100644
--- a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfaceBmcUsbNicLib.c
+++ b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfaceBmcUsbNicLib.c
@@ -738,8 +738,8 @@ HostInterfaceIpmiCheckMacAddress (
              (VOID *)&IpmiLanChannelMacAddress.Addr,
              IpmiLanMacAddressSize - 1
              ) != 0) ||
-          (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1] !=
-           *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1) - 1)
+          (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1] - 1 !=
+           *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1))
           )
       {
         DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, "    MAC address is not matched.\n"));
-- 
2.32.0 (Apple Git-132)


      parent reply	other threads:[~2023-11-22 23:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-22 23:50 [edk2-devel] [PATCH 0/3] RedfishPkg: refine HiiUtilityLib and fix USB NIC discovering Mike Maslenkin
2023-11-22 23:50 ` [edk2-devel] [PATCH 1/3] RedfishPkg: fix memory leak in HiiUtilityLib Mike Maslenkin
2023-11-22 23:50 ` [edk2-devel] [PATCH 2/3] RedfishPkg: add explicit variable initialization Mike Maslenkin
2023-11-22 23:50 ` Mike Maslenkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231122235008.31001-4-mike.maslenkin@gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox