[edk2-devel] [PATCH v2 0/3] RedfishPkg: refine HiiUtilityLib and fix USB NIC discovering

[edk2-devel] [PATCH v2 0/3] RedfishPkg: refine HiiUtilityLib and fix USB NIC discovering

[Mike Maslenkin]

v2:
  removed --transfer-encoding=base64 from `git send-email` command line
  as it has broken patch format as I can see from the mailing list.

v1:
  This patch series involves the following changes:
  1. fix memory leak and add explicit variable initialization in HiiUtilityLib
  2. fix MAC address comparison during USB NIC discovering.

Cc: Abner Chang <abner.chang@amd.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111627): https://edk2.groups.io/g/devel/message/111627
Mute This Topic: https://groups.io/mt/102759076/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v2 1/3] RedfishPkg: fix memory leak in HiiUtilityLib

[Mike Maslenkin]

Cc: Abner Chang <abner.chang@amd.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
---
 RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c b/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c
index 168b4459844f..fd322c2086d8 100644
--- a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c
+++ b/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c
@@ -388,11 +388,13 @@ SetQuestionValue (
       Question->Value.BufferLen = Question->StorageWidth;
       Question->Value.Buffer    = AllocateZeroPool (Question->StorageWidth);
       if (Question->Value.Buffer == NULL) {
+        FreePool (TemString);
         return EFI_OUT_OF_RESOURCES;
       }
 
       CopyMem (Question->Value.Buffer, TemString, StrSize (TemString));
       Src = Question->Value.Buffer;
+      FreePool (TemString);
     } else {
       CopyMem (&Question->Value.Value, &QuestionValue->Value, sizeof (EFI_IFR_TYPE_VALUE));
       Src = (UINT8 *)&Question->Value.Value;
-- 
2.32.0 (Apple Git-132)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111628): https://edk2.groups.io/g/devel/message/111628
Mute This Topic: https://groups.io/mt/102759077/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 1/3] RedfishPkg: fix memory leak in HiiUtilityLib

[Nickle Wang via groups.io]

Thanks for fixing memory leak issue.

Reviewed-by: Nickle Wang <nicklew@nvidia.com>

Regards,
Nickle

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Thursday, November 23, 2023 8:01 AM
> To: devel@edk2.groups.io
> Cc: abner.chang@amd.com; Nickle Wang <nicklew@nvidia.com>;
> igork@ami.com
> Subject: [PATCH v2 1/3] RedfishPkg: fix memory leak in HiiUtilityLib
> 
> External email: Use caution opening links or attachments
> 
> 
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> ---
>  RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c
> b/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c
> index 168b4459844f..fd322c2086d8 100644
> --- a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c
> +++ b/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c
> @@ -388,11 +388,13 @@ SetQuestionValue (
>        Question->Value.BufferLen = Question->StorageWidth;
> 
>        Question->Value.Buffer    = AllocateZeroPool (Question->StorageWidth);
> 
>        if (Question->Value.Buffer == NULL) {
> 
> +        FreePool (TemString);
> 
>          return EFI_OUT_OF_RESOURCES;
> 
>        }
> 
> 
> 
>        CopyMem (Question->Value.Buffer, TemString, StrSize (TemString));
> 
>        Src = Question->Value.Buffer;
> 
> +      FreePool (TemString);
> 
>      } else {
> 
>        CopyMem (&Question->Value.Value, &QuestionValue->Value, sizeof
> (EFI_IFR_TYPE_VALUE));
> 
>        Src = (UINT8 *)&Question->Value.Value;
> 
> --
> 2.32.0 (Apple Git-132)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111631): https://edk2.groups.io/g/devel/message/111631
Mute This Topic: https://groups.io/mt/102759077/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v2 2/3] RedfishPkg: add explicit variable initialization

[Mike Maslenkin]

Ancient GCC 4.8.5 warned about variable may be unitialied.
And it doesn't look like false alarm.

The warning is:
edk2/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c: In function 'GetQuestionDefault':
edk2/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c:5519:6: error: 'ConfigAccess' may be used uninitialized in this function [-Werror=maybe-uninitialized]
   if (ConfigAccess != NULL) {

Cc: Abner Chang <abner.chang@amd.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
---
 RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c b/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c
index 80b93beae999..b61b7f5fcdcc 100644
--- a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c
+++ b/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c
@@ -5451,6 +5451,7 @@ GetQuestionDefault (
 
   Status            = EFI_NOT_FOUND;
   StrValue          = NULL;
+  ConfigAccess      = NULL;
   OriginalDefaultId = DefaultId;
   DefaultLink       = GetFirstNode (&FormSet->DefaultStoreListHead);
 
-- 
2.32.0 (Apple Git-132)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111629): https://edk2.groups.io/g/devel/message/111629
Mute This Topic: https://groups.io/mt/102759079/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 2/3] RedfishPkg: add explicit variable initialization

[Nickle Wang via groups.io]

Yes, it is an issue. Thanks!

Reviewed-by: Nickle Wang <nicklew@nvidia.com>

Regards,
Nickle

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Thursday, November 23, 2023 8:01 AM
> To: devel@edk2.groups.io
> Cc: abner.chang@amd.com; Nickle Wang <nicklew@nvidia.com>;
> igork@ami.com
> Subject: [PATCH v2 2/3] RedfishPkg: add explicit variable initialization
> 
> External email: Use caution opening links or attachments
> 
> 
> Ancient GCC 4.8.5 warned about variable may be unitialied.
> And it doesn't look like false alarm.
> 
> The warning is:
> edk2/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c: In function
> 'GetQuestionDefault':
> edk2/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c:5519:6: error:
> 'ConfigAccess' may be used uninitialized in this function [-Werror=maybe-
> uninitialized]
>    if (ConfigAccess != NULL) {
> 
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> ---
>  RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c
> b/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c
> index 80b93beae999..b61b7f5fcdcc 100644
> --- a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c
> +++ b/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c
> @@ -5451,6 +5451,7 @@ GetQuestionDefault (
> 
> 
>    Status            = EFI_NOT_FOUND;
> 
>    StrValue          = NULL;
> 
> +  ConfigAccess      = NULL;
> 
>    OriginalDefaultId = DefaultId;
> 
>    DefaultLink       = GetFirstNode (&FormSet->DefaultStoreListHead);
> 
> 
> 
> --
> 2.32.0 (Apple Git-132)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111632): https://edk2.groups.io/g/devel/message/111632
Mute This Topic: https://groups.io/mt/102759079/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC

[Mike Maslenkin]

According to RedfishPkg/Readme.md document:
"The last byte of host-end USB NIC MAC address is the last byte of
BMC-end USB NIC MAC address minus 1."

It is necessary to subtract 1 from IpmiLanChannelMacAddress.

Cc: Abner Chang <abner.chang@amd.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
---
 .../PlatformHostInterfaceBmcUsbNicLib.c                       | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfaceBmcUsbNicLib.c b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfaceBmcUsbNicLib.c
index 95900579118b..20ec89d4fcb0 100644
--- a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfaceBmcUsbNicLib.c
+++ b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfaceBmcUsbNicLib.c
@@ -738,8 +738,8 @@ HostInterfaceIpmiCheckMacAddress (
              (VOID *)&IpmiLanChannelMacAddress.Addr,
              IpmiLanMacAddressSize - 1
              ) != 0) ||
-          (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1] !=
-           *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1) - 1)
+          (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1] - 1 !=
+           *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1))
           )
       {
         DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, "    MAC address is not matched.\n"));
-- 
2.32.0 (Apple Git-132)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111630): https://edk2.groups.io/g/devel/message/111630
Mute This Topic: https://groups.io/mt/102759080/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC

[Nickle Wang via groups.io]

Reviewed-by: Nickle Wang <nicklew@nvidia.com>

Regards,
Nickle

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Thursday, November 23, 2023 8:01 AM
> To: devel@edk2.groups.io
> Cc: abner.chang@amd.com; Nickle Wang <nicklew@nvidia.com>;
> igork@ami.com
> Subject: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC
> 
> External email: Use caution opening links or attachments
> 
> 
> According to RedfishPkg/Readme.md document:
> "The last byte of host-end USB NIC MAC address is the last byte of BMC-end USB
> NIC MAC address minus 1."
> 
> It is necessary to subtract 1 from IpmiLanChannelMacAddress.
> 
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> ---
>  .../PlatformHostInterfaceBmcUsbNicLib.c                       | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git
> a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfac
> eBmcUsbNicLib.c
> b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfac
> eBmcUsbNicLib.c
> index 95900579118b..20ec89d4fcb0 100644
> ---
> a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfac
> eBmcUsbNicLib.c
> +++ b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostI
> +++ nterfaceBmcUsbNicLib.c
> @@ -738,8 +738,8 @@ HostInterfaceIpmiCheckMacAddress (
>               (VOID *)&IpmiLanChannelMacAddress.Addr,
> 
>               IpmiLanMacAddressSize - 1
> 
>               ) != 0) ||
> 
> -          (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1] !=
> 
> -           *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1) - 1)
> 
> +          (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1] - 1
> + !=
> 
> +           *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1))
> 
>            )
> 
>        {
> 
>          DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, "    MAC address is not
> matched.\n"));
> 
> --
> 2.32.0 (Apple Git-132)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111633): https://edk2.groups.io/g/devel/message/111633
Mute This Topic: https://groups.io/mt/102759080/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC

[Chang, Abner via groups.io]

[AMD Official Use Only - General]

HI Nickle and Mike,
I also have some fixes and revised BMC USB NIC library for searching BMC exposed NIC.
Please don't not merge this patch set just for now. I will review this and compare with the changes I have.

Thanks
Abner

> -----Original Message-----
> From: Nickle Wang <nicklew@nvidia.com>
> Sent: Thursday, November 23, 2023 8:24 AM
> To: Mike Maslenkin <mike.maslenkin@gmail.com>; devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; igork@ami.com
> Subject: RE: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed
> USB NIC
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Reviewed-by: Nickle Wang <nicklew@nvidia.com>
>
> Regards,
> Nickle
>
> > -----Original Message-----
> > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > Sent: Thursday, November 23, 2023 8:01 AM
> > To: devel@edk2.groups.io
> > Cc: abner.chang@amd.com; Nickle Wang <nicklew@nvidia.com>;
> > igork@ami.com
> > Subject: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB
> NIC
> >
> > External email: Use caution opening links or attachments
> >
> >
> > According to RedfishPkg/Readme.md document:
> > "The last byte of host-end USB NIC MAC address is the last byte of BMC-end
> USB
> > NIC MAC address minus 1."
> >
> > It is necessary to subtract 1 from IpmiLanChannelMacAddress.
> >
> > Cc: Abner Chang <abner.chang@amd.com>
> > Cc: Nickle Wang <nicklew@nvidia.com>
> > Cc: Igor Kulchytskyy <igork@ami.com>
> > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> > ---
> >  .../PlatformHostInterfaceBmcUsbNicLib.c                       | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git
> >
> a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> fac
> > eBmcUsbNicLib.c
> >
> b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> fac
> > eBmcUsbNicLib.c
> > index 95900579118b..20ec89d4fcb0 100644
> > ---
> >
> a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> fac
> > eBmcUsbNicLib.c
> > +++
> b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostI
> > +++ nterfaceBmcUsbNicLib.c
> > @@ -738,8 +738,8 @@ HostInterfaceIpmiCheckMacAddress (
> >               (VOID *)&IpmiLanChannelMacAddress.Addr,
> >
> >               IpmiLanMacAddressSize - 1
> >
> >               ) != 0) ||
> >
> > -          (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1] !=
> >
> > -           *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1) - 1)
> >
> > +          (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1] - 1
> > + !=
> >
> > +           *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1))
> >
> >            )
> >
> >        {
> >
> >          DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, "    MAC address is not
> > matched.\n"));
> >
> > --
> > 2.32.0 (Apple Git-132)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111636): https://edk2.groups.io/g/devel/message/111636
Mute This Topic: https://groups.io/mt/102759080/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC

[Chang, Abner via groups.io]

[AMD Official Use Only - General]

Good to go. We can merge this after code freeze.

Abner

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang,
> Abner via groups.io
> Sent: Thursday, November 23, 2023 9:20 AM
> To: Nickle Wang <nicklew@nvidia.com>; Mike Maslenkin
> <mike.maslenkin@gmail.com>; devel@edk2.groups.io
> Cc: igork@ami.com
> Subject: Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the
> BMC-exposed USB NIC
>
> [AMD Official Use Only - General]
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> [AMD Official Use Only - General]
>
> HI Nickle and Mike,
> I also have some fixes and revised BMC USB NIC library for searching BMC
> exposed NIC.
> Please don't not merge this patch set just for now. I will review this and
> compare with the changes I have.
>
> Thanks
> Abner
>
> > -----Original Message-----
> > From: Nickle Wang <nicklew@nvidia.com>
> > Sent: Thursday, November 23, 2023 8:24 AM
> > To: Mike Maslenkin <mike.maslenkin@gmail.com>; devel@edk2.groups.io
> > Cc: Chang, Abner <Abner.Chang@amd.com>; igork@ami.com
> > Subject: RE: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed
> > USB NIC
> >
> > Caution: This message originated from an External Source. Use proper
> caution
> > when opening attachments, clicking links, or responding.
> >
> >
> > Reviewed-by: Nickle Wang <nicklew@nvidia.com>
> >
> > Regards,
> > Nickle
> >
> > > -----Original Message-----
> > > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > Sent: Thursday, November 23, 2023 8:01 AM
> > > To: devel@edk2.groups.io
> > > Cc: abner.chang@amd.com; Nickle Wang <nicklew@nvidia.com>;
> > > igork@ami.com
> > > Subject: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed
> USB
> > NIC
> > >
> > > External email: Use caution opening links or attachments
> > >
> > >
> > > According to RedfishPkg/Readme.md document:
> > > "The last byte of host-end USB NIC MAC address is the last byte of BMC-
> end
> > USB
> > > NIC MAC address minus 1."
> > >
> > > It is necessary to subtract 1 from IpmiLanChannelMacAddress.
> > >
> > > Cc: Abner Chang <abner.chang@amd.com>
> > > Cc: Nickle Wang <nicklew@nvidia.com>
> > > Cc: Igor Kulchytskyy <igork@ami.com>
> > > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > ---
> > >  .../PlatformHostInterfaceBmcUsbNicLib.c                       | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git
> > >
> >
> a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> > fac
> > > eBmcUsbNicLib.c
> > >
> >
> b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> > fac
> > > eBmcUsbNicLib.c
> > > index 95900579118b..20ec89d4fcb0 100644
> > > ---
> > >
> >
> a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> > fac
> > > eBmcUsbNicLib.c
> > > +++
> > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostI
> > > +++ nterfaceBmcUsbNicLib.c
> > > @@ -738,8 +738,8 @@ HostInterfaceIpmiCheckMacAddress (
> > >               (VOID *)&IpmiLanChannelMacAddress.Addr,
> > >
> > >               IpmiLanMacAddressSize - 1
> > >
> > >               ) != 0) ||
> > >
> > > -          (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1] !=
> > >
> > > -           *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1) - 1)
> > >
> > > +          (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1] - 1
> > > + !=
> > >
> > > +           *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1))
> > >
> > >            )
> > >
> > >        {
> > >
> > >          DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, "    MAC address is not
> > > matched.\n"));
> > >
> > > --
> > > 2.32.0 (Apple Git-132)
>
>
>
> 
>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111644): https://edk2.groups.io/g/devel/message/111644
Mute This Topic: https://groups.io/mt/102759080/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC

[Mike Maslenkin]

Hi Abner,

I agree with your fixes.
This patch can be dropped from this set.

BTW, do I understand correctly, PR is not required because changes are trivial?

Regards,
Mike.

On Thu, Nov 23, 2023 at 6:06 AM Chang, Abner <Abner.Chang@amd.com> wrote:
>
> [AMD Official Use Only - General]
>
> Good to go. We can merge this after code freeze.
>
> Abner
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang,
> > Abner via groups.io
> > Sent: Thursday, November 23, 2023 9:20 AM
> > To: Nickle Wang <nicklew@nvidia.com>; Mike Maslenkin
> > <mike.maslenkin@gmail.com>; devel@edk2.groups.io
> > Cc: igork@ami.com
> > Subject: Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the
> > BMC-exposed USB NIC
> >
> > [AMD Official Use Only - General]
> >
> > Caution: This message originated from an External Source. Use proper caution
> > when opening attachments, clicking links, or responding.
> >
> >
> > [AMD Official Use Only - General]
> >
> > HI Nickle and Mike,
> > I also have some fixes and revised BMC USB NIC library for searching BMC
> > exposed NIC.
> > Please don't not merge this patch set just for now. I will review this and
> > compare with the changes I have.
> >
> > Thanks
> > Abner
> >
> > > -----Original Message-----
> > > From: Nickle Wang <nicklew@nvidia.com>
> > > Sent: Thursday, November 23, 2023 8:24 AM
> > > To: Mike Maslenkin <mike.maslenkin@gmail.com>; devel@edk2.groups.io
> > > Cc: Chang, Abner <Abner.Chang@amd.com>; igork@ami.com
> > > Subject: RE: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed
> > > USB NIC
> > >
> > > Caution: This message originated from an External Source. Use proper
> > caution
> > > when opening attachments, clicking links, or responding.
> > >
> > >
> > > Reviewed-by: Nickle Wang <nicklew@nvidia.com>
> > >
> > > Regards,
> > > Nickle
> > >
> > > > -----Original Message-----
> > > > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > > Sent: Thursday, November 23, 2023 8:01 AM
> > > > To: devel@edk2.groups.io
> > > > Cc: abner.chang@amd.com; Nickle Wang <nicklew@nvidia.com>;
> > > > igork@ami.com
> > > > Subject: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed
> > USB
> > > NIC
> > > >
> > > > External email: Use caution opening links or attachments
> > > >
> > > >
> > > > According to RedfishPkg/Readme.md document:
> > > > "The last byte of host-end USB NIC MAC address is the last byte of BMC-
> > end
> > > USB
> > > > NIC MAC address minus 1."
> > > >
> > > > It is necessary to subtract 1 from IpmiLanChannelMacAddress.
> > > >
> > > > Cc: Abner Chang <abner.chang@amd.com>
> > > > Cc: Nickle Wang <nicklew@nvidia.com>
> > > > Cc: Igor Kulchytskyy <igork@ami.com>
> > > > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > > ---
> > > >  .../PlatformHostInterfaceBmcUsbNicLib.c                       | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git
> > > >
> > >
> > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> > > fac
> > > > eBmcUsbNicLib.c
> > > >
> > >
> > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> > > fac
> > > > eBmcUsbNicLib.c
> > > > index 95900579118b..20ec89d4fcb0 100644
> > > > ---
> > > >
> > >
> > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> > > fac
> > > > eBmcUsbNicLib.c
> > > > +++
> > > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostI
> > > > +++ nterfaceBmcUsbNicLib.c
> > > > @@ -738,8 +738,8 @@ HostInterfaceIpmiCheckMacAddress (
> > > >               (VOID *)&IpmiLanChannelMacAddress.Addr,
> > > >
> > > >               IpmiLanMacAddressSize - 1
> > > >
> > > >               ) != 0) ||
> > > >
> > > > -          (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1] !=
> > > >
> > > > -           *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1) - 1)
> > > >
> > > > +          (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1] - 1
> > > > + !=
> > > >
> > > > +           *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1))
> > > >
> > > >            )
> > > >
> > > >        {
> > > >
> > > >          DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, "    MAC address is not
> > > > matched.\n"));
> > > >
> > > > --
> > > > 2.32.0 (Apple Git-132)
> >
> >
> >
> > 
> >
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111708): https://edk2.groups.io/g/devel/message/111708
Mute This Topic: https://groups.io/mt/102759080/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC

[Chang, Abner via groups.io]

[AMD Official Use Only - General]

Ok, thanks. Then we will just merge 1/3 and 2/3.

Not quite right, as maintainer has to change the label to "push" on PR then CI will merge it automatically. So, there must be a PR for the change.  Also for the CI tests.

Thanks
Abner

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Monday, November 27, 2023 4:41 AM
> To: Chang, Abner <Abner.Chang@amd.com>
> Cc: devel@edk2.groups.io; Nickle Wang <nicklew@nvidia.com>;
> igork@ami.com
> Subject: Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the
> BMC-exposed USB NIC
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Hi Abner,
>
> I agree with your fixes.
> This patch can be dropped from this set.
>
> BTW, do I understand correctly, PR is not required because changes are trivial?
>
> Regards,
> Mike.
>
> On Thu, Nov 23, 2023 at 6:06 AM Chang, Abner <Abner.Chang@amd.com>
> wrote:
> >
> > [AMD Official Use Only - General]
> >
> > Good to go. We can merge this after code freeze.
> >
> > Abner
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> Chang,
> > > Abner via groups.io
> > > Sent: Thursday, November 23, 2023 9:20 AM
> > > To: Nickle Wang <nicklew@nvidia.com>; Mike Maslenkin
> > > <mike.maslenkin@gmail.com>; devel@edk2.groups.io
> > > Cc: igork@ami.com
> > > Subject: Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the
> > > BMC-exposed USB NIC
> > >
> > > [AMD Official Use Only - General]
> > >
> > > Caution: This message originated from an External Source. Use proper
> caution
> > > when opening attachments, clicking links, or responding.
> > >
> > >
> > > [AMD Official Use Only - General]
> > >
> > > HI Nickle and Mike,
> > > I also have some fixes and revised BMC USB NIC library for searching BMC
> > > exposed NIC.
> > > Please don't not merge this patch set just for now. I will review this and
> > > compare with the changes I have.
> > >
> > > Thanks
> > > Abner
> > >
> > > > -----Original Message-----
> > > > From: Nickle Wang <nicklew@nvidia.com>
> > > > Sent: Thursday, November 23, 2023 8:24 AM
> > > > To: Mike Maslenkin <mike.maslenkin@gmail.com>;
> devel@edk2.groups.io
> > > > Cc: Chang, Abner <Abner.Chang@amd.com>; igork@ami.com
> > > > Subject: RE: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-
> exposed
> > > > USB NIC
> > > >
> > > > Caution: This message originated from an External Source. Use proper
> > > caution
> > > > when opening attachments, clicking links, or responding.
> > > >
> > > >
> > > > Reviewed-by: Nickle Wang <nicklew@nvidia.com>
> > > >
> > > > Regards,
> > > > Nickle
> > > >
> > > > > -----Original Message-----
> > > > > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > > > Sent: Thursday, November 23, 2023 8:01 AM
> > > > > To: devel@edk2.groups.io
> > > > > Cc: abner.chang@amd.com; Nickle Wang <nicklew@nvidia.com>;
> > > > > igork@ami.com
> > > > > Subject: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed
> > > USB
> > > > NIC
> > > > >
> > > > > External email: Use caution opening links or attachments
> > > > >
> > > > >
> > > > > According to RedfishPkg/Readme.md document:
> > > > > "The last byte of host-end USB NIC MAC address is the last byte of
> BMC-
> > > end
> > > > USB
> > > > > NIC MAC address minus 1."
> > > > >
> > > > > It is necessary to subtract 1 from IpmiLanChannelMacAddress.
> > > > >
> > > > > Cc: Abner Chang <abner.chang@amd.com>
> > > > > Cc: Nickle Wang <nicklew@nvidia.com>
> > > > > Cc: Igor Kulchytskyy <igork@ami.com>
> > > > > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > > > ---
> > > > >  .../PlatformHostInterfaceBmcUsbNicLib.c                       | 4 ++--
> > > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > > >
> > > > > diff --git
> > > > >
> > > >
> > >
> a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> > > > fac
> > > > > eBmcUsbNicLib.c
> > > > >
> > > >
> > >
> b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> > > > fac
> > > > > eBmcUsbNicLib.c
> > > > > index 95900579118b..20ec89d4fcb0 100644
> > > > > ---
> > > > >
> > > >
> > >
> a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> > > > fac
> > > > > eBmcUsbNicLib.c
> > > > > +++
> > > >
> b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostI
> > > > > +++ nterfaceBmcUsbNicLib.c
> > > > > @@ -738,8 +738,8 @@ HostInterfaceIpmiCheckMacAddress (
> > > > >               (VOID *)&IpmiLanChannelMacAddress.Addr,
> > > > >
> > > > >               IpmiLanMacAddressSize - 1
> > > > >
> > > > >               ) != 0) ||
> > > > >
> > > > > -          (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize -
> 1] !=
> > > > >
> > > > > -           *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1) - 1)
> > > > >
> > > > > +          (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1]
> - 1
> > > > > + !=
> > > > >
> > > > > +           *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1))
> > > > >
> > > > >            )
> > > > >
> > > > >        {
> > > > >
> > > > >          DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, "    MAC address is
> not
> > > > > matched.\n"));
> > > > >
> > > > > --
> > > > > 2.32.0 (Apple Git-132)
> > >
> > >
> > >
> > > 
> > >
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111711): https://edk2.groups.io/g/devel/message/111711
Mute This Topic: https://groups.io/mt/102759080/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC

[Mike Maslenkin]

Hi Abner,

I dropped patch 3/3, added R-b and created PR
https://github.com/tianocore/edk2/pull/5091

Regards,
Mike

On Mon, Nov 27, 2023 at 5:25 AM Chang, Abner <Abner.Chang@amd.com> wrote:
>
> [AMD Official Use Only - General]
>
> Ok, thanks. Then we will just merge 1/3 and 2/3.
>
> Not quite right, as maintainer has to change the label to "push" on PR then CI will merge it automatically. So, there must be a PR for the change.  Also for the CI tests.
>
> Thanks
> Abner
>
> > -----Original Message-----
> > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > Sent: Monday, November 27, 2023 4:41 AM
> > To: Chang, Abner <Abner.Chang@amd.com>
> > Cc: devel@edk2.groups.io; Nickle Wang <nicklew@nvidia.com>;
> > igork@ami.com
> > Subject: Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the
> > BMC-exposed USB NIC
> >
> > Caution: This message originated from an External Source. Use proper caution
> > when opening attachments, clicking links, or responding.
> >
> >
> > Hi Abner,
> >
> > I agree with your fixes.
> > This patch can be dropped from this set.
> >
> > BTW, do I understand correctly, PR is not required because changes are trivial?
> >
> > Regards,
> > Mike.
> >
> > On Thu, Nov 23, 2023 at 6:06 AM Chang, Abner <Abner.Chang@amd.com>
> > wrote:
> > >
> > > [AMD Official Use Only - General]
> > >
> > > Good to go. We can merge this after code freeze.
> > >
> > > Abner
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > Chang,
> > > > Abner via groups.io
> > > > Sent: Thursday, November 23, 2023 9:20 AM
> > > > To: Nickle Wang <nicklew@nvidia.com>; Mike Maslenkin
> > > > <mike.maslenkin@gmail.com>; devel@edk2.groups.io
> > > > Cc: igork@ami.com
> > > > Subject: Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the
> > > > BMC-exposed USB NIC
> > > >
> > > > [AMD Official Use Only - General]
> > > >
> > > > Caution: This message originated from an External Source. Use proper
> > caution
> > > > when opening attachments, clicking links, or responding.
> > > >
> > > >
> > > > [AMD Official Use Only - General]
> > > >
> > > > HI Nickle and Mike,
> > > > I also have some fixes and revised BMC USB NIC library for searching BMC
> > > > exposed NIC.
> > > > Please don't not merge this patch set just for now. I will review this and
> > > > compare with the changes I have.
> > > >
> > > > Thanks
> > > > Abner
> > > >
> > > > > -----Original Message-----
> > > > > From: Nickle Wang <nicklew@nvidia.com>
> > > > > Sent: Thursday, November 23, 2023 8:24 AM
> > > > > To: Mike Maslenkin <mike.maslenkin@gmail.com>;
> > devel@edk2.groups.io
> > > > > Cc: Chang, Abner <Abner.Chang@amd.com>; igork@ami.com
> > > > > Subject: RE: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-
> > exposed
> > > > > USB NIC
> > > > >
> > > > > Caution: This message originated from an External Source. Use proper
> > > > caution
> > > > > when opening attachments, clicking links, or responding.
> > > > >
> > > > >
> > > > > Reviewed-by: Nickle Wang <nicklew@nvidia.com>
> > > > >
> > > > > Regards,
> > > > > Nickle
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > > > > Sent: Thursday, November 23, 2023 8:01 AM
> > > > > > To: devel@edk2.groups.io
> > > > > > Cc: abner.chang@amd.com; Nickle Wang <nicklew@nvidia.com>;
> > > > > > igork@ami.com
> > > > > > Subject: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed
> > > > USB
> > > > > NIC
> > > > > >
> > > > > > External email: Use caution opening links or attachments
> > > > > >
> > > > > >
> > > > > > According to RedfishPkg/Readme.md document:
> > > > > > "The last byte of host-end USB NIC MAC address is the last byte of
> > BMC-
> > > > end
> > > > > USB
> > > > > > NIC MAC address minus 1."
> > > > > >
> > > > > > It is necessary to subtract 1 from IpmiLanChannelMacAddress.
> > > > > >
> > > > > > Cc: Abner Chang <abner.chang@amd.com>
> > > > > > Cc: Nickle Wang <nicklew@nvidia.com>
> > > > > > Cc: Igor Kulchytskyy <igork@ami.com>
> > > > > > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > > > > ---
> > > > > >  .../PlatformHostInterfaceBmcUsbNicLib.c                       | 4 ++--
> > > > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > > > >
> > > > > > diff --git
> > > > > >
> > > > >
> > > >
> > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> > > > > fac
> > > > > > eBmcUsbNicLib.c
> > > > > >
> > > > >
> > > >
> > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> > > > > fac
> > > > > > eBmcUsbNicLib.c
> > > > > > index 95900579118b..20ec89d4fcb0 100644
> > > > > > ---
> > > > > >
> > > > >
> > > >
> > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> > > > > fac
> > > > > > eBmcUsbNicLib.c
> > > > > > +++
> > > > >
> > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostI
> > > > > > +++ nterfaceBmcUsbNicLib.c
> > > > > > @@ -738,8 +738,8 @@ HostInterfaceIpmiCheckMacAddress (
> > > > > >               (VOID *)&IpmiLanChannelMacAddress.Addr,
> > > > > >
> > > > > >               IpmiLanMacAddressSize - 1
> > > > > >
> > > > > >               ) != 0) ||
> > > > > >
> > > > > > -          (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize -
> > 1] !=
> > > > > >
> > > > > > -           *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1) - 1)
> > > > > >
> > > > > > +          (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1]
> > - 1
> > > > > > + !=
> > > > > >
> > > > > > +           *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1))
> > > > > >
> > > > > >            )
> > > > > >
> > > > > >        {
> > > > > >
> > > > > >          DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, "    MAC address is
> > not
> > > > > > matched.\n"));
> > > > > >
> > > > > > --
> > > > > > 2.32.0 (Apple Git-132)
> > > >
> > > >
> > > >
> > > > 
> > > >
> > >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111864): https://edk2.groups.io/g/devel/message/111864
Mute This Topic: https://groups.io/mt/102759080/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC

[Chang, Abner via groups.io]

[AMD Official Use Only - General]

Hi Mike,
There is an error in CI. Could you please check it here https://github.com/tianocore/edk2/pull/5091/checks?check_run_id=19163237933? As it says Mergify needs permission from you. I think this is new to edk2 CI.

Thanks
Abner

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Thursday, November 30, 2023 8:24 AM
> To: Chang, Abner <Abner.Chang@amd.com>
> Cc: devel@edk2.groups.io; Nickle Wang <nicklew@nvidia.com>;
> igork@ami.com
> Subject: Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the
> BMC-exposed USB NIC
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Hi Abner,
>
> I dropped patch 3/3, added R-b and created PR
> https://github.com/tianocore/edk2/pull/5091
>
> Regards,
> Mike
>
> On Mon, Nov 27, 2023 at 5:25 AM Chang, Abner <Abner.Chang@amd.com>
> wrote:
> >
> > [AMD Official Use Only - General]
> >
> > Ok, thanks. Then we will just merge 1/3 and 2/3.
> >
> > Not quite right, as maintainer has to change the label to "push" on PR then
> CI will merge it automatically. So, there must be a PR for the change.  Also for
> the CI tests.
> >
> > Thanks
> > Abner
> >
> > > -----Original Message-----
> > > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > Sent: Monday, November 27, 2023 4:41 AM
> > > To: Chang, Abner <Abner.Chang@amd.com>
> > > Cc: devel@edk2.groups.io; Nickle Wang <nicklew@nvidia.com>;
> > > igork@ami.com
> > > Subject: Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the
> > > BMC-exposed USB NIC
> > >
> > > Caution: This message originated from an External Source. Use proper
> caution
> > > when opening attachments, clicking links, or responding.
> > >
> > >
> > > Hi Abner,
> > >
> > > I agree with your fixes.
> > > This patch can be dropped from this set.
> > >
> > > BTW, do I understand correctly, PR is not required because changes are
> trivial?
> > >
> > > Regards,
> > > Mike.
> > >
> > > On Thu, Nov 23, 2023 at 6:06 AM Chang, Abner
> <Abner.Chang@amd.com>
> > > wrote:
> > > >
> > > > [AMD Official Use Only - General]
> > > >
> > > > Good to go. We can merge this after code freeze.
> > > >
> > > > Abner
> > > >
> > > > > -----Original Message-----
> > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > Chang,
> > > > > Abner via groups.io
> > > > > Sent: Thursday, November 23, 2023 9:20 AM
> > > > > To: Nickle Wang <nicklew@nvidia.com>; Mike Maslenkin
> > > > > <mike.maslenkin@gmail.com>; devel@edk2.groups.io
> > > > > Cc: igork@ami.com
> > > > > Subject: Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for
> the
> > > > > BMC-exposed USB NIC
> > > > >
> > > > > [AMD Official Use Only - General]
> > > > >
> > > > > Caution: This message originated from an External Source. Use proper
> > > caution
> > > > > when opening attachments, clicking links, or responding.
> > > > >
> > > > >
> > > > > [AMD Official Use Only - General]
> > > > >
> > > > > HI Nickle and Mike,
> > > > > I also have some fixes and revised BMC USB NIC library for searching
> BMC
> > > > > exposed NIC.
> > > > > Please don't not merge this patch set just for now. I will review this and
> > > > > compare with the changes I have.
> > > > >
> > > > > Thanks
> > > > > Abner
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Nickle Wang <nicklew@nvidia.com>
> > > > > > Sent: Thursday, November 23, 2023 8:24 AM
> > > > > > To: Mike Maslenkin <mike.maslenkin@gmail.com>;
> > > devel@edk2.groups.io
> > > > > > Cc: Chang, Abner <Abner.Chang@amd.com>; igork@ami.com
> > > > > > Subject: RE: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-
> > > exposed
> > > > > > USB NIC
> > > > > >
> > > > > > Caution: This message originated from an External Source. Use proper
> > > > > caution
> > > > > > when opening attachments, clicking links, or responding.
> > > > > >
> > > > > >
> > > > > > Reviewed-by: Nickle Wang <nicklew@nvidia.com>
> > > > > >
> > > > > > Regards,
> > > > > > Nickle
> > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > > > > > Sent: Thursday, November 23, 2023 8:01 AM
> > > > > > > To: devel@edk2.groups.io
> > > > > > > Cc: abner.chang@amd.com; Nickle Wang <nicklew@nvidia.com>;
> > > > > > > igork@ami.com
> > > > > > > Subject: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-
> exposed
> > > > > USB
> > > > > > NIC
> > > > > > >
> > > > > > > External email: Use caution opening links or attachments
> > > > > > >
> > > > > > >
> > > > > > > According to RedfishPkg/Readme.md document:
> > > > > > > "The last byte of host-end USB NIC MAC address is the last byte of
> > > BMC-
> > > > > end
> > > > > > USB
> > > > > > > NIC MAC address minus 1."
> > > > > > >
> > > > > > > It is necessary to subtract 1 from IpmiLanChannelMacAddress.
> > > > > > >
> > > > > > > Cc: Abner Chang <abner.chang@amd.com>
> > > > > > > Cc: Nickle Wang <nicklew@nvidia.com>
> > > > > > > Cc: Igor Kulchytskyy <igork@ami.com>
> > > > > > > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> > > > > > > ---
> > > > > > >  .../PlatformHostInterfaceBmcUsbNicLib.c                       | 4 ++--
> > > > > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > > > > >
> > > > > > > diff --git
> > > > > > >
> > > > > >
> > > > >
> > >
> a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> > > > > > fac
> > > > > > > eBmcUsbNicLib.c
> > > > > > >
> > > > > >
> > > > >
> > >
> b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> > > > > > fac
> > > > > > > eBmcUsbNicLib.c
> > > > > > > index 95900579118b..20ec89d4fcb0 100644
> > > > > > > ---
> > > > > > >
> > > > > >
> > > > >
> > >
> a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> > > > > > fac
> > > > > > > eBmcUsbNicLib.c
> > > > > > > +++
> > > > > >
> > > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostI
> > > > > > > +++ nterfaceBmcUsbNicLib.c
> > > > > > > @@ -738,8 +738,8 @@ HostInterfaceIpmiCheckMacAddress (
> > > > > > >               (VOID *)&IpmiLanChannelMacAddress.Addr,
> > > > > > >
> > > > > > >               IpmiLanMacAddressSize - 1
> > > > > > >
> > > > > > >               ) != 0) ||
> > > > > > >
> > > > > > > -          (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize -
> > > 1] !=
> > > > > > >
> > > > > > > -           *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1) -
> 1)
> > > > > > >
> > > > > > > +          (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize -
> 1]
> > > - 1
> > > > > > > + !=
> > > > > > >
> > > > > > > +           *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1))
> > > > > > >
> > > > > > >            )
> > > > > > >
> > > > > > >        {
> > > > > > >
> > > > > > >          DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, "    MAC address
> is
> > > not
> > > > > > > matched.\n"));
> > > > > > >
> > > > > > > --
> > > > > > > 2.32.0 (Apple Git-132)
> > > > >
> > > > >
> > > > >
> > > > > 
> > > > >
> > > >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111887): https://edk2.groups.io/g/devel/message/111887
Mute This Topic: https://groups.io/mt/102759080/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC

[Chang, Abner via groups.io]

[AMD Official Use Only - General]

Reviewed-by: Abner Chang <abner.chang@amd.com>

Mike,  could you please create a PR for this patch set?
Thanks
Abner

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Thursday, November 23, 2023 8:01 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com;
> igork@ami.com
> Subject: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB
> NIC
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> According to RedfishPkg/Readme.md document:
> "The last byte of host-end USB NIC MAC address is the last byte of
> BMC-end USB NIC MAC address minus 1."
>
> It is necessary to subtract 1 from IpmiLanChannelMacAddress.
>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> ---
>  .../PlatformHostInterfaceBmcUsbNicLib.c                       | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
> a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> faceBmcUsbNicLib.c
> b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> faceBmcUsbNicLib.c
> index 95900579118b..20ec89d4fcb0 100644
> ---
> a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> faceBmcUsbNicLib.c
> +++
> b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> faceBmcUsbNicLib.c
> @@ -738,8 +738,8 @@ HostInterfaceIpmiCheckMacAddress (
>               (VOID *)&IpmiLanChannelMacAddress.Addr,
>
>               IpmiLanMacAddressSize - 1
>
>               ) != 0) ||
>
> -          (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1] !=
>
> -           *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1) - 1)
>
> +          (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1] - 1 !=
>
> +           *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1))
>
>            )
>
>        {
>
>          DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, "    MAC address is not
> matched.\n"));
>
> --
> 2.32.0 (Apple Git-132)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111643): https://edk2.groups.io/g/devel/message/111643
Mute This Topic: https://groups.io/mt/102759080/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-