From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8704F740034 for ; Thu, 23 Nov 2023 00:01:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=FRhAzBusHTzH1t0yTCmBGls720EOYfOHM1cOMuAixMw=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1700697679; v=1; b=RTWjhhifjENaZZikB2RWFjxUA+3ccvwo1+LBPpv/UgHmJ2B0cf0SCfLsBM35qYhcaku73FYM 2PZwCq0PL4t/MRw4mPMNgT9zetDcnAQVaQ8wy5Egb8ixsFRviSDYYsuf2a84s+T+J+coc96jPne cjcxnBDP/xo+YXr8kMNC27pw= X-Received: by 127.0.0.2 with SMTP id tYgGYY7687511xlUPKM9ZqDW; Wed, 22 Nov 2023 16:01:19 -0800 X-Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by mx.groups.io with SMTP id smtpd.web11.79520.1700697678307292802 for ; Wed, 22 Nov 2023 16:01:18 -0800 X-Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-50abb83866bso359850e87.3 for ; Wed, 22 Nov 2023 16:01:18 -0800 (PST) X-Gm-Message-State: 0qwirAAhx7Q1dFB3Jpa2vktcx7686176AA= X-Google-Smtp-Source: AGHT+IELWss5WXo4nuB8hMPYhPIwB4+u1KmNqg9UWw515DFT/GWA2H/7r8I+8vsjCOp5SFW5H4Qlhw== X-Received: by 2002:a05:6512:3091:b0:503:653:5711 with SMTP id z17-20020a056512309100b0050306535711mr3395457lfd.9.1700697676069; Wed, 22 Nov 2023 16:01:16 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id q19-20020a194313000000b0050a78dac3fasm10621lfa.12.2023.11.22.16.01.15 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 22 Nov 2023 16:01:15 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com Subject: [edk2-devel] [PATCH v2 2/3] RedfishPkg: add explicit variable initialization Date: Thu, 23 Nov 2023 03:01:02 +0300 Message-Id: <20231123000103.31216-3-mike.maslenkin@gmail.com> In-Reply-To: <20231123000103.31216-1-mike.maslenkin@gmail.com> References: <20231123000103.31216-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=RTWjhhif; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Ancient GCC 4.8.5 warned about variable may be unitialied. And it doesn't look like false alarm. The warning is: edk2/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c: In function 'Ge= tQuestionDefault': edk2/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c:5519:6: error: '= ConfigAccess' may be used uninitialized in this function [-Werror=3Dmaybe-u= ninitialized] if (ConfigAccess !=3D NULL) { Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c | 1 + 1 file changed, 1 insertion(+) diff --git a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c b/Redfis= hPkg/Library/HiiUtilityLib/HiiUtilityInternal.c index 80b93beae999..b61b7f5fcdcc 100644 --- a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c +++ b/RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c @@ -5451,6 +5451,7 @@ GetQuestionDefault ( =0D Status =3D EFI_NOT_FOUND;=0D StrValue =3D NULL;=0D + ConfigAccess =3D NULL;=0D OriginalDefaultId =3D DefaultId;=0D DefaultLink =3D GetFirstNode (&FormSet->DefaultStoreListHead);=0D =0D --=20 2.32.0 (Apple Git-132) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111629): https://edk2.groups.io/g/devel/message/111629 Mute This Topic: https://groups.io/mt/102759079/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-