From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2A17C740034 for ; Thu, 23 Nov 2023 00:01:21 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=E/RALcF/oyxXnN+BhCmQcnL24wrIOZ18Q4xHaDDk1xw=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1700697679; v=1; b=XvBzrIIwqBL9ap7h0Gr9QYbUDT10mxFO1qPj1TlhtGnml7/P8NbbKi3SDiNoruWze8FvMham m9bo3P91xpISLeMi/AnOKTAHJv9/kThppJreEJtm0qgRA23lFyhVSNuDLc60z6WOD0pqV1FAPhV zzrlwkbfmzN/LWKoHPR/luGY= X-Received: by 127.0.0.2 with SMTP id D2ObYY7687511xoO2BVGMQM9; Wed, 22 Nov 2023 16:01:19 -0800 X-Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by mx.groups.io with SMTP id smtpd.web11.79521.1700697678654581012 for ; Wed, 22 Nov 2023 16:01:19 -0800 X-Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-50abb83866bso359856e87.3 for ; Wed, 22 Nov 2023 16:01:18 -0800 (PST) X-Gm-Message-State: WdyAGKq0THyYvShtybPwKp8rx7686176AA= X-Google-Smtp-Source: AGHT+IGuzewDSdEHU/OCXEAFl33uYOO0H/jHWWSND1f7braD2+dHrrXRuDAcV8oeiju5OVPyhVYsNg== X-Received: by 2002:ac2:4e97:0:b0:508:1a25:a194 with SMTP id o23-20020ac24e97000000b005081a25a194mr2146761lfr.21.1700697676827; Wed, 22 Nov 2023 16:01:16 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id q19-20020a194313000000b0050a78dac3fasm10621lfa.12.2023.11.22.16.01.16 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 22 Nov 2023 16:01:16 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com Subject: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC Date: Thu, 23 Nov 2023 03:01:03 +0300 Message-Id: <20231123000103.31216-4-mike.maslenkin@gmail.com> In-Reply-To: <20231123000103.31216-1-mike.maslenkin@gmail.com> References: <20231123000103.31216-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=XvBzrIIw; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io According to RedfishPkg/Readme.md document: "The last byte of host-end USB NIC MAC address is the last byte of BMC-end USB NIC MAC address minus 1." It is necessary to subtract 1 from IpmiLanChannelMacAddress. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../PlatformHostInterfaceBmcUsbNicLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformH= ostInterfaceBmcUsbNicLib.c b/RedfishPkg/Library/PlatformHostInterfaceBmcUsb= NicLib/PlatformHostInterfaceBmcUsbNicLib.c index 95900579118b..20ec89d4fcb0 100644 --- a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInte= rfaceBmcUsbNicLib.c +++ b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInte= rfaceBmcUsbNicLib.c @@ -738,8 +738,8 @@ HostInterfaceIpmiCheckMacAddress ( (VOID *)&IpmiLanChannelMacAddress.Addr,=0D IpmiLanMacAddressSize - 1=0D ) !=3D 0) ||=0D - (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1] !=3D=0D - *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1) - 1)=0D + (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1] - 1 != =3D=0D + *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1))=0D )=0D {=0D DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, " MAC address is not matc= hed.\n"));=0D --=20 2.32.0 (Apple Git-132) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111630): https://edk2.groups.io/g/devel/message/111630 Mute This Topic: https://groups.io/mt/102759080/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-