* [edk2-devel] [PATCH v2] CloudHv: Add CI for CloudHv on AArch64
@ 2023-11-23 3:22 Jianyong Wu
2023-12-11 16:31 ` Laszlo Ersek
0 siblings, 1 reply; 5+ messages in thread
From: Jianyong Wu @ 2023-11-23 3:22 UTC (permalink / raw)
To: devel, lersek, Sami.Mujawar; +Cc: ardb+tianocore, jianyong.wu
Add the long lost CI for CloudHv on AArch64.
As CloudHv CI works nearly the same way with other VMMs like KvmTool,
thus we can easily create its CI configuration based on KvmTool.
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
---
.../PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 13 +++++++++++++
.../PlatformCI/{KvmToolBuild.py => CloudHvBuild.py} | 4 ++--
2 files changed, 15 insertions(+), 2 deletions(-)
copy ArmVirtPkg/PlatformCI/{KvmToolBuild.py => CloudHvBuild.py} (89%)
diff --git a/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
index d1772a65fc..ab8a2db530 100644
--- a/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
+++ b/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
@@ -140,6 +140,19 @@ jobs:
Build.Target: "RELEASE"
Run: false
+ CLOUDHV_AARCH64_DEBUG:
+ Build.File: "$(package)/PlatformCI/CloudHvBuild.py"
+ Build.Arch: "AARCH64"
+ Build.Flags: ""
+ Build.Target: "DEBUG"
+ Run: false
+ CLOUDHV_AARCH64_RELEASE:
+ Build.File: "$(package)/PlatformCI/CloudHvBuild.py"
+ Build.Arch: "AARCH64"
+ Build.Flags: ""
+ Build.Target: "RELEASE"
+ Run: false
+
workspace:
clean: all
diff --git a/ArmVirtPkg/PlatformCI/KvmToolBuild.py b/ArmVirtPkg/PlatformCI/CloudHvBuild.py
similarity index 89%
copy from ArmVirtPkg/PlatformCI/KvmToolBuild.py
copy to ArmVirtPkg/PlatformCI/CloudHvBuild.py
index 4d02dba124..06ada39886 100644
--- a/ArmVirtPkg/PlatformCI/KvmToolBuild.py
+++ b/ArmVirtPkg/PlatformCI/CloudHvBuild.py
@@ -19,13 +19,13 @@ class CommonPlatform():
for the different parts of stuart
'''
PackagesSupported = ("ArmVirtPkg",)
- ArchSupported = ("AARCH64", "ARM")
+ ArchSupported = ("AARCH64")
TargetsSupported = ("DEBUG", "RELEASE")
Scopes = ('armvirt', 'edk2-build')
WorkspaceRoot = os.path.realpath(os.path.join(
os.path.dirname(os.path.abspath(__file__)), "..", ".."))
- DscName = os.path.join("ArmVirtPkg", "ArmVirtKvmTool.dsc")
+ DscName = os.path.join("ArmVirtPkg", "ArmVirtCloudHv.dsc")
FvQemuArg = "" # ignored
import PlatformBuildLib
--
2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111646): https://edk2.groups.io/g/devel/message/111646
Mute This Topic: https://groups.io/mt/102761729/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH v2] CloudHv: Add CI for CloudHv on AArch64
2023-11-23 3:22 [edk2-devel] [PATCH v2] CloudHv: Add CI for CloudHv on AArch64 Jianyong Wu
@ 2023-12-11 16:31 ` Laszlo Ersek
2023-12-11 17:21 ` Laszlo Ersek
0 siblings, 1 reply; 5+ messages in thread
From: Laszlo Ersek @ 2023-12-11 16:31 UTC (permalink / raw)
To: devel, jianyong.wu, Sami.Mujawar; +Cc: ardb+tianocore
On 11/23/23 04:22, Jianyong Wu wrote:
> Add the long lost CI for CloudHv on AArch64.
> As CloudHv CI works nearly the same way with other VMMs like KvmTool,
> thus we can easily create its CI configuration based on KvmTool.
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
> ---
> .../PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 13 +++++++++++++
> .../PlatformCI/{KvmToolBuild.py => CloudHvBuild.py} | 4 ++--
> 2 files changed, 15 insertions(+), 2 deletions(-)
> copy ArmVirtPkg/PlatformCI/{KvmToolBuild.py => CloudHvBuild.py} (89%)
>
> diff --git a/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> index d1772a65fc..ab8a2db530 100644
> --- a/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> +++ b/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
> @@ -140,6 +140,19 @@ jobs:
> Build.Target: "RELEASE"
> Run: false
>
> + CLOUDHV_AARCH64_DEBUG:
> + Build.File: "$(package)/PlatformCI/CloudHvBuild.py"
> + Build.Arch: "AARCH64"
> + Build.Flags: ""
> + Build.Target: "DEBUG"
> + Run: false
> + CLOUDHV_AARCH64_RELEASE:
> + Build.File: "$(package)/PlatformCI/CloudHvBuild.py"
> + Build.Arch: "AARCH64"
> + Build.Flags: ""
> + Build.Target: "RELEASE"
> + Run: false
> +
> workspace:
> clean: all
>
> diff --git a/ArmVirtPkg/PlatformCI/KvmToolBuild.py b/ArmVirtPkg/PlatformCI/CloudHvBuild.py
> similarity index 89%
> copy from ArmVirtPkg/PlatformCI/KvmToolBuild.py
> copy to ArmVirtPkg/PlatformCI/CloudHvBuild.py
> index 4d02dba124..06ada39886 100644
> --- a/ArmVirtPkg/PlatformCI/KvmToolBuild.py
> +++ b/ArmVirtPkg/PlatformCI/CloudHvBuild.py
> @@ -19,13 +19,13 @@ class CommonPlatform():
> for the different parts of stuart
> '''
> PackagesSupported = ("ArmVirtPkg",)
> - ArchSupported = ("AARCH64", "ARM")
> + ArchSupported = ("AARCH64")
Right, and this one change is new in version 2 of the patch.
My R-b stands.
I'm picking this up now.
Laszlo
> TargetsSupported = ("DEBUG", "RELEASE")
> Scopes = ('armvirt', 'edk2-build')
> WorkspaceRoot = os.path.realpath(os.path.join(
> os.path.dirname(os.path.abspath(__file__)), "..", ".."))
>
> - DscName = os.path.join("ArmVirtPkg", "ArmVirtKvmTool.dsc")
> + DscName = os.path.join("ArmVirtPkg", "ArmVirtCloudHv.dsc")
> FvQemuArg = "" # ignored
>
> import PlatformBuildLib
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112317): https://edk2.groups.io/g/devel/message/112317
Mute This Topic: https://groups.io/mt/102761729/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH v2] CloudHv: Add CI for CloudHv on AArch64
2023-12-11 16:31 ` Laszlo Ersek
@ 2023-12-11 17:21 ` Laszlo Ersek
2023-12-13 9:29 ` Sami Mujawar
0 siblings, 1 reply; 5+ messages in thread
From: Laszlo Ersek @ 2023-12-11 17:21 UTC (permalink / raw)
To: devel, jianyong.wu, Sami.Mujawar; +Cc: ardb+tianocore
Hi Jianyong,
On 12/11/23 17:31, Laszlo Ersek wrote:
> On 11/23/23 04:22, Jianyong Wu wrote:
>> Add the long lost CI for CloudHv on AArch64.
>> As CloudHv CI works nearly the same way with other VMMs like KvmTool,
>> thus we can easily create its CI configuration based on KvmTool.
>>
>> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>> Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
>> ---
>> .../PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 13 +++++++++++++
>> .../PlatformCI/{KvmToolBuild.py => CloudHvBuild.py} | 4 ++--
>> 2 files changed, 15 insertions(+), 2 deletions(-)
>> copy ArmVirtPkg/PlatformCI/{KvmToolBuild.py => CloudHvBuild.py} (89%)
>>
>> diff --git a/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
>> index d1772a65fc..ab8a2db530 100644
>> --- a/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
>> +++ b/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
>> @@ -140,6 +140,19 @@ jobs:
>> Build.Target: "RELEASE"
>> Run: false
>>
>> + CLOUDHV_AARCH64_DEBUG:
>> + Build.File: "$(package)/PlatformCI/CloudHvBuild.py"
>> + Build.Arch: "AARCH64"
>> + Build.Flags: ""
>> + Build.Target: "DEBUG"
>> + Run: false
>> + CLOUDHV_AARCH64_RELEASE:
>> + Build.File: "$(package)/PlatformCI/CloudHvBuild.py"
>> + Build.Arch: "AARCH64"
>> + Build.Flags: ""
>> + Build.Target: "RELEASE"
>> + Run: false
>> +
>> workspace:
>> clean: all
>>
>> diff --git a/ArmVirtPkg/PlatformCI/KvmToolBuild.py b/ArmVirtPkg/PlatformCI/CloudHvBuild.py
>> similarity index 89%
>> copy from ArmVirtPkg/PlatformCI/KvmToolBuild.py
>> copy to ArmVirtPkg/PlatformCI/CloudHvBuild.py
>> index 4d02dba124..06ada39886 100644
>> --- a/ArmVirtPkg/PlatformCI/KvmToolBuild.py
>> +++ b/ArmVirtPkg/PlatformCI/CloudHvBuild.py
>> @@ -19,13 +19,13 @@ class CommonPlatform():
>> for the different parts of stuart
>> '''
>> PackagesSupported = ("ArmVirtPkg",)
>> - ArchSupported = ("AARCH64", "ARM")
>> + ArchSupported = ("AARCH64")
>
> Right, and this one change is new in version 2 of the patch.
>
> My R-b stands.
>
> I'm picking this up now.
>
The CI run failed for this patch when I tried to merge it; can you
please review <https://github.com/tianocore/edk2/pull/5137>?
Thanks,
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112321): https://edk2.groups.io/g/devel/message/112321
Mute This Topic: https://groups.io/mt/102761729/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [edk2-devel] [PATCH v2] CloudHv: Add CI for CloudHv on AArch64
2023-12-11 17:21 ` Laszlo Ersek
@ 2023-12-13 9:29 ` Sami Mujawar
2023-12-13 15:15 ` Sami Mujawar
0 siblings, 1 reply; 5+ messages in thread
From: Sami Mujawar @ 2023-12-13 9:29 UTC (permalink / raw)
To: Laszlo Ersek, devel@edk2.groups.io; +Cc: ardb+tianocore@kernel.org, nd
Hi Laszlo,
I will look into this and provide a fix shortly.
Regards,
Sami Mujawar
On 11/12/2023, 17:21, "Laszlo Ersek" <lersek@redhat.com <mailto:lersek@redhat.com>> wrote:
Hi Jianyong,
On 12/11/23 17:31, Laszlo Ersek wrote:
> On 11/23/23 04:22, Jianyong Wu wrote:
>> Add the long lost CI for CloudHv on AArch64.
>> As CloudHv CI works nearly the same way with other VMMs like KvmTool,
>> thus we can easily create its CI configuration based on KvmTool.
>>
>> Reviewed-by: Laszlo Ersek <lersek@redhat.com <mailto:lersek@redhat.com>>
>> Signed-off-by: Jianyong Wu <jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>>
>> ---
>> .../PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 13 +++++++++++++
>> .../PlatformCI/{KvmToolBuild.py => CloudHvBuild.py} | 4 ++--
>> 2 files changed, 15 insertions(+), 2 deletions(-)
>> copy ArmVirtPkg/PlatformCI/{KvmToolBuild.py => CloudHvBuild.py} (89%)
>>
>> diff --git a/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
>> index d1772a65fc..ab8a2db530 100644
>> --- a/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
>> +++ b/ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml
>> @@ -140,6 +140,19 @@ jobs:
>> Build.Target: "RELEASE"
>> Run: false
>>
>> + CLOUDHV_AARCH64_DEBUG:
>> + Build.File: "$(package)/PlatformCI/CloudHvBuild.py"
>> + Build.Arch: "AARCH64"
>> + Build.Flags: ""
>> + Build.Target: "DEBUG"
>> + Run: false
>> + CLOUDHV_AARCH64_RELEASE:
>> + Build.File: "$(package)/PlatformCI/CloudHvBuild.py"
>> + Build.Arch: "AARCH64"
>> + Build.Flags: ""
>> + Build.Target: "RELEASE"
>> + Run: false
>> +
>> workspace:
>> clean: all
>>
>> diff --git a/ArmVirtPkg/PlatformCI/KvmToolBuild.py b/ArmVirtPkg/PlatformCI/CloudHvBuild.py
>> similarity index 89%
>> copy from ArmVirtPkg/PlatformCI/KvmToolBuild.py
>> copy to ArmVirtPkg/PlatformCI/CloudHvBuild.py
>> index 4d02dba124..06ada39886 100644
>> --- a/ArmVirtPkg/PlatformCI/KvmToolBuild.py
>> +++ b/ArmVirtPkg/PlatformCI/CloudHvBuild.py
>> @@ -19,13 +19,13 @@ class CommonPlatform():
>> for the different parts of stuart
>> '''
>> PackagesSupported = ("ArmVirtPkg",)
>> - ArchSupported = ("AARCH64", "ARM")
>> + ArchSupported = ("AARCH64")
>
> Right, and this one change is new in version 2 of the patch.
>
> My R-b stands.
>
> I'm picking this up now.
>
The CI run failed for this patch when I tried to merge it; can you
please review <https://github.com/tianocore/edk2/pull/5137>? <https://github.com/tianocore/edk2/pull/5137>?>
Thanks,
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112469): https://edk2.groups.io/g/devel/message/112469
Mute This Topic: https://groups.io/mt/102761729/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-12-13 15:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-23 3:22 [edk2-devel] [PATCH v2] CloudHv: Add CI for CloudHv on AArch64 Jianyong Wu
2023-12-11 16:31 ` Laszlo Ersek
2023-12-11 17:21 ` Laszlo Ersek
2023-12-13 9:29 ` Sami Mujawar
2023-12-13 15:15 ` Sami Mujawar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox