From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9C372D800F3 for ; Thu, 23 Nov 2023 06:48:19 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=KJMVVyCjvlLceRd2FXJb49QwDLhZyphXEwwFxERgai0=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1700722098; v=1; b=lSXVDN5Dmh3OFrKtW8lMLmHImL5pzFxRtdEKpSHZxDq+FNR2A2gMoqgi+xsP0ch3zqIgJ8ps Ke2mMp4G9KH8rmKaLzHlCieVbzKYmKb58qVAjhUjK6j4UXpeWG0lVV2RsishxAtJy/mQ4I7Wk3Q wGm0kwBbFHaCeS+BWquAXeFI= X-Received: by 127.0.0.2 with SMTP id SCAUYY7687511xvVS4zkYMwX; Wed, 22 Nov 2023 22:48:18 -0800 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.41]) by mx.groups.io with SMTP id smtpd.web10.85905.1700722096517701727 for ; Wed, 22 Nov 2023 22:48:16 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OT2OjaTOYgmBfFF4c0o66sK1x9bTnybDOPr8Cm41Dpbu8tg36TMyCL3zwxdmqqXkyM4fv1sPr0mw/Yr5xjaBwEC+e7e4LWGX+lzHCXGyc4JfWFNKjvrmKeVBBJxsTNrW6QFB6FR41jqRbRw/pNI6XiP4+dzAr4tYF7KjJjmGMnY8NGz35yDcH4IxTsvEfmfll38vnvBlrtq+5wNNKH/GoRGqrIOPwvQDeaR6yLH2vA6gZV0s8eA6RZ+3z8Z/oqR7Eunpj5SNXWcP1hfXHc+7bajYOc8WzDJqjojoj6AkmPekOpbhDJHnJlWaeaV3QEybiJkBIZbvZ9CxnrQQMxvRXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZNGE/E8DPxHY7ypxpAPE1BtIyFzv49eXI+C2+U/uBOc=; b=lmf3gVd+PZbTTx1Q5s1aiqEC8TM7ZCleQN5kKi7BMx2RiidoYYNyqSe8iFC8iSacEZeIXKU10aag1Ysy2OWh3tvlbRcuZbz9n/7WUlH6oPnTCfF2Q9tin0NHwZ21H5N+7oTh1AHZR7r7hfpFO+aI3Lfobgmbcea2IYig7+84AXBlQJbCRL3UQI+qftcm6JfXat58uZOlFeMpZpND6Cqrw+OYFUaPsIvG1HQeHRBhCC0JI4HU/ZGj6CP5aJO+tnC+jPwZ6hwnX6+uni421GKnbAJpQaKF3LvmlpcMuICiEdmac0qHWtmSPyJt/pLo3mfuLN37aRbfvsnrplEev6GTkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from DM6PR07CA0067.namprd07.prod.outlook.com (2603:10b6:5:74::44) by MN2PR12MB4112.namprd12.prod.outlook.com (2603:10b6:208:19a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.20; Thu, 23 Nov 2023 06:48:14 +0000 X-Received: from DS1PEPF00017094.namprd03.prod.outlook.com (2603:10b6:5:74:cafe::39) by DM6PR07CA0067.outlook.office365.com (2603:10b6:5:74::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.19 via Frontend Transport; Thu, 23 Nov 2023 06:48:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF00017094.mail.protection.outlook.com (10.167.17.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7025.12 via Frontend Transport; Thu, 23 Nov 2023 06:48:13 +0000 X-Received: from TPE-L1-ABNCHANG.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 23 Nov 2023 00:48:11 -0600 From: "Chang, Abner via groups.io" To: CC: Nickle Wang , Igor Kulchytskyy , Mike Maslenkin Subject: [edk2-devel] [PATCH V2 8/8] RedfishPkg/HostInterfaceBmcUsbNic: Fix incorrect HI protocol record size Date: Thu, 23 Nov 2023 14:47:18 +0800 Message-ID: <20231123064719.1248-9-abner.chang@amd.com> In-Reply-To: <20231123064719.1248-1-abner.chang@amd.com> References: <20231123064719.1248-1-abner.chang@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017094:EE_|MN2PR12MB4112:EE_ X-MS-Office365-Filtering-Correlation-Id: 2fd266bb-be4b-4825-3324-08dbebf02a66 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: fMyT+xxUGvoYX/v572+NWKacIxol5yZEKZpX+XLS5J3WJdzIU4UJg4rOQltzqkLXofvUw39YjP9e2m5uyhiImdWcS+uzBBOeW9ONCIoxXxq/PU1N0lp1W68DLAFt3ahHP7WZEG6AwfaFpCoy93cNQyyYsiPijRweJ/Dw2CGL02V6j1I2CXN6DJU2kMsQvG/9nIj2o5TBTW11veHcjdLr4eFQdBFlqITrYn7GqVhBJJL5+S4aK1M1OVaXUAeSWUJeo1BKn5jw6IgqOGg6SPyZjX7LmlOXKhc+FqgmR+ZAdHN9/w/hFXf+KMAnZ2gUvf6yL7f+CVIazN3vSd684sV8Or2qRvbNMIEpb1Q+uTAnoGIQ4vY1owMbAsB8Ws6E5m3MrZwy6AoyixhXAdTFFb3JU8/QukhyVbVAx+YNfxhh740OB7m6pKXKXa/mn4UWw0MMHY4KFLlkj5JYxtdEE2B2E0XoeMlS+eYNob34ifCZi8VcttT0bninx1vsPOmSwz+uNbzayEfUMPGnfEKvsO8fKS2CVy/b52lrsljUFAHsoJ2aDKX/xPMRaXiWwt2FJcr8DcZm+wVb3e6H0q9kdiDWgnWMOPYFBQWwyubJHpTGNI1J0mS89GeQlSKRYunrwuW0tLljldMBSb6ozdeeITB4VN5IqOWU4GHXQ2HNzm+QjvSPxPThTRJ9w4u5oS00MbkgYBIXJ83/kpOaUjOV21+voRr4xS2TlR8nsqOgnNyEvqCVj8ZoYB6YXX/uf4QXz8nMrBsjrCfsxx9Hph2Lo/YSEsuF2mqgMXb8ebel1Q/tZ5Q= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2023 06:48:13.7045 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2fd266bb-be4b-4825-3324-08dbebf02a66 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017094.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4112 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: WALFvKfi6JqOVFi6Ty3LuT8Bx7686176AA= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=lSXVDN5D; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") From: Abner Chang The size of structure must be minus with byte that is occupied by the initial array. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Mike Maslenkin --- .../PlatformHostInterfaceBmcUsbNicLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformH= ostInterfaceBmcUsbNicLib.c b/RedfishPkg/Library/PlatformHostInterfaceBmcUsb= NicLib/PlatformHostInterfaceBmcUsbNicLib.c index c4a71226e63..a1ce2dd3d93 100644 --- a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInte= rfaceBmcUsbNicLib.c +++ b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInte= rfaceBmcUsbNicLib.c @@ -180,7 +180,7 @@ RedfishPlatformHostInterfaceProtocolData ( HostNameLength =3D (UINT8)AsciiStrSize (HostNameString); ThisProtocolRecord =3D (MC_HOST_INTERFACE_PROTOCOL_RECORD *)Allocate= ZeroPool ( sizeof (= MC_HOST_INTERFACE_PROTOCOL_RECORD) - 1 + - sizeof (= REDFISH_OVER_IP_PROTOCOL_DATA) + + sizeof (= REDFISH_OVER_IP_PROTOCOL_DATA) - 1 + HostName= Length ); if (ThisProtocolRecord =3D=3D NULL) { @@ -189,7 +189,7 @@ RedfishPlatformHostInterfaceProtocolData ( } =20 ThisProtocolRecord->ProtocolType =3D MCHostInterfaceProtocolT= ypeRedfishOverIP; - ThisProtocolRecord->ProtocolTypeDataLen =3D sizeof (REDFISH_OVER_IP_= PROTOCOL_DATA) + HostNameLength; + ThisProtocolRecord->ProtocolTypeDataLen =3D sizeof (REDFISH_OVER_IP_= PROTOCOL_DATA) -1 + HostNameLength; RedfishOverIpData =3D (REDFISH_OVER_IP_PROTOCO= L_DATA *)&ThisProtocolRecord->ProtocolTypeData[0]; // // Fill up REDFISH_OVER_IP_PROTOCOL_DATA --=20 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111661): https://edk2.groups.io/g/devel/message/111661 Mute This Topic: https://groups.io/mt/102763123/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-