From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1094D78003C for ; Thu, 23 Nov 2023 14:33:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=CylAkjpqGP6+UoO7qD+DjRtM3QEZNc2IbesTa/sdVHA=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1700750034; v=1; b=aiK9NWv5nAwdGy2Hii/9bJlg7mLG34Oy/uUX2ezzKwfbbC5hV84MDt6J+6JjH5D8rCnFhoAa tg7Bhnse+jLoLmYbZbrwt/Zf9gNnY2kT/Ti4SMKOMQLrltzg7BqWcBJn2e6WVnroSZIKapoEIfb +U1ZdNoAHSPl/N/3bz2D+4BA= X-Received: by 127.0.0.2 with SMTP id r896YY7687511xH1FRsR5ZDL; Thu, 23 Nov 2023 06:33:54 -0800 X-Received: from NAM02-SN1-obe.outbound.protection.outlook.com (NAM02-SN1-obe.outbound.protection.outlook.com [40.107.96.74]) by mx.groups.io with SMTP id smtpd.web10.91952.1700750033886933653 for ; Thu, 23 Nov 2023 06:33:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Iu4eS0Q8yvWJhT+ntRfhzLb3V+Skdr9Qtq9jr4TTaCt/A9FaJAbpdE5ELqYjWxUyoUhF6FM7cN7/f0bdH1PDq9eRdt55gVmyjVvMfacCvu12tO9hQtyZjpGn2DKkCMxSunhlC1UwVe8E6PFFK7PnZ3sEiMT/qy6N0l2y6TN433Rak3VV9IyxmOXmcPFYG0Syd/hoWQEutCfwdGt/fgPIJjDweUZzy79GZk9YvpcivT19G8fybxTNDbHBf1cfFML91XlGM1K1KQilRuxIANzlBuaYLxC+EttSrwz6tLrkVnvI8XaotEM8GlD7TZ1tSY/7eeVDm15dWJrhMRa/nazlrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tLg4Az9Ili2x+YcG5wio6IvK5nKFuppnTKntW8jrT3U=; b=VHpXDZ0ly6CsH8EFFqn17X2/sAeJjfetxSm56kFFAsVA6Wio01TZnpATv6Gt+YcJeZy1mBP42hNSyMaIqooXOFQ2qPcze8eNooL6+f3EEfT+V/2qtkmz+DbrQKMOB1HKxp8v/YRaPx1idM7SEdjXmV0xL6vVkMFAg+8d78EvcC2KQlG05RveeXFEeXoDgqlh51vXlNCewN7xAv6ycvrdQ0ZxO5Gi8OSOJk+tZj00c9s1f2pT1Q3ic/R+OF2hTDu1bNgkxlIQebC35RhyI5xvpOjhrUZ/F02fCYgiByL/dlMhyF5hnM69XRx/ekK8bA0hfEMpWMAx+U7cgnkuWxLs+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) X-Received: from MW4PR03CA0235.namprd03.prod.outlook.com (2603:10b6:303:b9::30) by PH7PR12MB6396.namprd12.prod.outlook.com (2603:10b6:510:1fc::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.20; Thu, 23 Nov 2023 14:33:48 +0000 X-Received: from CO1PEPF000044F6.namprd21.prod.outlook.com (2603:10b6:303:b9:cafe::74) by MW4PR03CA0235.outlook.office365.com (2603:10b6:303:b9::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.18 via Frontend Transport; Thu, 23 Nov 2023 14:33:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C X-Received: from mail.nvidia.com (216.228.117.161) by CO1PEPF000044F6.mail.protection.outlook.com (10.167.241.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.3 via Frontend Transport; Thu, 23 Nov 2023 14:33:47 +0000 X-Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 23 Nov 2023 06:33:38 -0800 X-Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 23 Nov 2023 06:33:38 -0800 X-Received: from NV-CL38DL3.nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server id 15.2.986.41 via Frontend Transport; Thu, 23 Nov 2023 06:33:37 -0800 From: "Nickle Wang via groups.io" To: CC: Abner Chang , Igor Kulchytskyy , "Nick Ramirez" Subject: [edk2-devel] [edk2-redfish-client][PATCH 0/6] Feature driver fix and Date: Thu, 23 Nov 2023 22:33:36 +0800 Message-ID: <20231123143336.3043-1-nicklew@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044F6:EE_|PH7PR12MB6396:EE_ X-MS-Office365-Filtering-Correlation-Id: 98c50be1-5fea-4424-4b7b-08dbec313455 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: 6LjqhrMD/RheRTjL6kRjO7GW0E37lwKr3vePbU1elazZ7ibxmKoi1N6Y57nsRLukSLog02fEIHQxjzThKVVQ4GKpLY2iAft5RiqxIOVi5l93YAYwWk6XcFwETI/QrgyNtPBM5h9entjr30nqNzdWy2WhDjs7CO6xYaX1uBJ2yih+hb2FpfTZR/EJXba9fPRkQa9/Hn9cLZQbVxP1ozjBRJfpbxZZm17Aq0t7gpjY19elju3HmnSxXuzahmgTywknSgzd3VL3pybbwwbs9TL+67Dht6sbfdKUKNwXJH5Q+alewDPyOSaYZoEL00BDsiwWz3vpfMzdoUtKmtrrqexdnvucgenVt7gpd670dWm/b3+LaWu9afYTGyhu5pRVWpk0wLgqwFWAkrDI+6jeE07jcLWcfhZjdJQtmhR6R48sfraWZVyAh/mxKhOnpZbS4ER5c6KBTPkLkL3egc9Th62QC+wyHCmgRnnwehu0ZVDuCdZ/cJV8RHsYEyZjbrns087kAz9r5jFzPE33MskbL8rWg0Q79Cj5BfLfSbdmCNpIoBENM0/Q8iNnN3Qwo6LXQAZOScQ7wBXoP+VHMULO0KZS70U6Ps7eOj79OIyQAtCdTGQIoeEk0207ZZYDdHUfrchXktyynVKWh5X8ZpuLZ7uYHrzNU/uNnYc1tAT5pjL765An0nRsacBibUwG4E2IGHTE03gbSpdkeifjwZOm0DPNAGkYlU5Ifra7G+sz/4xzfnhnXLzhunFDGDWPEpq0tXY1 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2023 14:33:47.7677 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 98c50be1-5fea-4424-4b7b-08dbec313455 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F6.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6396 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: q3SsA1KW97413wODQE0o6u0rx7686176AA= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-Spam-Flag: yes X-Spam-Level: ************ X-GND-Spam-Score: 190 X-GND-Status: SPAM Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=aiK9NWv5; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io There are several bug fix and enhancement to Redfish feature driver. I also fix typo in comments, variable and function name. A pull request is created here for ease of review:=20 https://github.com/tianocore/edk2-redfish-client/pull/60 Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Nickle Wang (6): RedfishClientPkg/RedfishETagDxe: fix issue and enhancement. RedfishClientPkg/RedfishConfigLangMapDxe: fix issue and enhancement. RedfishClientPkg: feature driver enhancement. RedfishClientPkg/ConverterLib: fix empty attribute value issue RedfishClientPkg/Features: fix NULL cached handler issue. RedfishClientPkg/RedfishFeatureUtilityLib: add string NULL check .../RedfishConfigLangMapDxe.inf | 1 - .../RedfishETagDxe/RedfishETagDxe.inf | 5 +- .../Library/EdkIIRedfishResourceConfigLib.h | 9 +- .../Library/RedfishFeatureUtilityLib.h | 81 +++++-- .../RedfishConfigLangMapDxe.h | 2 +- .../RedfishETagDxe/RedfishETagDxe.h | 4 +- .../ConverterLib/src/RedfishCsCommon.c | 4 + .../Features/Bios/v1_0_9/Common/BiosCommon.c | 13 +- .../Features/Bios/v1_0_9/Dxe/BiosDxe.c | 3 +- .../v1_5_0/Common/ComputerSystemCommon.c | 12 +- .../v1_5_0/Dxe/ComputerSystemDxe.c | 3 +- .../ComputerSystemCollectionDxe.c | 5 +- .../Memory/V1_7_1/Common/MemoryCommon.c | 12 +- .../Features/Memory/V1_7_1/Dxe/MemoryDxe.c | 3 +- .../MemoryCollectionDxe/MemoryCollectionDxe.c | 5 +- .../EdkIIRedfishResourceConfigLib.c | 18 +- .../RedfishFeatureUtilityLib.c | 223 +++++++++++++++++- .../RedfishConfigLangMapDxe.c | 89 ++++--- .../RedfishETagDxe/RedfishETagDxe.c | 84 +++---- 19 files changed, 416 insertions(+), 160 deletions(-) --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111670): https://edk2.groups.io/g/devel/message/111670 Mute This Topic: https://groups.io/mt/102767537/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-