[edk2-devel] [edk2-redfish-client][PATCH 4/6] RedfishClientPkg/ConverterLib: fix empty attribute value issue

[edk2-devel] [edk2-redfish-client][PATCH 4/6] RedfishClientPkg/ConverterLib: fix empty attribute value issue

[Nickle Wang via groups.io]

When attribute is empty string, converter library creates NULL
attribute value in C structure instead of empty string.

Signed-off-by: Nickle Wang <nicklew@nvidia.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Cc: Nick Ramirez <nramirez@nvidia.com>
---
 RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c b/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c
index 02fcb2b2..7c2fa3c9 100644
--- a/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c
+++ b/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c
@@ -1,6 +1,7 @@
 /** @file
 
   (C) Copyright 2018-2022 Hewlett Packard Enterprise Development LP<BR>
+  Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
@@ -446,6 +447,9 @@ CreateEmptyPropCsJson (
     if (TempJsonObj == NULL) {
       return RedfishCS_status_not_found;
     }
+  } else {
+    // Dump JSON from JsonObj.
+    TempJsonObj = JsonObj;
   }
 
   Status = allocateRecordCsMemory (Cs, sizeof (RedfishCS_Type_EmptyProp_CS_Data), (void **)&CsTypeEmptyPropCS);
-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111674): https://edk2.groups.io/g/devel/message/111674
Mute This Topic: https://groups.io/mt/102767546/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-redfish-client][PATCH 4/6] RedfishClientPkg/ConverterLib: fix empty attribute value issue

[Chang, Abner via groups.io]

[AMD Official Use Only - General]

Reviewed-by: Abner Chang <abner.chang@amd.com>

> -----Original Message-----
> From: Nickle Wang <nicklew@nvidia.com>
> Sent: Thursday, November 23, 2023 10:34 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; Igor Kulchytskyy
> <igork@ami.com>; Nick Ramirez <nramirez@nvidia.com>
> Subject: [edk2-redfish-client][PATCH 4/6] RedfishClientPkg/ConverterLib: fix
> empty attribute value issue
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> When attribute is empty string, converter library creates NULL
> attribute value in C structure instead of empty string.
>
> Signed-off-by: Nickle Wang <nicklew@nvidia.com>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Cc: Nick Ramirez <nramirez@nvidia.com>
> ---
>  RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c
> b/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c
> index 02fcb2b2..7c2fa3c9 100644
> --- a/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c
> +++ b/RedfishClientPkg/ConverterLib/src/RedfishCsCommon.c
> @@ -1,6 +1,7 @@
>  /** @file
>
>    (C) Copyright 2018-2022 Hewlett Packard Enterprise Development LP<BR>
> +  Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights
> reserved.
>
>    SPDX-License-Identifier: BSD-2-Clause-Patent
>
> @@ -446,6 +447,9 @@ CreateEmptyPropCsJson (
>      if (TempJsonObj == NULL) {
>        return RedfishCS_status_not_found;
>      }
> +  } else {
> +    // Dump JSON from JsonObj.
> +    TempJsonObj = JsonObj;
>    }
>
>    Status = allocateRecordCsMemory (Cs, sizeof
> (RedfishCS_Type_EmptyProp_CS_Data), (void **)&CsTypeEmptyPropCS);
> --
> 2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111792): https://edk2.groups.io/g/devel/message/111792
Mute This Topic: https://groups.io/mt/102767546/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-