From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 74393D80733 for ; Mon, 27 Nov 2023 05:31:51 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=BsU9252HxnrzUcvBis6ck6c9WKdK9t5vf6KaPGXPypY=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1701063110; v=1; b=LTpaeeD8mz/2rDWb96rSPBkdeQJ/uTycUlYXpUqekhENcYitPRVykCVfuZ/r2CBQbiSWX5Aw xdJHu2OtsMcgZXu8p9pUZ7h/pSGUCWOGmydmjzqbkXZBfQjNxCbjEQMqanxrhI+zynD24aYmI4V mtPRHIkuu9fP6XA+Pn9rHVC8= X-Received: by 127.0.0.2 with SMTP id Y9yPYY7687511xvFg9pm5Fh9; Sun, 26 Nov 2023 21:31:50 -0800 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.47]) by mx.groups.io with SMTP id smtpd.web10.87212.1701063109502958050 for ; Sun, 26 Nov 2023 21:31:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oa28gDWqYslCiMyu0IbeYU+SnLWAVEsVZGYvACDD6ueVTtNjdV2wbYjnjVU0gxc7CPjTbBeavIBKlfkk3FvRGfi+iaElYIhY3+6yO4OQgDcUno9CqY5BKFOOXa+kc3LXmUz/iTVrcqAKo8Ckx+dAkOJAWuivp/NaT1oD+HVlTnDLMn2th7RYJLydwBy7k0A0hXoCYS8m0ogyOks4r59ocU9etMheiWGHQXwQ9toJAaK9EWWdbCUFS+m5WuSomJCGopiTMajP2lBIZdKvCkkztSewO8znGsYvH+2T24t/nGSdOm2lUr7+Gsa3L/FoIPIHMfRb93e8YtZoYX6FYPU77g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bheeMP4Yli9NPYFa5zp50l7a+BcijBVoYgFNc/it18k=; b=XLnMd93niiaF11+5OgBHVFeM/mak3rPaO8di53aTQUVNMItgHI1hlAJtBIQ8RkwkugBs8oePkScgO37Vuzpa0uAyLediE1VAPZQ/umHTDYK2KGs4tCGuyUUhpI9BqVqBFkR6XE1Xs8Pzdku2lUaat44oSIX4R1rqJ1ZKMbcU4cei/8OCAzfwMcnms8WMXDIDwLllwhTCEs2HPidehy92T5q7VOMZh+dtcuu0txNhHTg4TKgIw75nKimeBp8yOX06bMk6xBEGWc8AGMjn3z1bZIGpebOGh+0rkdz7KQaqn/aSPJwfvmdt1fmzZ59JXF/3TjwrrxV8ynqMtEOuRrpc0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from SA0PR11CA0103.namprd11.prod.outlook.com (2603:10b6:806:d1::18) by MN2PR12MB4109.namprd12.prod.outlook.com (2603:10b6:208:1d9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.27; Mon, 27 Nov 2023 05:31:47 +0000 X-Received: from SN1PEPF0002BA52.namprd03.prod.outlook.com (2603:10b6:806:d1:cafe::30) by SA0PR11CA0103.outlook.office365.com (2603:10b6:806:d1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.27 via Frontend Transport; Mon, 27 Nov 2023 05:31:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by SN1PEPF0002BA52.mail.protection.outlook.com (10.167.242.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7046.17 via Frontend Transport; Mon, 27 Nov 2023 05:31:46 +0000 X-Received: from TPE-L1-ABNCHANG.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Sun, 26 Nov 2023 23:31:41 -0600 From: "Chang, Abner via groups.io" To: CC: Nickle Wang , Igor Kulchytskyy , Mike Maslenkin Subject: [edk2-devel] [PATCH V3 9/9] RedfishPkg/HostInterfaceBmcUsbNic: Fix potential memory corruption issue Date: Mon, 27 Nov 2023 13:31:07 +0800 Message-ID: <20231127053107.1686-10-abner.chang@amd.com> In-Reply-To: <20231127053107.1686-1-abner.chang@amd.com> References: <20231127053107.1686-1-abner.chang@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002BA52:EE_|MN2PR12MB4109:EE_ X-MS-Office365-Filtering-Correlation-Id: c9b69de8-40e4-49a0-6ae8-08dbef0a25fd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: 0PL05qMJbuldQ5n/2w5CN8CeCBi+9Ac8jV50FeAq3cfH2qLL02Yag23RQGAjWPjoBg8OwDh7LFUldGSPqNY+Utr4+IV84QBSfKgMzPZCPEwlGLrZdRkXpV8H+jyQUie59/0uH9+UJMe3JSkDi1FTP1oYIg5BpgsGEAzFm+EKJ4ObKAXp9IeHnkQoN9oC+6ln8yUorA4t5mWNfQoNjG4LCMbCwoK4igOhfQzQHOFbKNEJeBVTfj9su4gWy3KS+RBZsXBtalboEFGw9JZURdZ7avaEEdkHF0hl92xJZ/SmT2Ku1LPRtq8hZTSSE75UEz7+oJpwyPoB5a9r/Q5ROTql1MqA6izLYLR2BsDPjZND4Ez1nINbIEPyW6hcx6oRY3daJdc6vwYpZmV3wMUS3ovdwQcSXfivDudVTMoJTsYv5VQvj8wo+mqEzkoRwzDd2Q8SJukKYU8/hpGIpko+DXeFiFSj/iIpsnVI2MrRQn73TZWE1LwI397jNVgSEISIj75gzvoSuYjTyA80cu79fp3knKfKWuwDvaSxy5ubCxHmZemFAOSw4gqTLPSv/vDvqmKnZINlowevtJZc2B5r2mDfAnBvvMJLuXFc1yGpYhzXP19n6OW007oX9W1VWB9cRzvKoSb7spIlX8YcQ+HN50Irc3Bv0qO+cEoNDWfXXq01Yv8Q4qOdb3rRii4miwoOSRusS0Vx7d680disqdu6yIb3+W4ry93KkWu0sWN3nHaQmACYst/BQrlEDzOzn1eve+Hs/eGErCFBF7Teq4bwKbQYd/Jqpo3P86P3VhSuEQ95eOU= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2023 05:31:46.8508 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c9b69de8-40e4-49a0-6ae8-08dbef0a25fd X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002BA52.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4109 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ra3Ju3SXkNnXU3rPxtanfZAfx7686176AA= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=LTpaeeD8; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") From: Abner Chang Wrong memory allocation issue may result in memory corruption. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Mike Maslenkin --- .../PlatformHostInterfaceBmcUsbNicLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformH= ostInterfaceBmcUsbNicLib.c b/RedfishPkg/Library/PlatformHostInterfaceBmcUsb= NicLib/PlatformHostInterfaceBmcUsbNicLib.c index a1ce2dd3d93..2938d54da65 100644 --- a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInte= rfaceBmcUsbNicLib.c +++ b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInte= rfaceBmcUsbNicLib.c @@ -1060,7 +1060,7 @@ IdentifyUsbNicBmcChannel ( =20 InitializeListHead (&BmcUsbNic->NextInstance); BmcUsbNic->MacAddressSize =3D Snp->Mode->HwAddressSize; - BmcUsbNic->MacAddress =3D AllocateZeroPool (sizeof (BmcUsbNic->MacAd= dressSize)); + BmcUsbNic->MacAddress =3D AllocatePool (BmcUsbNic->MacAddressSize); if (BmcUsbNic->MacAddress =3D=3D NULL) { DEBUG ((DEBUG_ERROR, " Failed to allocate memory for HW MAC address= s.\n")); FreePool (BmcUsbNic); @@ -1133,7 +1133,7 @@ CheckBmcUsbNicOnHandles ( (VOID **)&DevicePath ); if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, " Failed to locate device path on %d handle.= \n", __func__, Index)); + DEBUG ((DEBUG_ERROR, " Failed to locate device path on %d handle.= \n", Index)); continue; } =20 --=20 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111724): https://edk2.groups.io/g/devel/message/111724 Mute This Topic: https://groups.io/mt/102824324/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-