From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id DC84CD80F77 for ; Mon, 27 Nov 2023 05:31:52 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=pVYHtW1DMobuYqdZF+adlXrF1HEOKioZmZPvmFv2qMU=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1701063111; v=1; b=e6pR8So03kuLJXMvSSRRiHa9cewptFHjT8pChPwvb10afYM6cmw52Ave+8N3FbSLyLn+rDnM Pz9yNKy7U+DbfjvmctCUvYGa3imx6vEnC46lju/p4kJcfEnrG8a5IhfOkr4EkEBmjYr7DmrMLQN 8IqmC9+g3bklRdXhEYsPyilc= X-Received: by 127.0.0.2 with SMTP id LiuZYY7687511xHVjXuXTkxq; Sun, 26 Nov 2023 21:31:51 -0800 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.84]) by mx.groups.io with SMTP id smtpd.web10.87214.1701063110898322115 for ; Sun, 26 Nov 2023 21:31:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GNtJsygdcClieEb2WdIkzc9T7mDCi52RW3OOWQoUeNEYXIueXw8FNY6RHi3AyApqudpoDPIwmsNIuzX4BYPnm3ON/49Q+x8hMPZ3RcdZ+GNgO9y7nxoBe/UZmY6XkZL5FnvDoqqET1tBQThcIkYFkRD6M1FMNSMiGHng76tkVBJ5feq7hQol/O4L88MmFAOuLa8/uwgby4V5Pf5c16xThaJSyUmodPcYDxXLdGvvOI8i1dnVPv9nC/jTFX9ndxJYSbg+CdcAZ9cz35rOorZD0cn+WiUcPJOZqI7kcnYUii1UTRmPmdjjZnDSPQqTchna6iLy1vC7fURZ09LdQHvjwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZNGE/E8DPxHY7ypxpAPE1BtIyFzv49eXI+C2+U/uBOc=; b=V1QLYPtzwXpJQ5M1Gfw2Ep/pHdMP5Q+MDPWxiBWVj7Y2CeyE6o40QLKQQMIJZUoTSgU1Nv2IQCMmcaL3d6TKFPLyZnB4+eJH/HjoCD46Fw03eN1SudM1e4JqFEZnpyPo/b56vyGheU3gKzL6b2rii8OIj4iibtFqmxA2GXCrx7LcLqe2Ppgne+DDG+WjldDqQZvQ7+mK4s0i8r1z0RriKzCpUF8ZK7VYeul6+MPnu+DbYHB5pceZGzxSOdG4onLbrenzVaTFPKmykwitgo8GJL/ScuvUePRj5r9RQxtmv6lQP8+ut3sIiioAyDDUmlykqr5iZ68pdMnSyPCi7KcuGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from SA0PR11CA0118.namprd11.prod.outlook.com (2603:10b6:806:d1::33) by PH7PR12MB6489.namprd12.prod.outlook.com (2603:10b6:510:1f7::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.27; Mon, 27 Nov 2023 05:31:45 +0000 X-Received: from SN1PEPF0002BA52.namprd03.prod.outlook.com (2603:10b6:806:d1:cafe::cb) by SA0PR11CA0118.outlook.office365.com (2603:10b6:806:d1::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.29 via Frontend Transport; Mon, 27 Nov 2023 05:31:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by SN1PEPF0002BA52.mail.protection.outlook.com (10.167.242.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7046.17 via Frontend Transport; Mon, 27 Nov 2023 05:31:45 +0000 X-Received: from TPE-L1-ABNCHANG.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Sun, 26 Nov 2023 23:31:40 -0600 From: "Chang, Abner via groups.io" To: CC: Nickle Wang , Igor Kulchytskyy , Mike Maslenkin Subject: [edk2-devel] [PATCH V3 8/9] RedfishPkg/HostInterfaceBmcUsbNic: Fix incorrect HI protocol record size Date: Mon, 27 Nov 2023 13:31:06 +0800 Message-ID: <20231127053107.1686-9-abner.chang@amd.com> In-Reply-To: <20231127053107.1686-1-abner.chang@amd.com> References: <20231127053107.1686-1-abner.chang@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002BA52:EE_|PH7PR12MB6489:EE_ X-MS-Office365-Filtering-Correlation-Id: 23b71ea0-a76b-425e-633f-08dbef0a24f2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: QHtgsptNbJNHwap3UdR+C73j3AnVdPQqCy6CKdATiXduaOFrV2cpmqnC/fsEA0pPu1UA4B+z7yzf2ZZlBPT9kLCQV+XEpX8tSsZFhi33GXrHGQxXgf6fME+bO5yPLn+i0OSHbKoUzXW3qViy0+EXP8E3TAnYVShds9m+FY4kpS075olQrXQpIwIbXbp33cM+SdZCQ6g8fDccNKgT1ugaA3NeavmSuSnATLFgGg9WWLTul4/doh7ank035eiU6MEdbvpgUY9WteOQqrqwBUOnESUSJhRjIiQAcHRR9W6X01uxhLR+7oCxKSV2BADFgar2PiFggkzS95hmMkjFf9iLCI1MYTUOu3bNhezzTtGWuhA0sGUY24tyPfiT9r5S67aY2c+B6WAgelTeZ6A9vxlL4ArBGjd2Dykp5YF7YPX+cIF7Aso65iq4kGqDFxVgpBesX+Kmdi2pDndZSZkpZuIhET9XqjtCeWF2gDuBXnYquNhh+AyB1bRhqDoXX14nAdX6PTx9KPlTam2Za2ztJWyqlg+CknLOZDGV2yUWdWZBafeqonUfGpt3lp0Nre7u2ddnFJ2RfiArO+/umGOkgtL59CVBreaFYEHUXpTcB0JOw+6P4uP6/lz6dgk/AW2rIBu5BHRrCfNZ2KJWbLDZeoITIsNy9ucysLZsmPoECpgZhb5S0aZtRrd8RmFnBDB7+7cMuH8E0GDcAOXjFM518jSJEaGOwUf8vGpr+s0W/OFA/qRowaHkxigIYGwuiWu0b55T9c2TlF9M1m47r1XfRAavZSHwEiz5/wAcfmQvfOq3lxA= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2023 05:31:45.1008 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 23b71ea0-a76b-425e-633f-08dbef0a24f2 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002BA52.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6489 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: gJUQYNecp4hYgPEweje6E81Hx7686176AA= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=e6pR8So0; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") From: Abner Chang The size of structure must be minus with byte that is occupied by the initial array. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Mike Maslenkin --- .../PlatformHostInterfaceBmcUsbNicLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformH= ostInterfaceBmcUsbNicLib.c b/RedfishPkg/Library/PlatformHostInterfaceBmcUsb= NicLib/PlatformHostInterfaceBmcUsbNicLib.c index c4a71226e63..a1ce2dd3d93 100644 --- a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInte= rfaceBmcUsbNicLib.c +++ b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInte= rfaceBmcUsbNicLib.c @@ -180,7 +180,7 @@ RedfishPlatformHostInterfaceProtocolData ( HostNameLength =3D (UINT8)AsciiStrSize (HostNameString); ThisProtocolRecord =3D (MC_HOST_INTERFACE_PROTOCOL_RECORD *)Allocate= ZeroPool ( sizeof (= MC_HOST_INTERFACE_PROTOCOL_RECORD) - 1 + - sizeof (= REDFISH_OVER_IP_PROTOCOL_DATA) + + sizeof (= REDFISH_OVER_IP_PROTOCOL_DATA) - 1 + HostName= Length ); if (ThisProtocolRecord =3D=3D NULL) { @@ -189,7 +189,7 @@ RedfishPlatformHostInterfaceProtocolData ( } =20 ThisProtocolRecord->ProtocolType =3D MCHostInterfaceProtocolT= ypeRedfishOverIP; - ThisProtocolRecord->ProtocolTypeDataLen =3D sizeof (REDFISH_OVER_IP_= PROTOCOL_DATA) + HostNameLength; + ThisProtocolRecord->ProtocolTypeDataLen =3D sizeof (REDFISH_OVER_IP_= PROTOCOL_DATA) -1 + HostNameLength; RedfishOverIpData =3D (REDFISH_OVER_IP_PROTOCO= L_DATA *)&ThisProtocolRecord->ProtocolTypeData[0]; // // Fill up REDFISH_OVER_IP_PROTOCOL_DATA --=20 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111725): https://edk2.groups.io/g/devel/message/111725 Mute This Topic: https://groups.io/mt/102824325/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-