* [edk2-devel] [edk2-platforms][PATCH] MinPlatformPkg: should build Performance driver only when perf enabled
@ 2023-11-28 5:09 Li, Yi
2023-11-30 1:33 ` Nate DeSimone
2023-11-30 1:36 ` Nate DeSimone
0 siblings, 2 replies; 3+ messages in thread
From: Li, Yi @ 2023-11-28 5:09 UTC (permalink / raw)
To: devel; +Cc: Yi Li, Chasel Chiu, Nate DeSimone, Liming Gao, Eric Dong
Should build FirmwarePerformancePei only when perf enabled.
Avoiding unconditional compilation of performance PEI drivers can
save 2KB(LZMA compressed) in PostMem FV, small but important.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Yi Li <yi1.li@intel.com>
---
.../MinPlatformPkg/Include/Fdf/CorePostMemoryInclude.fdf | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Platform/Intel/MinPlatformPkg/Include/Fdf/CorePostMemoryInclude.fdf b/Platform/Intel/MinPlatformPkg/Include/Fdf/CorePostMemoryInclude.fdf
index 3edc239e5..bc8ebc84b 100644
--- a/Platform/Intel/MinPlatformPkg/Include/Fdf/CorePostMemoryInclude.fdf
+++ b/Platform/Intel/MinPlatformPkg/Include/Fdf/CorePostMemoryInclude.fdf
@@ -1,12 +1,14 @@
## @file
# FDF file of Platform.
#
-# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2023, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
##
!if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly == FALSE
- INF MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTablePei/FirmwarePerformancePei.inf
+ !if gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable == TRUE
+ INF MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTablePei/FirmwarePerformancePei.inf
+ !endif
!endif
--
2.42.0.windows.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111793): https://edk2.groups.io/g/devel/message/111793
Mute This Topic: https://groups.io/mt/102845821/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH] MinPlatformPkg: should build Performance driver only when perf enabled
2023-11-28 5:09 [edk2-devel] [edk2-platforms][PATCH] MinPlatformPkg: should build Performance driver only when perf enabled Li, Yi
@ 2023-11-30 1:33 ` Nate DeSimone
2023-11-30 1:36 ` Nate DeSimone
1 sibling, 0 replies; 3+ messages in thread
From: Nate DeSimone @ 2023-11-30 1:33 UTC (permalink / raw)
To: Li, Yi1, devel@edk2.groups.io; +Cc: Chiu, Chasel, Gao, Liming, Dong, Eric
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
-----Original Message-----
From: Li, Yi1 <yi1.li@intel.com>
Sent: Monday, November 27, 2023 9:09 PM
To: devel@edk2.groups.io
Cc: Li, Yi1 <yi1.li@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
Subject: [edk2-platforms][PATCH] MinPlatformPkg: should build Performance driver only when perf enabled
Should build FirmwarePerformancePei only when perf enabled.
Avoiding unconditional compilation of performance PEI drivers can save 2KB(LZMA compressed) in PostMem FV, small but important.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Yi Li <yi1.li@intel.com>
---
.../MinPlatformPkg/Include/Fdf/CorePostMemoryInclude.fdf | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Platform/Intel/MinPlatformPkg/Include/Fdf/CorePostMemoryInclude.fdf b/Platform/Intel/MinPlatformPkg/Include/Fdf/CorePostMemoryInclude.fdf
index 3edc239e5..bc8ebc84b 100644
--- a/Platform/Intel/MinPlatformPkg/Include/Fdf/CorePostMemoryInclude.fdf
+++ b/Platform/Intel/MinPlatformPkg/Include/Fdf/CorePostMemoryInclude.fd
+++ f
@@ -1,12 +1,14 @@
## @file
# FDF file of Platform.
#
-# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2023, Intel Corporation. All rights
+reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent # ##
!if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly == FALSE
- INF MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTablePei/FirmwarePerformancePei.inf
+ !if gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable == TRUE
+ INF
+ MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTablePei/FirmwarePe
+ rformancePei.inf
+ !endif
!endif
--
2.42.0.windows.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111876): https://edk2.groups.io/g/devel/message/111876
Mute This Topic: https://groups.io/mt/102845821/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH] MinPlatformPkg: should build Performance driver only when perf enabled
2023-11-28 5:09 [edk2-devel] [edk2-platforms][PATCH] MinPlatformPkg: should build Performance driver only when perf enabled Li, Yi
2023-11-30 1:33 ` Nate DeSimone
@ 2023-11-30 1:36 ` Nate DeSimone
1 sibling, 0 replies; 3+ messages in thread
From: Nate DeSimone @ 2023-11-30 1:36 UTC (permalink / raw)
To: Li, Yi1, devel@edk2.groups.io; +Cc: Chiu, Chasel, Gao, Liming, Dong, Eric
Pushed as 4e34823
-----Original Message-----
From: Li, Yi1 <yi1.li@intel.com>
Sent: Monday, November 27, 2023 9:09 PM
To: devel@edk2.groups.io
Cc: Li, Yi1 <yi1.li@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Eric <eric.dong@intel.com>
Subject: [edk2-platforms][PATCH] MinPlatformPkg: should build Performance driver only when perf enabled
Should build FirmwarePerformancePei only when perf enabled.
Avoiding unconditional compilation of performance PEI drivers can save 2KB(LZMA compressed) in PostMem FV, small but important.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Yi Li <yi1.li@intel.com>
---
.../MinPlatformPkg/Include/Fdf/CorePostMemoryInclude.fdf | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Platform/Intel/MinPlatformPkg/Include/Fdf/CorePostMemoryInclude.fdf b/Platform/Intel/MinPlatformPkg/Include/Fdf/CorePostMemoryInclude.fdf
index 3edc239e5..bc8ebc84b 100644
--- a/Platform/Intel/MinPlatformPkg/Include/Fdf/CorePostMemoryInclude.fdf
+++ b/Platform/Intel/MinPlatformPkg/Include/Fdf/CorePostMemoryInclude.fd
+++ f
@@ -1,12 +1,14 @@
## @file
# FDF file of Platform.
#
-# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2023, Intel Corporation. All rights
+reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent # ##
!if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly == FALSE
- INF MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTablePei/FirmwarePerformancePei.inf
+ !if gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable == TRUE
+ INF
+ MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTablePei/FirmwarePe
+ rformancePei.inf
+ !endif
!endif
--
2.42.0.windows.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111877): https://edk2.groups.io/g/devel/message/111877
Mute This Topic: https://groups.io/mt/102845821/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-30 1:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-28 5:09 [edk2-devel] [edk2-platforms][PATCH] MinPlatformPkg: should build Performance driver only when perf enabled Li, Yi
2023-11-30 1:33 ` Nate DeSimone
2023-11-30 1:36 ` Nate DeSimone
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox