public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-devel] [PATCH v1 1/1] BaseTools/Conf/target.template: Use VS2019 as default tool chain
@ 2023-11-28 19:48 Michael Kubacki
  2023-11-29  5:31 ` Yuwei Chen
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Kubacki @ 2023-11-28 19:48 UTC (permalink / raw)
  To: devel; +Cc: Bob Feng, Liming Gao, Rebecca Cran, Yuwei Chen

From: Michael Kubacki <michael.kubacki@microsoft.com>

Updates the default tool chain from VS2015x86 to VS2019.

This is the VS tool chain used in CI and more likely to be installed
on developer's systems. This is used in stuart commands when a
toolchain is not explicitly specified.

Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 BaseTools/Conf/target.template | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/BaseTools/Conf/target.template b/BaseTools/Conf/target.template
index d4a3b53b7f3e..592febf55762 100644
--- a/BaseTools/Conf/target.template
+++ b/BaseTools/Conf/target.template
@@ -22,8 +22,8 @@ ACTIVE_PLATFORM       = EmulatorPkg/EmulatorPkg.dsc
 #  TARGET                List       Optional    Zero or more of the following: DEBUG, RELEASE, NOOPT
 #                                               UserDefined; separated by a space character.
 #                                               If the line is missing or no value is specified, all
-#                                               valid targets specified in the platform description file 
-#                                               will attempt to be built. The following line will build 
+#                                               valid targets specified in the platform description file
+#                                               will attempt to be built. The following line will build
 #                                               DEBUG platform target.
 TARGET                = DEBUG
 
@@ -32,7 +32,7 @@ TARGET                = DEBUG
 #                                               or AArch64.
 #                                               Multiple values can be specified on a single line, using
 #                                               space characters to separate the values.  These are used
-#                                               during the parsing of a platform description file, 
+#                                               during the parsing of a platform description file,
 #                                               restricting the build output target(s.)
 #                                               The Build Target ARCH is determined by (precedence high to low):
 #                                                 Command-line: -a ARCH option
@@ -51,7 +51,7 @@ TOOL_CHAIN_CONF       = Conf/tools_def.txt
 #  TAGNAME               List      Optional   Specify the name(s) of the tools_def.txt TagName to use.
 #                                             If not specified, all applicable TagName tools will be
 #                                             used for the build.  The list uses space character separation.
-TOOL_CHAIN_TAG        = VS2015x86
+TOOL_CHAIN_TAG        = VS2019
 
 # MAX_CONCURRENT_THREAD_NUMBER  NUMBER  Optional  The number of concurrent threads. If not specified or set
 #                                                 to zero, tool automatically detect number of processor
@@ -64,7 +64,7 @@ TOOL_CHAIN_TAG        = VS2015x86
 
 
 # BUILD_RULE_CONF  Filename Optional  Specify the file name to use for the build rules that are followed
-#                                     when generating Makefiles. If not specified, the file: 
+#                                     when generating Makefiles. If not specified, the file:
 #                                     WORKSPACE/Conf/build_rule.txt will be used
 BUILD_RULE_CONF = Conf/build_rule.txt
 
-- 
2.42.0.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111825): https://edk2.groups.io/g/devel/message/111825
Mute This Topic: https://groups.io/mt/102858057/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [edk2-devel] [PATCH v1 1/1] BaseTools/Conf/target.template: Use VS2019 as default tool chain
  2023-11-28 19:48 [edk2-devel] [PATCH v1 1/1] BaseTools/Conf/target.template: Use VS2019 as default tool chain Michael Kubacki
@ 2023-11-29  5:31 ` Yuwei Chen
  0 siblings, 0 replies; 2+ messages in thread
From: Yuwei Chen @ 2023-11-29  5:31 UTC (permalink / raw)
  To: mikuback@linux.microsoft.com, devel@edk2.groups.io
  Cc: Feng, Bob C, Gao, Liming, Rebecca Cran

Reviewed-by: Yuwei Chen <yuwei.chen@intel.com>

> -----Original Message-----
> From: mikuback@linux.microsoft.com <mikuback@linux.microsoft.com>
> Sent: Wednesday, November 29, 2023 3:49 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Rebecca Cran <rebecca@bsdio.com>; Chen,
> Christine <yuwei.chen@intel.com>
> Subject: [PATCH v1 1/1] BaseTools/Conf/target.template: Use VS2019 as
> default tool chain
> 
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> Updates the default tool chain from VS2015x86 to VS2019.
> 
> This is the VS tool chain used in CI and more likely to be installed on
> developer's systems. This is used in stuart commands when a toolchain is not
> explicitly specified.
> 
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>  BaseTools/Conf/target.template | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/BaseTools/Conf/target.template b/BaseTools/Conf/target.template
> index d4a3b53b7f3e..592febf55762 100644
> --- a/BaseTools/Conf/target.template
> +++ b/BaseTools/Conf/target.template
> @@ -22,8 +22,8 @@ ACTIVE_PLATFORM       = EmulatorPkg/EmulatorPkg.dsc
>  #  TARGET                List       Optional    Zero or more of the following: DEBUG,
> RELEASE, NOOPT
>  #                                               UserDefined; separated by a space character.
>  #                                               If the line is missing or no value is specified, all
> -#                                               valid targets specified in the platform description
> file
> -#                                               will attempt to be built. The following line will
> build
> +#                                               valid targets specified in the platform description
> file
> +#                                               will attempt to be built. The following line will
> build
>  #                                               DEBUG platform target.
>  TARGET                = DEBUG
> 
> @@ -32,7 +32,7 @@ TARGET                = DEBUG
>  #                                               or AArch64.
>  #                                               Multiple values can be specified on a single line,
> using
>  #                                               space characters to separate the values.  These
> are used
> -#                                               during the parsing of a platform description file,
> +#                                               during the parsing of a platform description file,
>  #                                               restricting the build output target(s.)
>  #                                               The Build Target ARCH is determined by
> (precedence high to low):
>  #                                                 Command-line: -a ARCH option
> @@ -51,7 +51,7 @@ TOOL_CHAIN_CONF       = Conf/tools_def.txt
>  #  TAGNAME               List      Optional   Specify the name(s) of the tools_def.txt
> TagName to use.
>  #                                             If not specified, all applicable TagName tools will
> be
>  #                                             used for the build.  The list uses space character
> separation.
> -TOOL_CHAIN_TAG        = VS2015x86
> +TOOL_CHAIN_TAG        = VS2019
> 
>  # MAX_CONCURRENT_THREAD_NUMBER  NUMBER  Optional  The number
> of concurrent threads. If not specified or set
>  #                                                 to zero, tool automatically detect number of
> processor
> @@ -64,7 +64,7 @@ TOOL_CHAIN_TAG        = VS2015x86
> 
> 
>  # BUILD_RULE_CONF  Filename Optional  Specify the file name to use for the
> build rules that are followed
> -#                                     when generating Makefiles. If not specified, the file:
> +#                                     when generating Makefiles. If not specified, the file:
>  #                                     WORKSPACE/Conf/build_rule.txt will be used
>  BUILD_RULE_CONF = Conf/build_rule.txt
> 
> --
> 2.42.0.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111835): https://edk2.groups.io/g/devel/message/111835
Mute This Topic: https://groups.io/mt/102858057/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-11-29  5:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-28 19:48 [edk2-devel] [PATCH v1 1/1] BaseTools/Conf/target.template: Use VS2019 as default tool chain Michael Kubacki
2023-11-29  5:31 ` Yuwei Chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox