From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D1D6BD802DF for ; Fri, 1 Dec 2023 00:18:39 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6NZXb6uNszIoWaSdWaX5SKF7dZlJLo4BTb8dygNc0d8=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1701389918; v=1; b=CTfr2VM0vhX6W0tvmYhBhPArsIZnkyQzNUxxLL9oGE+rj+pbmsoyugFgku0zuv29hIDu8Q0Y kQiEn575+mpAGWzReVaOa8FT+fwXhSduPGL7+CTrudEs2ijFj2dInvHui47Yz8du//g4pzxQl+M tBSDlWh0WyrQfKLKNy78Cwxo= X-Received: by 127.0.0.2 with SMTP id wAZjYY7687511xgYkNEc05cv; Thu, 30 Nov 2023 16:18:38 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mx.groups.io with SMTP id smtpd.web10.11523.1701389917656105954 for ; Thu, 30 Nov 2023 16:18:37 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10910"; a="309874" X-IronPort-AV: E=Sophos;i="6.04,240,1695711600"; d="scan'208";a="309874" X-Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2023 16:18:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10910"; a="1016824153" X-IronPort-AV: E=Sophos;i="6.04,240,1695711600"; d="scan'208";a="1016824153" X-Received: from nldesimo-desk.amr.corp.intel.com ([10.241.240.67]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2023 16:18:36 -0800 From: "Nate DeSimone" To: devel@edk2.groups.io Cc: Chasel Chiu , Ray Ni , Sai Chaganty , Liming Gao , Michael D Kinney , Kelly Steele , Taylor Beebe , Michael Kubacki Subject: [edk2-devel] [edk2-platforms][PATCH v1] QuarkPlatformPkg: Fix DxeCore Build Failures Date: Thu, 30 Nov 2023 16:18:21 -0800 Message-Id: <20231201001822.3346-1-nathaniel.l.desimone@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: jloWCDHkIebXob16aVPN5dO9x7686176AA= Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=CTfr2VM0; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) Commit 7284c44 in edk2 introduces an incompatibility that causes any project that uses DxeMain.inf to fail to build. This is due to the addition of ImagePropertiesRecordLib, and a new added dependency on that library in DxeMain. Platforms will not have this LibraryClass defined in their DSC yet and hence currently fail to build. This changes addes ImagePropertiesRecordLib to QuarkPlatformPkg and resolves the build failure. Cc: Chasel Chiu Cc: Ray Ni Cc: Sai Chaganty Cc: Liming Gao Cc: Michael D Kinney Cc: Kelly Steele Cc: Taylor Beebe Cc: Michael Kubacki Signed-off-by: Nate DeSimone --- Platform/Intel/QuarkPlatformPkg/Quark.dsc | 1 + Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 1 + 2 files changed, 2 insertions(+) diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc b/Platform/Intel/QuarkPlatformPkg/Quark.dsc index 7cc548058a..40d9768336 100644 --- a/Platform/Intel/QuarkPlatformPkg/Quark.dsc +++ b/Platform/Intel/QuarkPlatformPkg/Quark.dsc @@ -196,6 +196,7 @@ !endif FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf + ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf # # CPU diff --git a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc index 59577eda4f..67472930c9 100644 --- a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc +++ b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc @@ -167,6 +167,7 @@ !endif CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf + ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf # # CPU -- 2.39.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111927): https://edk2.groups.io/g/devel/message/111927 Mute This Topic: https://groups.io/mt/102906246/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-