From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5B6FE941543 for ; Wed, 6 Dec 2023 10:01:37 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=UcdD68ehppCHwNP47wmqTy+3BulabtVPTp38TZXHusw=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe; s=20140610; t=1701856896; v=1; b=rlBhMzYkv2Xrb4JFo+woN3T2hYasEHUvXnqFJNKp0UrdKxMxguoizoPMxrywzoD7gNAkH4Mi zYnCG1puWa14276NiFusSRwREH0Se/EwgEsAfhQFOTv0dm93UrPSJcWXLOoSRzAj/JaRsHiCb8P L9hv3pdR3E3dYEanvCaubbQ0= X-Received: by 127.0.0.2 with SMTP id MZy4YY7687511x77AwDhVZZA; Wed, 06 Dec 2023 02:01:36 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by mx.groups.io with SMTP id smtpd.web11.28132.1701856892226271583 for ; Wed, 06 Dec 2023 02:01:35 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10915"; a="1130568" X-IronPort-AV: E=Sophos;i="6.04,254,1695711600"; d="scan'208";a="1130568" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2023 02:01:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10915"; a="841775357" X-IronPort-AV: E=Sophos;i="6.04,254,1695711600"; d="scan'208";a="841775357" X-Received: from sh1gapp1009.ccr.corp.intel.com ([10.239.189.219]) by fmsmga004.fm.intel.com with ESMTP; 06 Dec 2023 02:01:32 -0800 From: "Wu, Jiaxin" To: devel@edk2.groups.io Cc: Laszlo Ersek , Eric Dong , Ray Ni , Zeng Star , Gerd Hoffmann , Rahul Kumar Subject: [edk2-devel] [PATCH v3 3/6] UefiCpuPkg: Implements SmmCpuSyncLib library instance Date: Wed, 6 Dec 2023 18:01:19 +0800 Message-Id: <20231206100122.8028-4-jiaxin.wu@intel.com> In-Reply-To: <20231206100122.8028-1-jiaxin.wu@intel.com> References: <20231206100122.8028-1-jiaxin.wu@intel.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jiaxin.wu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: FvBroMIHJFlRqL9wct2oZbNhx7686176AA= X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=rlBhMzYk; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Implements SmmCpuSyncLib Library instance. The instance refers the existing SMM CPU driver (PiSmmCpuDxeSmm) sync implementation and behavior: 1.Abstract Counter and Run semaphores into SmmCpuSyncCtx. 2.Abstract CPU arrival count operation to SmmCpuSyncGetArrivedCpuCount(), SmmCpuSyncCheckInCpu(), SmmCpuSyncCheckOutCpu(), SmmCpuSyncLockDoor(). Implementation is aligned with existing SMM CPU driver. 3. Abstract SMM CPU Sync flow to: BSP: SmmCpuSyncReleaseOneAp --> AP: SmmCpuSyncWaitForBsp BSP: SmmCpuSyncWaitForAPs <-- AP: SmmCpuSyncReleaseBsp Semaphores release & wait during sync flow is same as existing SMM CPU driver. 4.Same operation to Counter and Run semaphores by leverage the atomic compare exchange. Cc: Laszlo Ersek Cc: Eric Dong Cc: Ray Ni Cc: Zeng Star Cc: Gerd Hoffmann Cc: Rahul Kumar Signed-off-by: Jiaxin Wu --- UefiCpuPkg/Library/SmmCpuSyncLib/SmmCpuSyncLib.c | 647 +++++++++++++++++++++ UefiCpuPkg/Library/SmmCpuSyncLib/SmmCpuSyncLib.inf | 39 ++ UefiCpuPkg/UefiCpuPkg.dsc | 3 + 3 files changed, 689 insertions(+) create mode 100644 UefiCpuPkg/Library/SmmCpuSyncLib/SmmCpuSyncLib.c create mode 100644 UefiCpuPkg/Library/SmmCpuSyncLib/SmmCpuSyncLib.inf diff --git a/UefiCpuPkg/Library/SmmCpuSyncLib/SmmCpuSyncLib.c b/UefiCpuPkg/Library/SmmCpuSyncLib/SmmCpuSyncLib.c new file mode 100644 index 0000000000..3c2835f8de --- /dev/null +++ b/UefiCpuPkg/Library/SmmCpuSyncLib/SmmCpuSyncLib.c @@ -0,0 +1,647 @@ +/** @file + SMM CPU Sync lib implementation. + The lib provides 3 sets of APIs: + 1. ContextInit/ContextDeinit/ContextReset: + ContextInit() is called in driver's entrypoint to allocate and initialize the SMM CPU Sync context. + ContextDeinit() is called in driver's unload function to deinitialize the SMM CPU Sync context. + ContextReset() is called before CPU exist SMI, which allows CPU to check into the next SMI from this point. + + 2. GetArrivedCpuCount/CheckInCpu/CheckOutCpu/LockDoor: + When SMI happens, all processors including BSP enter to SMM mode by calling CheckInCpu(). + The elected BSP calls LockDoor() so that CheckInCpu() will return the error code after that. + CheckOutCpu() can be called in error handling flow for the CPU who calls CheckInCpu() earlier. + GetArrivedCpuCount() returns the number of checked-in CPUs. + + 3. WaitForAPs/ReleaseOneAp/WaitForBsp/ReleaseBsp + WaitForAPs() & ReleaseOneAp() are called from BSP to wait the number of APs and release one specific AP. + WaitForBsp() & ReleaseBsp() are called from APs to wait and release BSP. + The 4 APIs are used to synchronize the running flow among BSP and APs. BSP and AP Sync flow can be + easy understand as below: + BSP: ReleaseOneAp --> AP: WaitForBsp + BSP: WaitForAPs <-- AP: ReleaseBsp + + Copyright (c) 2023, Intel Corporation. All rights reserved.
+ SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +typedef struct { + /// + /// Indicate how many CPU entered SMM. + /// + volatile UINT32 *Counter; +} SMM_CPU_SYNC_SEMAPHORE_GLOBAL; + +typedef struct { + /// + /// Used for control each CPU continue run or wait for signal + /// + volatile UINT32 *Run; +} SMM_CPU_SYNC_SEMAPHORE_CPU; + +struct SMM_CPU_SYNC_CONTEXT { + /// + /// All global semaphores' pointer in SMM CPU Sync + /// + SMM_CPU_SYNC_SEMAPHORE_GLOBAL *GlobalSem; + /// + /// All semaphores for each processor in SMM CPU Sync + /// + SMM_CPU_SYNC_SEMAPHORE_CPU *CpuSem; + /// + /// The number of processors in the system. + /// This does not indicate the number of processors that entered SMM. + /// + UINTN NumberOfCpus; + /// + /// Address of global and each CPU semaphores + /// + UINTN *SemBuffer; + /// + /// Size in bytes of global and each CPU semaphores + /// + UINTN SemBufferSize; +}; + +/** + Performs an atomic compare exchange operation to get semaphore. + The compare exchange operation must be performed using MP safe + mechanisms. + + @param[in,out] Sem IN: 32-bit unsigned integer + OUT: original integer - 1 + + @retval Original integer - 1 + +**/ +UINT32 +InternalWaitForSemaphore ( + IN OUT volatile UINT32 *Sem + ) +{ + UINT32 Value; + + for ( ; ;) { + Value = *Sem; + if ((Value != 0) && + (InterlockedCompareExchange32 ( + (UINT32 *)Sem, + Value, + Value - 1 + ) == Value)) + { + break; + } + + CpuPause (); + } + + return Value - 1; +} + +/** + Performs an atomic compare exchange operation to release semaphore. + The compare exchange operation must be performed using MP safe + mechanisms. + + @param[in,out] Sem IN: 32-bit unsigned integer + OUT: original integer + 1 + + @retval Original integer + 1 + +**/ +UINT32 +InternalReleaseSemaphore ( + IN OUT volatile UINT32 *Sem + ) +{ + UINT32 Value; + + do { + Value = *Sem; + } while (Value + 1 != 0 && + InterlockedCompareExchange32 ( + (UINT32 *)Sem, + Value, + Value + 1 + ) != Value); + + return Value + 1; +} + +/** + Performs an atomic compare exchange operation to lock semaphore. + The compare exchange operation must be performed using MP safe + mechanisms. + + @param[in,out] Sem IN: 32-bit unsigned integer + OUT: -1 + + @retval Original integer + +**/ +UINT32 +InternalLockdownSemaphore ( + IN OUT volatile UINT32 *Sem + ) +{ + UINT32 Value; + + do { + Value = *Sem; + } while (InterlockedCompareExchange32 ( + (UINT32 *)Sem, + Value, + (UINT32)-1 + ) != Value); + + return Value; +} + +/** + Create and initialize the SMM CPU Sync context. + + SmmCpuSyncContextInit() function is to allocate and initialize the SMM CPU Sync context. + + @param[in] NumberOfCpus The number of Logical Processors in the system. + @param[out] SmmCpuSyncCtx Pointer to the new created and initialized SMM CPU Sync context object. + NULL will be returned if any error happen during init. + + @retval RETURN_SUCCESS The SMM CPU Sync context was successful created and initialized. + @retval RETURN_INVALID_PARAMETER SmmCpuSyncCtx is NULL. + @retval RETURN_BUFFER_TOO_SMALL Overflow happen + @retval RETURN_OUT_OF_RESOURCES There are not enough resources available to create and initialize SMM CPU Sync context. + +**/ +RETURN_STATUS +EFIAPI +SmmCpuSyncContextInit ( + IN UINTN NumberOfCpus, + OUT SMM_CPU_SYNC_CONTEXT **SmmCpuSyncCtx + ) +{ + RETURN_STATUS Status; + UINTN CpuSemInCtxSize; + UINTN CtxSize; + UINTN OneSemSize; + UINTN GlobalSemSize; + UINTN OneCpuSemSize; + UINTN CpuSemSize; + UINTN TotalSemSize; + UINTN SemAddr; + UINTN CpuIndex; + + ASSERT (SmmCpuSyncCtx != NULL); + if (SmmCpuSyncCtx == NULL) { + return RETURN_INVALID_PARAMETER; + } + + // + // Count the CtxSize + // + Status = SafeUintnMult (NumberOfCpus, sizeof (SMM_CPU_SYNC_SEMAPHORE_CPU), &CpuSemInCtxSize); + if (EFI_ERROR (Status)) { + return Status; + } + + Status = SafeUintnAdd (sizeof (SMM_CPU_SYNC_CONTEXT), CpuSemInCtxSize, &CtxSize); + if (EFI_ERROR (Status)) { + return Status; + } + + Status = SafeUintnAdd (CtxSize, sizeof (SMM_CPU_SYNC_SEMAPHORE_GLOBAL), &CtxSize); + if (EFI_ERROR (Status)) { + return Status; + } + + // + // Allocate CtxSize buffer for the *SmmCpuSyncCtx + // + *SmmCpuSyncCtx = NULL; + *SmmCpuSyncCtx = (SMM_CPU_SYNC_CONTEXT *)AllocatePages (EFI_SIZE_TO_PAGES (CtxSize)); + ASSERT (*SmmCpuSyncCtx != NULL); + if (*SmmCpuSyncCtx == NULL) { + return RETURN_OUT_OF_RESOURCES; + } + + (*SmmCpuSyncCtx)->GlobalSem = (SMM_CPU_SYNC_SEMAPHORE_GLOBAL *)((UINT8 *)(*SmmCpuSyncCtx) + sizeof (SMM_CPU_SYNC_CONTEXT)); + (*SmmCpuSyncCtx)->CpuSem = (SMM_CPU_SYNC_SEMAPHORE_CPU *)((UINT8 *)(*SmmCpuSyncCtx) + sizeof (SMM_CPU_SYNC_CONTEXT) + sizeof (SMM_CPU_SYNC_SEMAPHORE_GLOBAL)); + (*SmmCpuSyncCtx)->NumberOfCpus = NumberOfCpus; + + // + // Count the TotalSemSize + // + OneSemSize = GetSpinLockProperties (); + + Status = SafeUintnMult (OneSemSize, sizeof (SMM_CPU_SYNC_SEMAPHORE_GLOBAL) / sizeof (VOID *), &GlobalSemSize); + if (EFI_ERROR (Status)) { + goto ON_ERROR; + } + + Status = SafeUintnMult (OneSemSize, sizeof (SMM_CPU_SYNC_SEMAPHORE_CPU) / sizeof (VOID *), &OneCpuSemSize); + if (EFI_ERROR (Status)) { + goto ON_ERROR; + } + + Status = SafeUintnMult (NumberOfCpus, OneCpuSemSize, &CpuSemSize); + if (EFI_ERROR (Status)) { + goto ON_ERROR; + } + + Status = SafeUintnAdd (GlobalSemSize, CpuSemSize, &TotalSemSize); + if (EFI_ERROR (Status)) { + goto ON_ERROR; + } + + DEBUG ((DEBUG_INFO, "[%a] - One Semaphore Size = 0x%x\n", __func__, OneSemSize)); + DEBUG ((DEBUG_INFO, "[%a] - Total Semaphores Size = 0x%x\n", __func__, TotalSemSize)); + + // + // Allocate for Semaphores in the *SmmCpuSyncCtx + // + (*SmmCpuSyncCtx)->SemBufferSize = TotalSemSize; + (*SmmCpuSyncCtx)->SemBuffer = AllocatePages (EFI_SIZE_TO_PAGES ((*SmmCpuSyncCtx)->SemBufferSize)); + ASSERT ((*SmmCpuSyncCtx)->SemBuffer != NULL); + if ((*SmmCpuSyncCtx)->SemBuffer == NULL) { + Status = RETURN_OUT_OF_RESOURCES; + goto ON_ERROR; + } + + ZeroMem ((*SmmCpuSyncCtx)->SemBuffer, TotalSemSize); + + // + // Assign Global Semaphore pointer + // + SemAddr = (UINTN)(*SmmCpuSyncCtx)->SemBuffer; + (*SmmCpuSyncCtx)->GlobalSem->Counter = (UINT32 *)SemAddr; + *(*SmmCpuSyncCtx)->GlobalSem->Counter = 0; + DEBUG ((DEBUG_INFO, "[%a] - (*SmmCpuSyncCtx)->GlobalSem->Counter Address: 0x%08x\n", __func__, (UINTN)(*SmmCpuSyncCtx)->GlobalSem->Counter)); + + SemAddr += GlobalSemSize; + + // + // Assign CPU Semaphore pointer + // + for (CpuIndex = 0; CpuIndex < NumberOfCpus; CpuIndex++) { + (*SmmCpuSyncCtx)->CpuSem[CpuIndex].Run = (UINT32 *)(SemAddr + (CpuSemSize / NumberOfCpus) * CpuIndex); + *(*SmmCpuSyncCtx)->CpuSem[CpuIndex].Run = 0; + DEBUG ((DEBUG_INFO, "[%a] - (*SmmCpuSyncCtx)->CpuSem[%d].Run Address: 0x%08x\n", __func__, CpuIndex, (UINTN)(*SmmCpuSyncCtx)->CpuSem[CpuIndex].Run)); + } + + return RETURN_SUCCESS; + +ON_ERROR: + FreePages (*SmmCpuSyncCtx, EFI_SIZE_TO_PAGES (CtxSize)); + return Status; +} + +/** + Deinit an allocated SMM CPU Sync context. + + SmmCpuSyncContextDeinit() function is to deinitialize SMM CPU Sync context, the resources allocated in + SmmCpuSyncContextInit() will be freed. + + Note: This function only can be called after SmmCpuSyncContextInit() return success. + + @param[in,out] SmmCpuSyncCtx Pointer to the SMM CPU Sync context object to be deinitialized. + + @retval RETURN_SUCCESS The SMM CPU Sync context was successful deinitialized. + @retval RETURN_INVALID_PARAMETER SmmCpuSyncCtx is NULL. + @retval RETURN_UNSUPPORTED Unsupported operation. + +**/ +RETURN_STATUS +EFIAPI +SmmCpuSyncContextDeinit ( + IN OUT SMM_CPU_SYNC_CONTEXT *SmmCpuSyncCtx + ) +{ + UINTN SmmCpuSyncCtxSize; + + ASSERT (SmmCpuSyncCtx != NULL); + if (SmmCpuSyncCtx == NULL) { + return RETURN_INVALID_PARAMETER; + } + + SmmCpuSyncCtxSize = sizeof (SMM_CPU_SYNC_CONTEXT) + sizeof (SMM_CPU_SYNC_SEMAPHORE_GLOBAL) + sizeof (SMM_CPU_SYNC_SEMAPHORE_CPU) * (SmmCpuSyncCtx->NumberOfCpus); + + FreePages (SmmCpuSyncCtx->SemBuffer, EFI_SIZE_TO_PAGES (SmmCpuSyncCtx->SemBufferSize)); + + FreePages (SmmCpuSyncCtx, EFI_SIZE_TO_PAGES (SmmCpuSyncCtxSize)); + + return RETURN_SUCCESS; +} + +/** + Reset SMM CPU Sync context. + + SmmCpuSyncContextReset() function is to reset SMM CPU Sync context to the initialized state. + + @param[in,out] SmmCpuSyncCtx Pointer to the SMM CPU Sync context object to be reset. + + @retval RETURN_SUCCESS The SMM CPU Sync context was successful reset. + @retval RETURN_INVALID_PARAMETER SmmCpuSyncCtx is NULL. + +**/ +RETURN_STATUS +EFIAPI +SmmCpuSyncContextReset ( + IN OUT SMM_CPU_SYNC_CONTEXT *SmmCpuSyncCtx + ) +{ + ASSERT (SmmCpuSyncCtx != NULL); + if (SmmCpuSyncCtx == NULL) { + return RETURN_INVALID_PARAMETER; + } + + *SmmCpuSyncCtx->GlobalSem->Counter = 0; + + return RETURN_SUCCESS; +} + +/** + Get current number of arrived CPU in SMI. + + For traditional CPU synchronization method, BSP might need to know the current number of arrived CPU in + SMI to make sure all APs in SMI. This API can be for that purpose. + + @param[in] SmmCpuSyncCtx Pointer to the SMM CPU Sync context object. + @param[in,out] CpuCount Current count of arrived CPU in SMI. + + @retval RETURN_SUCCESS Get current number of arrived CPU in SMI successfully. + @retval RETURN_INVALID_PARAMETER SmmCpuSyncCtx or CpuCount is NULL. + @retval RETURN_UNSUPPORTED Unsupported operation. + +**/ +RETURN_STATUS +EFIAPI +SmmCpuSyncGetArrivedCpuCount ( + IN SMM_CPU_SYNC_CONTEXT *SmmCpuSyncCtx, + IN OUT UINTN *CpuCount + ) +{ + ASSERT (SmmCpuSyncCtx != NULL && CpuCount != NULL); + if ((SmmCpuSyncCtx == NULL) || (CpuCount == NULL)) { + return RETURN_INVALID_PARAMETER; + } + + if (*SmmCpuSyncCtx->GlobalSem->Counter < 0) { + return RETURN_UNSUPPORTED; + } + + *CpuCount = *SmmCpuSyncCtx->GlobalSem->Counter; + + return RETURN_SUCCESS; +} + +/** + Performs an atomic operation to check in CPU. + + When SMI happens, all processors including BSP enter to SMM mode by calling SmmCpuSyncCheckInCpu(). + + @param[in,out] SmmCpuSyncCtx Pointer to the SMM CPU Sync context object. + @param[in] CpuIndex Check in CPU index. + + @retval RETURN_SUCCESS Check in CPU (CpuIndex) successfully. + @retval RETURN_INVALID_PARAMETER SmmCpuSyncCtx is NULL. + @retval RETURN_ABORTED Check in CPU failed due to SmmCpuSyncLockDoor() has been called by one elected CPU. + +**/ +RETURN_STATUS +EFIAPI +SmmCpuSyncCheckInCpu ( + IN OUT SMM_CPU_SYNC_CONTEXT *SmmCpuSyncCtx, + IN UINTN CpuIndex + ) +{ + ASSERT (SmmCpuSyncCtx != NULL); + if (SmmCpuSyncCtx == NULL) { + return RETURN_INVALID_PARAMETER; + } + + // + // Check to return if Counter has already been locked. + // + if ((INT32)InternalReleaseSemaphore (SmmCpuSyncCtx->GlobalSem->Counter) <= 0) { + return RETURN_ABORTED; + } + + return RETURN_SUCCESS; +} + +/** + Performs an atomic operation to check out CPU. + + CheckOutCpu() can be called in error handling flow for the CPU who calls CheckInCpu() earlier. + + @param[in,out] SmmCpuSyncCtx Pointer to the SMM CPU Sync context object. + @param[in] CpuIndex Check out CPU index. + + @retval RETURN_SUCCESS Check out CPU (CpuIndex) successfully. + @retval RETURN_INVALID_PARAMETER SmmCpuSyncCtx is NULL. + @retval RETURN_NOT_READY The CPU is not checked-in. + @retval RETURN_UNSUPPORTED Unsupported operation. + +**/ +RETURN_STATUS +EFIAPI +SmmCpuSyncCheckOutCpu ( + IN OUT SMM_CPU_SYNC_CONTEXT *SmmCpuSyncCtx, + IN UINTN CpuIndex + ) +{ + ASSERT (SmmCpuSyncCtx != NULL); + if (SmmCpuSyncCtx == NULL) { + return RETURN_INVALID_PARAMETER; + } + + if (*SmmCpuSyncCtx->GlobalSem->Counter == 0) { + return RETURN_NOT_READY; + } + + if ((INT32)InternalWaitForSemaphore (SmmCpuSyncCtx->GlobalSem->Counter) < 0) { + return RETURN_UNSUPPORTED; + } + + return RETURN_SUCCESS; +} + +/** + Performs an atomic operation lock door for CPU checkin or checkout. + + After this function, CPU can not check in via SmmCpuSyncCheckInCpu(). + + The CPU specified by CpuIndex is elected to lock door. + + @param[in,out] SmmCpuSyncCtx Pointer to the SMM CPU Sync context object. + @param[in] CpuIndex Indicate which CPU to lock door. + @param[in,out] CpuCount Number of arrived CPU in SMI after look door. + + @retval RETURN_SUCCESS Lock door for CPU successfully. + @retval RETURN_INVALID_PARAMETER SmmCpuSyncCtx or CpuCount is NULL. + +**/ +RETURN_STATUS +EFIAPI +SmmCpuSyncLockDoor ( + IN OUT SMM_CPU_SYNC_CONTEXT *SmmCpuSyncCtx, + IN UINTN CpuIndex, + IN OUT UINTN *CpuCount + ) +{ + ASSERT (SmmCpuSyncCtx != NULL && CpuCount != NULL); + if ((SmmCpuSyncCtx == NULL) || (CpuCount == NULL)) { + return RETURN_INVALID_PARAMETER; + } + + *CpuCount = InternalLockdownSemaphore (SmmCpuSyncCtx->GlobalSem->Counter); + + return RETURN_SUCCESS; +} + +/** + Used by the BSP to wait for APs. + + The number of APs need to be waited is specified by NumberOfAPs. The BSP is specified by BspIndex. + + Note: This function is blocking mode, and it will return only after the number of APs released by + calling SmmCpuSyncReleaseBsp(): + BSP: WaitForAPs <-- AP: ReleaseBsp + + @param[in,out] SmmCpuSyncCtx Pointer to the SMM CPU Sync context object. + @param[in] NumberOfAPs Number of APs need to be waited by BSP. + @param[in] BspIndex The BSP Index to wait for APs. + + @retval RETURN_SUCCESS BSP to wait for APs successfully. + @retval RETURN_INVALID_PARAMETER SmmCpuSyncCtx is NULL or NumberOfAPs > total number of processors in system. + +**/ +RETURN_STATUS +EFIAPI +SmmCpuSyncWaitForAPs ( + IN OUT SMM_CPU_SYNC_CONTEXT *SmmCpuSyncCtx, + IN UINTN NumberOfAPs, + IN UINTN BspIndex + ) +{ + ASSERT (SmmCpuSyncCtx != NULL && NumberOfAPs <= SmmCpuSyncCtx->NumberOfCpus); + if ((SmmCpuSyncCtx == NULL) || (NumberOfAPs > SmmCpuSyncCtx->NumberOfCpus)) { + return RETURN_INVALID_PARAMETER; + } + + while (NumberOfAPs-- > 0) { + InternalWaitForSemaphore (SmmCpuSyncCtx->CpuSem[BspIndex].Run); + } + + return RETURN_SUCCESS; +} + +/** + Used by the BSP to release one AP. + + The AP is specified by CpuIndex. The BSP is specified by BspIndex. + + @param[in,out] SmmCpuSyncCtx Pointer to the SMM CPU Sync context object. + @param[in] CpuIndex Indicate which AP need to be released. + @param[in] BspIndex The BSP Index to release AP. + + @retval RETURN_SUCCESS BSP to release one AP successfully. + @retval RETURN_INVALID_PARAMETER SmmCpuSyncCtx is NULL or CpuIndex is same as BspIndex. + +**/ +RETURN_STATUS +EFIAPI +SmmCpuSyncReleaseOneAp ( + IN OUT SMM_CPU_SYNC_CONTEXT *SmmCpuSyncCtx, + IN UINTN CpuIndex, + IN UINTN BspIndex + ) +{ + ASSERT (SmmCpuSyncCtx != NULL && BspIndex != CpuIndex); + if ((SmmCpuSyncCtx == NULL) || (BspIndex == CpuIndex)) { + return RETURN_INVALID_PARAMETER; + } + + InternalReleaseSemaphore (SmmCpuSyncCtx->CpuSem[CpuIndex].Run); + + return RETURN_SUCCESS; +} + +/** + Used by the AP to wait BSP. + + The AP is specified by CpuIndex. The BSP is specified by BspIndex. + + Note: This function is blocking mode, and it will return only after the AP released by + calling SmmCpuSyncReleaseOneAp(): + BSP: ReleaseOneAp --> AP: WaitForBsp + + @param[in,out] SmmCpuSyncCtx Pointer to the SMM CPU Sync context object. + @param[in] CpuIndex Indicate which AP wait BSP. + @param[in] BspIndex The BSP Index to be waited. + + @retval RETURN_SUCCESS AP to wait BSP successfully. + @retval RETURN_INVALID_PARAMETER SmmCpuSyncCtx is NULL or CpuIndex is same as BspIndex. + +**/ +RETURN_STATUS +EFIAPI +SmmCpuSyncWaitForBsp ( + IN OUT SMM_CPU_SYNC_CONTEXT *SmmCpuSyncCtx, + IN UINTN CpuIndex, + IN UINTN BspIndex + ) +{ + ASSERT (SmmCpuSyncCtx != NULL && BspIndex != CpuIndex); + if ((SmmCpuSyncCtx == NULL) || (BspIndex == CpuIndex)) { + return RETURN_INVALID_PARAMETER; + } + + InternalWaitForSemaphore (SmmCpuSyncCtx->CpuSem[CpuIndex].Run); + + return RETURN_SUCCESS; +} + +/** + Used by the AP to release BSP. + + The AP is specified by CpuIndex. The BSP is specified by BspIndex. + + @param[in,out] SmmCpuSyncCtx Pointer to the SMM CPU Sync context object. + @param[in] CpuIndex Indicate which AP release BSP. + @param[in] BspIndex The BSP Index to be released. + + @retval RETURN_SUCCESS AP to release BSP successfully. + @retval RETURN_INVALID_PARAMETER SmmCpuSyncCtx is NULL or CpuIndex is same as BspIndex. + +**/ +RETURN_STATUS +EFIAPI +SmmCpuSyncReleaseBsp ( + IN OUT SMM_CPU_SYNC_CONTEXT *SmmCpuSyncCtx, + IN UINTN CpuIndex, + IN UINTN BspIndex + ) +{ + ASSERT (SmmCpuSyncCtx != NULL && BspIndex != CpuIndex); + if ((SmmCpuSyncCtx == NULL) || (BspIndex == CpuIndex)) { + return RETURN_INVALID_PARAMETER; + } + + InternalReleaseSemaphore (SmmCpuSyncCtx->CpuSem[BspIndex].Run); + + return RETURN_SUCCESS; +} diff --git a/UefiCpuPkg/Library/SmmCpuSyncLib/SmmCpuSyncLib.inf b/UefiCpuPkg/Library/SmmCpuSyncLib/SmmCpuSyncLib.inf new file mode 100644 index 0000000000..6bb1895577 --- /dev/null +++ b/UefiCpuPkg/Library/SmmCpuSyncLib/SmmCpuSyncLib.inf @@ -0,0 +1,39 @@ +## @file +# SMM CPU Synchronization lib. +# +# This is SMM CPU Synchronization lib used for SMM CPU sync operations. +# +# Copyright (c) 2023, Intel Corporation. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent +# +## + +[Defines] + INF_VERSION = 0x00010005 + BASE_NAME = SmmCpuSyncLib + FILE_GUID = 1ca1bc1a-16a4-46ef-956a-ca500fd3381f + MODULE_TYPE = DXE_SMM_DRIVER + LIBRARY_CLASS = SmmCpuSyncLib|DXE_SMM_DRIVER + +[Sources] + SmmCpuSyncLib.c + +[Packages] + MdePkg/MdePkg.dec + MdeModulePkg/MdeModulePkg.dec + UefiCpuPkg/UefiCpuPkg.dec + +[LibraryClasses] + UefiLib + BaseLib + DebugLib + PrintLib + SafeIntLib + SynchronizationLib + BaseMemoryLib + SmmServicesTableLib + MemoryAllocationLib + +[Pcd] + +[Protocols] diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc index 074fd77461..f264031c77 100644 --- a/UefiCpuPkg/UefiCpuPkg.dsc +++ b/UefiCpuPkg/UefiCpuPkg.dsc @@ -23,10 +23,11 @@ # !include MdePkg/MdeLibs.dsc.inc [LibraryClasses] + SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf BaseLib|MdePkg/Library/BaseLib/BaseLib.inf BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf @@ -54,10 +55,11 @@ CacheMaintenanceLib|MdePkg/Library/BaseCacheMaintenanceLib/BaseCacheMaintenanceLib.inf PciLib|MdePkg/Library/BasePciLibPciExpress/BasePciLibPciExpress.inf PciExpressLib|MdePkg/Library/BasePciExpressLib/BasePciExpressLib.inf SmmCpuPlatformHookLib|UefiCpuPkg/Library/SmmCpuPlatformHookLibNull/SmmCpuPlatformHookLibNull.inf SmmCpuFeaturesLib|UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf + SmmCpuSyncLib|UefiCpuPkg/Library/SmmCpuSyncLib/SmmCpuSyncLib.inf PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeCoffExtraActionLibNull.inf TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf CcExitLib|UefiCpuPkg/Library/CcExitLibNull/CcExitLibNull.inf MicrocodeLib|UefiCpuPkg/Library/MicrocodeLib/MicrocodeLib.inf @@ -154,10 +156,11 @@ UefiCpuPkg/Library/RegisterCpuFeaturesLib/DxeRegisterCpuFeaturesLib.inf UefiCpuPkg/Library/SmmCpuPlatformHookLibNull/SmmCpuPlatformHookLibNull.inf UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibStm.inf UefiCpuPkg/Library/SmmCpuFeaturesLib/StandaloneMmCpuFeaturesLib.inf + UefiCpuPkg/Library/SmmCpuSyncLib/SmmCpuSyncLib.inf UefiCpuPkg/Library/CcExitLibNull/CcExitLibNull.inf UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.inf UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.inf UefiCpuPkg/SecCore/SecCore.inf UefiCpuPkg/SecCore/SecCoreNative.inf -- 2.16.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112111): https://edk2.groups.io/g/devel/message/112111 Mute This Topic: https://groups.io/mt/103010165/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-