[edk2-devel] [PATCH 0/4] Add DEBUG_MANAGEABILITY to debug level comments

[edk2-devel] [PATCH 0/4] Add DEBUG_MANAGEABILITY to debug level comments

[Rebecca Cran via groups.io]

Add the new DEBUG_MANAGEABILITY debug level to MdePkg.dec and MdePkg.uni.

Improve the wording of the description of the DEBUG_MANAGEABILITY level in
DebugLib.h.

Update the comment block in ArmVirtPkg.dsc.inc with the new list and updated
formatting.


Rebecca Cran (4):
  MdePkg: Improve wording of manageability debug level comment
  MdePkg: Add manageability debug level to PcdFixedDebugPrintErrorLevel
  MdePkg: Update MdePkg.uni with manageability debug level
  ArmVirtPkg: Sync debug level comments in ArmVirt.dsc.inc

 MdePkg/MdePkg.dec                 |  1 +
 ArmVirtPkg/ArmVirt.dsc.inc        | 42 ++++++++++----------
 MdePkg/Include/Library/DebugLib.h |  4 +-
 MdePkg/MdePkg.uni                 |  2 +
 4 files changed, 27 insertions(+), 22 deletions(-)

-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112243): https://edk2.groups.io/g/devel/message/112243
Mute This Topic: https://groups.io/mt/103066384/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 1/4] MdePkg: Improve wording of manageability debug level comment

[Rebecca Cran via groups.io]

Improve the wording of the comment explaining the DEBUG_MANAGEABILITY
debug level.

Signed-off-by: Rebecca Cran <rebecca@os.amperecomputing.com>
---
 MdePkg/Include/Library/DebugLib.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MdePkg/Include/Library/DebugLib.h b/MdePkg/Include/Library/DebugLib.h
index f0c9f6448794..40772f2e0f7b 100644
--- a/MdePkg/Include/Library/DebugLib.h
+++ b/MdePkg/Include/Library/DebugLib.h
@@ -48,8 +48,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #define DEBUG_CACHE     0x00200000       // Memory range cachability changes
 #define DEBUG_VERBOSE   0x00400000       // Detailed debug messages that may
                                          // significantly impact boot performance
-#define DEBUG_MANAGEABILITY  0x00800000  // Detailed debug and payload message of manageability
-                                         // related modules, such Redfish, IPMI, MCTP and etc.
+#define DEBUG_MANAGEABILITY  0x00800000  // Detailed debug and payload manageability messages
+                                         // related to modules such as Redfish, IPMI, MCTP etc.
 #define DEBUG_ERROR  0x80000000          // Error
 
 //
-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112241): https://edk2.groups.io/g/devel/message/112241
Mute This Topic: https://groups.io/mt/103066382/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 2/4] MdePkg: Add manageability debug level to PcdFixedDebugPrintErrorLevel

[Rebecca Cran via groups.io]

Update MdePkg.dec to add the manageability debug level to
PcdFixedDebugPrintErrorLevel.

Signed-off-by: Rebecca Cran <rebecca@os.amperecomputing.com>
---
 MdePkg/MdePkg.dec | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
index ac54338089e8..bec63f5416e2 100644
--- a/MdePkg/MdePkg.dec
+++ b/MdePkg/MdePkg.dec
@@ -2213,6 +2213,7 @@ [PcdsFixedAtBuild]
   #  BIT20 - Global Coherency Database changes message.<BR>
   #  BIT21 - Memory range cachability changes message.<BR>
   #  BIT22 - Detailed debug message.<BR>
+  #  BIT23 - Manageability debug message.<BR>
   #  BIT31 - Error message.<BR>
   # @Prompt Fixed Debug Message Print Level.
   gEfiMdePkgTokenSpaceGuid.PcdFixedDebugPrintErrorLevel|0xFFFFFFFF|UINT32|0x30001016
-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112242): https://edk2.groups.io/g/devel/message/112242
Mute This Topic: https://groups.io/mt/103066383/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 3/4] MdePkg: Update MdePkg.uni with manageability debug level

[Rebecca Cran via groups.io]

Update MdePkg.uni with the manageability debug level.

Signed-off-by: Rebecca Cran <rebecca@os.amperecomputing.com>
---
 MdePkg/MdePkg.uni | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MdePkg/MdePkg.uni b/MdePkg/MdePkg.uni
index 5c1fa24065c7..75dbc6ffe3c0 100644
--- a/MdePkg/MdePkg.uni
+++ b/MdePkg/MdePkg.uni
@@ -214,6 +214,7 @@
                                                                                    "BIT20 - Global Coherency Database changes message.<BR>\n"
                                                                                    "BIT21 - Memory range cacheability changes message.<BR>\n"
                                                                                    "BIT22 - Detailed debug message.<BR>\n"
+                                                                                   "BIT23 - Manageability debug message.<BR>\n"
                                                                                    "BIT31 - Error message.<BR>"
 
 #string STR_gEfiMdePkgTokenSpaceGuid_PcdFixedDebugPrintErrorLevel_PROMPT  #language en-US "Fixed Debug Message Print Level"
@@ -237,6 +238,7 @@
                                                                                    "BIT20 - Global Coherency Database changes message.<BR>\n"
                                                                                    "BIT21 - Memory range cacheability changes message.<BR>\n"
                                                                                    "BIT22 - Detailed debug message.<BR>\n"
+                                                                                   "BIT23 - Manageability debug message.<BR>\n"
                                                                                    "BIT31 - Error message.<BR>"
 
 #string STR_gEfiMdePkgTokenSpaceGuid_PcdReportStatusCodePropertyMask_PROMPT  #language en-US "Report Status Code Property"
-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112244): https://edk2.groups.io/g/devel/message/112244
Mute This Topic: https://groups.io/mt/103066385/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 4/4] ArmVirtPkg: Sync debug level comments in ArmVirt.dsc.inc

[Rebecca Cran via groups.io]

Update the debug level comments in ArmVirt.dsc.inc to sync with
MdePkg/Include/Library/DebugLib.h.

Signed-off-by: Rebecca Cran <rebecca@os.amperecomputing.com>
---
 ArmVirtPkg/ArmVirt.dsc.inc | 42 ++++++++++----------
 1 file changed, 22 insertions(+), 20 deletions(-)

diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
index 6bc72f1decbd..9b23ef97ec5f 100644
--- a/ArmVirtPkg/ArmVirt.dsc.inc
+++ b/ArmVirtPkg/ArmVirt.dsc.inc
@@ -315,26 +315,28 @@ [PcdsFixedAtBuild.common]
   gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x2f
 !endif
 
-  #  DEBUG_INIT      0x00000001  // Initialization
-  #  DEBUG_WARN      0x00000002  // Warnings
-  #  DEBUG_LOAD      0x00000004  // Load events
-  #  DEBUG_FS        0x00000008  // EFI File system
-  #  DEBUG_POOL      0x00000010  // Alloc & Free (pool)
-  #  DEBUG_PAGE      0x00000020  // Alloc & Free (page)
-  #  DEBUG_INFO      0x00000040  // Informational debug messages
-  #  DEBUG_DISPATCH  0x00000080  // PEI/DXE/SMM Dispatchers
-  #  DEBUG_VARIABLE  0x00000100  // Variable
-  #  DEBUG_BM        0x00000400  // Boot Manager
-  #  DEBUG_BLKIO     0x00001000  // BlkIo Driver
-  #  DEBUG_NET       0x00004000  // SNP Driver
-  #  DEBUG_UNDI      0x00010000  // UNDI Driver
-  #  DEBUG_LOADFILE  0x00020000  // LoadFile
-  #  DEBUG_EVENT     0x00080000  // Event messages
-  #  DEBUG_GCD       0x00100000  // Global Coherency Database changes
-  #  DEBUG_CACHE     0x00200000  // Memory range cachability changes
-  #  DEBUG_VERBOSE   0x00400000  // Detailed debug messages that may
-  #                              // significantly impact boot performance
-  #  DEBUG_ERROR     0x80000000  // Error
+  #  DEBUG_INIT           0x00000001  // Initialization
+  #  DEBUG_WARN           0x00000002  // Warnings
+  #  DEBUG_LOAD           0x00000004  // Load events
+  #  DEBUG_FS             0x00000008  // EFI File system
+  #  DEBUG_POOL           0x00000010  // Alloc & Free (pool)
+  #  DEBUG_PAGE           0x00000020  // Alloc & Free (page)
+  #  DEBUG_INFO           0x00000040  // Informational debug messages
+  #  DEBUG_DISPATCH       0x00000080  // PEI/DXE/SMM Dispatchers
+  #  DEBUG_VARIABLE       0x00000100  // Variable
+  #  DEBUG_BM             0x00000400  // Boot Manager
+  #  DEBUG_BLKIO          0x00001000  // BlkIo Driver
+  #  DEBUG_NET            0x00004000  // Network Io Driver
+  #  DEBUG_UNDI           0x00010000  // UNDI Driver
+  #  DEBUG_LOADFILE       0x00020000  // LoadFile
+  #  DEBUG_EVENT          0x00080000  // Event messages
+  #  DEBUG_GCD            0x00100000  // Global Coherency Database changes
+  #  DEBUG_CACHE          0x00200000  // Memory range cachability changes
+  #  DEBUG_VERBOSE        0x00400000  // Detailed debug messages that may
+  #                                   // significantly impact boot performance
+  #  DEBUG_MANAGEABILITY  0x00800000  // Detailed debug and payload manageability messages
+  #                                   // related to modules such as Redfish, IPMI, MCTP etc.
+  #  DEBUG_ERROR          0x80000000  // Error
 !if $(TARGET) != RELEASE
   gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|$(DEBUG_PRINT_ERROR_LEVEL)
 !endif
-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112245): https://edk2.groups.io/g/devel/message/112245
Mute This Topic: https://groups.io/mt/103066386/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/4] Add DEBUG_MANAGEABILITY to debug level comments

[Rebecca Cran via groups.io]

On 12/8/2023 5:19 PM, Rebecca Cran wrote:
> Add the new DEBUG_MANAGEABILITY debug level to MdePkg.dec and MdePkg.uni.
> 
> Improve the wording of the description of the DEBUG_MANAGEABILITY level in
> DebugLib.h.
> 
> Update the comment block in ArmVirtPkg.dsc.inc with the new list and updated
> formatting.

PR: https://github.com/tianocore/edk2/pull/5127

-- 
Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112246): https://edk2.groups.io/g/devel/message/112246
Mute This Topic: https://groups.io/mt/103066384/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/4] Add DEBUG_MANAGEABILITY to debug level comments

[Michael D Kinney]

Series Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Rebecca
> Cran via groups.io
> Sent: Friday, December 8, 2023 4:20 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Ard
> Biesheuvel <ardb+tianocore@kernel.org>; Laszlo Ersek
> <lersek@redhat.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Sami
> Mujawar <sami.mujawar@arm.com>; Gerd Hoffmann <kraxel@redhat.com>
> Cc: Rebecca Cran <rebecca@os.amperecomputing.com>; devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH 0/4] Add DEBUG_MANAGEABILITY to debug level
> comments
> 
> Add the new DEBUG_MANAGEABILITY debug level to MdePkg.dec and
> MdePkg.uni.
> 
> Improve the wording of the description of the DEBUG_MANAGEABILITY level
> in
> DebugLib.h.
> 
> Update the comment block in ArmVirtPkg.dsc.inc with the new list and
> updated
> formatting.
> 
> 
> Rebecca Cran (4):
>   MdePkg: Improve wording of manageability debug level comment
>   MdePkg: Add manageability debug level to PcdFixedDebugPrintErrorLevel
>   MdePkg: Update MdePkg.uni with manageability debug level
>   ArmVirtPkg: Sync debug level comments in ArmVirt.dsc.inc
> 
>  MdePkg/MdePkg.dec                 |  1 +
>  ArmVirtPkg/ArmVirt.dsc.inc        | 42 ++++++++++----------
>  MdePkg/Include/Library/DebugLib.h |  4 +-
>  MdePkg/MdePkg.uni                 |  2 +
>  4 files changed, 27 insertions(+), 22 deletions(-)
> 
> --
> 2.34.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112247): https://edk2.groups.io/g/devel/message/112247
Mute This Topic: https://groups.io/mt/103066384/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 4/4] ArmVirtPkg: Sync debug level comments in ArmVirt.dsc.inc

[Ard Biesheuvel]

On Sat, 9 Dec 2023 at 01:20, Rebecca Cran
<rebecca@os.amperecomputing.com> wrote:
>
> Update the debug level comments in ArmVirt.dsc.inc to sync with
> MdePkg/Include/Library/DebugLib.h.
>
> Signed-off-by: Rebecca Cran <rebecca@os.amperecomputing.com>

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  ArmVirtPkg/ArmVirt.dsc.inc | 42 ++++++++++----------
>  1 file changed, 22 insertions(+), 20 deletions(-)
>
> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> index 6bc72f1decbd..9b23ef97ec5f 100644
> --- a/ArmVirtPkg/ArmVirt.dsc.inc
> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
> @@ -315,26 +315,28 @@ [PcdsFixedAtBuild.common]
>    gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x2f
>  !endif
>
> -  #  DEBUG_INIT      0x00000001  // Initialization
> -  #  DEBUG_WARN      0x00000002  // Warnings
> -  #  DEBUG_LOAD      0x00000004  // Load events
> -  #  DEBUG_FS        0x00000008  // EFI File system
> -  #  DEBUG_POOL      0x00000010  // Alloc & Free (pool)
> -  #  DEBUG_PAGE      0x00000020  // Alloc & Free (page)
> -  #  DEBUG_INFO      0x00000040  // Informational debug messages
> -  #  DEBUG_DISPATCH  0x00000080  // PEI/DXE/SMM Dispatchers
> -  #  DEBUG_VARIABLE  0x00000100  // Variable
> -  #  DEBUG_BM        0x00000400  // Boot Manager
> -  #  DEBUG_BLKIO     0x00001000  // BlkIo Driver
> -  #  DEBUG_NET       0x00004000  // SNP Driver
> -  #  DEBUG_UNDI      0x00010000  // UNDI Driver
> -  #  DEBUG_LOADFILE  0x00020000  // LoadFile
> -  #  DEBUG_EVENT     0x00080000  // Event messages
> -  #  DEBUG_GCD       0x00100000  // Global Coherency Database changes
> -  #  DEBUG_CACHE     0x00200000  // Memory range cachability changes
> -  #  DEBUG_VERBOSE   0x00400000  // Detailed debug messages that may
> -  #                              // significantly impact boot performance
> -  #  DEBUG_ERROR     0x80000000  // Error
> +  #  DEBUG_INIT           0x00000001  // Initialization
> +  #  DEBUG_WARN           0x00000002  // Warnings
> +  #  DEBUG_LOAD           0x00000004  // Load events
> +  #  DEBUG_FS             0x00000008  // EFI File system
> +  #  DEBUG_POOL           0x00000010  // Alloc & Free (pool)
> +  #  DEBUG_PAGE           0x00000020  // Alloc & Free (page)
> +  #  DEBUG_INFO           0x00000040  // Informational debug messages
> +  #  DEBUG_DISPATCH       0x00000080  // PEI/DXE/SMM Dispatchers
> +  #  DEBUG_VARIABLE       0x00000100  // Variable
> +  #  DEBUG_BM             0x00000400  // Boot Manager
> +  #  DEBUG_BLKIO          0x00001000  // BlkIo Driver
> +  #  DEBUG_NET            0x00004000  // Network Io Driver
> +  #  DEBUG_UNDI           0x00010000  // UNDI Driver
> +  #  DEBUG_LOADFILE       0x00020000  // LoadFile
> +  #  DEBUG_EVENT          0x00080000  // Event messages
> +  #  DEBUG_GCD            0x00100000  // Global Coherency Database changes
> +  #  DEBUG_CACHE          0x00200000  // Memory range cachability changes
> +  #  DEBUG_VERBOSE        0x00400000  // Detailed debug messages that may
> +  #                                   // significantly impact boot performance
> +  #  DEBUG_MANAGEABILITY  0x00800000  // Detailed debug and payload manageability messages
> +  #                                   // related to modules such as Redfish, IPMI, MCTP etc.
> +  #  DEBUG_ERROR          0x80000000  // Error
>  !if $(TARGET) != RELEASE
>    gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|$(DEBUG_PRINT_ERROR_LEVEL)
>  !endif
> --
> 2.34.1
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112250): https://edk2.groups.io/g/devel/message/112250
Mute This Topic: https://groups.io/mt/103066386/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/4] Add DEBUG_MANAGEABILITY to debug level comments

[Laszlo Ersek]

On 12/9/23 01:33, Rebecca Cran via groups.io wrote:
> On 12/8/2023 5:19 PM, Rebecca Cran wrote:
>> Add the new DEBUG_MANAGEABILITY debug level to MdePkg.dec and MdePkg.uni.
>>
>> Improve the wording of the description of the DEBUG_MANAGEABILITY
>> level in
>> DebugLib.h.
>>
>> Update the comment block in ArmVirtPkg.dsc.inc with the new list and
>> updated
>> formatting.
> 
> PR: https://github.com/tianocore/edk2/pull/5127

... commenting only because I was CC'd:

Please confirm on the list whenever a series is merged; it saves time
for reviewers.

(This problem should disappear once we move reviews to github.com, but
until then, a short confirmation on-list can prevent wasted time.)

For the record: commit range
5b5481526fc9b89e5f3843d9bb3d6c4f5ce41060..aa2f32cefa567133d94d574672a4479e004211ee.

Thanks!
Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112351): https://edk2.groups.io/g/devel/message/112351
Mute This Topic: https://groups.io/mt/103066384/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/4] Add DEBUG_MANAGEABILITY to debug level comments

[Rebecca Cran]

On 12/11/2023 6:17 PM, Laszlo Ersek wrote:
> On 12/9/23 01:33, Rebecca Cran via groups.io wrote:
>> On 12/8/2023 5:19 PM, Rebecca Cran wrote:
>>> Add the new DEBUG_MANAGEABILITY debug level to MdePkg.dec and MdePkg.uni.
>>>
>>> Improve the wording of the description of the DEBUG_MANAGEABILITY
>>> level in
>>> DebugLib.h.
>>>
>>> Update the comment block in ArmVirtPkg.dsc.inc with the new list and
>>> updated
>>> formatting.
>>
>> PR: https://github.com/tianocore/edk2/pull/5127
> 
> ... commenting only because I was CC'd:
> 
> Please confirm on the list whenever a series is merged; it saves time
> for reviewers.
> 
> (This problem should disappear once we move reviews to github.com, but
> until then, a short confirmation on-list can prevent wasted time.)
> 
> For the record: commit range
> 5b5481526fc9b89e5f3843d9bb3d6c4f5ce41060..aa2f32cefa567133d94d574672a4479e004211ee.

Oh, thanks! I was meaning to do that but forgot between setting the 
'push' label and waiting for CI to complete.


-- 
Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112352): https://edk2.groups.io/g/devel/message/112352
Mute This Topic: https://groups.io/mt/103066384/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-