From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 0A375740032 for ; Thu, 14 Dec 2023 23:25:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=wS851L+Kb6kVxrcFtgQsd/w/1c/AcULek8vcC47IIos=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1702596308; v=1; b=O9pLV5dpyuqG3JzaLIT52h7Ghm41BKtz+0zsxfgiQ0O2DbCKEMPFaxTfqcFxcxKVcC3Iqrun yQ+pQZiZAneD3yfIgQaI1NHacLoQp41T1/x2OoV/dv/wPo388ADJQi7Ekq6hu9YYsH1TcyGYTkC ZewUH0IcqRXHdn31CnrpvcB0= X-Received: by 127.0.0.2 with SMTP id aT7BYY7687511xQeUIwdZaFV; Thu, 14 Dec 2023 15:25:08 -0800 X-Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by mx.groups.io with SMTP id smtpd.web11.44952.1702596306787282785 for ; Thu, 14 Dec 2023 15:25:07 -0800 X-Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-50e0ba402b4so41578e87.1 for ; Thu, 14 Dec 2023 15:25:06 -0800 (PST) X-Gm-Message-State: iJDLO3AoElA0KrHKRcmYb74Tx7686176AA= X-Google-Smtp-Source: AGHT+IEkTK5uYPNY53dTPeA0rxMziTdh6uTErXMAFEtE9zWXlsYghok9JodPaJagrR/ngQBKZueFmg== X-Received: by 2002:ac2:4c51:0:b0:50e:1870:1ef4 with SMTP id o17-20020ac24c51000000b0050e18701ef4mr1313650lfk.48.1702596304788; Thu, 14 Dec 2023 15:25:04 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id j24-20020ac24558000000b0050bfe5815e7sm1973119lfm.165.2023.12.14.15.25.04 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 14 Dec 2023 15:25:04 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH v2 04/14] RedfishPkg: RedfishPlatformConfigDxe: reduce memory allocations Date: Fri, 15 Dec 2023 02:24:48 +0300 Message-Id: <20231214232458.4636-5-mike.maslenkin@gmail.com> In-Reply-To: <20231214232458.4636-1-mike.maslenkin@gmail.com> References: <20231214232458.4636-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=O9pLV5dp; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io It's unclear why the new string is allocated as copy of the original string if its pointer is stored in an array and the original string is released immediately after the copy is created. All data allocated in the same pool. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c= b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c index cbc65ba59408..f970e317b3f6 100644 --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c @@ -2057,9 +2057,7 @@ RedfishPlatformConfigProtocolGetConfigureLang ( TmpString =3D HiiGetRedfishString (StatementRef->Statement->Parent= Form->ParentFormset->HiiHandle, FullSchema, StatementRef->Statement->Descri= ption);=0D ASSERT (TmpString !=3D NULL);=0D if (TmpString !=3D NULL) {=0D - TmpConfigureLangList[Index] =3D AllocateCopyPool (StrSize (TmpSt= ring), TmpString);=0D - ASSERT (TmpConfigureLangList[Index] !=3D NULL);=0D - FreePool (TmpString);=0D + TmpConfigureLangList[Index] =3D TmpString;=0D ++Index;=0D }=0D }=0D --=20 2.32.0 (Apple Git-132) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112553): https://edk2.groups.io/g/devel/message/112553 Mute This Topic: https://groups.io/mt/103181039/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-