From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3A69EAC00F7 for ; Fri, 15 Dec 2023 00:04:22 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Ma36MFjbKjkUZ2Ggy29MbIm4ORw+74JCXPk7SS9aWck=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1702598660; v=1; b=ZObStRpFC6UR8QLvme9t7P5Ieul5Qf+BoJ+viBcqkiC8NwUtWEqqfvRoJ/0/jdM8CFHZeSXr XP7Bxmi3od8jUVr4leSArp+G4+1COfEiLKpALA+5qAcIgCRB0h7CKh8bSuSMeOwt75ZizxrphO3 3R5vD/anMSRFQhpL07SUNt/k= X-Received: by 127.0.0.2 with SMTP id y3zyYY7687511xjXBph3LQSQ; Thu, 14 Dec 2023 16:04:20 -0800 X-Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by mx.groups.io with SMTP id smtpd.web10.45421.1702598660088474334 for ; Thu, 14 Dec 2023 16:04:20 -0800 X-Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-50e0ba402b4so72905e87.1 for ; Thu, 14 Dec 2023 16:04:19 -0800 (PST) X-Gm-Message-State: QmCs6jGKjsSauJikAMyFAbcrx7686176AA= X-Google-Smtp-Source: AGHT+IFfXg6XxBrSMYsiS8nm7bLM3S5/9LhjbWjap8Tj9JA6IRPB8PIaM9gnd20mE25mzhXyvN9LxA== X-Received: by 2002:a05:6512:ad5:b0:50d:1eb3:7bfd with SMTP id n21-20020a0565120ad500b0050d1eb37bfdmr5877581lfu.13.1702598658246; Thu, 14 Dec 2023 16:04:18 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id n11-20020a0565120acb00b0050be6038170sm1991256lfu.48.2023.12.14.16.04.17 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 14 Dec 2023 16:04:17 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [edk2-redfish-client][PATCH 1/4] RedfishClientPkg: add check for NULL pointer to avoid ASSERT Date: Fri, 15 Dec 2023 03:03:57 +0300 Message-Id: <20231215000400.5311-2-mike.maslenkin@gmail.com> In-Reply-To: <20231215000400.5311-1-mike.maslenkin@gmail.com> References: <20231215000400.5311-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ZObStRpF; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Initially RedfishPlatformConfigGetConfigureLang could return success even if ConfigureLangList is empty. After fixing this condition, RedfishPlatformConfigGetConfigureLang returns an error, but this doesn't help to avoid ASSERT because the error path is the same as for non-empty list. Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nickle Wang Signed-off-by: Mike Maslenkin --- .../RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatu= reUtilityLib.c b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishF= eatureUtilityLib.c index 4cb7621c25c4..0f0b050d7eba 100644 --- a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtili= tyLib.c +++ b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtili= tyLib.c @@ -3118,7 +3118,9 @@ LeaveFunction: FreePool (ConfigureLangBuffer);=0D }=0D =0D - FreePool (ConfigureLangList);=0D + if (ConfigureLangList !=3D NULL) {=0D + FreePool (ConfigureLangList);=0D + }=0D =0D *NumberOfValues =3D (UINT32)ListCount;=0D return FirstEmptyPropKeyValueList;=0D --=20 2.32.0 (Apple Git-132) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112574): https://edk2.groups.io/g/devel/message/112574 Mute This Topic: https://groups.io/mt/103181638/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-