* [edk2-devel] [PATCH] BaseTools: FMMT GuidTool Auto Select Config file Enabling
@ 2023-12-15 9:11 Yuwei Chen
2023-12-19 7:31 ` Guo, Gua
2023-12-20 22:12 ` Rebecca Cran
0 siblings, 2 replies; 6+ messages in thread
From: Yuwei Chen @ 2023-12-15 9:11 UTC (permalink / raw)
To: devel; +Cc: Rebecca Cran, Liming Gao, Bob Feng
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4624
Currently, Python FMMT tool does not support automatically
select FMMTConf.ini file which saves GuidTool settings.
This patch supports this features.
Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Bob Feng <bob.c.feng@intel.com>
Signed-off-by: Yuwei Chen <yuwei.chen@intel.com>
---
BaseTools/Source/Python/FMMT/core/GuidTools.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/FMMT/core/GuidTools.py b/BaseTools/Source/Python/FMMT/core/GuidTools.py
index a25681709b..f6bdeffa50 100644
--- a/BaseTools/Source/Python/FMMT/core/GuidTools.py
+++ b/BaseTools/Source/Python/FMMT/core/GuidTools.py
@@ -110,7 +110,7 @@ class GUIDTools:
if os.environ['FmmtConfPath']:
self.tooldef_file = os.path.join(os.environ['FmmtConfPath'], 'FmmtConf.ini')
else:
- PathList = os.environ['PATH']
+ PathList = os.environ['PATH'].split(os.pathsep)
for CurrentPath in PathList:
if os.path.exists(os.path.join(CurrentPath, 'FmmtConf.ini')):
self.tooldef_file = os.path.join(CurrentPath, 'FmmtConf.ini')
--
2.42.0.windows.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112587): https://edk2.groups.io/g/devel/message/112587
Mute This Topic: https://groups.io/mt/103187642/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH] BaseTools: FMMT GuidTool Auto Select Config file Enabling
[not found] <17A0F657EB4E520F.5876@groups.io>
@ 2023-12-15 9:13 ` Yuwei Chen
0 siblings, 0 replies; 6+ messages in thread
From: Yuwei Chen @ 2023-12-15 9:13 UTC (permalink / raw)
To: devel@edk2.groups.io, Chen, Christine
Cc: Rebecca Cran, Gao, Liming, Feng, Bob C, Guo, Gua
Edk2-basetools repo PR link: https://github.com/tianocore/edk2-basetools/pull/100
Thanks,
Christine
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yuwei
> Chen
> Sent: Friday, December 15, 2023 5:12 PM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran <rebecca@bsdio.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Feng, Bob C <bob.c.feng@intel.com>
> Subject: [edk2-devel] [PATCH] BaseTools: FMMT GuidTool Auto Select Config
> file Enabling
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4624
>
> Currently, Python FMMT tool does not support automatically select
> FMMTConf.ini file which saves GuidTool settings.
> This patch supports this features.
>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Bob Feng <bob.c.feng@intel.com>
>
> Signed-off-by: Yuwei Chen <yuwei.chen@intel.com>
> ---
> BaseTools/Source/Python/FMMT/core/GuidTools.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/BaseTools/Source/Python/FMMT/core/GuidTools.py
> b/BaseTools/Source/Python/FMMT/core/GuidTools.py
> index a25681709b..f6bdeffa50 100644
> --- a/BaseTools/Source/Python/FMMT/core/GuidTools.py
> +++ b/BaseTools/Source/Python/FMMT/core/GuidTools.py
> @@ -110,7 +110,7 @@ class GUIDTools:
> if os.environ['FmmtConfPath']: self.tooldef_file =
> os.path.join(os.environ['FmmtConfPath'], 'FmmtConf.ini') else:-
> PathList = os.environ['PATH']+ PathList =
> os.environ['PATH'].split(os.pathsep) for CurrentPath in PathList:
> if os.path.exists(os.path.join(CurrentPath, 'FmmtConf.ini')):
> self.tooldef_file = os.path.join(CurrentPath, 'FmmtConf.ini')--
> 2.42.0.windows.2
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#112587):
> https://edk2.groups.io/g/devel/message/112587
> Mute This Topic: https://groups.io/mt/103187642/4546272
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [yuwei.chen@intel.com] -
> =-=-=-=-=-=
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112588): https://edk2.groups.io/g/devel/message/112588
Mute This Topic: https://groups.io/mt/103187642/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH] BaseTools: FMMT GuidTool Auto Select Config file Enabling
2023-12-15 9:11 [edk2-devel] [PATCH] BaseTools: FMMT GuidTool Auto Select Config file Enabling Yuwei Chen
@ 2023-12-19 7:31 ` Guo, Gua
2023-12-19 13:02 ` 回复: " gaoliming via groups.io
2023-12-20 22:12 ` Rebecca Cran
1 sibling, 1 reply; 6+ messages in thread
From: Guo, Gua @ 2023-12-19 7:31 UTC (permalink / raw)
To: devel@edk2.groups.io, Chen, Christine, Rebecca Cran, Gao, Liming
Cc: Feng, Bob C
Hi @Gao, Liming and @Rebecca Cran
I may need to get your help for review it, any concern you can also share for us.
Thanks,
Gua
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yuwei Chen
Sent: Friday, December 15, 2023 5:12 PM
To: devel@edk2.groups.io
Cc: Rebecca Cran <rebecca@bsdio.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Feng, Bob C <bob.c.feng@intel.com>
Subject: [edk2-devel] [PATCH] BaseTools: FMMT GuidTool Auto Select Config file Enabling
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4624
Currently, Python FMMT tool does not support automatically select FMMTConf.ini file which saves GuidTool settings.
This patch supports this features.
Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Bob Feng <bob.c.feng@intel.com>
Signed-off-by: Yuwei Chen <yuwei.chen@intel.com>
---
BaseTools/Source/Python/FMMT/core/GuidTools.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/FMMT/core/GuidTools.py b/BaseTools/Source/Python/FMMT/core/GuidTools.py
index a25681709b..f6bdeffa50 100644
--- a/BaseTools/Source/Python/FMMT/core/GuidTools.py
+++ b/BaseTools/Source/Python/FMMT/core/GuidTools.py
@@ -110,7 +110,7 @@ class GUIDTools:
if os.environ['FmmtConfPath']: self.tooldef_file = os.path.join(os.environ['FmmtConfPath'], 'FmmtConf.ini') else:- PathList = os.environ['PATH']+ PathList = os.environ['PATH'].split(os.pathsep) for CurrentPath in PathList: if os.path.exists(os.path.join(CurrentPath, 'FmmtConf.ini')): self.tooldef_file = os.path.join(CurrentPath, 'FmmtConf.ini')--
2.42.0.windows.2
-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112587): https://edk2.groups.io/g/devel/message/112587
Mute This Topic: https://groups.io/mt/103187642/6998960
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [gua.guo@intel.com] -=-=-=-=-=-=
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112712): https://edk2.groups.io/g/devel/message/112712
Mute This Topic: https://groups.io/mt/103187642/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 6+ messages in thread
* 回复: [edk2-devel] [PATCH] BaseTools: FMMT GuidTool Auto Select Config file Enabling
2023-12-19 7:31 ` Guo, Gua
@ 2023-12-19 13:02 ` gaoliming via groups.io
2023-12-20 22:17 ` Rebecca Cran
0 siblings, 1 reply; 6+ messages in thread
From: gaoliming via groups.io @ 2023-12-19 13:02 UTC (permalink / raw)
To: devel, gua.guo, 'Chen, Christine', 'Rebecca Cran'
Cc: 'Feng, Bob C'
The change is good.
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Guo, Gua
> 发送时间: 2023年12月19日 15:32
> 收件人: devel@edk2.groups.io; Chen, Christine <yuwei.chen@intel.com>;
> Rebecca Cran <rebecca@bsdio.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>
> 抄送: Feng, Bob C <bob.c.feng@intel.com>
> 主题: Re: [edk2-devel] [PATCH] BaseTools: FMMT GuidTool Auto Select Config
> file Enabling
>
> Hi @Gao, Liming and @Rebecca Cran
>
> I may need to get your help for review it, any concern you can also share
for
> us.
>
> Thanks,
> Gua
>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yuwei
> Chen
> Sent: Friday, December 15, 2023 5:12 PM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran <rebecca@bsdio.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Feng, Bob C <bob.c.feng@intel.com>
> Subject: [edk2-devel] [PATCH] BaseTools: FMMT GuidTool Auto Select Config
> file Enabling
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4624
>
> Currently, Python FMMT tool does not support automatically select
> FMMTConf.ini file which saves GuidTool settings.
> This patch supports this features.
>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Bob Feng <bob.c.feng@intel.com>
>
> Signed-off-by: Yuwei Chen <yuwei.chen@intel.com>
> ---
> BaseTools/Source/Python/FMMT/core/GuidTools.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/BaseTools/Source/Python/FMMT/core/GuidTools.py
> b/BaseTools/Source/Python/FMMT/core/GuidTools.py
> index a25681709b..f6bdeffa50 100644
> --- a/BaseTools/Source/Python/FMMT/core/GuidTools.py
> +++ b/BaseTools/Source/Python/FMMT/core/GuidTools.py
> @@ -110,7 +110,7 @@ class GUIDTools:
> if os.environ['FmmtConfPath']: self.tooldef_file =
> os.path.join(os.environ['FmmtConfPath'], 'FmmtConf.ini') else:-
> PathList = os.environ['PATH']+ PathList =
> os.environ['PATH'].split(os.pathsep) for CurrentPath in
PathList:
> if os.path.exists(os.path.join(CurrentPath, 'FmmtConf.ini')):
> self.tooldef_file = os.path.join(CurrentPath, 'FmmtConf.ini')--
> 2.42.0.windows.2
>
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#112587):
> https://edk2.groups.io/g/devel/message/112587
> Mute This Topic: https://groups.io/mt/103187642/6998960
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [gua.guo@intel.com]
> -=-=-=-=-=-=
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112725): https://edk2.groups.io/g/devel/message/112725
Mute This Topic: https://groups.io/mt/103261683/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [PATCH] BaseTools: FMMT GuidTool Auto Select Config file Enabling
2023-12-15 9:11 [edk2-devel] [PATCH] BaseTools: FMMT GuidTool Auto Select Config file Enabling Yuwei Chen
2023-12-19 7:31 ` Guo, Gua
@ 2023-12-20 22:12 ` Rebecca Cran
1 sibling, 0 replies; 6+ messages in thread
From: Rebecca Cran @ 2023-12-20 22:12 UTC (permalink / raw)
To: Yuwei Chen, devel; +Cc: Liming Gao, Bob Feng
Reviewed-by: Rebecca Cran <rebecca@bsdio.com>
On 12/15/2023 2:11 AM, Yuwei Chen wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4624
>
> Currently, Python FMMT tool does not support automatically
> select FMMTConf.ini file which saves GuidTool settings.
> This patch supports this features.
>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Bob Feng <bob.c.feng@intel.com>
>
> Signed-off-by: Yuwei Chen <yuwei.chen@intel.com>
> ---
> BaseTools/Source/Python/FMMT/core/GuidTools.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/BaseTools/Source/Python/FMMT/core/GuidTools.py b/BaseTools/Source/Python/FMMT/core/GuidTools.py
> index a25681709b..f6bdeffa50 100644
> --- a/BaseTools/Source/Python/FMMT/core/GuidTools.py
> +++ b/BaseTools/Source/Python/FMMT/core/GuidTools.py
> @@ -110,7 +110,7 @@ class GUIDTools:
> if os.environ['FmmtConfPath']:
>
> self.tooldef_file = os.path.join(os.environ['FmmtConfPath'], 'FmmtConf.ini')
>
> else:
>
> - PathList = os.environ['PATH']
>
> + PathList = os.environ['PATH'].split(os.pathsep)
>
> for CurrentPath in PathList:
>
> if os.path.exists(os.path.join(CurrentPath, 'FmmtConf.ini')):
>
> self.tooldef_file = os.path.join(CurrentPath, 'FmmtConf.ini')
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112771): https://edk2.groups.io/g/devel/message/112771
Mute This Topic: https://groups.io/mt/103187642/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 回复: [edk2-devel] [PATCH] BaseTools: FMMT GuidTool Auto Select Config file Enabling
2023-12-19 13:02 ` 回复: " gaoliming via groups.io
@ 2023-12-20 22:17 ` Rebecca Cran
0 siblings, 0 replies; 6+ messages in thread
From: Rebecca Cran @ 2023-12-20 22:17 UTC (permalink / raw)
To: gaoliming, devel, gua.guo, 'Chen, Christine'
Cc: 'Feng, Bob C'
Queued as https://github.com/tianocore/edk2/pull/5177 .
On 12/19/2023 6:02 AM, gaoliming wrote:
> The change is good.
>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
>
>> -----邮件原件-----
>> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Guo, Gua
>> 发送时间: 2023年12月19日 15:32
>> 收件人: devel@edk2.groups.io; Chen, Christine <yuwei.chen@intel.com>;
>> Rebecca Cran <rebecca@bsdio.com>; Gao, Liming
>> <gaoliming@byosoft.com.cn>
>> 抄送: Feng, Bob C <bob.c.feng@intel.com>
>> 主题: Re: [edk2-devel] [PATCH] BaseTools: FMMT GuidTool Auto Select Config
>> file Enabling
>>
>> Hi @Gao, Liming and @Rebecca Cran
>>
>> I may need to get your help for review it, any concern you can also share
> for
>> us.
>>
>> Thanks,
>> Gua
>>
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yuwei
>> Chen
>> Sent: Friday, December 15, 2023 5:12 PM
>> To: devel@edk2.groups.io
>> Cc: Rebecca Cran <rebecca@bsdio.com>; Gao, Liming
>> <gaoliming@byosoft.com.cn>; Feng, Bob C <bob.c.feng@intel.com>
>> Subject: [edk2-devel] [PATCH] BaseTools: FMMT GuidTool Auto Select Config
>> file Enabling
>>
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4624
>>
>> Currently, Python FMMT tool does not support automatically select
>> FMMTConf.ini file which saves GuidTool settings.
>> This patch supports this features.
>>
>> Cc: Rebecca Cran <rebecca@bsdio.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>> Cc: Bob Feng <bob.c.feng@intel.com>
>>
>> Signed-off-by: Yuwei Chen <yuwei.chen@intel.com>
>> ---
>> BaseTools/Source/Python/FMMT/core/GuidTools.py | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/BaseTools/Source/Python/FMMT/core/GuidTools.py
>> b/BaseTools/Source/Python/FMMT/core/GuidTools.py
>> index a25681709b..f6bdeffa50 100644
>> --- a/BaseTools/Source/Python/FMMT/core/GuidTools.py
>> +++ b/BaseTools/Source/Python/FMMT/core/GuidTools.py
>> @@ -110,7 +110,7 @@ class GUIDTools:
>> if os.environ['FmmtConfPath']: self.tooldef_file =
>> os.path.join(os.environ['FmmtConfPath'], 'FmmtConf.ini') else:-
>> PathList = os.environ['PATH']+ PathList =
>> os.environ['PATH'].split(os.pathsep) for CurrentPath in
> PathList:
>> if os.path.exists(os.path.join(CurrentPath, 'FmmtConf.ini')):
>> self.tooldef_file = os.path.join(CurrentPath, 'FmmtConf.ini')--
>> 2.42.0.windows.2
>>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112772): https://edk2.groups.io/g/devel/message/112772
Mute This Topic: https://groups.io/mt/103261683/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-12-20 22:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-15 9:11 [edk2-devel] [PATCH] BaseTools: FMMT GuidTool Auto Select Config file Enabling Yuwei Chen
2023-12-19 7:31 ` Guo, Gua
2023-12-19 13:02 ` 回复: " gaoliming via groups.io
2023-12-20 22:17 ` Rebecca Cran
2023-12-20 22:12 ` Rebecca Cran
[not found] <17A0F657EB4E520F.5876@groups.io>
2023-12-15 9:13 ` Yuwei Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox