From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id AD277D8019A for ; Fri, 22 Dec 2023 22:41:23 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=/Mh76VSeXI56XEw2IBIf3TZ6TjS0uRLw6yuGvnrgVII=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1703284882; v=1; b=Ac2pOvmpvOk1ykZX2/S516cxLc4znwNNA9rIPKd6fgkt0s2cvd0a7UwDkfsh2JebuBBKO7lT zRTW4rl/zzCQV0acmK19jt5VPz5LIsw2yTdda3Oa2Eauxi4o0D/bVTo30T3m4KXW6oMjUR2WahP FURkKLB3GAyryYIBB7ORdVa4= X-Received: by 127.0.0.2 with SMTP id 3OR5YY7687511xZRUkWUBMcP; Fri, 22 Dec 2023 14:41:22 -0800 X-Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by mx.groups.io with SMTP id smtpd.web10.34715.1703284881599368552 for ; Fri, 22 Dec 2023 14:41:21 -0800 X-Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-50e70583191so488325e87.3 for ; Fri, 22 Dec 2023 14:41:21 -0800 (PST) X-Gm-Message-State: kcSJFchgRKzXIgLr2xIkmeqpx7686176AA= X-Google-Smtp-Source: AGHT+IGC7IiI50BfjCRuTkFpeKRG5FoaFcOvrdV42JUqKdFJbNgDBh0+btHhIAijPNy8Jggta3SSFg== X-Received: by 2002:a19:6419:0:b0:50e:7410:e890 with SMTP id y25-20020a196419000000b0050e7410e890mr33037lfb.127.1703284879592; Fri, 22 Dec 2023 14:41:19 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id c2-20020a056512074200b0050e6abeb1e4sm246453lfs.170.2023.12.22.14.41.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 22 Dec 2023 14:41:19 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [edk2-redfish-client][PATCH v3 3/3] RedfishClientPkg: fix access to unitialized variable. Date: Sat, 23 Dec 2023 01:41:13 +0300 Message-Id: <20231222224113.99793-4-mike.maslenkin@gmail.com> In-Reply-To: <20231222224113.99793-1-mike.maslenkin@gmail.com> References: <20231222224113.99793-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Ac2pOvmp; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) It is possible that at the time of accessing to AsciiLocation pointer the memory is not allocated. Also gcc version 4.8.5 20150623 (Red Hat 4.8.5-44) emits a warning for this case: RedfishFeatureUtilityLib.c:1889:37: error: 'AsciiLocation' may be used unin= itialized in this function [-Werror=3Dmaybe-uninitialized] *Location =3D StrAsciiToUnicode (AsciiLocation); Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin Reviewed-by: Nickle Wang Reviewed-by: Abner Chang --- .../RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatu= reUtilityLib.c b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishF= eatureUtilityLib.c index 0f0b050d7eba..01c054ae3b70 100644 --- a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtili= tyLib.c +++ b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtili= tyLib.c @@ -1856,7 +1856,8 @@ GetEtagAndLocation ( }=0D =0D if (Location !=3D NULL) {=0D - *Location =3D NULL;=0D + *Location =3D NULL;=0D + AsciiLocation =3D NULL;=0D =0D if (*(Response->StatusCode) =3D=3D HTTP_STATUS_200_OK) {=0D Header =3D HttpFindHeader (Response->HeaderCount, Response->Headers,= HTTP_HEADER_LOCATION);=0D --=20 2.32.0 (Apple Git-132) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112851): https://edk2.groups.io/g/devel/message/112851 Mute This Topic: https://groups.io/mt/103326962/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-