From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C52897803CC for ; Sun, 24 Dec 2023 22:59:46 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=46v5LfdX5ALOpocuG3z8JJ7QfymaWAh5+ypEziKVgN4=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1703458785; v=1; b=YXw7YnoAF/IOd3mP7BtBRJFoYIqIRkX1pIqvg9519OD3TEz3PKpMO21wZyQrI8A000dI/eNx SXFTX3mraJ0I2roh5jFxU+bEQ0y+ELaps8szOPmeAePw/P/dCxnoo43b+yX/Iu0SLHx7DWgvSqI eyZoqPUdsXXMzyRQ5soFklbc= X-Received: by 127.0.0.2 with SMTP id bSgIYY7687511xdG5X7td4fU; Sun, 24 Dec 2023 14:59:45 -0800 X-Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by mx.groups.io with SMTP id smtpd.web10.35949.1703458783678865758 for ; Sun, 24 Dec 2023 14:59:44 -0800 X-Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-50e6ee8e911so1365361e87.1 for ; Sun, 24 Dec 2023 14:59:43 -0800 (PST) X-Gm-Message-State: 6SqSSR1dU113v2aZTcWWdLXmx7686176AA= X-Google-Smtp-Source: AGHT+IFexs8VN/tyiwHbflLTffwtgdWctMsqzbv4gxlpKOE8k0fn0uBq4ptwS6f43WbGR2xOV5UgmQ== X-Received: by 2002:a19:c20f:0:b0:50e:6332:7025 with SMTP id l15-20020a19c20f000000b0050e63327025mr1635067lfc.89.1703458781856; Sun, 24 Dec 2023 14:59:41 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id be44-20020a056512252c00b0050e78f5178asm326596lfb.262.2023.12.24.14.59.41 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 24 Dec 2023 14:59:41 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH v3 13/16] RedfishDiscoverDxe: add a helper function deallocating string resources. Date: Mon, 25 Dec 2023 01:59:24 +0300 Message-Id: <20231224225927.9119-14-mike.maslenkin@gmail.com> In-Reply-To: <20231224225927.9119-1-mike.maslenkin@gmail.com> References: <20231224225927.9119-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=YXw7YnoA; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io This patch adds a handy helper function deallocating resources from the EFI_REDFISH_DISCOVERED_INFORMATION structure instance. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 68 ++++++++++++------- 1 file changed, 44 insertions(+), 24 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPk= g/RedfishDiscoverDxe/RedfishDiscoverDxe.c index 76f87e4fe5e7..ff0c3ff1d1f5 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -712,6 +712,49 @@ DiscoverRedfishHostInterface ( return Status;=0D }=0D =0D +/**=0D + The function releases particular strings into the structure instance.=0D +=0D + @param[in] Information EFI_REDFISH_DISCOVERED_INFORMATION=0D +=0D +**/=0D +STATIC=0D +VOID=0D +FreeInformationData (=0D + IN EFI_REDFISH_DISCOVERED_INFORMATION *Information=0D + )=0D +{=0D + if (Information->Location !=3D NULL) {=0D + FreePool (Information->Location);=0D + Information->Location =3D NULL;=0D + }=0D +=0D + if (Information->Uuid !=3D NULL) {=0D + FreePool (Information->Uuid);=0D + Information->Uuid =3D NULL;=0D + }=0D +=0D + if (Information->Os !=3D NULL) {=0D + FreePool (Information->Os);=0D + Information->Os =3D NULL;=0D + }=0D +=0D + if (Information->OsVersion !=3D NULL) {=0D + FreePool (Information->OsVersion);=0D + Information->OsVersion =3D NULL;=0D + }=0D +=0D + if (Information->Product !=3D NULL) {=0D + FreePool (Information->Product);=0D + Information->Product =3D NULL;=0D + }=0D +=0D + if (Information->ProductVer !=3D NULL) {=0D + FreePool (Information->ProductVer);=0D + Information->ProductVer =3D NULL;=0D + }=0D +}=0D +=0D /**=0D The function initializes particular strings into the structure instance.= =0D =0D @@ -1514,30 +1557,7 @@ RedfishServiceReleaseService ( do {=0D if (DiscoveredRedfishInstance->Instance =3D=3D ThisRedfishInstance) = {=0D RemoveEntryList (&DiscoveredRedfishInstance->NextInstance);=0D - if (ThisRedfishInstance->Information.Location !=3D NULL) {=0D - FreePool (ThisRedfishInstance->Information.Location);=0D - }=0D -=0D - if (ThisRedfishInstance->Information.Uuid !=3D NULL) {=0D - FreePool (ThisRedfishInstance->Information.Uuid);=0D - }=0D -=0D - if (ThisRedfishInstance->Information.Os !=3D NULL) {=0D - FreePool (ThisRedfishInstance->Information.Os);=0D - }=0D -=0D - if (ThisRedfishInstance->Information.OsVersion !=3D NULL) {=0D - FreePool (ThisRedfishInstance->Information.OsVersion);=0D - }=0D -=0D - if (ThisRedfishInstance->Information.Product !=3D NULL) {=0D - FreePool (ThisRedfishInstance->Information.Product);=0D - }=0D -=0D - if (ThisRedfishInstance->Information.ProductVer !=3D NULL) {=0D - FreePool (ThisRedfishInstance->Information.ProductVer);=0D - }=0D -=0D + FreeInformationData (&ThisRedfishInstance->Information);=0D FreePool ((VOID *)ThisRedfishInstance);=0D goto ReleaseNext;=0D }=0D --=20 2.32.0 (Apple Git-132) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112872): https://edk2.groups.io/g/devel/message/112872 Mute This Topic: https://groups.io/mt/103354132/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-