From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 18577941E55 for ; Sun, 24 Dec 2023 22:59:38 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=lLz4z7IQL8Xk/FYsaw146KCeEKJyVxXU6S27Sums04Y=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1703458777; v=1; b=byy7dD4YTVONoG4/GH4lDMYHK+Tuct1ahLoReZOnvZycP5UXpDAQbD3O1BqwLnm7h9jSVGO/ 22AkUY4VqG81LyMq8lgwv3lQ1lzS15T78RyPIMSnKLKe81ZHYomcnORkxU2ToNN6yEATLR/CjFi Swv3vIsaosjQNsi80x4xE8qg= X-Received: by 127.0.0.2 with SMTP id oDa0YY7687511xmjQ0ylbPpn; Sun, 24 Dec 2023 14:59:37 -0800 X-Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by mx.groups.io with SMTP id smtpd.web10.35942.1703458776129724345 for ; Sun, 24 Dec 2023 14:59:36 -0800 X-Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-50e68e93be1so2103138e87.0 for ; Sun, 24 Dec 2023 14:59:35 -0800 (PST) X-Gm-Message-State: wppFXLOuNsnAWQhypVZ155fix7686176AA= X-Google-Smtp-Source: AGHT+IHqUozZz2IXgxZIh5aV0Ol1qj0E9EANUeLk1AqDTD6MWjq4v1M2sNhOfcpPqRVSbtBWm0FL5w== X-Received: by 2002:a05:6512:208e:b0:50e:7b47:97d with SMTP id t14-20020a056512208e00b0050e7b47097dmr144592lfr.112.1703458774265; Sun, 24 Dec 2023 14:59:34 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id be44-20020a056512252c00b0050e78f5178asm326596lfb.262.2023.12.24.14.59.33 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 24 Dec 2023 14:59:33 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH v3 04/16] RedfishPkg: RedfishPlatformConfigDxe: reduce memory allocations Date: Mon, 25 Dec 2023 01:59:15 +0300 Message-Id: <20231224225927.9119-5-mike.maslenkin@gmail.com> In-Reply-To: <20231224225927.9119-1-mike.maslenkin@gmail.com> References: <20231224225927.9119-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=byy7dD4Y; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io It's unclear why the new string is allocated as copy of the original string if its pointer is stored in an array and the original string is released immediately after the copy is created. All data allocated in the same pool. Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin Reviewed-by: Abner Chang --- .../RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c= b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c index cbc65ba59408..f970e317b3f6 100644 --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c @@ -2057,9 +2057,7 @@ RedfishPlatformConfigProtocolGetConfigureLang ( TmpString =3D HiiGetRedfishString (StatementRef->Statement->Parent= Form->ParentFormset->HiiHandle, FullSchema, StatementRef->Statement->Descri= ption);=0D ASSERT (TmpString !=3D NULL);=0D if (TmpString !=3D NULL) {=0D - TmpConfigureLangList[Index] =3D AllocateCopyPool (StrSize (TmpSt= ring), TmpString);=0D - ASSERT (TmpConfigureLangList[Index] !=3D NULL);=0D - FreePool (TmpString);=0D + TmpConfigureLangList[Index] =3D TmpString;=0D ++Index;=0D }=0D }=0D --=20 2.32.0 (Apple Git-132) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112863): https://edk2.groups.io/g/devel/message/112863 Mute This Topic: https://groups.io/mt/103354123/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-