From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C2A84D80591 for ; Sun, 24 Dec 2023 22:59:39 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=425OpeHOlMdqJMDFTzVBf+SOjNyoN1nVSUjM/33hbQA=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1703458778; v=1; b=Hv9x0uMddxf+xq0Ig/S9jhJTJ008jtiL6lMfPRwGpYrFczfzqMdjhDDy/WJkYsumI+Guy5UL 6h29NpJiZz+zaVSTe5NVvfwLWU55xqlhZd6oxm5e2mFqRMwLzn4ooZoTbyg5SWnC89NyJVivM0p cnLoSpAOZDNoKVhQS3B3xSwE= X-Received: by 127.0.0.2 with SMTP id 99e5YY7687511x5V2nD7CzeU; Sun, 24 Dec 2023 14:59:38 -0800 X-Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by mx.groups.io with SMTP id smtpd.web11.35797.1703458777129393265 for ; Sun, 24 Dec 2023 14:59:37 -0800 X-Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-50e7d6565b5so27510e87.0 for ; Sun, 24 Dec 2023 14:59:36 -0800 (PST) X-Gm-Message-State: R6U0l8jlPByqY0APHb3AGJvzx7686176AA= X-Google-Smtp-Source: AGHT+IEeRo0cyEodqJw7iuZPqOZy1I8FVoN9I2TgTCxLNgkO4/MublI7QKSsE9gYSrUg9YIhJnkAMA== X-Received: by 2002:a05:6512:614:b0:50e:76ac:18a7 with SMTP id b20-20020a056512061400b0050e76ac18a7mr504888lfe.130.1703458775145; Sun, 24 Dec 2023 14:59:35 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id be44-20020a056512252c00b0050e78f5178asm326596lfb.262.2023.12.24.14.59.34 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 24 Dec 2023 14:59:34 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH v3 05/16] RedfishPkg: RedfishDiscoverDxe: fix memory leak on error path. Date: Mon, 25 Dec 2023 01:59:16 +0300 Message-Id: <20231224225927.9119-6-mike.maslenkin@gmail.com> In-Reply-To: <20231224225927.9119-1-mike.maslenkin@gmail.com> References: <20231224225927.9119-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Hv9x0uMd; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin Reviewed-by: Abner Chang --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPk= g/RedfishDiscoverDxe/RedfishDiscoverDxe.c index 06d8d00da7fb..e344e06d8dcc 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -829,6 +829,10 @@ AddAndSignalNewRedfishService ( } while (TRUE);=0D }=0D =0D + if (Char16Uuid !=3D NULL) {=0D + FreePool (Char16Uuid);=0D + }=0D +=0D if (NewFound || InfoRefresh) {=0D if (!InfoRefresh) {=0D DiscoveredList =3D (EFI_REDFISH_DISCOVERED_INTERNAL_LIST *)AllocateZ= eroPool (sizeof (EFI_REDFISH_DISCOVERED_INTERNAL_LIST));=0D @@ -907,10 +911,6 @@ AddAndSignalNewRedfishService ( }=0D }=0D =0D - if (Char16Uuid !=3D NULL) {=0D - FreePool ((VOID *)Char16Uuid);=0D - }=0D -=0D Status =3D EFI_SUCCESS;=0D if (NewFound || InfoRefresh) {=0D //=0D --=20 2.32.0 (Apple Git-132) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112864): https://edk2.groups.io/g/devel/message/112864 Mute This Topic: https://groups.io/mt/103354124/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-