From: "Mike Maslenkin" <mike.maslenkin@gmail.com>
To: devel@edk2.groups.io
Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com,
Mike Maslenkin <mike.maslenkin@gmail.com>
Subject: [edk2-devel] [PATCH v3 08/16] EmulatorPkg: fix typo. PcdRedfishServie -> PcdRedfishService
Date: Mon, 25 Dec 2023 01:59:19 +0300 [thread overview]
Message-ID: <20231224225927.9119-9-mike.maslenkin@gmail.com> (raw)
In-Reply-To: <20231224225927.9119-1-mike.maslenkin@gmail.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Reviewed-by: Abner Chang <abner.chang@amd.com>
---
EmulatorPkg/EmulatorPkg.dec | 8 ++++----
.../RedfishPlatformCredentialLib.c | 12 ++++++------
.../RedfishPlatformCredentialLib.inf | 8 ++++----
3 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/EmulatorPkg/EmulatorPkg.dec b/EmulatorPkg/EmulatorPkg.dec
index fe81652b0478..c2a92923e9b7 100644
--- a/EmulatorPkg/EmulatorPkg.dec
+++ b/EmulatorPkg/EmulatorPkg.dec
@@ -77,15 +77,15 @@
## Platform level Redfish Service control PCD
# These PCDs are used to stop the Redfish sevice when secure boot is disabled
# or exit boot service.
- gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfSecureBootDisabled|TRUE|BOOLEAN|0x00001020
- gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfExitbootService|TRUE|BOOLEAN|0x00001021
+ gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfSecureBootDisabled|TRUE|BOOLEAN|0x00001020
+ gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfExitbootService|TRUE|BOOLEAN|0x00001021
##
# edk2 Redfish implementation on Emulator package is designed to access
# to Redfish simulator.
# https://github.com/DMTF/Redfish-Profile-Simulator
# The user ID and password are fixed as below.
- gEmulatorPkgTokenSpaceGuid.PcdRedfishServieUserId|"admin"|VOID*|0x00001022
- gEmulatorPkgTokenSpaceGuid.PcdRedfishServiePassword|"pwd123456"|VOID*|0x00001023
+ gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceUserId|"admin"|VOID*|0x00001022
+ gEmulatorPkgTokenSpaceGuid.PcdRedfishServicePassword|"pwd123456"|VOID*|0x00001023
gEmulatorPkgTokenSpaceGuid.PcdPersistentMemorySize|0x4000000|UINT32|0x00001024
[PcdsFixedAtBuild, PcdsPatchableInModule]
diff --git a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCredentialLib.c b/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCredentialLib.c
index 614eaebb0d0e..5c167fcdea56 100644
--- a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCredentialLib.c
+++ b/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCredentialLib.c
@@ -57,8 +57,8 @@ GetRedfishCredential (
//
// User ID and Password.
//
- UserIdSize = AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdRedfishServieUserId));
- PasswordSize = AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdRedfishServiePassword));
+ UserIdSize = AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdRedfishServiceUserId));
+ PasswordSize = AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdRedfishServicePassword));
if ((UserIdSize == 0) || (PasswordSize == 0)) {
DEBUG ((DEBUG_ERROR, "Incorrect string of UserID or Password for REdfish service.\n"));
return EFI_INVALID_PARAMETER;
@@ -69,7 +69,7 @@ GetRedfishCredential (
return EFI_OUT_OF_RESOURCES;
}
- CopyMem (*UserId, (CHAR8 *)PcdGetPtr (PcdRedfishServieUserId), UserIdSize);
+ CopyMem (*UserId, (CHAR8 *)PcdGetPtr (PcdRedfishServiceUserId), UserIdSize);
*Password = AllocateZeroPool (PasswordSize);
if (*Password == NULL) {
@@ -77,7 +77,7 @@ GetRedfishCredential (
return EFI_OUT_OF_RESOURCES;
}
- CopyMem (*Password, (CHAR8 *)PcdGetPtr (PcdRedfishServiePassword), PasswordSize);
+ CopyMem (*Password, (CHAR8 *)PcdGetPtr (PcdRedfishServicePassword), PasswordSize);
return EFI_SUCCESS;
}
@@ -177,7 +177,7 @@ LibStopRedfishService (
// Check platform PCD to determine the action for stopping
// Redfish service due to secure boot is disabled.
//
- if (!PcdGetBool (PcdRedfishServieStopIfSecureBootDisabled)) {
+ if (!PcdGetBool (PcdRedfishServiceStopIfSecureBootDisabled)) {
return EFI_UNSUPPORTED;
} else {
//
@@ -198,7 +198,7 @@ LibStopRedfishService (
// Check platform PCD to determine the action for stopping
// Redfish service due to exit boot service.
//
- if (PcdGetBool (PcdRedfishServieStopIfExitbootService)) {
+ if (PcdGetBool (PcdRedfishServiceStopIfExitbootService)) {
return EFI_UNSUPPORTED;
} else {
mStopRedfishService = TRUE;
diff --git a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCredentialLib.inf b/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCredentialLib.inf
index 41c389c4a292..9d151f14ee17 100644
--- a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCredentialLib.inf
+++ b/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCredentialLib.inf
@@ -36,10 +36,10 @@
UefiLib
[Pcd]
- gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfSecureBootDisabled ## CONSUMES
- gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfExitbootService ## CONSUMES
- gEmulatorPkgTokenSpaceGuid.PcdRedfishServieUserId ## CONSUMES
- gEmulatorPkgTokenSpaceGuid.PcdRedfishServiePassword ## CONSUMES
+ gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfSecureBootDisabled ## CONSUMES
+ gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfExitbootService ## CONSUMES
+ gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceUserId ## CONSUMES
+ gEmulatorPkgTokenSpaceGuid.PcdRedfishServicePassword ## CONSUMES
[Guids]
gEfiGlobalVariableGuid
--
2.32.0 (Apple Git-132)
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112867): https://edk2.groups.io/g/devel/message/112867
Mute This Topic: https://groups.io/mt/103354127/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-12-24 22:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-24 22:59 [edk2-devel] [PATCH v3 0/16] Redfish related fixes and improvements Mike Maslenkin
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 01/16] RedfishPkg: fix RedfishPlatformHostInterfaceLib library class name typo Mike Maslenkin
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 02/16] RedfishPkg: fix RedfishPlatformCredentialLib " Mike Maslenkin
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 03/16] RedfishPkg: get rid of unused definitions from RedfishCrtLib.h Mike Maslenkin
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 04/16] RedfishPkg: RedfishPlatformConfigDxe: reduce memory allocations Mike Maslenkin
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 05/16] RedfishPkg: RedfishDiscoverDxe: fix memory leak on error path Mike Maslenkin
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 06/16] RedfishPkg: add Component Name protocols to RedfishConfigHandler driver Mike Maslenkin
2023-12-26 1:12 ` Chang, Abner via groups.io
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 07/16] RedfishPkg: add proper initialization of IPMI request Mike Maslenkin
2023-12-24 22:59 ` Mike Maslenkin [this message]
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 09/16] EmulatorPkg: RedfishPlatformHostInterfaceLib: get rid of unused variable Mike Maslenkin
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 10/16] RedfishDiscoverDxe: introduce InitInformationData helper function Mike Maslenkin
2023-12-26 1:14 ` Chang, Abner via groups.io
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 11/16] RedfishDiscoverDxe: refine InitInformationData(), remove unnecessary casts Mike Maslenkin
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 12/16] RedfishDiscoverDxe: refine InitInformationData() function Mike Maslenkin
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 13/16] RedfishDiscoverDxe: add a helper function deallocating string resources Mike Maslenkin
2023-12-26 1:17 ` Chang, Abner via groups.io
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 14/16] RedfishDiscoverDxe: release resources when refreshing information data Mike Maslenkin
2023-12-26 1:20 ` Chang, Abner via groups.io
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 15/16] RedfishDiscoverDxe: handle memory allocation error conditions Mike Maslenkin
2023-12-26 1:22 ` Chang, Abner via groups.io
2023-12-24 22:59 ` [edk2-devel] [PATCH v3 16/16] RedfishPkg: RedfishDiscoverDxe: add [] brackets to URI for IPv6 addresses Mike Maslenkin
2023-12-26 1:39 ` Chang, Abner via groups.io
2023-12-26 1:40 ` [edk2-devel] [PATCH v3 0/16] Redfish related fixes and improvements Chang, Abner via groups.io
2023-12-26 16:10 ` Mike Maslenkin
2023-12-27 2:54 ` Chang, Abner via groups.io
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231224225927.9119-9-mike.maslenkin@gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox