From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D30F5D806DD for ; Sun, 24 Dec 2023 22:59:42 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=aLRSZ83gWV6b+nc5igFfp8UA33RIagGMIAm411ebn0c=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1703458781; v=1; b=g3i9EyB3XdTMunw/fqxlVtCYdZpMruTwegnTrlxPrHBZXtKSu9iXPe9UrbN+TfB2d6qzolAa UADYuXDiB9jPu48Oi1hmcDJ4+r+HYfBdLIjNfZgDebu3Fjuh54lY6t1ZY6nrWGaaaW7J2Tsyl9P uXvqM3Z1dHj/WthumnHoRkLE= X-Received: by 127.0.0.2 with SMTP id 8rQbYY7687511xs1ps8w20Nx; Sun, 24 Dec 2023 14:59:41 -0800 X-Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by mx.groups.io with SMTP id smtpd.web10.35943.1703458779777522038 for ; Sun, 24 Dec 2023 14:59:40 -0800 X-Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-50e7be1c65dso110330e87.3 for ; Sun, 24 Dec 2023 14:59:39 -0800 (PST) X-Gm-Message-State: CzWaApfXzG1yQlnVNBeeW8eHx7686176AA= X-Google-Smtp-Source: AGHT+IHLGaV02d6aKPV07rbZW+o7jo+awiyZxB67BslwE4UCEHQYcb455F65/amwq6A2PgQeFm3mpw== X-Received: by 2002:a05:6512:3e0f:b0:50e:7846:7adc with SMTP id i15-20020a0565123e0f00b0050e78467adcmr276091lfv.73.1703458777650; Sun, 24 Dec 2023 14:59:37 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id be44-20020a056512252c00b0050e78f5178asm326596lfb.262.2023.12.24.14.59.36 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 24 Dec 2023 14:59:37 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH v3 08/16] EmulatorPkg: fix typo. PcdRedfishServie -> PcdRedfishService Date: Mon, 25 Dec 2023 01:59:19 +0300 Message-Id: <20231224225927.9119-9-mike.maslenkin@gmail.com> In-Reply-To: <20231224225927.9119-1-mike.maslenkin@gmail.com> References: <20231224225927.9119-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=g3i9EyB3; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none) Cc: Nickle Wang Signed-off-by: Mike Maslenkin Reviewed-by: Abner Chang --- EmulatorPkg/EmulatorPkg.dec | 8 ++++---- .../RedfishPlatformCredentialLib.c | 12 ++++++------ .../RedfishPlatformCredentialLib.inf | 8 ++++---- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/EmulatorPkg/EmulatorPkg.dec b/EmulatorPkg/EmulatorPkg.dec index fe81652b0478..c2a92923e9b7 100644 --- a/EmulatorPkg/EmulatorPkg.dec +++ b/EmulatorPkg/EmulatorPkg.dec @@ -77,15 +77,15 @@ ## Platform level Redfish Service control PCD=0D # These PCDs are used to stop the Redfish sevice when secure boot is dis= abled=0D # or exit boot service.=0D - gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfSecureBootDisabled|TRUE= |BOOLEAN|0x00001020=0D - gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfExitbootService|TRUE|BO= OLEAN|0x00001021=0D + gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfSecureBootDisabled|TRU= E|BOOLEAN|0x00001020=0D + gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfExitbootService|TRUE|B= OOLEAN|0x00001021=0D ##=0D # edk2 Redfish implementation on Emulator package is designed to access= =0D # to Redfish simulator.=0D # https://github.com/DMTF/Redfish-Profile-Simulator=0D # The user ID and password are fixed as below.=0D - gEmulatorPkgTokenSpaceGuid.PcdRedfishServieUserId|"admin"|VOID*|0x000010= 22=0D - gEmulatorPkgTokenSpaceGuid.PcdRedfishServiePassword|"pwd123456"|VOID*|0x= 00001023=0D + gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceUserId|"admin"|VOID*|0x00001= 022=0D + gEmulatorPkgTokenSpaceGuid.PcdRedfishServicePassword|"pwd123456"|VOID*|0= x00001023=0D gEmulatorPkgTokenSpaceGuid.PcdPersistentMemorySize|0x4000000|UINT32|0x00= 001024=0D =0D [PcdsFixedAtBuild, PcdsPatchableInModule]=0D diff --git a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatfo= rmCredentialLib.c b/EmulatorPkg/Library/RedfishPlatformCredentialLib/Redfis= hPlatformCredentialLib.c index 614eaebb0d0e..5c167fcdea56 100644 --- a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCrede= ntialLib.c +++ b/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCrede= ntialLib.c @@ -57,8 +57,8 @@ GetRedfishCredential ( //=0D // User ID and Password.=0D //=0D - UserIdSize =3D AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdRedfishServieUserI= d));=0D - PasswordSize =3D AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdRedfishServiePassw= ord));=0D + UserIdSize =3D AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdRedfishServiceUser= Id));=0D + PasswordSize =3D AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdRedfishServicePass= word));=0D if ((UserIdSize =3D=3D 0) || (PasswordSize =3D=3D 0)) {=0D DEBUG ((DEBUG_ERROR, "Incorrect string of UserID or Password for REdfi= sh service.\n"));=0D return EFI_INVALID_PARAMETER;=0D @@ -69,7 +69,7 @@ GetRedfishCredential ( return EFI_OUT_OF_RESOURCES;=0D }=0D =0D - CopyMem (*UserId, (CHAR8 *)PcdGetPtr (PcdRedfishServieUserId), UserIdSiz= e);=0D + CopyMem (*UserId, (CHAR8 *)PcdGetPtr (PcdRedfishServiceUserId), UserIdSi= ze);=0D =0D *Password =3D AllocateZeroPool (PasswordSize);=0D if (*Password =3D=3D NULL) {=0D @@ -77,7 +77,7 @@ GetRedfishCredential ( return EFI_OUT_OF_RESOURCES;=0D }=0D =0D - CopyMem (*Password, (CHAR8 *)PcdGetPtr (PcdRedfishServiePassword), Passw= ordSize);=0D + CopyMem (*Password, (CHAR8 *)PcdGetPtr (PcdRedfishServicePassword), Pass= wordSize);=0D return EFI_SUCCESS;=0D }=0D =0D @@ -177,7 +177,7 @@ LibStopRedfishService ( // Check platform PCD to determine the action for stopping=0D // Redfish service due to secure boot is disabled.=0D //=0D - if (!PcdGetBool (PcdRedfishServieStopIfSecureBootDisabled)) {=0D + if (!PcdGetBool (PcdRedfishServiceStopIfSecureBootDisabled)) {=0D return EFI_UNSUPPORTED;=0D } else {=0D //=0D @@ -198,7 +198,7 @@ LibStopRedfishService ( // Check platform PCD to determine the action for stopping=0D // Redfish service due to exit boot service.=0D //=0D - if (PcdGetBool (PcdRedfishServieStopIfExitbootService)) {=0D + if (PcdGetBool (PcdRedfishServiceStopIfExitbootService)) {=0D return EFI_UNSUPPORTED;=0D } else {=0D mStopRedfishService =3D TRUE;=0D diff --git a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatfo= rmCredentialLib.inf b/EmulatorPkg/Library/RedfishPlatformCredentialLib/Redf= ishPlatformCredentialLib.inf index 41c389c4a292..9d151f14ee17 100644 --- a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCrede= ntialLib.inf +++ b/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCrede= ntialLib.inf @@ -36,10 +36,10 @@ UefiLib=0D =0D [Pcd]=0D - gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfSecureBootDisabled ## C= ONSUMES=0D - gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfExitbootService ## C= ONSUMES=0D - gEmulatorPkgTokenSpaceGuid.PcdRedfishServieUserId ## C= ONSUMES=0D - gEmulatorPkgTokenSpaceGuid.PcdRedfishServiePassword ## C= ONSUMES=0D + gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfSecureBootDisabled ## = CONSUMES=0D + gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfExitbootService ## = CONSUMES=0D + gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceUserId ## = CONSUMES=0D + gEmulatorPkgTokenSpaceGuid.PcdRedfishServicePassword ## = CONSUMES=0D =0D [Guids]=0D gEfiGlobalVariableGuid=0D --=20 2.32.0 (Apple Git-132) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112867): https://edk2.groups.io/g/devel/message/112867 Mute This Topic: https://groups.io/mt/103354127/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-