From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 03A26D811B1 for ; Thu, 4 Jan 2024 08:03:08 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=7M+nlU+RJKqptPg2AYVB1nW+vCs7Y/UxKf7QoqwwAcM=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1704355387; v=1; b=uRELAx3YuA3bgrjqC4MMze0cCI1xgD6FoL3+pl/04fkeShNSVIXn0p/1kfuuLBC4MK/rOcFs BK3HkYUuw1dgcV2NJlhCE7T4BWFMsfiaW6fE//NDaeZyGACBI/FQocsckG14IiVGMaM5I0al7WM sDiY4oOyaOo37SF2QAqblYho= X-Received: by 127.0.0.2 with SMTP id mfXXYY7687511xP005EWXPJW; Thu, 04 Jan 2024 00:03:07 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.49722.1704355386454869341 for ; Thu, 04 Jan 2024 00:03:06 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5C798C15; Thu, 4 Jan 2024 00:03:51 -0800 (PST) X-Received: from usa.arm.com (a076756.arm.com [10.162.16.85]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A9DB43F7A6; Thu, 4 Jan 2024 00:03:03 -0800 (PST) From: "Himanshu Sharma" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Pierre Gondois , Himanshu Sharma Subject: [edk2-devel] [edk2][PATCH V2 0/2] Update handling of interrupt node for SSDT Serial Port Fixup Library Date: Thu, 4 Jan 2024 13:32:55 +0530 Message-Id: <20240104080257.319631-1-Himanshu.Sharma@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,Himanshu.Sharma@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: RTzyOk4k4AGPzuARLfUH58BXx7686176AA= Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=uRELAx3Y; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none) Currently in the Dynamic Tables Framework, the interrupt node for the AML description of the serial-ports is populated using the template and so is mandatorily added even if the serial-port is enumerated as a DBG2 port in the platform's configuration manager where the interrupt is not mandatory. The proposed implementation adds the interrupt node only if the interrupt defined for the serial-port is a valid SPI or a valid extended SPI. So, in case of DBG2 ports, the platforms with interrupt defined as SPI (like Morello) can have the interrupt node added to the description and the platforms where it is not defined (like N1SDP) can ignore the addition of the interrupt node. The changes include adding the SPI range macros in ArmGicArchLib (ArmPkg) which can be used by the SSDTSerialPortFixupLib (DynamicTablesPkg) to put a check for generating the interrupt node using AML Codegen API. Change log: V2: - Fix comments on V1 - Add link to Arm GIC Specification. - Fix uncrustify errors. - Add a check more if the interrupt is 0, to be used when an interrupt is not wired to the serial port. - Update copyright year to 2024. - Link to branch with the patches in this series https://github.com/himsha01/edk2/tree/ssdt_serial_port_interrupt_v2 V1: - Link to branch with the patches in this series https://github.com/himsha01/edk2/tree/ssdt_serial_port_interrupt=20 Himanshu Sharma (2): ArmPkg/ArmGicArchLib: Add macros for SPI and extended SPI ranges DynamicTablesPkg/SsdtSerialPortFixupLib: Add Interrupt node for SPIs on= ly DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFix= upLib.inf | 3 +- ArmPkg/Include/Library/ArmGicArchLib.h = | 14 ++++++ DynamicTablesPkg/Include/ArmNameSpaceObjects.h = | 6 ++- DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortFix= upLib.c | 49 ++++++++++++++------ DynamicTablesPkg/Library/Common/SsdtSerialPortFixupLib/SsdtSerialPortTem= plate.asl | 29 +++++++----- 5 files changed, 72 insertions(+), 29 deletions(-) --=20 2.25.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113140): https://edk2.groups.io/g/devel/message/113140 Mute This Topic: https://groups.io/mt/103518971/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-